* [PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy
@ 2012-12-18 15:39 ` Vivek Gautam
0 siblings, 0 replies; 18+ messages in thread
From: Vivek Gautam @ 2012-12-18 15:39 UTC (permalink / raw)
To: linux-samsung-soc
Cc: linux-usb, devicetree-discuss, linux-kernel, kgene.kim, balbi,
thomas.abraham, rob.herring, grant.likely, sylvester.nawrocki,
p.paneri
This patch-set enables the samsung-usbphy driver on exynos5250,
which enables the support for USB2 type and USB3 type phys.
The corresponding phy driver patches are available at:
1) https://lkml.org/lkml/2012/12/18/201
2) https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-December/024559.html
Tested this patch-set on exynos5250 with following patch-sets for
USB 2.0 and USB 3.0:
- https://patchwork.kernel.org/patch/1794651/
- https://lkml.org/lkml/2012/12/18/201
- https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-December/024559.html
- http://comments.gmane.org/gmane.linux.usb.general/76352
- https://lkml.org/lkml/2012/12/13/492
Vivek Gautam (2):
ARM: Exynos5250: Enabling samsung-usbphy driver
ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver
arch/arm/boot/dts/exynos5250.dtsi | 23 +++++++++++++++++++++++
arch/arm/mach-exynos/include/mach/map.h | 1 +
arch/arm/mach-exynos/mach-exynos5-dt.c | 2 ++
3 files changed, 26 insertions(+), 0 deletions(-)
--
1.7.6.5
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy
@ 2012-12-18 15:39 ` Vivek Gautam
0 siblings, 0 replies; 18+ messages in thread
From: Vivek Gautam @ 2012-12-18 15:39 UTC (permalink / raw)
To: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA
Cc: kgene.kim-Sze3O3UU22JBDgjK7y7TUQ,
p.paneri-Sze3O3UU22JBDgjK7y7TUQ,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, balbi-l0cyMroinI0,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ,
sylvester.nawrocki-Re5JQEeQqe8AvxtiuMwx3w
This patch-set enables the samsung-usbphy driver on exynos5250,
which enables the support for USB2 type and USB3 type phys.
The corresponding phy driver patches are available at:
1) https://lkml.org/lkml/2012/12/18/201
2) https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-December/024559.html
Tested this patch-set on exynos5250 with following patch-sets for
USB 2.0 and USB 3.0:
- https://patchwork.kernel.org/patch/1794651/
- https://lkml.org/lkml/2012/12/18/201
- https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-December/024559.html
- http://comments.gmane.org/gmane.linux.usb.general/76352
- https://lkml.org/lkml/2012/12/13/492
Vivek Gautam (2):
ARM: Exynos5250: Enabling samsung-usbphy driver
ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver
arch/arm/boot/dts/exynos5250.dtsi | 23 +++++++++++++++++++++++
arch/arm/mach-exynos/include/mach/map.h | 1 +
arch/arm/mach-exynos/mach-exynos5-dt.c | 2 ++
3 files changed, 26 insertions(+), 0 deletions(-)
--
1.7.6.5
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 1/2] ARM: Exynos5250: Enabling samsung-usbphy driver
@ 2012-12-18 15:39 ` Vivek Gautam
0 siblings, 0 replies; 18+ messages in thread
From: Vivek Gautam @ 2012-12-18 15:39 UTC (permalink / raw)
To: linux-samsung-soc
Cc: linux-usb, devicetree-discuss, linux-kernel, kgene.kim, balbi,
thomas.abraham, rob.herring, grant.likely, sylvester.nawrocki,
p.paneri
Adding usbphy node for Exynos5250 along with the
necessary device data to be parsed.
Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
---
arch/arm/boot/dts/exynos5250.dtsi | 22 ++++++++++++++++++++++
arch/arm/mach-exynos/include/mach/map.h | 1 +
arch/arm/mach-exynos/mach-exynos5-dt.c | 2 ++
3 files changed, 25 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 581e57a..bbdb2c2 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -299,6 +299,28 @@
rx-dma-channel = <&pdma0 11>; /* preliminary */
};
+ phy_h0: usbdev_phyctrl@10040704 {
+ compatible = "samsung,usbdev-phyctrl";
+ samsung,phyhandle-reg = <0x10040704>;
+ };
+
+ phy_h1: usbhost_phyctrl@10040708 {
+ compatible = "samsung,usbhost-phyctrl";
+ samsung,phyhandle-reg = <0x10040708>;
+ };
+
+ phy_h2: usbhost_phycfg@10050230 {
+ compatible = "samsung,usb-phycfg";
+ samsung,phyhandle-reg = <0x10050230>;
+ };
+
+ usbphy@12130000 {
+ compatible = "samsung,exynos5250-usbphy";
+ reg = <0x12130000 0x100>;
+ samsung,usb-phyhandle = <&phy_h0 &phy_h1 &phy_h2>;
+ samsung,enable-mask = <1>;
+ };
+
amba {
#address-cells = <1>;
#size-cells = <1>;
diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-exynos/include/mach/map.h
index cbb2852..778348e 100644
--- a/arch/arm/mach-exynos/include/mach/map.h
+++ b/arch/arm/mach-exynos/include/mach/map.h
@@ -201,6 +201,7 @@
#define EXYNOS4_PA_EHCI 0x12580000
#define EXYNOS4_PA_OHCI 0x12590000
#define EXYNOS4_PA_HSPHY 0x125B0000
+#define EXYNOS5_PA_HSPHY 0x12130000
#define EXYNOS4_PA_MFC 0x13400000
#define EXYNOS4_PA_UART 0x13800000
diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c b/arch/arm/mach-exynos/mach-exynos5-dt.c
index 462e5ac..24e7529 100644
--- a/arch/arm/mach-exynos/mach-exynos5-dt.c
+++ b/arch/arm/mach-exynos/mach-exynos5-dt.c
@@ -110,6 +110,8 @@ static const struct of_dev_auxdata exynos5250_auxdata_lookup[] __initconst = {
"samsung-i2s.1", NULL),
OF_DEV_AUXDATA("samsung,samsung-i2s", 0x12D70000,
"samsung-i2s.2", NULL),
+ OF_DEV_AUXDATA("samsung,exynos5250-usbphy", EXYNOS5_PA_HSPHY,
+ "s3c-usbphy", NULL),
{},
};
--
1.7.6.5
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 1/2] ARM: Exynos5250: Enabling samsung-usbphy driver
@ 2012-12-18 15:39 ` Vivek Gautam
0 siblings, 0 replies; 18+ messages in thread
From: Vivek Gautam @ 2012-12-18 15:39 UTC (permalink / raw)
To: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA
Cc: kgene.kim-Sze3O3UU22JBDgjK7y7TUQ,
p.paneri-Sze3O3UU22JBDgjK7y7TUQ,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, balbi-l0cyMroinI0,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ,
sylvester.nawrocki-Re5JQEeQqe8AvxtiuMwx3w
Adding usbphy node for Exynos5250 along with the
necessary device data to be parsed.
Signed-off-by: Vivek Gautam <gautam.vivek-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
arch/arm/boot/dts/exynos5250.dtsi | 22 ++++++++++++++++++++++
arch/arm/mach-exynos/include/mach/map.h | 1 +
arch/arm/mach-exynos/mach-exynos5-dt.c | 2 ++
3 files changed, 25 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 581e57a..bbdb2c2 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -299,6 +299,28 @@
rx-dma-channel = <&pdma0 11>; /* preliminary */
};
+ phy_h0: usbdev_phyctrl@10040704 {
+ compatible = "samsung,usbdev-phyctrl";
+ samsung,phyhandle-reg = <0x10040704>;
+ };
+
+ phy_h1: usbhost_phyctrl@10040708 {
+ compatible = "samsung,usbhost-phyctrl";
+ samsung,phyhandle-reg = <0x10040708>;
+ };
+
+ phy_h2: usbhost_phycfg@10050230 {
+ compatible = "samsung,usb-phycfg";
+ samsung,phyhandle-reg = <0x10050230>;
+ };
+
+ usbphy@12130000 {
+ compatible = "samsung,exynos5250-usbphy";
+ reg = <0x12130000 0x100>;
+ samsung,usb-phyhandle = <&phy_h0 &phy_h1 &phy_h2>;
+ samsung,enable-mask = <1>;
+ };
+
amba {
#address-cells = <1>;
#size-cells = <1>;
diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-exynos/include/mach/map.h
index cbb2852..778348e 100644
--- a/arch/arm/mach-exynos/include/mach/map.h
+++ b/arch/arm/mach-exynos/include/mach/map.h
@@ -201,6 +201,7 @@
#define EXYNOS4_PA_EHCI 0x12580000
#define EXYNOS4_PA_OHCI 0x12590000
#define EXYNOS4_PA_HSPHY 0x125B0000
+#define EXYNOS5_PA_HSPHY 0x12130000
#define EXYNOS4_PA_MFC 0x13400000
#define EXYNOS4_PA_UART 0x13800000
diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c b/arch/arm/mach-exynos/mach-exynos5-dt.c
index 462e5ac..24e7529 100644
--- a/arch/arm/mach-exynos/mach-exynos5-dt.c
+++ b/arch/arm/mach-exynos/mach-exynos5-dt.c
@@ -110,6 +110,8 @@ static const struct of_dev_auxdata exynos5250_auxdata_lookup[] __initconst = {
"samsung-i2s.1", NULL),
OF_DEV_AUXDATA("samsung,samsung-i2s", 0x12D70000,
"samsung-i2s.2", NULL),
+ OF_DEV_AUXDATA("samsung,exynos5250-usbphy", EXYNOS5_PA_HSPHY,
+ "s3c-usbphy", NULL),
{},
};
--
1.7.6.5
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 2/2] ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver
2012-12-18 15:39 ` Vivek Gautam
(?)
(?)
@ 2012-12-18 15:39 ` Vivek Gautam
2012-12-18 23:32 ` Sylwester Nawrocki
-1 siblings, 1 reply; 18+ messages in thread
From: Vivek Gautam @ 2012-12-18 15:39 UTC (permalink / raw)
To: linux-samsung-soc
Cc: linux-usb, devicetree-discuss, linux-kernel, kgene.kim, balbi,
thomas.abraham, rob.herring, grant.likely, sylvester.nawrocki,
p.paneri
Adding base address information required for enabling
USB 3.0 DRD phy on exynos5250 SOC.
Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
---
arch/arm/boot/dts/exynos5250.dtsi | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index bbdb2c2..07b7477 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -316,7 +316,8 @@
usbphy@12130000 {
compatible = "samsung,exynos5250-usbphy";
- reg = <0x12130000 0x100>;
+ reg = <0x12130000 0x100>,
+ <0x12100000 0x100>;
samsung,usb-phyhandle = <&phy_h0 &phy_h1 &phy_h2>;
samsung,enable-mask = <1>;
};
--
1.7.6.5
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH 2/2] ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver
2012-12-18 15:39 ` [PATCH 2/2] ARM: Exynos5250: Enabling USB 3.0 phy for " Vivek Gautam
@ 2012-12-18 23:32 ` Sylwester Nawrocki
2012-12-19 5:49 ` Vivek Gautam
0 siblings, 1 reply; 18+ messages in thread
From: Sylwester Nawrocki @ 2012-12-18 23:32 UTC (permalink / raw)
To: Vivek Gautam
Cc: linux-samsung-soc, linux-usb, devicetree-discuss, linux-kernel,
kgene.kim, balbi, thomas.abraham, rob.herring, grant.likely,
p.paneri
On 12/18/2012 04:39 PM, Vivek Gautam wrote:
> Adding base address information required for enabling
> USB 3.0 DRD phy on exynos5250 SOC.
>
> Signed-off-by: Vivek Gautam<gautam.vivek@samsung.com>
> ---
> arch/arm/boot/dts/exynos5250.dtsi | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index bbdb2c2..07b7477 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -316,7 +316,8 @@
>
> usbphy@12130000 {
> compatible = "samsung,exynos5250-usbphy";
> - reg =<0x12130000 0x100>;
> + reg =<0x12130000 0x100>,
> + <0x12100000 0x100>;
Doesn't this second memory region mean distinct PHY controller device ?
Why separate usbphy node can't/shouldn't be created for it ?
> samsung,usb-phyhandle =<&phy_h0&phy_h1&phy_h2>;
> samsung,enable-mask =<1>;
> };
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy
2012-12-18 15:39 ` Vivek Gautam
` (2 preceding siblings ...)
(?)
@ 2012-12-19 5:45 ` Vivek Gautam
-1 siblings, 0 replies; 18+ messages in thread
From: Vivek Gautam @ 2012-12-19 5:45 UTC (permalink / raw)
To: linux-samsung-soc
Cc: dianders, linux-usb, devicetree-discuss, linux-kernel, kgene.kim,
balbi, thomas.abraham, rob.herring, grant.likely,
sylvester.nawrocki, Vivek Gautam
CC: Doug Anderson.
On Tue, Dec 18, 2012 at 9:09 PM, Vivek Gautam <gautam.vivek@samsung.com> wrote:
> This patch-set enables the samsung-usbphy driver on exynos5250,
> which enables the support for USB2 type and USB3 type phys.
> The corresponding phy driver patches are available at:
> 1) https://lkml.org/lkml/2012/12/18/201
> 2) https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-December/024559.html
>
> Tested this patch-set on exynos5250 with following patch-sets for
> USB 2.0 and USB 3.0:
> - https://patchwork.kernel.org/patch/1794651/
> - https://lkml.org/lkml/2012/12/18/201
> - https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-December/024559.html
> - http://comments.gmane.org/gmane.linux.usb.general/76352
> - https://lkml.org/lkml/2012/12/13/492
>
> Vivek Gautam (2):
> ARM: Exynos5250: Enabling samsung-usbphy driver
> ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver
>
> arch/arm/boot/dts/exynos5250.dtsi | 23 +++++++++++++++++++++++
> arch/arm/mach-exynos/include/mach/map.h | 1 +
> arch/arm/mach-exynos/mach-exynos5-dt.c | 2 ++
> 3 files changed, 26 insertions(+), 0 deletions(-)
>
> --
> 1.7.6.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Thanks & Regards
Vivek
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] ARM: Exynos5250: Enabling samsung-usbphy driver
2012-12-18 15:39 ` Vivek Gautam
(?)
@ 2012-12-19 5:47 ` Vivek Gautam
-1 siblings, 0 replies; 18+ messages in thread
From: Vivek Gautam @ 2012-12-19 5:47 UTC (permalink / raw)
To: linux-samsung-soc
Cc: dianders, kgene.kim, devicetree-discuss, linux-usb, linux-kernel,
balbi, rob.herring, sylvester.nawrocki, p.paneri, Vivek Gautam
CC: Doug Anderson.
On Tue, Dec 18, 2012 at 9:09 PM, Vivek Gautam <gautam.vivek@samsung.com> wrote:
> Adding usbphy node for Exynos5250 along with the
> necessary device data to be parsed.
>
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> ---
> arch/arm/boot/dts/exynos5250.dtsi | 22 ++++++++++++++++++++++
> arch/arm/mach-exynos/include/mach/map.h | 1 +
> arch/arm/mach-exynos/mach-exynos5-dt.c | 2 ++
> 3 files changed, 25 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 581e57a..bbdb2c2 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -299,6 +299,28 @@
> rx-dma-channel = <&pdma0 11>; /* preliminary */
> };
>
> + phy_h0: usbdev_phyctrl@10040704 {
> + compatible = "samsung,usbdev-phyctrl";
> + samsung,phyhandle-reg = <0x10040704>;
> + };
> +
> + phy_h1: usbhost_phyctrl@10040708 {
> + compatible = "samsung,usbhost-phyctrl";
> + samsung,phyhandle-reg = <0x10040708>;
> + };
> +
> + phy_h2: usbhost_phycfg@10050230 {
> + compatible = "samsung,usb-phycfg";
> + samsung,phyhandle-reg = <0x10050230>;
> + };
> +
> + usbphy@12130000 {
> + compatible = "samsung,exynos5250-usbphy";
> + reg = <0x12130000 0x100>;
> + samsung,usb-phyhandle = <&phy_h0 &phy_h1 &phy_h2>;
> + samsung,enable-mask = <1>;
> + };
> +
> amba {
> #address-cells = <1>;
> #size-cells = <1>;
> diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-exynos/include/mach/map.h
> index cbb2852..778348e 100644
> --- a/arch/arm/mach-exynos/include/mach/map.h
> +++ b/arch/arm/mach-exynos/include/mach/map.h
> @@ -201,6 +201,7 @@
> #define EXYNOS4_PA_EHCI 0x12580000
> #define EXYNOS4_PA_OHCI 0x12590000
> #define EXYNOS4_PA_HSPHY 0x125B0000
> +#define EXYNOS5_PA_HSPHY 0x12130000
> #define EXYNOS4_PA_MFC 0x13400000
>
> #define EXYNOS4_PA_UART 0x13800000
> diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c b/arch/arm/mach-exynos/mach-exynos5-dt.c
> index 462e5ac..24e7529 100644
> --- a/arch/arm/mach-exynos/mach-exynos5-dt.c
> +++ b/arch/arm/mach-exynos/mach-exynos5-dt.c
> @@ -110,6 +110,8 @@ static const struct of_dev_auxdata exynos5250_auxdata_lookup[] __initconst = {
> "samsung-i2s.1", NULL),
> OF_DEV_AUXDATA("samsung,samsung-i2s", 0x12D70000,
> "samsung-i2s.2", NULL),
> + OF_DEV_AUXDATA("samsung,exynos5250-usbphy", EXYNOS5_PA_HSPHY,
> + "s3c-usbphy", NULL),
> {},
> };
>
> --
> 1.7.6.5
>
> _______________________________________________
> devicetree-discuss mailing list
> devicetree-discuss@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/devicetree-discuss
--
Thanks & Regards
Vivek
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 2/2] ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver
2012-12-18 23:32 ` Sylwester Nawrocki
@ 2012-12-19 5:49 ` Vivek Gautam
0 siblings, 0 replies; 18+ messages in thread
From: Vivek Gautam @ 2012-12-19 5:49 UTC (permalink / raw)
To: linux-samsung-soc
Cc: dianders, Sylwester Nawrocki, linux-usb, devicetree-discuss,
linux-kernel, kgene.kim, balbi, thomas.abraham, rob.herring,
grant.likely, p.paneri, Vivek Gautam
CC: Doug Anderson.
On Wed, Dec 19, 2012 at 5:02 AM, Sylwester Nawrocki
<sylvester.nawrocki@gmail.com> wrote:
> On 12/18/2012 04:39 PM, Vivek Gautam wrote:
>>
>> Adding base address information required for enabling
>> USB 3.0 DRD phy on exynos5250 SOC.
>>
>> Signed-off-by: Vivek Gautam<gautam.vivek@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos5250.dtsi | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
>> b/arch/arm/boot/dts/exynos5250.dtsi
>> index bbdb2c2..07b7477 100644
>> --- a/arch/arm/boot/dts/exynos5250.dtsi
>> +++ b/arch/arm/boot/dts/exynos5250.dtsi
>> @@ -316,7 +316,8 @@
>>
>> usbphy@12130000 {
>> compatible = "samsung,exynos5250-usbphy";
>> - reg =<0x12130000 0x100>;
>> + reg =<0x12130000 0x100>,
>> + <0x12100000 0x100>;
>
>
> Doesn't this second memory region mean distinct PHY controller device ?
> Why separate usbphy node can't/shouldn't be created for it ?
>
>> samsung,usb-phyhandle =<&phy_h0&phy_h1&phy_h2>;
>> samsung,enable-mask =<1>;
>> };
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Thanks & Regards
Vivek
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy
@ 2013-01-18 13:10 ` Felipe Balbi
0 siblings, 0 replies; 18+ messages in thread
From: Felipe Balbi @ 2013-01-18 13:10 UTC (permalink / raw)
To: Vivek Gautam
Cc: linux-samsung-soc, linux-usb, devicetree-discuss, linux-kernel,
kgene.kim, balbi, thomas.abraham, rob.herring, grant.likely,
sylvester.nawrocki, p.paneri
[-- Attachment #1: Type: text/plain, Size: 1057 bytes --]
Hi,
On Tue, Dec 18, 2012 at 09:09:40PM +0530, Vivek Gautam wrote:
> This patch-set enables the samsung-usbphy driver on exynos5250,
> which enables the support for USB2 type and USB3 type phys.
> The corresponding phy driver patches are available at:
> 1) https://lkml.org/lkml/2012/12/18/201
> 2) https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-December/024559.html
>
> Tested this patch-set on exynos5250 with following patch-sets for
> USB 2.0 and USB 3.0:
> - https://patchwork.kernel.org/patch/1794651/
> - https://lkml.org/lkml/2012/12/18/201
> - https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-December/024559.html
> - http://comments.gmane.org/gmane.linux.usb.general/76352
> - https://lkml.org/lkml/2012/12/13/492
>
> Vivek Gautam (2):
> ARM: Exynos5250: Enabling samsung-usbphy driver
> ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver
What should I do with this series ? Is it ready to apply ? If it is,
then please resend with Kukjim's Acked-by.
cheers
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy
@ 2013-01-18 13:10 ` Felipe Balbi
0 siblings, 0 replies; 18+ messages in thread
From: Felipe Balbi @ 2013-01-18 13:10 UTC (permalink / raw)
To: Vivek Gautam
Cc: kgene.kim-Sze3O3UU22JBDgjK7y7TUQ,
p.paneri-Sze3O3UU22JBDgjK7y7TUQ,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, balbi-l0cyMroinI0,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ,
sylvester.nawrocki-Re5JQEeQqe8AvxtiuMwx3w
[-- Attachment #1.1: Type: text/plain, Size: 1057 bytes --]
Hi,
On Tue, Dec 18, 2012 at 09:09:40PM +0530, Vivek Gautam wrote:
> This patch-set enables the samsung-usbphy driver on exynos5250,
> which enables the support for USB2 type and USB3 type phys.
> The corresponding phy driver patches are available at:
> 1) https://lkml.org/lkml/2012/12/18/201
> 2) https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-December/024559.html
>
> Tested this patch-set on exynos5250 with following patch-sets for
> USB 2.0 and USB 3.0:
> - https://patchwork.kernel.org/patch/1794651/
> - https://lkml.org/lkml/2012/12/18/201
> - https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-December/024559.html
> - http://comments.gmane.org/gmane.linux.usb.general/76352
> - https://lkml.org/lkml/2012/12/13/492
>
> Vivek Gautam (2):
> ARM: Exynos5250: Enabling samsung-usbphy driver
> ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver
What should I do with this series ? Is it ready to apply ? If it is,
then please resend with Kukjim's Acked-by.
cheers
--
balbi
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 192 bytes --]
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy
@ 2013-01-18 13:12 ` Felipe Balbi
0 siblings, 0 replies; 18+ messages in thread
From: Felipe Balbi @ 2013-01-18 13:12 UTC (permalink / raw)
To: Felipe Balbi
Cc: Vivek Gautam, linux-samsung-soc, linux-usb, devicetree-discuss,
linux-kernel, kgene.kim, thomas.abraham, rob.herring,
grant.likely, sylvester.nawrocki, p.paneri
[-- Attachment #1: Type: text/plain, Size: 1272 bytes --]
On Fri, Jan 18, 2013 at 03:10:13PM +0200, Felipe Balbi wrote:
> Hi,
>
> On Tue, Dec 18, 2012 at 09:09:40PM +0530, Vivek Gautam wrote:
> > This patch-set enables the samsung-usbphy driver on exynos5250,
> > which enables the support for USB2 type and USB3 type phys.
> > The corresponding phy driver patches are available at:
> > 1) https://lkml.org/lkml/2012/12/18/201
> > 2) https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-December/024559.html
> >
> > Tested this patch-set on exynos5250 with following patch-sets for
> > USB 2.0 and USB 3.0:
> > - https://patchwork.kernel.org/patch/1794651/
> > - https://lkml.org/lkml/2012/12/18/201
> > - https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-December/024559.html
> > - http://comments.gmane.org/gmane.linux.usb.general/76352
> > - https://lkml.org/lkml/2012/12/13/492
> >
> > Vivek Gautam (2):
> > ARM: Exynos5250: Enabling samsung-usbphy driver
> > ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver
>
> What should I do with this series ? Is it ready to apply ? If it is,
> then please resend with Kukjim's Acked-by.
actually, now that I look again, it's all under arch/arm/, so Kukjim can
take all of those through his tree ;-)
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy
@ 2013-01-18 13:12 ` Felipe Balbi
0 siblings, 0 replies; 18+ messages in thread
From: Felipe Balbi @ 2013-01-18 13:12 UTC (permalink / raw)
To: Felipe Balbi
Cc: kgene.kim-Sze3O3UU22JBDgjK7y7TUQ,
p.paneri-Sze3O3UU22JBDgjK7y7TUQ,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, Vivek Gautam,
sylvester.nawrocki-Re5JQEeQqe8AvxtiuMwx3w
[-- Attachment #1.1: Type: text/plain, Size: 1272 bytes --]
On Fri, Jan 18, 2013 at 03:10:13PM +0200, Felipe Balbi wrote:
> Hi,
>
> On Tue, Dec 18, 2012 at 09:09:40PM +0530, Vivek Gautam wrote:
> > This patch-set enables the samsung-usbphy driver on exynos5250,
> > which enables the support for USB2 type and USB3 type phys.
> > The corresponding phy driver patches are available at:
> > 1) https://lkml.org/lkml/2012/12/18/201
> > 2) https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-December/024559.html
> >
> > Tested this patch-set on exynos5250 with following patch-sets for
> > USB 2.0 and USB 3.0:
> > - https://patchwork.kernel.org/patch/1794651/
> > - https://lkml.org/lkml/2012/12/18/201
> > - https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-December/024559.html
> > - http://comments.gmane.org/gmane.linux.usb.general/76352
> > - https://lkml.org/lkml/2012/12/13/492
> >
> > Vivek Gautam (2):
> > ARM: Exynos5250: Enabling samsung-usbphy driver
> > ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver
>
> What should I do with this series ? Is it ready to apply ? If it is,
> then please resend with Kukjim's Acked-by.
actually, now that I look again, it's all under arch/arm/, so Kukjim can
take all of those through his tree ;-)
--
balbi
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 192 bytes --]
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
^ permalink raw reply [flat|nested] 18+ messages in thread
* RE: [PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy
2013-01-18 13:12 ` Felipe Balbi
(?)
@ 2013-01-22 5:06 ` Kukjin Kim
2013-01-22 5:54 ` Vivek Gautam
-1 siblings, 1 reply; 18+ messages in thread
From: Kukjin Kim @ 2013-01-22 5:06 UTC (permalink / raw)
To: balbi
Cc: 'Vivek Gautam',
linux-samsung-soc, linux-usb, devicetree-discuss, linux-kernel,
thomas.abraham, rob.herring, grant.likely, sylvester.nawrocki,
p.paneri, cpgs
Felipe Balbi wrote:
>
> On Fri, Jan 18, 2013 at 03:10:13PM +0200, Felipe Balbi wrote:
> > Hi,
> >
> > On Tue, Dec 18, 2012 at 09:09:40PM +0530, Vivek Gautam wrote:
> > > This patch-set enables the samsung-usbphy driver on exynos5250,
> > > which enables the support for USB2 type and USB3 type phys.
> > > The corresponding phy driver patches are available at:
> > > 1) https://lkml.org/lkml/2012/12/18/201
> > > 2) https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-
> December/024559.html
> > >
> > > Tested this patch-set on exynos5250 with following patch-sets for
> > > USB 2.0 and USB 3.0:
> > > - https://patchwork.kernel.org/patch/1794651/
> > > - https://lkml.org/lkml/2012/12/18/201
> > > - https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-
> December/024559.html
> > > - http://comments.gmane.org/gmane.linux.usb.general/76352
> > > - https://lkml.org/lkml/2012/12/13/492
> > >
> > > Vivek Gautam (2):
> > > ARM: Exynos5250: Enabling samsung-usbphy driver
> > > ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver
> >
> > What should I do with this series ? Is it ready to apply ? If it is,
> > then please resend with Kukjim's Acked-by.
>
> actually, now that I look again, it's all under arch/arm/, so Kukjim can
> take all of those through his tree ;-)
>
Yes, once Vivek addresses comments from Sylwester, let me pick up into
Samsung tree :-)
Thanks.
- Kukjin
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy
2013-01-22 5:06 ` Kukjin Kim
@ 2013-01-22 5:54 ` Vivek Gautam
0 siblings, 0 replies; 18+ messages in thread
From: Vivek Gautam @ 2013-01-22 5:54 UTC (permalink / raw)
To: Kukjin Kim
Cc: balbi, Vivek Gautam, linux-samsung-soc, linux-usb,
devicetree-discuss, linux-kernel, thomas.abraham, rob.herring,
grant.likely, sylvester.nawrocki, p.paneri, cpgs
Hi Kukjin,
On Tue, Jan 22, 2013 at 10:36 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Felipe Balbi wrote:
>>
>> On Fri, Jan 18, 2013 at 03:10:13PM +0200, Felipe Balbi wrote:
>> > Hi,
>> >
>> > On Tue, Dec 18, 2012 at 09:09:40PM +0530, Vivek Gautam wrote:
>> > > This patch-set enables the samsung-usbphy driver on exynos5250,
>> > > which enables the support for USB2 type and USB3 type phys.
>> > > The corresponding phy driver patches are available at:
>> > > 1) https://lkml.org/lkml/2012/12/18/201
>> > > 2) https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-
>> December/024559.html
>> > >
>> > > Tested this patch-set on exynos5250 with following patch-sets for
>> > > USB 2.0 and USB 3.0:
>> > > - https://patchwork.kernel.org/patch/1794651/
>> > > - https://lkml.org/lkml/2012/12/18/201
>> > > - https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-
>> December/024559.html
>> > > - http://comments.gmane.org/gmane.linux.usb.general/76352
>> > > - https://lkml.org/lkml/2012/12/13/492
>> > >
>> > > Vivek Gautam (2):
>> > > ARM: Exynos5250: Enabling samsung-usbphy driver
>> > > ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver
>> >
>> > What should I do with this series ? Is it ready to apply ? If it is,
>> > then please resend with Kukjim's Acked-by.
>>
>> actually, now that I look again, it's all under arch/arm/, so Kukjim can
>> take all of those through his tree ;-)
>>
> Yes, once Vivek addresses comments from Sylwester, let me pick up into
> Samsung tree :-)
>
Sure, i shall update this patch-series based on separate drivers for
USB 3.0 PHY controller
as posted in following patch series :
[PATCH v3 0/2] Adding USB 3.0 DRD-phy support for exynos5250
--
Thanks & Regards
Vivek
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy
@ 2013-01-22 5:54 ` Vivek Gautam
0 siblings, 0 replies; 18+ messages in thread
From: Vivek Gautam @ 2013-01-22 5:54 UTC (permalink / raw)
To: Kukjin Kim
Cc: balbi-l0cyMroinI0, Vivek Gautam,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
thomas.abraham-QSEj5FYQhm4dnm+yROfE0A,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ,
grant.likely-s3s/WqlpOiPyB63q8FvJNQ,
sylvester.nawrocki-Re5JQEeQqe8AvxtiuMwx3w,
p.paneri-Sze3O3UU22JBDgjK7y7TUQ, cpgs-Sze3O3UU22JBDgjK7y7TUQ
Hi Kukjin,
On Tue, Jan 22, 2013 at 10:36 AM, Kukjin Kim <kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> Felipe Balbi wrote:
>>
>> On Fri, Jan 18, 2013 at 03:10:13PM +0200, Felipe Balbi wrote:
>> > Hi,
>> >
>> > On Tue, Dec 18, 2012 at 09:09:40PM +0530, Vivek Gautam wrote:
>> > > This patch-set enables the samsung-usbphy driver on exynos5250,
>> > > which enables the support for USB2 type and USB3 type phys.
>> > > The corresponding phy driver patches are available at:
>> > > 1) https://lkml.org/lkml/2012/12/18/201
>> > > 2) https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-
>> December/024559.html
>> > >
>> > > Tested this patch-set on exynos5250 with following patch-sets for
>> > > USB 2.0 and USB 3.0:
>> > > - https://patchwork.kernel.org/patch/1794651/
>> > > - https://lkml.org/lkml/2012/12/18/201
>> > > - https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-
>> December/024559.html
>> > > - http://comments.gmane.org/gmane.linux.usb.general/76352
>> > > - https://lkml.org/lkml/2012/12/13/492
>> > >
>> > > Vivek Gautam (2):
>> > > ARM: Exynos5250: Enabling samsung-usbphy driver
>> > > ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver
>> >
>> > What should I do with this series ? Is it ready to apply ? If it is,
>> > then please resend with Kukjim's Acked-by.
>>
>> actually, now that I look again, it's all under arch/arm/, so Kukjim can
>> take all of those through his tree ;-)
>>
> Yes, once Vivek addresses comments from Sylwester, let me pick up into
> Samsung tree :-)
>
Sure, i shall update this patch-series based on separate drivers for
USB 3.0 PHY controller
as posted in following patch series :
[PATCH v3 0/2] Adding USB 3.0 DRD-phy support for exynos5250
--
Thanks & Regards
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 2/2] ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver
2012-11-06 15:36 ` [PATCH 2/2] ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver Vivek Gautam
@ 2012-11-07 18:34 ` Sylwester Nawrocki
0 siblings, 0 replies; 18+ messages in thread
From: Sylwester Nawrocki @ 2012-11-07 18:34 UTC (permalink / raw)
To: Vivek Gautam
Cc: linux-usb, linux-samsung-soc, devicetree-discuss, gregkh, balbi,
rob.herring, kgene.kim, yulgon.kim, av.tikhomirov,
thomas.abraham, kishon, p.paneri
Hi Vivek,
On 11/06/2012 04:36 PM, Vivek Gautam wrote:
> Adding base address information and required platform data
> support for enabling USB DRD phy on exynos5250 SOC.
>
> Signed-off-by: Vivek Gautam<gautam.vivek@samsung.com>
> ---
> arch/arm/boot/dts/exynos5250.dtsi | 3 ++-
> arch/arm/mach-exynos/include/mach/regs-pmu.h | 4 ++++
> arch/arm/mach-exynos/setup-usb-phy.c | 9 +++++++++
> 3 files changed, 15 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 82bf042..51693af 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -220,7 +220,8 @@
>
> usbphy {
> compatible = "samsung,exynos5250-usbphy";
> - reg =<0x12130000 0x100>;
> + reg =<0x12130000 0x100>,
> + <0x12100000 0x100>;
> };
>
> amba {
> diff --git a/arch/arm/mach-exynos/include/mach/regs-pmu.h b/arch/arm/mach-exynos/include/mach/regs-pmu.h
> index d4e392b..67132b4 100644
> --- a/arch/arm/mach-exynos/include/mach/regs-pmu.h
> +++ b/arch/arm/mach-exynos/include/mach/regs-pmu.h
> @@ -39,6 +39,10 @@
> #define S5P_HDMI_PHY_CONTROL S5P_PMUREG(0x0700)
> #define S5P_HDMI_PHY_ENABLE (1<< 0)
>
> +/* only for EXYNOS5250*/
> +#define S5P_USBDRD_PHY_CONTROL S5P_PMUREG(0x0704)
> +#define S5P_USBDRD_PHY_ENABLE (1<< 0)
Hmm, couldn't it be added to your usbphy node above and then this register
left for the usb phy driver to do ioremap and control it directly ? Rather
than relying on the platform data callback ? I hoped this static mapping
can be dropped once there is a proper usb phy driver in place. AFAIU
arch/arm/mach-exynos/setup-usb-phy.c is supposed to be a non-dt only thing.
> +
> #define S5P_DAC_PHY_CONTROL S5P_PMUREG(0x070C)
> #define S5P_DAC_PHY_ENABLE (1<< 0)
>
> diff --git a/arch/arm/mach-exynos/setup-usb-phy.c b/arch/arm/mach-exynos/setup-usb-phy.c
> index 6c768e0..5e46fdd 100644
> --- a/arch/arm/mach-exynos/setup-usb-phy.c
> +++ b/arch/arm/mach-exynos/setup-usb-phy.c
> @@ -238,6 +238,15 @@ void s5p_usb_phy_pmu_isolation(int on, int type)
> writel(readl(S5P_USBHOST_PHY_CONTROL)
> | S5P_USBHOST_PHY_ENABLE,
> S5P_USBHOST_PHY_CONTROL);
> + } else if (type == USB_PHY_TYPE_DRD) {
> + if (on)
> + writel(readl(S5P_USBDRD_PHY_CONTROL)
> + & ~S5P_USBDRD_PHY_ENABLE,
> + S5P_USBDRD_PHY_CONTROL);
This is horrible coding style IMHO BTW. Why not just do
u32 reg = readl(S5P_USBDRD_PHY_CONTROL);
if (on)
reg &= ~S5P_USBDRD_PHY_ENABLE;
else
reg |= ~S5P_USBDRD_PHY_ENABLE;
writel(reg, S5P_USBDRD_PHY_CONTROL);
Or to create some read/modify/write helper ? Anyway, I suppose this whole
setup-usb-phy.c file is going to be removed, once exynos is completely dt
only.
> + else
> + writel(readl(S5P_USBDRD_PHY_CONTROL)
> + | S5P_USBDRD_PHY_ENABLE,
> + S5P_USBDRD_PHY_CONTROL);
> } else {
> if (on)
> writel(readl(S5P_USBDEVICE_PHY_CONTROL)
--
Thanks,
Sylwester
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 2/2] ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver
2012-11-06 15:36 [PATCH 0/2] Adding USB 3.0 DRD-phy support for exynos5250 Vivek Gautam
@ 2012-11-06 15:36 ` Vivek Gautam
2012-11-07 18:34 ` Sylwester Nawrocki
0 siblings, 1 reply; 18+ messages in thread
From: Vivek Gautam @ 2012-11-06 15:36 UTC (permalink / raw)
To: linux-usb, linux-samsung-soc, devicetree-discuss
Cc: gregkh, balbi, rob.herring, kgene.kim, yulgon.kim, av.tikhomirov,
thomas.abraham, kishon, p.paneri
Adding base address information and required platform data
support for enabling USB DRD phy on exynos5250 SOC.
Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
---
arch/arm/boot/dts/exynos5250.dtsi | 3 ++-
arch/arm/mach-exynos/include/mach/regs-pmu.h | 4 ++++
arch/arm/mach-exynos/setup-usb-phy.c | 9 +++++++++
3 files changed, 15 insertions(+), 1 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 82bf042..51693af 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -220,7 +220,8 @@
usbphy {
compatible = "samsung,exynos5250-usbphy";
- reg = <0x12130000 0x100>;
+ reg = <0x12130000 0x100>,
+ <0x12100000 0x100>;
};
amba {
diff --git a/arch/arm/mach-exynos/include/mach/regs-pmu.h b/arch/arm/mach-exynos/include/mach/regs-pmu.h
index d4e392b..67132b4 100644
--- a/arch/arm/mach-exynos/include/mach/regs-pmu.h
+++ b/arch/arm/mach-exynos/include/mach/regs-pmu.h
@@ -39,6 +39,10 @@
#define S5P_HDMI_PHY_CONTROL S5P_PMUREG(0x0700)
#define S5P_HDMI_PHY_ENABLE (1 << 0)
+/* only for EXYNOS5250*/
+#define S5P_USBDRD_PHY_CONTROL S5P_PMUREG(0x0704)
+#define S5P_USBDRD_PHY_ENABLE (1 << 0)
+
#define S5P_DAC_PHY_CONTROL S5P_PMUREG(0x070C)
#define S5P_DAC_PHY_ENABLE (1 << 0)
diff --git a/arch/arm/mach-exynos/setup-usb-phy.c b/arch/arm/mach-exynos/setup-usb-phy.c
index 6c768e0..5e46fdd 100644
--- a/arch/arm/mach-exynos/setup-usb-phy.c
+++ b/arch/arm/mach-exynos/setup-usb-phy.c
@@ -238,6 +238,15 @@ void s5p_usb_phy_pmu_isolation(int on, int type)
writel(readl(S5P_USBHOST_PHY_CONTROL)
| S5P_USBHOST_PHY_ENABLE,
S5P_USBHOST_PHY_CONTROL);
+ } else if (type == USB_PHY_TYPE_DRD) {
+ if (on)
+ writel(readl(S5P_USBDRD_PHY_CONTROL)
+ & ~S5P_USBDRD_PHY_ENABLE,
+ S5P_USBDRD_PHY_CONTROL);
+ else
+ writel(readl(S5P_USBDRD_PHY_CONTROL)
+ | S5P_USBDRD_PHY_ENABLE,
+ S5P_USBDRD_PHY_CONTROL);
} else {
if (on)
writel(readl(S5P_USBDEVICE_PHY_CONTROL)
--
1.7.6.5
^ permalink raw reply related [flat|nested] 18+ messages in thread
end of thread, other threads:[~2013-01-22 5:54 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-18 15:39 [PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy Vivek Gautam
2012-12-18 15:39 ` Vivek Gautam
2012-12-18 15:39 ` [PATCH 1/2] ARM: Exynos5250: Enabling samsung-usbphy driver Vivek Gautam
2012-12-18 15:39 ` Vivek Gautam
2012-12-19 5:47 ` Vivek Gautam
2012-12-18 15:39 ` [PATCH 2/2] ARM: Exynos5250: Enabling USB 3.0 phy for " Vivek Gautam
2012-12-18 23:32 ` Sylwester Nawrocki
2012-12-19 5:49 ` Vivek Gautam
2012-12-19 5:45 ` [PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy Vivek Gautam
2013-01-18 13:10 ` Felipe Balbi
2013-01-18 13:10 ` Felipe Balbi
2013-01-18 13:12 ` Felipe Balbi
2013-01-18 13:12 ` Felipe Balbi
2013-01-22 5:06 ` Kukjin Kim
2013-01-22 5:54 ` Vivek Gautam
2013-01-22 5:54 ` Vivek Gautam
-- strict thread matches above, loose matches on Subject: below --
2012-11-06 15:36 [PATCH 0/2] Adding USB 3.0 DRD-phy support for exynos5250 Vivek Gautam
2012-11-06 15:36 ` [PATCH 2/2] ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver Vivek Gautam
2012-11-07 18:34 ` Sylwester Nawrocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.