All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] ARM: OMAP: Fix build breakage due to missing include in i2c.c
@ 2012-12-19  6:46 ` Vaibhav Bedia
  0 siblings, 0 replies; 6+ messages in thread
From: Vaibhav Bedia @ 2012-12-19  6:46 UTC (permalink / raw)
  To: tony; +Cc: linux-arm-kernel, linux-omap, Vaibhav Bedia

Merge commit 752451f (Merge branch 'i2c-embedded/for-next' of git://git.pengutronix.de/git/wsa/linux)
resulted in a build breakage for OMAP

...
arch/arm/mach-omap2/i2c.c: In function 'omap_pm_set_max_mpu_wakeup_lat_compat':
arch/arm/mach-omap2/i2c.c:130:2: error: implicit declaration of function 'omap_pm_set_max_mpu_wakeup_lat'
make[1]: *** [arch/arm/mach-omap2/i2c.o] Error 1
...

Fix this by including the appropriate header file with the function prototype

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Vaibhav Bedia <vaibhav.bedia@ti.com>
---
 arch/arm/mach-omap2/i2c.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/i2c.c b/arch/arm/mach-omap2/i2c.c
index df6d6ac..b9074dd 100644
--- a/arch/arm/mach-omap2/i2c.c
+++ b/arch/arm/mach-omap2/i2c.c
@@ -22,6 +22,7 @@
 #include "soc.h"
 #include "omap_hwmod.h"
 #include "omap_device.h"
+#include "omap-pm.h"
 
 #include "prm.h"
 #include "common.h"
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 1/1] ARM: OMAP: Fix build breakage due to missing include in i2c.c
@ 2012-12-19  6:46 ` Vaibhav Bedia
  0 siblings, 0 replies; 6+ messages in thread
From: Vaibhav Bedia @ 2012-12-19  6:46 UTC (permalink / raw)
  To: linux-arm-kernel

Merge commit 752451f (Merge branch 'i2c-embedded/for-next' of git://git.pengutronix.de/git/wsa/linux)
resulted in a build breakage for OMAP

...
arch/arm/mach-omap2/i2c.c: In function 'omap_pm_set_max_mpu_wakeup_lat_compat':
arch/arm/mach-omap2/i2c.c:130:2: error: implicit declaration of function 'omap_pm_set_max_mpu_wakeup_lat'
make[1]: *** [arch/arm/mach-omap2/i2c.o] Error 1
...

Fix this by including the appropriate header file with the function prototype

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Vaibhav Bedia <vaibhav.bedia@ti.com>
---
 arch/arm/mach-omap2/i2c.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/i2c.c b/arch/arm/mach-omap2/i2c.c
index df6d6ac..b9074dd 100644
--- a/arch/arm/mach-omap2/i2c.c
+++ b/arch/arm/mach-omap2/i2c.c
@@ -22,6 +22,7 @@
 #include "soc.h"
 #include "omap_hwmod.h"
 #include "omap_device.h"
+#include "omap-pm.h"
 
 #include "prm.h"
 #include "common.h"
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] ARM: OMAP: Fix build breakage due to missing include in i2c.c
  2012-12-19  6:46 ` Vaibhav Bedia
@ 2012-12-19 16:38   ` Tony Lindgren
  -1 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2012-12-19 16:38 UTC (permalink / raw)
  To: Vaibhav Bedia; +Cc: linux-arm-kernel, linux-omap

* Vaibhav Bedia <vaibhav.bedia@ti.com> [121218 22:49]:
> Merge commit 752451f (Merge branch 'i2c-embedded/for-next' of git://git.pengutronix.de/git/wsa/linux)
> resulted in a build breakage for OMAP
> 
> ...
> arch/arm/mach-omap2/i2c.c: In function 'omap_pm_set_max_mpu_wakeup_lat_compat':
> arch/arm/mach-omap2/i2c.c:130:2: error: implicit declaration of function 'omap_pm_set_max_mpu_wakeup_lat'
> make[1]: *** [arch/arm/mach-omap2/i2c.o] Error 1
> ...
> 
> Fix this by including the appropriate header file with the function prototype

Thanks applying.

Tony
 
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Vaibhav Bedia <vaibhav.bedia@ti.com>
> ---
>  arch/arm/mach-omap2/i2c.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/i2c.c b/arch/arm/mach-omap2/i2c.c
> index df6d6ac..b9074dd 100644
> --- a/arch/arm/mach-omap2/i2c.c
> +++ b/arch/arm/mach-omap2/i2c.c
> @@ -22,6 +22,7 @@
>  #include "soc.h"
>  #include "omap_hwmod.h"
>  #include "omap_device.h"
> +#include "omap-pm.h"
>  
>  #include "prm.h"
>  #include "common.h"
> -- 
> 1.7.0.4
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/1] ARM: OMAP: Fix build breakage due to missing include in i2c.c
@ 2012-12-19 16:38   ` Tony Lindgren
  0 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2012-12-19 16:38 UTC (permalink / raw)
  To: linux-arm-kernel

* Vaibhav Bedia <vaibhav.bedia@ti.com> [121218 22:49]:
> Merge commit 752451f (Merge branch 'i2c-embedded/for-next' of git://git.pengutronix.de/git/wsa/linux)
> resulted in a build breakage for OMAP
> 
> ...
> arch/arm/mach-omap2/i2c.c: In function 'omap_pm_set_max_mpu_wakeup_lat_compat':
> arch/arm/mach-omap2/i2c.c:130:2: error: implicit declaration of function 'omap_pm_set_max_mpu_wakeup_lat'
> make[1]: *** [arch/arm/mach-omap2/i2c.o] Error 1
> ...
> 
> Fix this by including the appropriate header file with the function prototype

Thanks applying.

Tony
 
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Vaibhav Bedia <vaibhav.bedia@ti.com>
> ---
>  arch/arm/mach-omap2/i2c.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/i2c.c b/arch/arm/mach-omap2/i2c.c
> index df6d6ac..b9074dd 100644
> --- a/arch/arm/mach-omap2/i2c.c
> +++ b/arch/arm/mach-omap2/i2c.c
> @@ -22,6 +22,7 @@
>  #include "soc.h"
>  #include "omap_hwmod.h"
>  #include "omap_device.h"
> +#include "omap-pm.h"
>  
>  #include "prm.h"
>  #include "common.h"
> -- 
> 1.7.0.4
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH 1/1] ARM: OMAP: Fix build breakage due to missing include in i2c.c
  2012-12-19  6:44 Vaibhav Bedia
@ 2012-12-19  6:50 ` Bedia, Vaibhav
  0 siblings, 0 replies; 6+ messages in thread
From: Bedia, Vaibhav @ 2012-12-19  6:50 UTC (permalink / raw)
  To: Bedia, Vaibhav, tony; +Cc: linux-arm-kernel, linux-omap

On Wed, Dec 19, 2012 at 12:14:58, Bedia, Vaibhav wrote:
> Merge commit 752451f (Merge branch 'i2c-embedded/for-next' of git://git.pengutronix.de/git/wsa/linux)
> resulted in a build breakage for OMAP
> 
> ...
> arch/arm/mach-omap2/i2c.c: In function 'omap_pm_set_max_mpu_wakeup_lat_compat':
> arch/arm/mach-omap2/i2c.c:130:2: error: implicit declaration of function 'omap_pm_set_max_mpu_wakeup_lat'
> make[1]: *** [arch/arm/mach-omap2/i2c.o] Error 1
> ...
> 
> Fix this by including the appropriate header file with the function prototype
> 
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Vaibhav Bedia <vaibhav.bedia@ti.com>

I messed up the LAKML address in this version. Resent with the right address.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/1] ARM: OMAP: Fix build breakage due to missing include in i2c.c
@ 2012-12-19  6:44 Vaibhav Bedia
  2012-12-19  6:50 ` Bedia, Vaibhav
  0 siblings, 1 reply; 6+ messages in thread
From: Vaibhav Bedia @ 2012-12-19  6:44 UTC (permalink / raw)
  To: tony; +Cc: linux-arm-kernel, linux-omap, Vaibhav Bedia

Merge commit 752451f (Merge branch 'i2c-embedded/for-next' of git://git.pengutronix.de/git/wsa/linux)
resulted in a build breakage for OMAP

...
arch/arm/mach-omap2/i2c.c: In function 'omap_pm_set_max_mpu_wakeup_lat_compat':
arch/arm/mach-omap2/i2c.c:130:2: error: implicit declaration of function 'omap_pm_set_max_mpu_wakeup_lat'
make[1]: *** [arch/arm/mach-omap2/i2c.o] Error 1
...

Fix this by including the appropriate header file with the function prototype

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Vaibhav Bedia <vaibhav.bedia@ti.com>
---
 arch/arm/mach-omap2/i2c.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/i2c.c b/arch/arm/mach-omap2/i2c.c
index df6d6ac..b9074dd 100644
--- a/arch/arm/mach-omap2/i2c.c
+++ b/arch/arm/mach-omap2/i2c.c
@@ -22,6 +22,7 @@
 #include "soc.h"
 #include "omap_hwmod.h"
 #include "omap_device.h"
+#include "omap-pm.h"
 
 #include "prm.h"
 #include "common.h"
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2012-12-19 16:38 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-19  6:46 [PATCH 1/1] ARM: OMAP: Fix build breakage due to missing include in i2c.c Vaibhav Bedia
2012-12-19  6:46 ` Vaibhav Bedia
2012-12-19 16:38 ` Tony Lindgren
2012-12-19 16:38   ` Tony Lindgren
  -- strict thread matches above, loose matches on Subject: below --
2012-12-19  6:44 Vaibhav Bedia
2012-12-19  6:50 ` Bedia, Vaibhav

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.