* [PATCH 2/2] thermal: db8500: Use of_match_ptr() macro in db8500_cpufreq_cooling.c
2012-12-19 8:50 [PATCH 1/2] thermal: db8500: Use of_match_ptr() macro in db8500_thermal.c Sachin Kamat
@ 2012-12-19 8:50 ` Sachin Kamat
2013-01-03 9:07 ` Hongbo Zhang
2013-01-04 7:36 ` Zhang Rui
2013-01-03 9:05 ` [PATCH 1/2] thermal: db8500: Use of_match_ptr() macro in db8500_thermal.c Hongbo Zhang
2013-01-04 7:36 ` Zhang Rui
2 siblings, 2 replies; 6+ messages in thread
From: Sachin Kamat @ 2012-12-19 8:50 UTC (permalink / raw)
To: linux-pm; +Cc: rui.zhang, hongbo.zhang, sachin.kamat, patches, Hongbo Zhang
This eliminates having an #ifdef returning NULL for the case
when OF is disabled.
Cc: Hongbo Zhang <hongbo.zhang@stericsson.com>
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
Compile tested on linux-next.
---
drivers/thermal/db8500_cpufreq_cooling.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/thermal/db8500_cpufreq_cooling.c b/drivers/thermal/db8500_cpufreq_cooling.c
index 4cf8e72..2141985 100644
--- a/drivers/thermal/db8500_cpufreq_cooling.c
+++ b/drivers/thermal/db8500_cpufreq_cooling.c
@@ -21,6 +21,7 @@
#include <linux/cpufreq.h>
#include <linux/err.h>
#include <linux/module.h>
+#include <linux/of.h>
#include <linux/platform_device.h>
#include <linux/slab.h>
@@ -73,15 +74,13 @@ static const struct of_device_id db8500_cpufreq_cooling_match[] = {
{ .compatible = "stericsson,db8500-cpufreq-cooling" },
{},
};
-#else
-#define db8500_cpufreq_cooling_match NULL
#endif
static struct platform_driver db8500_cpufreq_cooling_driver = {
.driver = {
.owner = THIS_MODULE,
.name = "db8500-cpufreq-cooling",
- .of_match_table = db8500_cpufreq_cooling_match,
+ .of_match_table = of_match_ptr(db8500_cpufreq_cooling_match),
},
.probe = db8500_cpufreq_cooling_probe,
.suspend = db8500_cpufreq_cooling_suspend,
--
1.7.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] thermal: db8500: Use of_match_ptr() macro in db8500_cpufreq_cooling.c
2012-12-19 8:50 ` [PATCH 2/2] thermal: db8500: Use of_match_ptr() macro in db8500_cpufreq_cooling.c Sachin Kamat
@ 2013-01-03 9:07 ` Hongbo Zhang
2013-01-04 7:36 ` Zhang Rui
1 sibling, 0 replies; 6+ messages in thread
From: Hongbo Zhang @ 2013-01-03 9:07 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-pm, rui.zhang, patches, Hongbo Zhang
On 19 December 2012 16:50, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> This eliminates having an #ifdef returning NULL for the case
> when OF is disabled.
>
> Cc: Hongbo Zhang <hongbo.zhang@stericsson.com>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> Compile tested on linux-next.
> ---
> drivers/thermal/db8500_cpufreq_cooling.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/thermal/db8500_cpufreq_cooling.c b/drivers/thermal/db8500_cpufreq_cooling.c
> index 4cf8e72..2141985 100644
> --- a/drivers/thermal/db8500_cpufreq_cooling.c
> +++ b/drivers/thermal/db8500_cpufreq_cooling.c
> @@ -21,6 +21,7 @@
> #include <linux/cpufreq.h>
> #include <linux/err.h>
> #include <linux/module.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
>
> @@ -73,15 +74,13 @@ static const struct of_device_id db8500_cpufreq_cooling_match[] = {
> { .compatible = "stericsson,db8500-cpufreq-cooling" },
> {},
> };
> -#else
> -#define db8500_cpufreq_cooling_match NULL
> #endif
>
> static struct platform_driver db8500_cpufreq_cooling_driver = {
> .driver = {
> .owner = THIS_MODULE,
> .name = "db8500-cpufreq-cooling",
> - .of_match_table = db8500_cpufreq_cooling_match,
> + .of_match_table = of_match_ptr(db8500_cpufreq_cooling_match),
> },
> .probe = db8500_cpufreq_cooling_probe,
> .suspend = db8500_cpufreq_cooling_suspend,
> --
> 1.7.4.1
>
Good one.
Reviewed-by: hongbo.zhang@linaro.org
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] thermal: db8500: Use of_match_ptr() macro in db8500_cpufreq_cooling.c
2012-12-19 8:50 ` [PATCH 2/2] thermal: db8500: Use of_match_ptr() macro in db8500_cpufreq_cooling.c Sachin Kamat
2013-01-03 9:07 ` Hongbo Zhang
@ 2013-01-04 7:36 ` Zhang Rui
1 sibling, 0 replies; 6+ messages in thread
From: Zhang Rui @ 2013-01-04 7:36 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-pm, hongbo.zhang, patches, Hongbo Zhang
On Wed, 2012-12-19 at 14:20 +0530, Sachin Kamat wrote:
> This eliminates having an #ifdef returning NULL for the case
> when OF is disabled.
>
> Cc: Hongbo Zhang <hongbo.zhang@stericsson.com>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
applied to thermal-next.
thanks,
rui
> ---
> Compile tested on linux-next.
> ---
> drivers/thermal/db8500_cpufreq_cooling.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/thermal/db8500_cpufreq_cooling.c b/drivers/thermal/db8500_cpufreq_cooling.c
> index 4cf8e72..2141985 100644
> --- a/drivers/thermal/db8500_cpufreq_cooling.c
> +++ b/drivers/thermal/db8500_cpufreq_cooling.c
> @@ -21,6 +21,7 @@
> #include <linux/cpufreq.h>
> #include <linux/err.h>
> #include <linux/module.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
>
> @@ -73,15 +74,13 @@ static const struct of_device_id db8500_cpufreq_cooling_match[] = {
> { .compatible = "stericsson,db8500-cpufreq-cooling" },
> {},
> };
> -#else
> -#define db8500_cpufreq_cooling_match NULL
> #endif
>
> static struct platform_driver db8500_cpufreq_cooling_driver = {
> .driver = {
> .owner = THIS_MODULE,
> .name = "db8500-cpufreq-cooling",
> - .of_match_table = db8500_cpufreq_cooling_match,
> + .of_match_table = of_match_ptr(db8500_cpufreq_cooling_match),
> },
> .probe = db8500_cpufreq_cooling_probe,
> .suspend = db8500_cpufreq_cooling_suspend,
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] thermal: db8500: Use of_match_ptr() macro in db8500_thermal.c
2012-12-19 8:50 [PATCH 1/2] thermal: db8500: Use of_match_ptr() macro in db8500_thermal.c Sachin Kamat
2012-12-19 8:50 ` [PATCH 2/2] thermal: db8500: Use of_match_ptr() macro in db8500_cpufreq_cooling.c Sachin Kamat
@ 2013-01-03 9:05 ` Hongbo Zhang
2013-01-04 7:36 ` Zhang Rui
2 siblings, 0 replies; 6+ messages in thread
From: Hongbo Zhang @ 2013-01-03 9:05 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-pm, rui.zhang, patches, Hongbo Zhang
On 19 December 2012 16:50, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> This eliminates having an #ifdef returning NULL for the case
> when OF is disabled.
>
> Cc: Hongbo Zhang <hongbo.zhang@stericsson.com>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> Compile tested on linux-next.
> ---
> drivers/thermal/db8500_thermal.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/thermal/db8500_thermal.c b/drivers/thermal/db8500_thermal.c
> index ec71ade..61ce60a 100644
> --- a/drivers/thermal/db8500_thermal.c
> +++ b/drivers/thermal/db8500_thermal.c
> @@ -508,15 +508,13 @@ static const struct of_device_id db8500_thermal_match[] = {
> { .compatible = "stericsson,db8500-thermal" },
> {},
> };
> -#else
> -#define db8500_thermal_match NULL
> #endif
>
> static struct platform_driver db8500_thermal_driver = {
> .driver = {
> .owner = THIS_MODULE,
> .name = "db8500-thermal",
> - .of_match_table = db8500_thermal_match,
> + .of_match_table = of_match_ptr(db8500_thermal_match),
> },
> .probe = db8500_thermal_probe,
> .suspend = db8500_thermal_suspend,
> --
> 1.7.4.1
>
Good one.
Reviewed-by: hongbo.zhang@linaro.org
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] thermal: db8500: Use of_match_ptr() macro in db8500_thermal.c
2012-12-19 8:50 [PATCH 1/2] thermal: db8500: Use of_match_ptr() macro in db8500_thermal.c Sachin Kamat
2012-12-19 8:50 ` [PATCH 2/2] thermal: db8500: Use of_match_ptr() macro in db8500_cpufreq_cooling.c Sachin Kamat
2013-01-03 9:05 ` [PATCH 1/2] thermal: db8500: Use of_match_ptr() macro in db8500_thermal.c Hongbo Zhang
@ 2013-01-04 7:36 ` Zhang Rui
2 siblings, 0 replies; 6+ messages in thread
From: Zhang Rui @ 2013-01-04 7:36 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-pm, hongbo.zhang, patches, Hongbo Zhang
On Wed, 2012-12-19 at 14:20 +0530, Sachin Kamat wrote:
> This eliminates having an #ifdef returning NULL for the case
> when OF is disabled.
>
> Cc: Hongbo Zhang <hongbo.zhang@stericsson.com>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
applied to thermal-next.
thanks,
rui
> ---
> Compile tested on linux-next.
> ---
> drivers/thermal/db8500_thermal.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/thermal/db8500_thermal.c b/drivers/thermal/db8500_thermal.c
> index ec71ade..61ce60a 100644
> --- a/drivers/thermal/db8500_thermal.c
> +++ b/drivers/thermal/db8500_thermal.c
> @@ -508,15 +508,13 @@ static const struct of_device_id db8500_thermal_match[] = {
> { .compatible = "stericsson,db8500-thermal" },
> {},
> };
> -#else
> -#define db8500_thermal_match NULL
> #endif
>
> static struct platform_driver db8500_thermal_driver = {
> .driver = {
> .owner = THIS_MODULE,
> .name = "db8500-thermal",
> - .of_match_table = db8500_thermal_match,
> + .of_match_table = of_match_ptr(db8500_thermal_match),
> },
> .probe = db8500_thermal_probe,
> .suspend = db8500_thermal_suspend,
^ permalink raw reply [flat|nested] 6+ messages in thread