[PATCH] namei.h: include errno.h

[PATCH] namei.h: include errno.h

[Stephen Warren]

This solves:

In file included from fs/ext3/symlink.c:20:0:
include/linux/namei.h: In function 'retry_estale':
include/linux/namei.h:114:19: error: 'ESTALE' undeclared (first use in this function)

Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
---
 include/linux/namei.h |    1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/namei.h b/include/linux/namei.h
index e998c03..5a5ff57 100644
--- a/include/linux/namei.h
+++ b/include/linux/namei.h
@@ -2,6 +2,7 @@
 #define _LINUX_NAMEI_H
 
 #include <linux/dcache.h>
+#include <linux/errno.h>
 #include <linux/linkage.h>
 #include <linux/path.h>
 
-- 
1.7.10.4

Re: namei.h: include errno.h

[Theodore Ts'o]

On Mon, Dec 24, 2012 at 08:14:58AM -0000, Stephen Warren wrote:
> This solves:
> 
> In file included from fs/ext3/symlink.c:20:0:
> include/linux/namei.h: In function 'retry_estale':
> include/linux/namei.h:114:19: error: 'ESTALE' undeclared (first use in this function)
> 
> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>

Reviewed-by: "Theodore Ts'o" <tytso@mit.edu>

Looks good to me.  You might want to add that this commit fixes a
build failure regression in v3.8-rc1 which was introduced in commit
b9d6ba94b875.

Al, you want to take this, since the original commit went in via the
VFS tree?   Or should we have Jan carry this patch?

    	       	      	      	  	- Ted

Re: namei.h: include errno.h

[Al Viro]

On Tue, Dec 25, 2012 at 01:24:49PM -0500, Theodore Ts'o wrote:
> On Mon, Dec 24, 2012 at 08:14:58AM -0000, Stephen Warren wrote:
> > This solves:
> > 
> > In file included from fs/ext3/symlink.c:20:0:
> > include/linux/namei.h: In function 'retry_estale':
> > include/linux/namei.h:114:19: error: 'ESTALE' undeclared (first use in this function)
> > 
> > Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
> 
> Reviewed-by: "Theodore Ts'o" <tytso@mit.edu>
> 
> Looks good to me.  You might want to add that this commit fixes a
> build failure regression in v3.8-rc1 which was introduced in commit
> b9d6ba94b875.
> 
> Al, you want to take this, since the original commit went in via the
> VFS tree?   Or should we have Jan carry this patch?

Applied, will push later today...

Re: [PATCH] namei.h: Include errno.h

[Al Viro]

On Sun, Jan 06, 2013 at 07:48:49AM -0800, Guenter Roeck wrote:
> Commit b9d6ba94 (vfs: add a retry_estale helper function to handle retries
> on ESTALE) intruduced the use of ESTALE in namei.h. Since namei.h does not
> include errno.h, this results in the following build error for callers/users
> which do not include errno.h directly.
> 
> include/linux/namei.h:114:19: error: 'ESTALE' undeclared (first use in this
> function)
> 
> Add the missing include.

That's the third patch doing the same thing; see vfs.git#for-linus for the
earliest one.  Still not pulled...

[PATCH] namei.h: Include errno.h

[Guenter Roeck]

Commit b9d6ba94 (vfs: add a retry_estale helper function to handle retries
on ESTALE) intruduced the use of ESTALE in namei.h. Since namei.h does not
include errno.h, this results in the following build error for callers/users
which do not include errno.h directly.

include/linux/namei.h:114:19: error: 'ESTALE' undeclared (first use in this
function)

Add the missing include.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 include/linux/namei.h |    1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/namei.h b/include/linux/namei.h
index e998c03..92313e4 100644
--- a/include/linux/namei.h
+++ b/include/linux/namei.h
@@ -4,6 +4,7 @@
 #include <linux/dcache.h>
 #include <linux/linkage.h>
 #include <linux/path.h>
+#include <linux/errno.h>
 
 struct vfsmount;
 
-- 
1.7.9.7