All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aaron Lu <aaron.lu@intel.com>
To: Jeff Garzik <jgarzik@pobox.com>,
	James Bottomley <James.Bottomley@hansenpartnership.com>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Alan Stern <stern@rowland.harvard.edu>, Tejun Heo <tj@kernel.org>
Cc: Aaron Lu <aaron.lwe@gmail.com>, Jeff Wu <jeff.wu@amd.com>,
	linux-ide@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-scsi@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: [PATCH v13 6/9] libata: expose pm qos flags for ata device
Date: Tue, 15 Jan 2013 17:21:02 +0800	[thread overview]
Message-ID: <1358241665-2156-7-git-send-email-aaron.lu@intel.com> (raw)
In-Reply-To: <1358241665-2156-1-git-send-email-aaron.lu@intel.com>

Expose pm qos flags to user space so that user has a chance to disable
ZPODD feature, if he/she has a broken platform or devices or simply does
not like this feature.

This flag is exposed to user space only for ZPODD devices.

Due to this flag, it is possible the ODD is ZP ready but we didn't power
it off. So the zp_ready flag will need to be cleared whenever we found
the ODD is not in ZP ready state. Previously, once zp_ready is set, the
ODD will always be powered off and the flag will be cleared in
post_poweron. But this is no longer the case now.

Signed-off-by: Aaron Lu <aaron.lu@intel.com>
---
 drivers/ata/libata-acpi.c  | 3 +++
 drivers/ata/libata-zpodd.c | 1 +
 2 files changed, 4 insertions(+)

diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c
index 6f72c64..9709449 100644
--- a/drivers/ata/libata-acpi.c
+++ b/drivers/ata/libata-acpi.c
@@ -17,6 +17,7 @@
 #include <linux/pci.h>
 #include <linux/slab.h>
 #include <linux/pm_runtime.h>
+#include <linux/pm_qos.h>
 #include <scsi/scsi_device.h>
 #include "libata.h"
 
@@ -1022,6 +1023,8 @@ static void ata_acpi_unregister_power_resource(struct ata_device *dev)
 void ata_acpi_bind(struct ata_device *dev)
 {
 	ata_acpi_register_power_resource(dev);
+	if (zpodd_dev_enabled(dev))
+		dev_pm_qos_expose_flags(&dev->sdev->sdev_gendev, 0);
 }
 
 void ata_acpi_unbind(struct ata_device *dev)
diff --git a/drivers/ata/libata-zpodd.c b/drivers/ata/libata-zpodd.c
index 1f5d52a..540b0b7 100644
--- a/drivers/ata/libata-zpodd.c
+++ b/drivers/ata/libata-zpodd.c
@@ -150,6 +150,7 @@ void zpodd_on_suspend(struct ata_device *dev)
 
 	if (!zpready(dev)) {
 		zpodd->zp_sampled = false;
+		zpodd->zp_ready = false;
 		return;
 	}
 
-- 
1.7.11.7


  parent reply	other threads:[~2013-01-15  9:21 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-15  9:20 [PATCH v13 0/9] ZPODD Patches Aaron Lu
2013-01-15  9:20 ` [PATCH v13 1/9] scsi: sr: support runtime pm Aaron Lu
2013-01-16 15:45   ` James Bottomley
2013-01-16 16:31     ` Alan Stern
2013-01-18  7:42       ` Aaron Lu
2013-01-18 15:24         ` Alan Stern
2013-01-19  8:55           ` Aaron Lu
2013-01-19 18:46             ` Alan Stern
2013-01-21  3:31               ` Julian Calaby
2013-01-21  8:14                 ` Aaron Lu
2013-01-21  8:55                   ` Julian Calaby
2013-01-21  9:11                     ` Aaron Lu
2013-01-21 14:56                       ` Oliver Neukum
2013-01-22  2:25                         ` Aaron Lu
2013-01-22  9:13                           ` Oliver Neukum
2013-01-22  9:20                             ` Aaron Lu
2013-01-21  8:04               ` Aaron Lu
2013-01-21  9:37               ` [RFC PATCH] " Aaron Lu
2013-01-21 16:59                 ` Alan Stern
2013-01-22  2:27                   ` Aaron Lu
2013-01-21 13:36               ` [PATCH v13 1/9] " Aaron Lu
2013-01-15  9:20 ` [PATCH v13 2/9] libata: identify and init ZPODD devices Aaron Lu
2013-01-21  9:16   ` Jeff Garzik
2013-01-21  9:28     ` Aaron Lu
2013-01-15  9:20 ` [PATCH v13 3/9] libata: move acpi notification code to zpodd Aaron Lu
2013-01-15  9:21 ` [PATCH v13 4/9] libata: check zero power ready status for ZPODD Aaron Lu
2013-01-15  9:21 ` [PATCH v13 5/9] libata: handle power transition of ODD Aaron Lu
2013-01-15  9:21 ` Aaron Lu [this message]
2013-01-15  9:21 ` [PATCH v13 7/9] libata: scsi: no poll when ODD is powered off Aaron Lu
2013-01-15  9:21 ` [PATCH v13 8/9] libata: do not suspend port if normal ODD is attached Aaron Lu
2013-01-21 20:42   ` Jeff Garzik
2013-01-22 11:27     ` Aaron Lu
2013-01-15  9:21 ` [PATCH v13 9/9] scsi: remove can_power_off flag from scsi_device Aaron Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358241665-2156-7-git-send-email-aaron.lu@intel.com \
    --to=aaron.lu@intel.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=aaron.lwe@gmail.com \
    --cc=jeff.wu@amd.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=stern@rowland.harvard.edu \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.