All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aaron Lu <aaron.lu@intel.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: James Bottomley <James.Bottomley@hansenpartnership.com>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Alan Stern <stern@rowland.harvard.edu>, Tejun Heo <tj@kernel.org>,
	Aaron Lu <aaron.lwe@gmail.com>, Jeff Wu <jeff.wu@amd.com>,
	linux-ide@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-scsi@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH v13 8/9] libata: do not suspend port if normal ODD is attached
Date: Tue, 22 Jan 2013 19:27:46 +0800	[thread overview]
Message-ID: <20130122112746.GA26380@aaronlu.sh.intel.com> (raw)
In-Reply-To: <50FDA84F.8030204@pobox.com>

On Mon, Jan 21, 2013 at 03:42:55PM -0500, Jeff Garzik wrote:
> On 01/15/2013 04:21 AM, Aaron Lu wrote:
> >For ODDs, the upper layer will poll for media change every few
> >seconds, which will make it enter and leave suspend state very
> >often. And as each suspend will also cause a hard/soft reset,
> >the gain of runtime suspend is very little while the ODD may
> >malfunction after constantly being reset. So the idle callback
> >here will not proceed to suspend if a non-ZPODD capable ODD is
> >attached to the port.
> >
> >Signed-off-by: Aaron Lu <aaron.lu@intel.com>
> >Acked-by: Tejun Heo <tj@kernel.org>
> >---
> >  drivers/ata/libata-core.c | 19 +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
> 
> applied patches #2-6 and #8

Thanks!

Now that patch 1 has ack from Alan Stern(and thus James), and consider
the smatch warning of patch #3, I can either send out the remaining 3
patches(#1, #7 and #9) together with a small fix patch for the smatch
warning or I can re-send the whole patchset. Just let me know which way
you prefer, thanks.

-Aaron


  reply	other threads:[~2013-01-22 11:27 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-15  9:20 [PATCH v13 0/9] ZPODD Patches Aaron Lu
2013-01-15  9:20 ` [PATCH v13 1/9] scsi: sr: support runtime pm Aaron Lu
2013-01-16 15:45   ` James Bottomley
2013-01-16 16:31     ` Alan Stern
2013-01-18  7:42       ` Aaron Lu
2013-01-18 15:24         ` Alan Stern
2013-01-19  8:55           ` Aaron Lu
2013-01-19 18:46             ` Alan Stern
2013-01-21  3:31               ` Julian Calaby
2013-01-21  8:14                 ` Aaron Lu
2013-01-21  8:55                   ` Julian Calaby
2013-01-21  9:11                     ` Aaron Lu
2013-01-21 14:56                       ` Oliver Neukum
2013-01-22  2:25                         ` Aaron Lu
2013-01-22  9:13                           ` Oliver Neukum
2013-01-22  9:20                             ` Aaron Lu
2013-01-21  8:04               ` Aaron Lu
2013-01-21  9:37               ` [RFC PATCH] " Aaron Lu
2013-01-21 16:59                 ` Alan Stern
2013-01-22  2:27                   ` Aaron Lu
2013-01-21 13:36               ` [PATCH v13 1/9] " Aaron Lu
2013-01-15  9:20 ` [PATCH v13 2/9] libata: identify and init ZPODD devices Aaron Lu
2013-01-21  9:16   ` Jeff Garzik
2013-01-21  9:28     ` Aaron Lu
2013-01-15  9:20 ` [PATCH v13 3/9] libata: move acpi notification code to zpodd Aaron Lu
2013-01-15  9:21 ` [PATCH v13 4/9] libata: check zero power ready status for ZPODD Aaron Lu
2013-01-15  9:21 ` [PATCH v13 5/9] libata: handle power transition of ODD Aaron Lu
2013-01-15  9:21 ` [PATCH v13 6/9] libata: expose pm qos flags for ata device Aaron Lu
2013-01-15  9:21 ` [PATCH v13 7/9] libata: scsi: no poll when ODD is powered off Aaron Lu
2013-01-15  9:21 ` [PATCH v13 8/9] libata: do not suspend port if normal ODD is attached Aaron Lu
2013-01-21 20:42   ` Jeff Garzik
2013-01-22 11:27     ` Aaron Lu [this message]
2013-01-15  9:21 ` [PATCH v13 9/9] scsi: remove can_power_off flag from scsi_device Aaron Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130122112746.GA26380@aaronlu.sh.intel.com \
    --to=aaron.lu@intel.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=aaron.lwe@gmail.com \
    --cc=jeff.wu@amd.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=stern@rowland.harvard.edu \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.