[PATCH loop_2013_01_04] fs: Fix a typo in aio_rw_vect_retry()

[PATCH loop_2013_01_04] fs: Fix a typo in aio_rw_vect_retry()

[Sedat Dilek]

Dave confirmed Jeff's suspicion in [1]:

> That wants to be rw_op = do_aio_write in the else clause.  How did you
> test this patch set?

Yep, that's certainly a bug. I concentrated on testing on loop mounts,
running some fio and ltp testcases, but I'm at a loss to explain how
things seem to work as well as they do. Let's see how where fixing this
leads.

This is a fixup to commit daf0f6142dd5 ("fs: use read_iter and write_iter
rather than aio_read and aio_write") from Dave Kleiklamp's GIT tree in [2].

[1] http://www.spinics.net/lists/linux-fsdevel/msg61587.html
[2] https://github.com/kleikamp/linux-shaggy/commits/loop_2013_01_04

Cc: Dave Kleikamp <dave.kleikamp@oracle.com>
Cc: Jeff Moyer <jmoyer@redhat.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
---
 fs/aio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/aio.c b/fs/aio.c
index 08f550a..9635e7a 100644
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -1320,7 +1320,7 @@ static ssize_t aio_rw_vect_retry(struct kiocb *iocb)
 		rw_op = do_aio_read;
 		opcode = IOCB_CMD_PREADV;
 	} else {
-		rw_op = do_aio_read;
+		rw_op = do_aio_write;
 		opcode = IOCB_CMD_PWRITEV;
 	}
 
-- 
1.8.1.1

Re: [PATCH loop_2013_01_04] fs: Fix a typo in aio_rw_vect_retry()

[Carlos Maiolino]

On Tue, Jan 22, 2013 at 02:47:31AM +0100, Sedat Dilek wrote:
> Dave confirmed Jeff's suspicion in [1]:
> 
> >> That wants to be rw_op = do_aio_write in the else clause.  How did you
> >> test this patch set?
> 
> > Yep, that's certainly a bug. I concentrated on testing on loop mounts,
> > running some fio and ltp testcases, but I'm at a loss to explain how
> > things seem to work as well as they do. Let's see how where fixing this
> > leads.
> 
> This is a fixup to commit daf0f6142dd5 ("fs: use read_iter and write_iter
> rather than aio_read and aio_write") from Dave Kleikamp's GIT tree in [2].
> 
> [1] http://www.spinics.net/lists/linux-fsdevel/msg61587.html
> [2] https://github.com/kleikamp/linux-shaggy/commits/loop_2013_01_04
> 
> Cc: Dave Kleikamp <dave.kleikamp@oracle.com>
> Cc: Jeff Moyer <jmoyer@redhat.com>
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: linux-fsdevel@vger.kernel.org
> [ v2: Misspelled Dave's last name and fix quoting. ]
> Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
> ---
>  fs/aio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/aio.c b/fs/aio.c
> index 08f550a..9635e7a 100644
> --- a/fs/aio.c
> +++ b/fs/aio.c
> @@ -1320,7 +1320,7 @@ static ssize_t aio_rw_vect_retry(struct kiocb *iocb)
>  		rw_op = do_aio_read;
>  		opcode = IOCB_CMD_PREADV;
>  	} else {
> -		rw_op = do_aio_read;
> +		rw_op = do_aio_write;
>  		opcode = IOCB_CMD_PWRITEV;
>  	}
>  
Looks Good,

Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
> -- 
> 1.8.1.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Carlos

[PATCH loop_2013_01_04] fs: Fix a typo in aio_rw_vect_retry()

[Sedat Dilek]

Dave confirmed Jeff's suspicion in [1]:

>> That wants to be rw_op = do_aio_write in the else clause.  How did you
>> test this patch set?

> Yep, that's certainly a bug. I concentrated on testing on loop mounts,
> running some fio and ltp testcases, but I'm at a loss to explain how
> things seem to work as well as they do. Let's see how where fixing this
> leads.

This is a fixup to commit daf0f6142dd5 ("fs: use read_iter and write_iter
rather than aio_read and aio_write") from Dave Kleikamp's GIT tree in [2].

[1] http://www.spinics.net/lists/linux-fsdevel/msg61587.html
[2] https://github.com/kleikamp/linux-shaggy/commits/loop_2013_01_04

Cc: Dave Kleikamp <dave.kleikamp@oracle.com>
Cc: Jeff Moyer <jmoyer@redhat.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
[ v2: Misspelled Dave's last name and fix quoting. ]
Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
---
 fs/aio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/aio.c b/fs/aio.c
index 08f550a..9635e7a 100644
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -1320,7 +1320,7 @@ static ssize_t aio_rw_vect_retry(struct kiocb *iocb)
 		rw_op = do_aio_read;
 		opcode = IOCB_CMD_PREADV;
 	} else {
-		rw_op = do_aio_read;
+		rw_op = do_aio_write;
 		opcode = IOCB_CMD_PWRITEV;
 	}
 
-- 
1.8.1.1