All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Ben Greear <greearb@candelatech.com>
Cc: netdev <netdev@vger.kernel.org>,
	"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: 3.7.3+:  Bad paging request in ip_rcv_finish while running NFS traffic.
Date: Tue, 22 Jan 2013 09:26:47 -0800	[thread overview]
Message-ID: <1358875607.3464.4020.camel@edumazet-glaptop> (raw)
In-Reply-To: <1358875020.3464.4006.camel@edumazet-glaptop>

On Tue, 2013-01-22 at 09:17 -0800, Eric Dumazet wrote:
> On Tue, 2013-01-22 at 09:08 -0800, Ben Greear wrote:
> 
> > Unfortunately, I hit it again this morning after the first restart of
> > my application (which bounces all 3000 interfaces).  Memory poisoning
> > was disabled.
> 
> Is your NFS traffic using TCP or UDP ?
> 

Oh well, it seems macvlan.c has to skb_drop_dst(skb) before giving skb
to netif_rx()

diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
index 68a43fe..4f049ee 100644
--- a/drivers/net/macvlan.c
+++ b/drivers/net/macvlan.c
@@ -114,6 +114,7 @@ static int macvlan_broadcast_one(struct sk_buff *skb,
 	if (!skb)
 		return NET_RX_DROP;
 
+	skb_dst_drop(skb);
 	if (local)
 		return vlan->forward(dev, skb);
 
@@ -220,6 +221,7 @@ static rx_handler_result_t macvlan_handle_frame(struct sk_buff **pskb)
 	if (!skb)
 		goto out;
 
+	skb_dst_drop(skb);
 	skb->dev = dev;
 	skb->pkt_type = PACKET_HOST;
 

  parent reply	other threads:[~2013-01-22 17:26 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-21 21:07 3.7.3+: Bad paging request in ip_rcv_finish while running NFS traffic Ben Greear
2013-01-21 21:07 ` Ben Greear
2013-01-22  0:32 ` Ben Greear
2013-01-22  4:40   ` Eric Dumazet
2013-01-22  5:57     ` Ben Greear
2013-01-22  5:57       ` Ben Greear
     [not found]       ` <50FE2A57.3040804-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2013-01-22 17:08         ` Ben Greear
2013-01-22 17:08           ` Ben Greear
     [not found]           ` <50FEC796.5090404-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2013-01-22 17:17             ` Eric Dumazet
2013-01-22 17:17               ` Eric Dumazet
2013-01-22 17:26               ` Ben Greear
2013-01-22 17:26                 ` Ben Greear
2013-01-22 17:26               ` Eric Dumazet [this message]
2013-01-22 22:18                 ` Ben Greear
2013-01-22 22:18                   ` Ben Greear
     [not found]                   ` <50FF102F.2050008-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2013-01-23  2:32                     ` Ben Greear
2013-01-23  2:32                       ` Ben Greear
2013-01-23  6:11                       ` Eric Dumazet
2013-01-23  7:14                         ` Ben Greear
2013-01-23  7:14                           ` Ben Greear
     [not found]                           ` <50FF8DEC.9070901-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2013-01-23 13:35                             ` Eric Dumazet
2013-01-23 13:35                               ` Eric Dumazet
2013-01-23 18:15                               ` Ben Greear
2013-01-23 18:15                                 ` Ben Greear
2013-01-23 21:43                                 ` Eric Dumazet
2013-01-23 14:42                             ` Eric Dumazet
2013-01-23 14:42                               ` Eric Dumazet
2013-01-23 21:53                               ` Ben Greear
2013-01-23 21:53                                 ` Ben Greear
     [not found]                       ` <50FF4BC9.1060206-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2013-01-23 23:55                         ` Ben Greear
2013-01-23 23:55                           ` Ben Greear
     [not found]                           ` <5100785D.8040101-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2013-01-24  0:01                             ` Eric Dumazet
2013-01-24  0:01                               ` Eric Dumazet
2013-01-24  0:13                               ` Ben Greear
2013-01-24  0:13                                 ` Ben Greear
     [not found]                                 ` <51007CA8.2050105-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2013-01-24  0:23                                   ` Eric Dumazet
2013-01-24  0:23                                     ` Eric Dumazet
2013-01-24  0:38                                     ` Ben Greear
2013-01-24  0:45                                       ` Eric Dumazet
2013-01-24  0:51                                         ` Ben Greear
2013-01-24  1:00                                           ` Eric Dumazet
2013-01-24  1:06                                             ` Ben Greear
2013-01-24  1:10                                               ` Eric Dumazet
2013-01-24  1:45                                                 ` Eric Dumazet
2013-01-24  4:26                                                   ` Ben Greear
2013-01-24  5:39                                                     ` Eric Dumazet
2013-01-24 20:03                                                   ` Ben Greear
2013-01-24 20:59                                                     ` Eric Dumazet
2013-01-24 21:01                                                       ` Ben Greear
2013-01-25 17:44                                                   ` [PATCH] net: loopback: fix a dst refcounting issue Eric Dumazet
2013-01-27  6:32                                                     ` David Miller
2013-01-27 17:25                                                       ` Eric Dumazet
2013-01-28  0:26                                                         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358875607.3464.4020.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=greearb@candelatech.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.