From: Eric Dumazet <eric.dumazet@gmail.com>
To: Ben Greear <greearb@candelatech.com>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: 3.7.3+: Bad paging request in ip_rcv_finish while running NFS traffic.
Date: Wed, 23 Jan 2013 17:45:06 -0800 [thread overview]
Message-ID: <1358991906.12374.1356.camel@edumazet-glaptop> (raw)
In-Reply-To: <1358989843.12374.1334.camel@edumazet-glaptop>
On Wed, 2013-01-23 at 17:10 -0800, Eric Dumazet wrote:
> Excellent, thats the bug.
>
> I'll send a fix asap, thanks !
loopback device doesnt have a qdisc, and unsets IFF_XMIT_DST_RELEASE
Its hard to believe such an old bug never hit us in the past.
Probably because most of the time, the packet given to netif_rx() is
immediately processed (and loopback device is hard wired ?)
diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c
index 81f8f9e..fcbf680 100644
--- a/drivers/net/loopback.c
+++ b/drivers/net/loopback.c
@@ -77,6 +77,11 @@ static netdev_tx_t loopback_xmit(struct sk_buff *skb,
skb_orphan(skb);
+ /* Before queueing this packet to netif_rx(),
+ * make sure dst is refcounted.
+ */
+ skb_dst_force(skb);
+
skb->protocol = eth_type_trans(skb, dev);
/* it's OK to use per_cpu_ptr() because BHs are off */
next prev parent reply other threads:[~2013-01-24 1:45 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-21 21:07 3.7.3+: Bad paging request in ip_rcv_finish while running NFS traffic Ben Greear
2013-01-21 21:07 ` Ben Greear
2013-01-22 0:32 ` Ben Greear
2013-01-22 4:40 ` Eric Dumazet
2013-01-22 5:57 ` Ben Greear
2013-01-22 5:57 ` Ben Greear
[not found] ` <50FE2A57.3040804-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2013-01-22 17:08 ` Ben Greear
2013-01-22 17:08 ` Ben Greear
[not found] ` <50FEC796.5090404-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2013-01-22 17:17 ` Eric Dumazet
2013-01-22 17:17 ` Eric Dumazet
2013-01-22 17:26 ` Ben Greear
2013-01-22 17:26 ` Ben Greear
2013-01-22 17:26 ` Eric Dumazet
2013-01-22 22:18 ` Ben Greear
2013-01-22 22:18 ` Ben Greear
[not found] ` <50FF102F.2050008-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2013-01-23 2:32 ` Ben Greear
2013-01-23 2:32 ` Ben Greear
2013-01-23 6:11 ` Eric Dumazet
2013-01-23 7:14 ` Ben Greear
2013-01-23 7:14 ` Ben Greear
[not found] ` <50FF8DEC.9070901-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2013-01-23 13:35 ` Eric Dumazet
2013-01-23 13:35 ` Eric Dumazet
2013-01-23 18:15 ` Ben Greear
2013-01-23 18:15 ` Ben Greear
2013-01-23 21:43 ` Eric Dumazet
2013-01-23 14:42 ` Eric Dumazet
2013-01-23 14:42 ` Eric Dumazet
2013-01-23 21:53 ` Ben Greear
2013-01-23 21:53 ` Ben Greear
[not found] ` <50FF4BC9.1060206-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2013-01-23 23:55 ` Ben Greear
2013-01-23 23:55 ` Ben Greear
[not found] ` <5100785D.8040101-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2013-01-24 0:01 ` Eric Dumazet
2013-01-24 0:01 ` Eric Dumazet
2013-01-24 0:13 ` Ben Greear
2013-01-24 0:13 ` Ben Greear
[not found] ` <51007CA8.2050105-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2013-01-24 0:23 ` Eric Dumazet
2013-01-24 0:23 ` Eric Dumazet
2013-01-24 0:38 ` Ben Greear
2013-01-24 0:45 ` Eric Dumazet
2013-01-24 0:51 ` Ben Greear
2013-01-24 1:00 ` Eric Dumazet
2013-01-24 1:06 ` Ben Greear
2013-01-24 1:10 ` Eric Dumazet
2013-01-24 1:45 ` Eric Dumazet [this message]
2013-01-24 4:26 ` Ben Greear
2013-01-24 5:39 ` Eric Dumazet
2013-01-24 20:03 ` Ben Greear
2013-01-24 20:59 ` Eric Dumazet
2013-01-24 21:01 ` Ben Greear
2013-01-25 17:44 ` [PATCH] net: loopback: fix a dst refcounting issue Eric Dumazet
2013-01-27 6:32 ` David Miller
2013-01-27 17:25 ` Eric Dumazet
2013-01-28 0:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358991906.12374.1356.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=greearb@candelatech.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.