All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: <netdev@vger.kernel.org>
Cc: Alexander Duyck <alexander.h.duyck@intel.com>
Subject: [PATCH ethtool] rxclass: Show full 64 bits of user-data in rxclass_print_nfc_spec_ext()
Date: Tue, 22 Jan 2013 20:33:55 +0000	[thread overview]
Message-ID: <1358886835.2892.14.camel@bwh-desktop.uk.solarflarecom.com> (raw)

Previously only the lower 32 bits would be shown.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
I just noticed this bug when applying Yan Burman's patch.  Untested
since sfc doesn't support this field.

Ben.

 rxclass.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/rxclass.c b/rxclass.c
index 1564b62..cd686a3 100644
--- a/rxclass.c
+++ b/rxclass.c
@@ -49,7 +49,7 @@ static void rxclass_print_nfc_spec_ext(struct ethtool_rx_flow_spec *fsp)
 		tci = ntohs(fsp->h_ext.vlan_tci);
 		tcim = ntohs(~fsp->m_ext.vlan_tci);
 		data = (u64)ntohl(fsp->h_ext.data[0]) << 32;
-		data = (u64)ntohl(fsp->h_ext.data[1]);
+		data |= (u64)ntohl(fsp->h_ext.data[1]);
 		datam = (u64)ntohl(~fsp->m_ext.data[0]) << 32;
 		datam |= (u64)ntohl(~fsp->m_ext.data[1]);
 
-- 
1.7.7.6


-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

             reply	other threads:[~2013-01-22 20:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-22 20:33 Ben Hutchings [this message]
2013-01-22 21:07 ` [PATCH ethtool] rxclass: Show full 64 bits of user-data in rxclass_print_nfc_spec_ext() Alexander Duyck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358886835.2892.14.camel@bwh-desktop.uk.solarflarecom.com \
    --to=bhutchings@solarflare.com \
    --cc=alexander.h.duyck@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.