* [PATCH ethtool] rxclass: Show full 64 bits of user-data in rxclass_print_nfc_spec_ext()
@ 2013-01-22 20:33 Ben Hutchings
2013-01-22 21:07 ` Alexander Duyck
0 siblings, 1 reply; 2+ messages in thread
From: Ben Hutchings @ 2013-01-22 20:33 UTC (permalink / raw)
To: netdev; +Cc: Alexander Duyck
Previously only the lower 32 bits would be shown.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
I just noticed this bug when applying Yan Burman's patch. Untested
since sfc doesn't support this field.
Ben.
rxclass.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/rxclass.c b/rxclass.c
index 1564b62..cd686a3 100644
--- a/rxclass.c
+++ b/rxclass.c
@@ -49,7 +49,7 @@ static void rxclass_print_nfc_spec_ext(struct ethtool_rx_flow_spec *fsp)
tci = ntohs(fsp->h_ext.vlan_tci);
tcim = ntohs(~fsp->m_ext.vlan_tci);
data = (u64)ntohl(fsp->h_ext.data[0]) << 32;
- data = (u64)ntohl(fsp->h_ext.data[1]);
+ data |= (u64)ntohl(fsp->h_ext.data[1]);
datam = (u64)ntohl(~fsp->m_ext.data[0]) << 32;
datam |= (u64)ntohl(~fsp->m_ext.data[1]);
--
1.7.7.6
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH ethtool] rxclass: Show full 64 bits of user-data in rxclass_print_nfc_spec_ext()
2013-01-22 20:33 [PATCH ethtool] rxclass: Show full 64 bits of user-data in rxclass_print_nfc_spec_ext() Ben Hutchings
@ 2013-01-22 21:07 ` Alexander Duyck
0 siblings, 0 replies; 2+ messages in thread
From: Alexander Duyck @ 2013-01-22 21:07 UTC (permalink / raw)
To: Ben Hutchings; +Cc: netdev
On 01/22/2013 12:33 PM, Ben Hutchings wrote:
> Previously only the lower 32 bits would be shown.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> ---
> I just noticed this bug when applying Yan Burman's patch. Untested
> since sfc doesn't support this field.
>
> Ben.
>
> rxclass.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/rxclass.c b/rxclass.c
> index 1564b62..cd686a3 100644
> --- a/rxclass.c
> +++ b/rxclass.c
> @@ -49,7 +49,7 @@ static void rxclass_print_nfc_spec_ext(struct ethtool_rx_flow_spec *fsp)
> tci = ntohs(fsp->h_ext.vlan_tci);
> tcim = ntohs(~fsp->m_ext.vlan_tci);
> data = (u64)ntohl(fsp->h_ext.data[0]) << 32;
> - data = (u64)ntohl(fsp->h_ext.data[1]);
> + data |= (u64)ntohl(fsp->h_ext.data[1]);
> datam = (u64)ntohl(~fsp->m_ext.data[0]) << 32;
> datam |= (u64)ntohl(~fsp->m_ext.data[1]);
>
>
This looks fine to me. We didn't use data[0] in ixgbe so we never
noticed this either.
Acked-by: Alexander Duyck <alexander.h.duyck@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-22 21:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-22 20:33 [PATCH ethtool] rxclass: Show full 64 bits of user-data in rxclass_print_nfc_spec_ext() Ben Hutchings
2013-01-22 21:07 ` Alexander Duyck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.