All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: <sameo@linux.intel.com>
Cc: <balbi@ti.com>, <tony@atomide.com>, <kishon@ti.com>,
	<sshtylyov@mvista.com>, <bjorn@mork.no>, <linux@arm.linux.org.uk>,
	<gregkh@linuxfoundation.org>, <linux-usb@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <rogerq@ti.com>,
	Alan Stern <stern@rowland.harvard.edu>, <stable@vger.kernel.org>
Subject: [PATCH v9 01/20] USB: ehci-omap: Don't free gpios that we didn't request
Date: Wed, 23 Jan 2013 12:37:53 +0200	[thread overview]
Message-ID: <1358937492-8129-2-git-send-email-rogerq@ti.com> (raw)
In-Reply-To: <1358937492-8129-1-git-send-email-rogerq@ti.com>

This driver does not request any gpios so don't free them.
Fixes L3 bus error on multiple modprobe/rmmod of ehci_hcd
with ehci-omap in use.

Without this patch, EHCI will break on repeated insmod/rmmod
of ehci_hcd for all OMAP2+ platforms that use EHCI and
set 'phy_reset = true' in usbhs_omap_board_data.
i.e.

board-3430sdp.c:	.phy_reset  = true,
board-3630sdp.c:	.phy_reset  = true,
board-am3517crane.c:	.phy_reset  = true,
board-am3517evm.c:	.phy_reset  = true,
board-cm-t3517.c:	.phy_reset  = true,
board-cm-t35.c:	.phy_reset  = true,
board-devkit8000.c:	.phy_reset  = true,
board-igep0020.c:	.phy_reset = true,
board-igep0020.c:	.phy_reset = true,
board-omap3beagle.c:	.phy_reset  = true,
board-omap3evm.c:	.phy_reset  = true,
board-omap3pandora.c:	.phy_reset  = true,
board-omap3stalker.c:	.phy_reset = true,
board-omap3touchbook.c:	.phy_reset  = true,
board-omap4panda.c:	.phy_reset  = false,
board-overo.c:	.phy_reset  = true,
board-zoom.c:	.phy_reset		= true,

CC: Alan Stern <stern@rowland.harvard.edu>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: stable@vger.kernel.org

Signed-off-by: Roger Quadros <rogerq@ti.com>
Reviewed-by: Felipe Balbi <balbi@ti.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
---
 drivers/usb/host/ehci-omap.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
index ac17a7c..e9d9b09 100644
--- a/drivers/usb/host/ehci-omap.c
+++ b/drivers/usb/host/ehci-omap.c
@@ -288,7 +288,6 @@ static int ehci_hcd_omap_remove(struct platform_device *pdev)
 {
 	struct device *dev				= &pdev->dev;
 	struct usb_hcd *hcd				= dev_get_drvdata(dev);
-	struct ehci_hcd_omap_platform_data *pdata	= dev->platform_data;
 
 	usb_remove_hcd(hcd);
 	disable_put_regulator(dev->platform_data);
@@ -298,13 +297,6 @@ static int ehci_hcd_omap_remove(struct platform_device *pdev)
 	pm_runtime_put_sync(dev);
 	pm_runtime_disable(dev);
 
-	if (pdata->phy_reset) {
-		if (gpio_is_valid(pdata->reset_gpio_port[0]))
-			gpio_free(pdata->reset_gpio_port[0]);
-
-		if (gpio_is_valid(pdata->reset_gpio_port[1]))
-			gpio_free(pdata->reset_gpio_port[1]);
-	}
 	return 0;
 }
 
-- 
1.7.4.1


WARNING: multiple messages have this Message-ID (diff)
From: rogerq@ti.com (Roger Quadros)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 01/20] USB: ehci-omap: Don't free gpios that we didn't request
Date: Wed, 23 Jan 2013 12:37:53 +0200	[thread overview]
Message-ID: <1358937492-8129-2-git-send-email-rogerq@ti.com> (raw)
In-Reply-To: <1358937492-8129-1-git-send-email-rogerq@ti.com>

This driver does not request any gpios so don't free them.
Fixes L3 bus error on multiple modprobe/rmmod of ehci_hcd
with ehci-omap in use.

Without this patch, EHCI will break on repeated insmod/rmmod
of ehci_hcd for all OMAP2+ platforms that use EHCI and
set 'phy_reset = true' in usbhs_omap_board_data.
i.e.

board-3430sdp.c:	.phy_reset  = true,
board-3630sdp.c:	.phy_reset  = true,
board-am3517crane.c:	.phy_reset  = true,
board-am3517evm.c:	.phy_reset  = true,
board-cm-t3517.c:	.phy_reset  = true,
board-cm-t35.c:	.phy_reset  = true,
board-devkit8000.c:	.phy_reset  = true,
board-igep0020.c:	.phy_reset = true,
board-igep0020.c:	.phy_reset = true,
board-omap3beagle.c:	.phy_reset  = true,
board-omap3evm.c:	.phy_reset  = true,
board-omap3pandora.c:	.phy_reset  = true,
board-omap3stalker.c:	.phy_reset = true,
board-omap3touchbook.c:	.phy_reset  = true,
board-omap4panda.c:	.phy_reset  = false,
board-overo.c:	.phy_reset  = true,
board-zoom.c:	.phy_reset		= true,

CC: Alan Stern <stern@rowland.harvard.edu>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: stable at vger.kernel.org

Signed-off-by: Roger Quadros <rogerq@ti.com>
Reviewed-by: Felipe Balbi <balbi@ti.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
---
 drivers/usb/host/ehci-omap.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
index ac17a7c..e9d9b09 100644
--- a/drivers/usb/host/ehci-omap.c
+++ b/drivers/usb/host/ehci-omap.c
@@ -288,7 +288,6 @@ static int ehci_hcd_omap_remove(struct platform_device *pdev)
 {
 	struct device *dev				= &pdev->dev;
 	struct usb_hcd *hcd				= dev_get_drvdata(dev);
-	struct ehci_hcd_omap_platform_data *pdata	= dev->platform_data;
 
 	usb_remove_hcd(hcd);
 	disable_put_regulator(dev->platform_data);
@@ -298,13 +297,6 @@ static int ehci_hcd_omap_remove(struct platform_device *pdev)
 	pm_runtime_put_sync(dev);
 	pm_runtime_disable(dev);
 
-	if (pdata->phy_reset) {
-		if (gpio_is_valid(pdata->reset_gpio_port[0]))
-			gpio_free(pdata->reset_gpio_port[0]);
-
-		if (gpio_is_valid(pdata->reset_gpio_port[1]))
-			gpio_free(pdata->reset_gpio_port[1]);
-	}
 	return 0;
 }
 
-- 
1.7.4.1

  reply	other threads:[~2013-01-23 10:38 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-23 10:37 [PATCH v9 00/20] OMAP USB Host cleanup Roger Quadros
2013-01-23 10:37 ` Roger Quadros
2013-01-23 10:37 ` Roger Quadros [this message]
2013-01-23 10:37   ` [PATCH v9 01/20] USB: ehci-omap: Don't free gpios that we didn't request Roger Quadros
2013-01-23 10:37 ` [PATCH v9 02/20] mfd: omap-usb-host: Consolidate OMAP USB-HS platform data Roger Quadros
2013-01-23 10:37   ` Roger Quadros
2013-02-14 10:18   ` Roger Quadros
2013-02-14 10:18     ` Roger Quadros
2013-02-14 15:03     ` Greg KH
2013-02-14 15:03       ` Greg KH
2013-01-23 10:37 ` [PATCH v9 03/20] mfd: omap-usb-tll: Fix channel count detection Roger Quadros
2013-01-23 10:37   ` Roger Quadros
2013-01-23 10:37 ` [PATCH v9 04/20] mfd: omap-usb-tll: Use devm_kzalloc/ioremap and clean up error path Roger Quadros
2013-01-23 10:37   ` Roger Quadros
2013-01-23 10:37 ` [PATCH v9 05/20] mfd: omap-usb-tll: Clean up clock handling Roger Quadros
2013-01-23 10:37   ` Roger Quadros
2013-01-23 10:37 ` [PATCH v9 06/20] mfd: omap-usb-tll: introduce and use mode_needs_tll() Roger Quadros
2013-01-23 10:37   ` Roger Quadros
2013-01-23 10:37 ` [PATCH v9 07/20] mfd: omap-usb-tll: Check for missing platform data in probe Roger Quadros
2013-01-23 10:37   ` Roger Quadros
2013-01-23 10:38 ` [PATCH v9 08/20] mfd: omap-usb-tll: Fix error message Roger Quadros
2013-01-23 10:38   ` Roger Quadros
2013-01-23 10:38 ` [PATCH v9 09/20] mfd: omap-usb-tll: serialize access to TLL device Roger Quadros
2013-01-23 10:38   ` Roger Quadros
2013-01-23 10:38 ` [PATCH v9 10/20] mfd: omap-usb-tll: Add OMAP5 revision and HSIC support Roger Quadros
2013-01-23 10:38   ` Roger Quadros
2013-01-23 10:38 ` [PATCH v9 11/20] mfd: omap_usb_host: Avoid missing platform data checks in suspend/resume Roger Quadros
2013-01-23 10:38   ` Roger Quadros
2013-01-23 10:38 ` [PATCH v9 12/20] mfd: omap-usb-host: Use devm_kzalloc() and devm_request_and_ioremap() Roger Quadros
2013-01-23 10:38   ` Roger Quadros
2013-01-23 10:38 ` [PATCH v9 13/20] mfd: omap-usb-host: know about number of ports from revision register Roger Quadros
2013-01-23 10:38   ` Roger Quadros
2013-01-23 10:38 ` [PATCH v9 14/20] mfd: omap-usb-host: override number of ports from platform data Roger Quadros
2013-01-23 10:38   ` Roger Quadros
2013-01-23 10:38 ` [PATCH v9 15/20] mfd: omap-usb-host: cleanup clock management code Roger Quadros
2013-01-23 10:38   ` Roger Quadros
2013-01-23 10:38 ` [PATCH v9 16/20] mfd: omap-usb-host: Manage HSIC clocks for HSIC mode Roger Quadros
2013-01-23 10:38   ` Roger Quadros
2013-01-23 10:38 ` [PATCH v9 17/20] mfd: omap-usb-host: Get rid of unnecessary spinlock Roger Quadros
2013-01-23 10:38   ` Roger Quadros
2013-01-23 10:38 ` [PATCH v9 18/20] mfd: omap-usb-host: clean up omap_usbhs_init() Roger Quadros
2013-01-23 10:38   ` Roger Quadros
2013-01-23 10:38 ` [PATCH v9 19/20] mfd: omap-usb-host: Don't spam console on clk_set_parent failure Roger Quadros
2013-01-23 10:38   ` Roger Quadros
2013-01-23 10:38 ` [PATCH v9 20/20] mdf: omap-usb-host: get rid of build warning Roger Quadros
2013-01-23 10:38   ` Roger Quadros
2013-01-23 23:36   ` Mike Turquette
2013-01-23 23:36     ` Mike Turquette
2013-01-24  9:00     ` Roger Quadros
2013-01-24  9:00       ` Roger Quadros
2013-01-24  9:04     ` [PATCH v10 20/20] mfd: " Roger Quadros
2013-01-24  9:04       ` Roger Quadros
2013-01-31 10:31 ` [PATCH v9 00/20] OMAP USB Host cleanup Roger Quadros
2013-01-31 10:31   ` Roger Quadros
2013-02-03 17:01 ` Samuel Ortiz
2013-02-03 17:01   ` Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358937492-8129-2-git-send-email-rogerq@ti.com \
    --to=rogerq@ti.com \
    --cc=balbi@ti.com \
    --cc=bjorn@mork.no \
    --cc=gregkh@linuxfoundation.org \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=sameo@linux.intel.com \
    --cc=sshtylyov@mvista.com \
    --cc=stable@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.