[PATCH 3.2.y] drbd: add missing part_round_stats to _drbd_start_io_acct

[PATCH 3.2.y] drbd: add missing part_round_stats to _drbd_start_io_acct

[Raoul Bhatia]

commit 72585d2428fa3a0daab02ebad1f41e5ef517dbaa upstream

Please include upstream patch 72585d2428fa3a0daab02ebad1f41e5ef517dbaa 
into 3.2.y.
Patch from git below.

Please also see the discussion at
http://lists.linbit.com/pipermail/drbd-user/2012-January/017622.html

and the upstream patches at
https://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=72585d2428fa3a0daab02ebad1f41e5ef517dbaa
http://git.drbd.org/gitweb.cgi?p=drbd-8.3.git;a=commitdiff;h=80cb2183911626747d3f7546fe3cb3c1abe6ba41

Thanks,
Raoul

 From 72585d2428fa3a0daab02ebad1f41e5ef517dbaa Mon Sep 17 00:00:00 2001
 From: Philipp Reisner <philipp.reisner@linbit.com>
Date: Thu, 23 Feb 2012 12:56:26 +0100
Subject: [PATCH] drbd: add missing part_round_stats to 
_drbd_start_io_acct

Without this, iostat frequently sees bogus svctime and >= 100% 
"utilization".

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
---
  drivers/block/drbd/drbd_req.c |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/block/drbd/drbd_req.c 
b/drivers/block/drbd/drbd_req.c
index 4737ad1..bfd14bc 100644
--- a/drivers/block/drbd/drbd_req.c
+++ b/drivers/block/drbd/drbd_req.c
@@ -39,6 +39,7 @@ static void _drbd_start_io_acct(struct drbd_conf 
*mdev, struct drbd_request *req
  	const int rw = bio_data_dir(bio);
  	int cpu;
  	cpu = part_stat_lock();
+	part_round_stats(cpu, &mdev->vdisk->part0);
  	part_stat_inc(cpu, &mdev->vdisk->part0, ios[rw]);
  	part_stat_add(cpu, &mdev->vdisk->part0, sectors[rw], 
bio_sectors(bio));
  	(void) cpu; /* The macro invocations above want the cpu argument, I 
do not like
-- 
1.7.6.5

-- 
DI (FH) Raoul Bhatia M.Sc.     |   E-Mail.  raoul@bhatia.at
Software Development and       |   Web.     http://www.ipax.at
System Administration          |   Tel.     +43 699 10132530

Re: [PATCH 3.2.y] drbd: add missing part_round_stats to _drbd_start_io_acct

[Greg KH]

On Fri, Jan 18, 2013 at 08:12:43PM +0100, Raoul Bhatia wrote:
> commit 72585d2428fa3a0daab02ebad1f41e5ef517dbaa upstream
> 
> Please include upstream patch
> 72585d2428fa3a0daab02ebad1f41e5ef517dbaa into 3.2.y.
> Patch from git below.

What about 3.4 and 3.7-stable kernels?

thanks,

greg k-h

Re: [PATCH 3.2.y] drbd: add missing part_round_stats to _drbd_start_io_acct

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 561 bytes --]

On Fri, 2013-01-18 at 20:12 +0100, Raoul Bhatia wrote:
> commit 72585d2428fa3a0daab02ebad1f41e5ef517dbaa upstream
> 
> Please include upstream patch 72585d2428fa3a0daab02ebad1f41e5ef517dbaa 
> into 3.2.y.
> Patch from git below.
> 
> Please also see the discussion at
> http://lists.linbit.com/pipermail/drbd-user/2012-January/017622.html
[...]

Added to the queue, thanks.

Ben.

-- 
Ben Hutchings
Everything should be made as simple as possible, but not simpler.
                                                           - Albert Einstein

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]