* [PATCH 0/7] ARM: dts: Add G2D DT nodes to Exynos4 machines
@ 2013-02-06 11:51 Sachin Kamat
2013-02-06 11:51 ` [PATCH 1/7] ARM: dts: Add G2D node to exynos4210.dtsi Sachin Kamat
` (7 more replies)
0 siblings, 8 replies; 17+ messages in thread
From: Sachin Kamat @ 2013-02-06 11:51 UTC (permalink / raw)
To: linux-samsung-soc, devicetree-discuss
Cc: kgene.kim, s.nawrocki, inki.dae, sachin.kamat, patches
This patch series is based on for-next branch of Kukjin Kim's tree
git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
Patches added on top of MFC DT series which has been accepted by Kukjin.
http://www.spinics.net/lists/linux-samsung-soc/msg15419.html
Sachin Kamat (7):
ARM: dts: Add G2D node to exynos4210.dtsi
ARM: dts: Add G2D node to SMDKV310
ARM: dts: Add G2D node to exynos4210-origen
ARM: dts: Add G2D node to exynos4x12.dtsi
ARM: dts: Add G2D node to SMDK4412
ARM: dts: Add G2D node to exynos4412-origen
ARM: dts: Add Samsung G2D DT bindings documentation
.../devicetree/bindings/gpu/samsung-g2d.txt | 30 ++++++++++++++++++++
arch/arm/boot/dts/exynos4210-origen.dts | 4 ++
arch/arm/boot/dts/exynos4210-smdkv310.dts | 4 ++
arch/arm/boot/dts/exynos4210.dtsi | 8 +++++
arch/arm/boot/dts/exynos4412-origen.dts | 4 ++
arch/arm/boot/dts/exynos4412-smdk4412.dts | 4 ++
arch/arm/boot/dts/exynos4x12.dtsi | 7 ++++
7 files changed, 61 insertions(+), 0 deletions(-)
create mode 100644 Documentation/devicetree/bindings/gpu/samsung-g2d.txt
--
1.7.4.1
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 1/7] ARM: dts: Add G2D node to exynos4210.dtsi
2013-02-06 11:51 [PATCH 0/7] ARM: dts: Add G2D DT nodes to Exynos4 machines Sachin Kamat
@ 2013-02-06 11:51 ` Sachin Kamat
2013-02-06 11:51 ` [PATCH 2/7] ARM: dts: Add G2D node to SMDKV310 Sachin Kamat
` (6 subsequent siblings)
7 siblings, 0 replies; 17+ messages in thread
From: Sachin Kamat @ 2013-02-06 11:51 UTC (permalink / raw)
To: linux-samsung-soc, devicetree-discuss
Cc: kgene.kim, s.nawrocki, inki.dae, sachin.kamat, patches
Added G2D DT node to Exynos4210.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
arch/arm/boot/dts/exynos4210.dtsi | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi
index 79ba247..3410d5f 100644
--- a/arch/arm/boot/dts/exynos4210.dtsi
+++ b/arch/arm/boot/dts/exynos4210.dtsi
@@ -47,6 +47,14 @@
<0 12 0>, <0 13 0>, <0 14 0>, <0 15 0>;
};
+ g2d@12800000 {
+ compatible = "samsung,s5pv210-g2d";
+ reg = <0x12800000 0x1000>;
+ interrupts = <0 89 0>;
+ samsung,power-domain = <&pd_lcd0>;
+ status = "disabled";
+ };
+
pmu {
compatible = "arm,cortex-a9-pmu";
interrupt-parent = <&combiner>;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 2/7] ARM: dts: Add G2D node to SMDKV310
2013-02-06 11:51 [PATCH 0/7] ARM: dts: Add G2D DT nodes to Exynos4 machines Sachin Kamat
2013-02-06 11:51 ` [PATCH 1/7] ARM: dts: Add G2D node to exynos4210.dtsi Sachin Kamat
@ 2013-02-06 11:51 ` Sachin Kamat
2013-02-06 11:51 ` [PATCH 3/7] ARM: dts: Add G2D node to exynos4210-origen Sachin Kamat
` (5 subsequent siblings)
7 siblings, 0 replies; 17+ messages in thread
From: Sachin Kamat @ 2013-02-06 11:51 UTC (permalink / raw)
To: linux-samsung-soc, devicetree-discuss
Cc: kgene.kim, s.nawrocki, inki.dae, sachin.kamat, patches
Added G2D DT node to SMDKV310 board.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
arch/arm/boot/dts/exynos4210-smdkv310.dts | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4210-smdkv310.dts b/arch/arm/boot/dts/exynos4210-smdkv310.dts
index 2b1e03a..7bb16aa 100644
--- a/arch/arm/boot/dts/exynos4210-smdkv310.dts
+++ b/arch/arm/boot/dts/exynos4210-smdkv310.dts
@@ -43,6 +43,10 @@
status = "okay";
};
+ g2d@12800000 {
+ status = "okay";
+ };
+
codec@13400000 {
samsung,mfc-r = <0x43000000 0x800000>;
samsung,mfc-l = <0x51000000 0x800000>;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 3/7] ARM: dts: Add G2D node to exynos4210-origen
2013-02-06 11:51 [PATCH 0/7] ARM: dts: Add G2D DT nodes to Exynos4 machines Sachin Kamat
2013-02-06 11:51 ` [PATCH 1/7] ARM: dts: Add G2D node to exynos4210.dtsi Sachin Kamat
2013-02-06 11:51 ` [PATCH 2/7] ARM: dts: Add G2D node to SMDKV310 Sachin Kamat
@ 2013-02-06 11:51 ` Sachin Kamat
2013-02-06 11:51 ` [PATCH 4/7] ARM: dts: Add G2D node to exynos4x12.dtsi Sachin Kamat
` (4 subsequent siblings)
7 siblings, 0 replies; 17+ messages in thread
From: Sachin Kamat @ 2013-02-06 11:51 UTC (permalink / raw)
To: linux-samsung-soc, devicetree-discuss
Cc: kgene.kim, s.nawrocki, inki.dae, sachin.kamat, patches
Added G2D DT node to Origen4210 board.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
arch/arm/boot/dts/exynos4210-origen.dts | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts
index 052606b..e081d89 100644
--- a/arch/arm/boot/dts/exynos4210-origen.dts
+++ b/arch/arm/boot/dts/exynos4210-origen.dts
@@ -57,6 +57,10 @@
status = "okay";
};
+ g2d@12800000 {
+ status = "okay";
+ };
+
codec@13400000 {
samsung,mfc-r = <0x43000000 0x800000>;
samsung,mfc-l = <0x51000000 0x800000>;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 4/7] ARM: dts: Add G2D node to exynos4x12.dtsi
2013-02-06 11:51 [PATCH 0/7] ARM: dts: Add G2D DT nodes to Exynos4 machines Sachin Kamat
` (2 preceding siblings ...)
2013-02-06 11:51 ` [PATCH 3/7] ARM: dts: Add G2D node to exynos4210-origen Sachin Kamat
@ 2013-02-06 11:51 ` Sachin Kamat
2013-02-06 11:51 ` [PATCH 5/7] ARM: dts: Add G2D node to SMDK4412 Sachin Kamat
` (3 subsequent siblings)
7 siblings, 0 replies; 17+ messages in thread
From: Sachin Kamat @ 2013-02-06 11:51 UTC (permalink / raw)
To: linux-samsung-soc, devicetree-discuss
Cc: kgene.kim, s.nawrocki, inki.dae, sachin.kamat, patches
Added G2D DT node to exynos4x12.dtsi file.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
arch/arm/boot/dts/exynos4x12.dtsi | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
index 022a839..f9247b9 100644
--- a/arch/arm/boot/dts/exynos4x12.dtsi
+++ b/arch/arm/boot/dts/exynos4x12.dtsi
@@ -36,6 +36,13 @@
<0 16 0>, <0 17 0>, <0 18 0>, <0 19 0>;
};
+ g2d@10800000 {
+ compatible = "samsung,exynos4212-g2d";
+ reg = <0x10800000 0x1000>;
+ interrupts = <0 89 0>;
+ status = "disabled";
+ };
+
pinctrl_0: pinctrl@11400000 {
compatible = "samsung,exynos4x12-pinctrl";
reg = <0x11400000 0x1000>;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 5/7] ARM: dts: Add G2D node to SMDK4412
2013-02-06 11:51 [PATCH 0/7] ARM: dts: Add G2D DT nodes to Exynos4 machines Sachin Kamat
` (3 preceding siblings ...)
2013-02-06 11:51 ` [PATCH 4/7] ARM: dts: Add G2D node to exynos4x12.dtsi Sachin Kamat
@ 2013-02-06 11:51 ` Sachin Kamat
2013-02-06 11:51 ` [PATCH 6/7] ARM: dts: Add G2D node to exynos4412-origen Sachin Kamat
` (2 subsequent siblings)
7 siblings, 0 replies; 17+ messages in thread
From: Sachin Kamat @ 2013-02-06 11:51 UTC (permalink / raw)
To: linux-samsung-soc, devicetree-discuss
Cc: kgene.kim, s.nawrocki, inki.dae, sachin.kamat, patches
Added G2D DT node to SMDK4412 board.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
This patch is added on top of below patch:
http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg15148.html
---
arch/arm/boot/dts/exynos4412-smdk4412.dts | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4412-smdk4412.dts b/arch/arm/boot/dts/exynos4412-smdk4412.dts
index 6ae4276..bba53a8 100644
--- a/arch/arm/boot/dts/exynos4412-smdk4412.dts
+++ b/arch/arm/boot/dts/exynos4412-smdk4412.dts
@@ -27,6 +27,10 @@
bootargs ="root=/dev/ram0 rw ramdisk=8192 initrd=0x41000000,8M console=ttySAC1,115200 init=/linuxrc";
};
+ g2d@10800000 {
+ status = "okay";
+ };
+
sdhci@12530000 {
bus-width = <4>;
pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_bus4 &sd2_cd>;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 6/7] ARM: dts: Add G2D node to exynos4412-origen
2013-02-06 11:51 [PATCH 0/7] ARM: dts: Add G2D DT nodes to Exynos4 machines Sachin Kamat
` (4 preceding siblings ...)
2013-02-06 11:51 ` [PATCH 5/7] ARM: dts: Add G2D node to SMDK4412 Sachin Kamat
@ 2013-02-06 11:51 ` Sachin Kamat
2013-02-06 11:51 ` [PATCH 7/7] ARM: dts: Add Samsung G2D DT bindings documentation Sachin Kamat
[not found] ` <1360151477-26460-1-git-send-email-sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
7 siblings, 0 replies; 17+ messages in thread
From: Sachin Kamat @ 2013-02-06 11:51 UTC (permalink / raw)
To: linux-samsung-soc, devicetree-discuss
Cc: kgene.kim, s.nawrocki, inki.dae, sachin.kamat, patches
Added G2D DT node to Origen4412 board.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
This patch is added on top of below patch:
http://www.spinics.net/lists/linux-samsung-soc/msg15543.html
---
arch/arm/boot/dts/exynos4412-origen.dts | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts
index daa3884..1df7ebd 100644
--- a/arch/arm/boot/dts/exynos4412-origen.dts
+++ b/arch/arm/boot/dts/exynos4412-origen.dts
@@ -36,6 +36,10 @@
enable-active-high;
};
+ g2d@10800000 {
+ status = "okay";
+ };
+
sdhci@12530000 {
bus-width = <4>;
pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_bus4 &sd2_cd>;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 7/7] ARM: dts: Add Samsung G2D DT bindings documentation
2013-02-06 11:51 [PATCH 0/7] ARM: dts: Add G2D DT nodes to Exynos4 machines Sachin Kamat
` (5 preceding siblings ...)
2013-02-06 11:51 ` [PATCH 6/7] ARM: dts: Add G2D node to exynos4412-origen Sachin Kamat
@ 2013-02-06 11:51 ` Sachin Kamat
2013-02-13 22:32 ` Sylwester Nawrocki
2013-02-13 23:17 ` Tomasz Figa
[not found] ` <1360151477-26460-1-git-send-email-sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
7 siblings, 2 replies; 17+ messages in thread
From: Sachin Kamat @ 2013-02-06 11:51 UTC (permalink / raw)
To: linux-samsung-soc, devicetree-discuss
Cc: kgene.kim, s.nawrocki, inki.dae, sachin.kamat, patches
Added documentaion about G2D bindings.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
.../devicetree/bindings/gpu/samsung-g2d.txt | 30 ++++++++++++++++++++
1 files changed, 30 insertions(+), 0 deletions(-)
create mode 100644 Documentation/devicetree/bindings/gpu/samsung-g2d.txt
diff --git a/Documentation/devicetree/bindings/gpu/samsung-g2d.txt b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
new file mode 100644
index 0000000..838b26b
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
@@ -0,0 +1,30 @@
+* Samsung 2D Graphics Accelerator
+
+Samsung FIMG2D is a 2D graphics accelerator which supports Bit Block Transfer.
+We set the drawing-context registers for configuring the rendering parameters
+and then start rendering.
+The G2D has V4L2 as well as DRM framework based driver support.
+
+Required properties:
+ - compatible : value should be one among the following
+ (a) "samsung,s5pv210-g2d" for G2D IP present in S5PV210 & Exynos4210 SoC
+ (b) "samsung,exynos4212-g2d" for G2D IP present in Exynos4x12 SoCs
+ (b) "samsung,exynos5250-g2d" for G2D IP present in Exynos5250 SoC
+
+ - reg : Physical base address of the IP registers and length of memory
+ mapped region.
+
+ - interrupts : G2D interrupt number to the CPU.
+
+Optional properties:
+ - samsung,power-domain : power-domain property defined with a phandle
+ to respective power domain.
+
+Example:
+ g2d@12800000 {
+ compatible = "samsung,s5pv210-g2d";
+ reg = <0x12800000 0x1000>;
+ interrupts = <0 89 0>;
+ samsung,power-domain = <&pd_lcd0>;
+ status = "disabled";
+ };
--
1.7.4.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH 0/7] ARM: dts: Add G2D DT nodes to Exynos4 machines
[not found] ` <1360151477-26460-1-git-send-email-sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
@ 2013-02-12 17:47 ` Sachin Kamat
0 siblings, 0 replies; 17+ messages in thread
From: Sachin Kamat @ 2013-02-12 17:47 UTC (permalink / raw)
To: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ
Cc: inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
sachin.kamat-QSEj5FYQhm4dnm+yROfE0A,
kgene.kim-Sze3O3UU22JBDgjK7y7TUQ,
s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ,
patches-QSEj5FYQhm4dnm+yROfE0A
[-- Attachment #1.1: Type: text/plain, Size: 1394 bytes --]
Ping...
On Wednesday, 6 February 2013, Sachin Kamat <sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> This patch series is based on for-next branch of Kukjin Kim's tree
> git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
>
> Patches added on top of MFC DT series which has been accepted by Kukjin.
> http://www.spinics.net/lists/linux-samsung-soc/msg15419.html
>
> Sachin Kamat (7):
> ARM: dts: Add G2D node to exynos4210.dtsi
> ARM: dts: Add G2D node to SMDKV310
> ARM: dts: Add G2D node to exynos4210-origen
> ARM: dts: Add G2D node to exynos4x12.dtsi
> ARM: dts: Add G2D node to SMDK4412
> ARM: dts: Add G2D node to exynos4412-origen
> ARM: dts: Add Samsung G2D DT bindings documentation
>
> .../devicetree/bindings/gpu/samsung-g2d.txt | 30
++++++++++++++++++++
> arch/arm/boot/dts/exynos4210-origen.dts | 4 ++
> arch/arm/boot/dts/exynos4210-smdkv310.dts | 4 ++
> arch/arm/boot/dts/exynos4210.dtsi | 8 +++++
> arch/arm/boot/dts/exynos4412-origen.dts | 4 ++
> arch/arm/boot/dts/exynos4412-smdk4412.dts | 4 ++
> arch/arm/boot/dts/exynos4x12.dtsi | 7 ++++
> 7 files changed, 61 insertions(+), 0 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/gpu/samsung-g2d.txt
>
> --
> 1.7.4.1
>
>
--
With warm regards,
Sachin
[-- Attachment #1.2: Type: text/html, Size: 1873 bytes --]
[-- Attachment #2: Type: text/plain, Size: 192 bytes --]
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 7/7] ARM: dts: Add Samsung G2D DT bindings documentation
2013-02-06 11:51 ` [PATCH 7/7] ARM: dts: Add Samsung G2D DT bindings documentation Sachin Kamat
@ 2013-02-13 22:32 ` Sylwester Nawrocki
[not found] ` <511C1462.5060106-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-02-13 23:17 ` Tomasz Figa
1 sibling, 1 reply; 17+ messages in thread
From: Sylwester Nawrocki @ 2013-02-13 22:32 UTC (permalink / raw)
To: Sachin Kamat
Cc: linux-samsung-soc, devicetree-discuss, kgene.kim, s.nawrocki,
inki.dae, patches
On 02/06/2013 12:51 PM, Sachin Kamat wrote:
> Added documentaion about G2D bindings.
s/documentaion/documentation
> Signed-off-by: Sachin Kamat<sachin.kamat@linaro.org>
> ---
> .../devicetree/bindings/gpu/samsung-g2d.txt | 30 ++++++++++++++++++++
> 1 files changed, 30 insertions(+), 0 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/gpu/samsung-g2d.txt
>
> diff --git a/Documentation/devicetree/bindings/gpu/samsung-g2d.txt b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
> new file mode 100644
> index 0000000..838b26b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
> @@ -0,0 +1,30 @@
> +* Samsung 2D Graphics Accelerator
> +
> +Samsung FIMG2D is a 2D graphics accelerator which supports Bit Block Transfer.
> +We set the drawing-context registers for configuring the rendering parameters
> +and then start rendering.
> +The G2D has V4L2 as well as DRM framework based driver support.
IMHO this whole paragraph is irrelevant and could be dropped.
> +Required properties:
> + - compatible : value should be one among the following
missing colon at the end of line ?
> + (a) "samsung,s5pv210-g2d" for G2D IP present in S5PV210& Exynos4210 SoC
> + (b) "samsung,exynos4212-g2d" for G2D IP present in Exynos4x12 SoCs
> + (b) "samsung,exynos5250-g2d" for G2D IP present in Exynos5250 SoC
s/(b)/(c)
> +
> + - reg : Physical base address of the IP registers and length of memory
> + mapped region.
> +
> + - interrupts : G2D interrupt number to the CPU.
> +
> +Optional properties:
> + - samsung,power-domain : power-domain property defined with a phandle
> + to respective power domain.
> +
> +Example:
> + g2d@12800000 {
> + compatible = "samsung,s5pv210-g2d";
> + reg =<0x12800000 0x1000>;
> + interrupts =<0 89 0>;
> + samsung,power-domain =<&pd_lcd0>;
> + status = "disabled";
> + };
Otherwise looks good to me.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 7/7] ARM: dts: Add Samsung G2D DT bindings documentation
2013-02-06 11:51 ` [PATCH 7/7] ARM: dts: Add Samsung G2D DT bindings documentation Sachin Kamat
2013-02-13 22:32 ` Sylwester Nawrocki
@ 2013-02-13 23:17 ` Tomasz Figa
2013-02-14 15:49 ` Sachin Kamat
1 sibling, 1 reply; 17+ messages in thread
From: Tomasz Figa @ 2013-02-13 23:17 UTC (permalink / raw)
To: Sachin Kamat
Cc: linux-samsung-soc, devicetree-discuss, kgene.kim, s.nawrocki,
inki.dae, patches
Hi Sachin,
On Wednesday 06 of February 2013 17:21:17 Sachin Kamat wrote:
> Added documentaion about G2D bindings.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> .../devicetree/bindings/gpu/samsung-g2d.txt | 30
> ++++++++++++++++++++ 1 files changed, 30 insertions(+), 0 deletions(-)
> create mode 100644
> Documentation/devicetree/bindings/gpu/samsung-g2d.txt
>
> diff --git a/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
> b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt new file mode
> 100644
> index 0000000..838b26b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
> @@ -0,0 +1,30 @@
> +* Samsung 2D Graphics Accelerator
> +
> +Samsung FIMG2D is a 2D graphics accelerator which supports Bit Block
> Transfer. +We set the drawing-context registers for configuring the
> rendering parameters +and then start rendering.
> +The G2D has V4L2 as well as DRM framework based driver support.
> +
> +Required properties:
> + - compatible : value should be one among the following
> + (a) "samsung,s5pv210-g2d" for G2D IP present in S5PV210 & Exynos4210
> SoC + (b) "samsung,exynos4212-g2d" for G2D IP present in Exynos4x12
> SoCs + (b) "samsung,exynos5250-g2d" for G2D IP present in Exynos5250
> SoC +
> + - reg : Physical base address of the IP registers and length of
> memory + mapped region.
> +
> + - interrupts : G2D interrupt number to the CPU.
> +
> +Optional properties:
> + - samsung,power-domain : power-domain property defined with a phandle
> + to respective power domain.
I'm not sure if samsung,power-domain should be mentioned in this
documentation file. The driver itself does not use this property.
Otherwise looks fine.
Best regards,
Tomasz
> +
> +Example:
> + g2d@12800000 {
> + compatible = "samsung,s5pv210-g2d";
> + reg = <0x12800000 0x1000>;
> + interrupts = <0 89 0>;
> + samsung,power-domain = <&pd_lcd0>;
> + status = "disabled";
> + };
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 7/7] ARM: dts: Add Samsung G2D DT bindings documentation
[not found] ` <511C1462.5060106-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2013-02-14 15:45 ` Sachin Kamat
2013-02-14 16:01 ` Sylwester Nawrocki
0 siblings, 1 reply; 17+ messages in thread
From: Sachin Kamat @ 2013-02-14 15:45 UTC (permalink / raw)
To: Sylwester Nawrocki
Cc: kgene.kim-Sze3O3UU22JBDgjK7y7TUQ, patches-QSEj5FYQhm4dnm+yROfE0A,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ
[-- Attachment #1.1: Type: text/plain, Size: 2474 bytes --]
On Thursday, 14 February 2013, Sylwester Nawrocki <
sylvester.nawrocki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On 02/06/2013 12:51 PM, Sachin Kamat wrote:
>>
>> Added documentaion about G2D bindings.
>
> s/documentaion/documentation
Ok.
>
>> Signed-off-by: Sachin Kamat<sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>> ---
>> .../devicetree/bindings/gpu/samsung-g2d.txt | 30
++++++++++++++++++++
>> 1 files changed, 30 insertions(+), 0 deletions(-)
>> create mode 100644
Documentation/devicetree/bindings/gpu/samsung-g2d.txt
>>
>> diff --git a/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
>> new file mode 100644
>> index 0000000..838b26b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
>> @@ -0,0 +1,30 @@
>> +* Samsung 2D Graphics Accelerator
>> +
>
>> +Samsung FIMG2D is a 2D graphics accelerator which supports Bit Block
Transfer.
>> +We set the drawing-context registers for configuring the rendering
parameters
>> +and then start rendering.
>> +The G2D has V4L2 as well as DRM framework based driver support.
>
> IMHO this whole paragraph is irrelevant and could be dropped.
Ok. Had formatted this based on mfc document.
>
>> +Required properties:
>> + - compatible : value should be one among the following
>
> missing colon at the end of line ?
Hmm. I think so.
>
>> + (a) "samsung,s5pv210-g2d" for G2D IP present in S5PV210&
Exynos4210 SoC
>> + (b) "samsung,exynos4212-g2d" for G2D IP present in Exynos4x12
SoCs
>> + (b) "samsung,exynos5250-g2d" for G2D IP present in Exynos5250 SoC
>
> s/(b)/(c)
Yes, copy paste error :)
>
>> +
>> + - reg : Physical base address of the IP registers and length of memory
>> + mapped region.
>> +
>> + - interrupts : G2D interrupt number to the CPU.
>> +
>> +Optional properties:
>> + - samsung,power-domain : power-domain property defined with a phandle
>> + to respective power domain.
>> +
>> +Example:
>> + g2d@12800000 {
>> + compatible = "samsung,s5pv210-g2d";
>> + reg =<0x12800000 0x1000>;
>> + interrupts =<0 89 0>;
>> + samsung,power-domain =<&pd_lcd0>;
>> + status = "disabled";
>> + };
>
> Otherwise looks good to me.
Thanks for reviewing. Does the filename look good or should it be
exynos-g2d?
Regards,
Sachin.
--
With warm regards,
Sachin
[-- Attachment #1.2: Type: text/html, Size: 3312 bytes --]
[-- Attachment #2: Type: text/plain, Size: 192 bytes --]
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 7/7] ARM: dts: Add Samsung G2D DT bindings documentation
2013-02-13 23:17 ` Tomasz Figa
@ 2013-02-14 15:49 ` Sachin Kamat
2013-02-18 5:17 ` Sachin Kamat
0 siblings, 1 reply; 17+ messages in thread
From: Sachin Kamat @ 2013-02-14 15:49 UTC (permalink / raw)
To: Tomasz Figa
Cc: kgene.kim-Sze3O3UU22JBDgjK7y7TUQ, patches-QSEj5FYQhm4dnm+yROfE0A,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ
[-- Attachment #1.1: Type: text/plain, Size: 2589 bytes --]
Hi Tomasz,
On Thursday, 14 February 2013, Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Hi Sachin,
>
> On Wednesday 06 of February 2013 17:21:17 Sachin Kamat wrote:
>> Added documentaion about G2D bindings.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>> ---
>> .../devicetree/bindings/gpu/samsung-g2d.txt | 30
>> ++++++++++++++++++++ 1 files changed, 30 insertions(+), 0 deletions(-)
>> create mode 100644
>> Documentation/devicetree/bindings/gpu/samsung-g2d.txt
>>
>> diff --git a/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
>> b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt new file mode
>> 100644
>> index 0000000..838b26b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
>> @@ -0,0 +1,30 @@
>> +* Samsung 2D Graphics Accelerator
>> +
>> +Samsung FIMG2D is a 2D graphics accelerator which supports Bit Block
>> Transfer. +We set the drawing-context registers for configuring the
>> rendering parameters +and then start rendering.
>> +The G2D has V4L2 as well as DRM framework based driver support.
>> +
>> +Required properties:
>> + - compatible : value should be one among the following
>> + (a) "samsung,s5pv210-g2d" for G2D IP present in S5PV210 &
Exynos4210
>> SoC + (b) "samsung,exynos4212-g2d" for G2D IP present in Exynos4x12
>> SoCs + (b) "samsung,exynos5250-g2d" for G2D IP present in
Exynos5250
>> SoC +
>> + - reg : Physical base address of the IP registers and length of
>> memory + mapped region.
>> +
>> + - interrupts : G2D interrupt number to the CPU.
>> +
>> +Optional properties:
>> + - samsung,power-domain : power-domain property defined with a phandle
>> + to respective power domain.
>
> I'm not sure if samsung,power-domain should be mentioned in this
> documentation file. The driver itself does not use this property.
Oh ok. I will check this again and remove if unnecessary.
>
> Otherwise looks fine.
>
> Best regards,
> Tomasz
>
>> +
>> +Example:
>> + g2d@12800000 {
>> + compatible = "samsung,s5pv210-g2d";
>> + reg = <0x12800000 0x1000>;
>> + interrupts = <0 89 0>;
>> + samsung,power-domain = <&pd_lcd0>;
>> + status = "disabled";
>> + };
> --
> To unsubscribe from this list: send the line "unsubscribe
linux-samsung-soc" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
With warm regards,
Sachin
[-- Attachment #1.2: Type: text/html, Size: 3560 bytes --]
[-- Attachment #2: Type: text/plain, Size: 192 bytes --]
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 7/7] ARM: dts: Add Samsung G2D DT bindings documentation
2013-02-14 15:45 ` Sachin Kamat
@ 2013-02-14 16:01 ` Sylwester Nawrocki
[not found] ` <511D0A5E.7060907-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
0 siblings, 1 reply; 17+ messages in thread
From: Sylwester Nawrocki @ 2013-02-14 16:01 UTC (permalink / raw)
To: Sachin Kamat
Cc: linux-samsung-soc, devicetree-discuss, kgene.kim, inki.dae, patches
On 02/14/2013 04:45 PM, Sachin Kamat wrote:
> Thanks for reviewing. Does the filename look good or should it be exynos-g2d?
You're welcome. My apologies for being a bit late.
I guess exynos-g2d.txt would be more appropriate. OTOH if this document is
going to cover all Samsung G2D IP blocks then current name might be better.
I used samsung- prefix for fimc and mipi-csis as those documents are supposed
to cover the S5P and Exynos4 SoCs.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 7/7] ARM: dts: Add Samsung G2D DT bindings documentation
[not found] ` <511D0A5E.7060907-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
@ 2013-02-18 5:15 ` Sachin Kamat
0 siblings, 0 replies; 17+ messages in thread
From: Sachin Kamat @ 2013-02-18 5:15 UTC (permalink / raw)
To: Sylwester Nawrocki
Cc: inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
kgene.kim-Sze3O3UU22JBDgjK7y7TUQ,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
patches-QSEj5FYQhm4dnm+yROfE0A
Hi Sylwester,
On 14 February 2013 21:31, Sylwester Nawrocki <s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> On 02/14/2013 04:45 PM, Sachin Kamat wrote:
>> Thanks for reviewing. Does the filename look good or should it be exynos-g2d?
>
> You're welcome. My apologies for being a bit late.
> I guess exynos-g2d.txt would be more appropriate. OTOH if this document is
> going to cover all Samsung G2D IP blocks then current name might be better.
> I used samsung- prefix for fimc and mipi-csis as those documents are supposed
> to cover the S5P and Exynos4 SoCs.
>
I have retained the filename as it was since it addresses both S5P as
well as Exynos IPs.
Thanks for the tip.
I have resent this series with your other comments addressed.
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 7/7] ARM: dts: Add Samsung G2D DT bindings documentation
2013-02-14 15:49 ` Sachin Kamat
@ 2013-02-18 5:17 ` Sachin Kamat
0 siblings, 0 replies; 17+ messages in thread
From: Sachin Kamat @ 2013-02-18 5:17 UTC (permalink / raw)
To: Tomasz Figa
Cc: linux-samsung-soc, devicetree-discuss, kgene.kim, s.nawrocki,
inki.dae, patches
Hi Tomasz,
>>> +Optional properties:
>>> + - samsung,power-domain : power-domain property defined with a phandle
>>> + to respective power domain.
>>
>> I'm not sure if samsung,power-domain should be mentioned in this
>> documentation file. The driver itself does not use this property.
>
> Oh ok. I will check this again and remove if unnecessary.
The driver does not use power-domain property for now and hence I have
removed this in V2.
Thanks for pointing out.
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 6/7] ARM: dts: Add G2D node to exynos4412-origen
2013-02-18 5:02 [PATCH v2 0/7] Add G2D " Sachin Kamat
@ 2013-02-18 5:02 ` Sachin Kamat
0 siblings, 0 replies; 17+ messages in thread
From: Sachin Kamat @ 2013-02-18 5:02 UTC (permalink / raw)
To: linux-samsung-soc, devicetree-discuss
Cc: kgene.kim, s.nawrocki, patches, sachin.kamat
Added G2D DT node to Origen4412 board.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
arch/arm/boot/dts/exynos4412-smdk4412.dts | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4412-smdk4412.dts b/arch/arm/boot/dts/exynos4412-smdk4412.dts
index bba53a8..539670b 100644
--- a/arch/arm/boot/dts/exynos4412-smdk4412.dts
+++ b/arch/arm/boot/dts/exynos4412-smdk4412.dts
@@ -31,6 +31,10 @@
status = "okay";
};
+ g2d@10800000 {
+ status = "okay";
+ };
+
sdhci@12530000 {
bus-width = <4>;
pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_bus4 &sd2_cd>;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
end of thread, other threads:[~2013-02-18 5:17 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-06 11:51 [PATCH 0/7] ARM: dts: Add G2D DT nodes to Exynos4 machines Sachin Kamat
2013-02-06 11:51 ` [PATCH 1/7] ARM: dts: Add G2D node to exynos4210.dtsi Sachin Kamat
2013-02-06 11:51 ` [PATCH 2/7] ARM: dts: Add G2D node to SMDKV310 Sachin Kamat
2013-02-06 11:51 ` [PATCH 3/7] ARM: dts: Add G2D node to exynos4210-origen Sachin Kamat
2013-02-06 11:51 ` [PATCH 4/7] ARM: dts: Add G2D node to exynos4x12.dtsi Sachin Kamat
2013-02-06 11:51 ` [PATCH 5/7] ARM: dts: Add G2D node to SMDK4412 Sachin Kamat
2013-02-06 11:51 ` [PATCH 6/7] ARM: dts: Add G2D node to exynos4412-origen Sachin Kamat
2013-02-06 11:51 ` [PATCH 7/7] ARM: dts: Add Samsung G2D DT bindings documentation Sachin Kamat
2013-02-13 22:32 ` Sylwester Nawrocki
[not found] ` <511C1462.5060106-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-02-14 15:45 ` Sachin Kamat
2013-02-14 16:01 ` Sylwester Nawrocki
[not found] ` <511D0A5E.7060907-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-02-18 5:15 ` Sachin Kamat
2013-02-13 23:17 ` Tomasz Figa
2013-02-14 15:49 ` Sachin Kamat
2013-02-18 5:17 ` Sachin Kamat
[not found] ` <1360151477-26460-1-git-send-email-sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-02-12 17:47 ` [PATCH 0/7] ARM: dts: Add G2D DT nodes to Exynos4 machines Sachin Kamat
2013-02-18 5:02 [PATCH v2 0/7] Add G2D " Sachin Kamat
2013-02-18 5:02 ` [PATCH 6/7] ARM: dts: Add G2D node to exynos4412-origen Sachin Kamat
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.