* [PATCH] bgmac: validate MAC addr
@ 2013-02-06 9:37 Rafał Miłecki
2013-02-06 17:11 ` Florian Fainelli
2013-02-07 10:14 ` [PATCH V2] " Rafał Miłecki
0 siblings, 2 replies; 6+ messages in thread
From: Rafał Miłecki @ 2013-02-06 9:37 UTC (permalink / raw)
To: netdev, David S. Miller; +Cc: Rafał Miłecki
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
drivers/net/ethernet/broadcom/bgmac.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
index af149a3..9f95089 100644
--- a/drivers/net/ethernet/broadcom/bgmac.c
+++ b/drivers/net/ethernet/broadcom/bgmac.c
@@ -1290,6 +1290,11 @@ static int bgmac_probe(struct bcma_device *core)
return -ENOTSUPP;
}
+ if (!is_valid_ether_addr(mac)) {
+ dev_err(&core->dev, "Invalid MAC addr: %pM\n", mac);
+ return -EADDRNOTAVAIL;
+ }
+
/* Allocation and references */
net_dev = alloc_etherdev(sizeof(*bgmac));
if (!net_dev)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] bgmac: validate MAC addr
2013-02-06 9:37 [PATCH] bgmac: validate MAC addr Rafał Miłecki
@ 2013-02-06 17:11 ` Florian Fainelli
2013-02-07 10:14 ` [PATCH V2] " Rafał Miłecki
1 sibling, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2013-02-06 17:11 UTC (permalink / raw)
To: Rafał Miłecki; +Cc: netdev, David S. Miller
Hello Rafal,
On 02/06/2013 10:37 AM, Rafał Miłecki wrote:
>
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> ---
> drivers/net/ethernet/broadcom/bgmac.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
> index af149a3..9f95089 100644
> --- a/drivers/net/ethernet/broadcom/bgmac.c
> +++ b/drivers/net/ethernet/broadcom/bgmac.c
> @@ -1290,6 +1290,11 @@ static int bgmac_probe(struct bcma_device *core)
> return -ENOTSUPP;
> }
>
> + if (!is_valid_ether_addr(mac)) {
> + dev_err(&core->dev, "Invalid MAC addr: %pM\n", mac);
> + return -EADDRNOTAVAIL;
> + }
Rather generate an random one, thus making the interface usable, but
keep the warning to help users track this down.
--
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH V2] bgmac: validate MAC addr
2013-02-06 9:37 [PATCH] bgmac: validate MAC addr Rafał Miłecki
2013-02-06 17:11 ` Florian Fainelli
@ 2013-02-07 10:14 ` Rafał Miłecki
2013-02-07 10:19 ` Florian Fainelli
2013-02-07 10:27 ` [PATCH V3] bgmac: validate (and random if needed) " Rafał Miłecki
1 sibling, 2 replies; 6+ messages in thread
From: Rafał Miłecki @ 2013-02-07 10:14 UTC (permalink / raw)
To: netdev, David S. Miller; +Cc: Florian Fainelli, Rafał Miłecki
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
V2: generate random addr
---
drivers/net/ethernet/broadcom/bgmac.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
index d08a4af..f90d1dc 100644
--- a/drivers/net/ethernet/broadcom/bgmac.c
+++ b/drivers/net/ethernet/broadcom/bgmac.c
@@ -1318,6 +1318,12 @@ static int bgmac_probe(struct bcma_device *core)
return -ENOTSUPP;
}
+ if (!is_valid_ether_addr(mac)) {
+ dev_err(&core->dev, "Invalid MAC addr: %pM\n", mac);
+ eth_random_addr(mac);
+ dev_warn(&core->dev, "Using random MAC: %pM\n", mac);
+ }
+
/* Allocation and references */
net_dev = alloc_etherdev(sizeof(*bgmac));
if (!net_dev)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH V2] bgmac: validate MAC addr
2013-02-07 10:14 ` [PATCH V2] " Rafał Miłecki
@ 2013-02-07 10:19 ` Florian Fainelli
2013-02-07 10:27 ` [PATCH V3] bgmac: validate (and random if needed) " Rafał Miłecki
1 sibling, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2013-02-07 10:19 UTC (permalink / raw)
To: Rafał Miłecki; +Cc: netdev, David S. Miller
On 02/07/2013 11:14 AM, Rafał Miłecki wrote:
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
This is looking good, however some commit message is desirable,
especially as you are no longer just validating the ethernet MAC
address, but also generating a new one. Something along those lines
would probably be enough:
"This patch changes bgmac_probe() to check for a valid Ethernet MAC
address and in case it is not, will generate a valid random one, such
that the adapter is still usable."
Thanks!
> ---
> V2: generate random addr
> ---
> drivers/net/ethernet/broadcom/bgmac.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
> index d08a4af..f90d1dc 100644
> --- a/drivers/net/ethernet/broadcom/bgmac.c
> +++ b/drivers/net/ethernet/broadcom/bgmac.c
> @@ -1318,6 +1318,12 @@ static int bgmac_probe(struct bcma_device *core)
> return -ENOTSUPP;
> }
>
> + if (!is_valid_ether_addr(mac)) {
> + dev_err(&core->dev, "Invalid MAC addr: %pM\n", mac);
> + eth_random_addr(mac);
> + dev_warn(&core->dev, "Using random MAC: %pM\n", mac);
> + }
> +
> /* Allocation and references */
> net_dev = alloc_etherdev(sizeof(*bgmac));
> if (!net_dev)
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH V3] bgmac: validate (and random if needed) MAC addr
2013-02-07 10:14 ` [PATCH V2] " Rafał Miłecki
2013-02-07 10:19 ` Florian Fainelli
@ 2013-02-07 10:27 ` Rafał Miłecki
2013-02-08 22:42 ` David Miller
1 sibling, 1 reply; 6+ messages in thread
From: Rafał Miłecki @ 2013-02-07 10:27 UTC (permalink / raw)
To: netdev, David S. Miller; +Cc: Florian Fainelli, Rafał Miłecki
This adds check for a valid Ethernet MAC address and in case it is not,
it will generate a valid random one, such that the adapter is still
usable.
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
V2: generate random addr
V3: update commit message
---
drivers/net/ethernet/broadcom/bgmac.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
index d08a4af..f90d1dc 100644
--- a/drivers/net/ethernet/broadcom/bgmac.c
+++ b/drivers/net/ethernet/broadcom/bgmac.c
@@ -1318,6 +1318,12 @@ static int bgmac_probe(struct bcma_device *core)
return -ENOTSUPP;
}
+ if (!is_valid_ether_addr(mac)) {
+ dev_err(&core->dev, "Invalid MAC addr: %pM\n", mac);
+ eth_random_addr(mac);
+ dev_warn(&core->dev, "Using random MAC: %pM\n", mac);
+ }
+
/* Allocation and references */
net_dev = alloc_etherdev(sizeof(*bgmac));
if (!net_dev)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-02-08 22:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-06 9:37 [PATCH] bgmac: validate MAC addr Rafał Miłecki
2013-02-06 17:11 ` Florian Fainelli
2013-02-07 10:14 ` [PATCH V2] " Rafał Miłecki
2013-02-07 10:19 ` Florian Fainelli
2013-02-07 10:27 ` [PATCH V3] bgmac: validate (and random if needed) " Rafał Miłecki
2013-02-08 22:42 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.