All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Hurley <peter@hurleysoftware.com>
To: Yinghai Lu <yinghai@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
	Lan Tianyu <tianyu.lan@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Kosina <jkosina@suse.cz>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-next@vger.kernel.org
Subject: [Bisected] [-next-20130204] usb/hcd:  irq 18: nobody cared
Date: Sat, 09 Feb 2013 22:14:20 -0500	[thread overview]
Message-ID: <1360466060.3703.15.camel@thor.lan> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1302051520220.2245-100000@iolanthe.rowland.org>

On Tue, 2013-02-05 at 15:26 -0500, Alan Stern wrote:
> On Tue, 5 Feb 2013, Peter Hurley wrote:
> 
> > With -next-20130204:
> > 
> > [   33.855570] irq 18: nobody cared (try booting with the "irqpoll" option)
> > [   33.855580] Pid: 0, comm: swapper/4 Not tainted 3.8.0-next-20130204-xeon #20130204
> > [   33.855582] Call Trace:
> > [   33.855585]  <IRQ>  [<ffffffff810f1076>] __report_bad_irq+0x36/0xe0
> > [   33.855600]  [<ffffffff810f152a>] note_interrupt+0x1aa/0x200
> > [   33.855606]  [<ffffffff8101edf2>] ? mwait_idle+0x82/0x1b0
> > [   33.855610]  [<ffffffff810eed89>] handle_irq_event_percpu+0xc9/0x260
> > [   33.855614]  [<ffffffff810eef68>] handle_irq_event+0x48/0x70
> > [   33.855618]  [<ffffffff810f20ba>] handle_fasteoi_irq+0x5a/0x100
> > [   33.855624]  [<ffffffff810182f2>] handle_irq+0x22/0x40
> > [   33.855630]  [<ffffffff816e2a9a>] do_IRQ+0x5a/0xd0
> > [   33.855636]  [<ffffffff816d97ad>] common_interrupt+0x6d/0x6d
> > [   33.855638]  <EOI>  [<ffffffff810f8e2a>] ? rcu_eqs_enter_common+0x4a/0x320
> > [   33.855646]  [<ffffffff8101edf2>] ? mwait_idle+0x82/0x1b0
> > [   33.855649]  [<ffffffff8101ed99>] ? mwait_idle+0x29/0x1b0
> > [   33.855653]  [<ffffffff8101f8a6>] cpu_idle+0x116/0x130
> > [   33.855658]  [<ffffffff816c0c0f>] start_secondary+0x251/0x258
> > [   33.855660] handlers:
> > [   33.855664] [<ffffffff814f98a0>] usb_hcd_irq
> > [   33.855667] Disabling IRQ #18
> > 
> > From earlier in the boot log:
> > [    1.297020] uhci_hcd 0000:00:1d.2: setting latency timer to 64
> > [    1.297032] uhci_hcd 0000:00:1d.2: UHCI Host Controller
> > [    1.297040] uhci_hcd 0000:00:1d.2: new USB bus registered, assigned bus number 4
> > [    1.297076] uhci_hcd 0000:00:1d.2: irq 18, io base 0x0000ff40
> > [    1.297213] hub 4-0:1.0: USB hub found
> > [    1.297221] hub 4-0:1.0: 2 ports detected
> > 
> > lsusb:
> > ...
> > Bus 004 Device 002: ID 0764:0501 Cyber Power System, Inc. CP1500 AVR UPS
> > Bus 004 Device 003: ID 046d:c52b Logitech, Inc. Unifying Receiver

[...]

> If the suggestion above doesn't work out, bisection may be the best way
> to find the answer.

This bad irq bisected to:

4f535093cf8f6da8cfda7c36c2c1ecd2e9586ee4 is the first bad commit
commit 4f535093cf8f6da8cfda7c36c2c1ecd2e9586ee4
Author: Yinghai Lu <yinghai@kernel.org>
Date:   Mon Jan 21 13:20:52 2013 -0800

    PCI: Put pci_dev in device tree as early as possible
    
    We want to put pci_dev structs in the device tree as soon as possible so
    for_each_pci_dev() iteration will not miss them, but driver attachment
    needs to be delayed until after pci_assign_unassigned_resources() to make
    sure all devices have resources assigned first.
    
    This patch moves device registering from pci_bus_add_devices() to
    pci_device_add(), which happens earlier, leaving driver attachment in
    pci_bus_add_devices().
    
    It also removes unattached child bus handling in pci_bus_add_devices().
    That's not needed because child bus via pci_add_new_bus() is already
    in parent bus children list.
    
    [bhelgaas: changelog]
    Signed-off-by: Yinghai Lu <yinghai@kernel.org>
    Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
    Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

:040000 040000 0540c98d04d00de24b4e12fa750f6cd26c5addd2 2e24946cb7165a4028b7efb0a622271cc3990005 M	drivers

All is fine if I revert these 2 commits:

40064ac PCI: Remove unused "rc" in virtfn_add_bus()
4f53509 (HEAD, refs/bisect/bad) PCI: Put pci_dev in device tree as early as possible

Any ideas how these are causing the USB HCD core / hid-logitech-dj
driver to drop interrupts?

Regards,
Peter Hurley


  parent reply	other threads:[~2013-02-10  3:35 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-05 17:51 [-next-20130204] usb/hcd: irq 18: nobody cared Peter Hurley
2013-02-05 20:26 ` Alan Stern
2013-02-05 20:26   ` Alan Stern
2013-02-08 11:57   ` Peter Hurley
2013-02-10  3:14   ` Peter Hurley [this message]
2013-02-10 14:23     ` [Bisected] " Peter Hurley
2013-02-10 20:33       ` Yinghai Lu
2013-02-11  6:40         ` Yinghai Lu
2013-02-11 10:25           ` Jiri Slaby
2013-02-11 13:02           ` Peter Hurley
2013-02-11 19:19             ` Yinghai Lu
2013-02-11 19:45               ` Sedat Dilek
2013-02-11 19:53                 ` Yinghai Lu
2013-02-11 19:57               ` Yinghai Lu
2013-02-11 21:06                 ` Yinghai Lu
2013-02-11 22:41                   ` Bjorn Helgaas
2013-02-12  0:08                     ` Yinghai Lu
2013-02-12  3:21                       ` Yinghai Lu
2013-02-12 19:11                         ` [PATCH] ACPI, PCI: Get PRT entry during acpi_pci_enable_irq() Yinghai Lu
2013-02-12 20:22                           ` Rafael J. Wysocki
2013-02-15  0:50                             ` Yinghai Lu
2013-02-16  0:39                               ` Bjorn Helgaas
2013-02-16  1:26                                 ` Yinghai Lu
2013-02-16  1:37                                   ` Yinghai Lu
2013-02-19 18:51                                     ` Bjorn Helgaas
2013-02-13  2:20                           ` Peter Hurley
2013-02-13  2:42                             ` Yinghai Lu
2013-02-13  3:18                               ` Peter Hurley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1360466060.3703.15.camel@thor.lan \
    --to=peter@hurleysoftware.com \
    --cc=bhelgaas@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=stern@rowland.harvard.edu \
    --cc=tianyu.lan@intel.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.