From: Doug Anderson <dianders@chromium.org> To: Wolfram Sang <wolfram@the-dreams.de> Cc: Guenter Roeck <linux@roeck-us.net>, Linus Walleij <linus.walleij@linaro.org>, Simon Glass <sjg@chromium.org>, Naveen Krishna Chatradhi <ch.naveen@samsung.com>, Grant Likely <grant.likely@secretlab.ca>, Yuvaraj Kumar <yuvaraj.cd@gmail.com>, Ben Dooks <ben.dooks@codethink.co.uk>, u.kleine-koenig@pengutronix.de, Mark Brown <broonie@opensource.wolfsonmicro.com>, Girish Shivananjappa <girish.shivananjappa@linaro.org>, bhushan.r@samsung.com, sreekumar.c@samsung.com, Prashanth G <prashanth.g@samsung.com>, Olof Johansson <olof@lixom.net>, Daniel Kurtz <djkurtz@chromium.org>, Grant Grundler <grundler@chromium.org>, Doug Anderson <dianders@chromium.org>, Russell King <linux@arm.linux.org.uk>, Kukjin Kim <kgene.kim@samsung.com>, Rahul Sharma <rahul.sharma@samsung.com>, Thomas Abraham <thomas.abraham@linaro.org>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow Date: Thu, 14 Feb 2013 16:21:16 -0800 [thread overview] Message-ID: <1360887677-20758-2-git-send-email-dianders@chromium.org> (raw) In-Reply-To: <1360887677-20758-1-git-send-email-dianders@chromium.org> We need to use the i2c-arbitrator to talk to any of the devices on i2c bus 4 on exynos5250-snow so that we don't confuse the embedded controller (EC). Add the i2c-arbitrator to the device tree. As we add future devices (keyboard, sbs, tps65090) we'll add them on top of this. The arbitrated bus is numbered 104 simply as a convenience to make it easier for people poking around to guess that it might have something to do with the physical bus 4. The addition is split between the cros5250-common and the snow device tree file since not all cros5250-class devices use arbitration. Signed-off-by: Doug Anderson <dianders@chromium.org> --- Changes in v2: - Use new device tree property names / compatible string. - Include that the GPIOs for arbitration are active low. arch/arm/boot/dts/cros5250-common.dtsi | 5 ++++- arch/arm/boot/dts/exynos5250-snow.dts | 25 +++++++++++++++++++++++++ 2 files changed, 29 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/cros5250-common.dtsi b/arch/arm/boot/dts/cros5250-common.dtsi index 46c0980..f451375 100644 --- a/arch/arm/boot/dts/cros5250-common.dtsi +++ b/arch/arm/boot/dts/cros5250-common.dtsi @@ -58,7 +58,10 @@ }; i2c@12CA0000 { - status = "disabled"; + samsung,i2c-sda-delay = <100>; + samsung,i2c-max-bus-freq = <66000>; + gpios = <&gpa2 0 3 3 0>, + <&gpa2 1 3 3 0>; }; i2c@12CB0000 { diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts index 17dd951..d2d4b48 100644 --- a/arch/arm/boot/dts/exynos5250-snow.dts +++ b/arch/arm/boot/dts/exynos5250-snow.dts @@ -16,6 +16,10 @@ model = "Google Snow"; compatible = "google,snow", "samsung,exynos5250"; + aliases { + i2c104 = &i2c_104; + }; + gpio-keys { compatible = "gpio-keys"; @@ -29,6 +33,27 @@ }; }; + i2c-arbitrator { + compatible = "i2c-arbitrator-cros-ec"; + #address-cells = <1>; + #size-cells = <0>; + + i2c-parent = <&{/i2c@12CA0000}>; + + ap-claim-gpio = <&gpf0 3 1 0x10000 0>; + ec-claim-gpio = <&gpe0 4 0 0x10003 0>; + slew-delay-us = <10>; + wait-retry-us = <3000>; + wait-free-us = <50000>; + + /* Use ID 104 as a hint that we're on physical bus 4 */ + i2c_104: i2c@0 { + reg = <0>; + #address-cells = <1>; + #size-cells = <0>; + }; + }; + /* * On Snow we've got SIP WiFi and so can keep drive strengths low to * reduce EMI. -- 1.8.1
WARNING: multiple messages have this Message-ID (diff)
From: dianders@chromium.org (Doug Anderson) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow Date: Thu, 14 Feb 2013 16:21:16 -0800 [thread overview] Message-ID: <1360887677-20758-2-git-send-email-dianders@chromium.org> (raw) In-Reply-To: <1360887677-20758-1-git-send-email-dianders@chromium.org> We need to use the i2c-arbitrator to talk to any of the devices on i2c bus 4 on exynos5250-snow so that we don't confuse the embedded controller (EC). Add the i2c-arbitrator to the device tree. As we add future devices (keyboard, sbs, tps65090) we'll add them on top of this. The arbitrated bus is numbered 104 simply as a convenience to make it easier for people poking around to guess that it might have something to do with the physical bus 4. The addition is split between the cros5250-common and the snow device tree file since not all cros5250-class devices use arbitration. Signed-off-by: Doug Anderson <dianders@chromium.org> --- Changes in v2: - Use new device tree property names / compatible string. - Include that the GPIOs for arbitration are active low. arch/arm/boot/dts/cros5250-common.dtsi | 5 ++++- arch/arm/boot/dts/exynos5250-snow.dts | 25 +++++++++++++++++++++++++ 2 files changed, 29 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/cros5250-common.dtsi b/arch/arm/boot/dts/cros5250-common.dtsi index 46c0980..f451375 100644 --- a/arch/arm/boot/dts/cros5250-common.dtsi +++ b/arch/arm/boot/dts/cros5250-common.dtsi @@ -58,7 +58,10 @@ }; i2c at 12CA0000 { - status = "disabled"; + samsung,i2c-sda-delay = <100>; + samsung,i2c-max-bus-freq = <66000>; + gpios = <&gpa2 0 3 3 0>, + <&gpa2 1 3 3 0>; }; i2c at 12CB0000 { diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts index 17dd951..d2d4b48 100644 --- a/arch/arm/boot/dts/exynos5250-snow.dts +++ b/arch/arm/boot/dts/exynos5250-snow.dts @@ -16,6 +16,10 @@ model = "Google Snow"; compatible = "google,snow", "samsung,exynos5250"; + aliases { + i2c104 = &i2c_104; + }; + gpio-keys { compatible = "gpio-keys"; @@ -29,6 +33,27 @@ }; }; + i2c-arbitrator { + compatible = "i2c-arbitrator-cros-ec"; + #address-cells = <1>; + #size-cells = <0>; + + i2c-parent = <&{/i2c@12CA0000}>; + + ap-claim-gpio = <&gpf0 3 1 0x10000 0>; + ec-claim-gpio = <&gpe0 4 0 0x10003 0>; + slew-delay-us = <10>; + wait-retry-us = <3000>; + wait-free-us = <50000>; + + /* Use ID 104 as a hint that we're on physical bus 4 */ + i2c_104: i2c at 0 { + reg = <0>; + #address-cells = <1>; + #size-cells = <0>; + }; + }; + /* * On Snow we've got SIP WiFi and so can keep drive strengths low to * reduce EMI. -- 1.8.1
next prev parent reply other threads:[~2013-02-15 0:22 UTC|newest] Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-02-15 0:21 [PATCH v2 1/3] i2c: mux: Add i2c-arbitrator-cros-ec 'mux' driver Doug Anderson 2013-02-15 0:21 ` Doug Anderson [this message] 2013-02-15 0:21 ` [PATCH v2 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow Doug Anderson 2013-02-15 0:21 ` [PATCH v2 3/3] ARM: dts: Add sbs-battery " Doug Anderson 2013-02-15 0:21 ` Doug Anderson 2013-02-15 16:39 ` [PATCH v2 1/3] i2c: mux: Add i2c-arbitrator-cros-ec 'mux' driver Stephen Warren 2013-02-15 16:39 ` Stephen Warren [not found] ` <511E64C0.9090500-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> 2013-02-15 17:25 ` Doug Anderson [not found] ` <CAD=FV=W9WwSsid_KqtDRmAkFXnneRXu5zcakDB3t4hLhOpuCtw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2013-02-15 17:38 ` Stephen Warren 2013-02-15 17:44 ` Mark Brown 2013-02-15 17:44 ` Mark Brown [not found] ` <20130215174425.GF22283-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> 2013-02-15 18:57 ` Doug Anderson 2013-02-15 19:46 ` [PATCH v3 " Doug Anderson 2013-02-15 19:46 ` Doug Anderson 2013-02-15 19:46 ` [PATCH v3 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow Doug Anderson 2013-02-15 19:46 ` Doug Anderson 2013-03-05 23:48 ` Naveen Krishna Ch 2013-03-05 23:48 ` Naveen Krishna Ch 2013-03-13 7:30 ` Kukjin Kim 2013-03-13 7:30 ` Kukjin Kim 2013-03-13 15:14 ` Doug Anderson 2013-03-13 15:14 ` Doug Anderson 2013-02-15 19:46 ` [PATCH v3 3/3] ARM: dts: Add sbs-battery " Doug Anderson 2013-02-15 19:46 ` Doug Anderson 2013-03-05 23:49 ` Naveen Krishna Ch 2013-03-05 23:49 ` Naveen Krishna Ch 2013-02-15 21:31 ` [PATCH v3 1/3] i2c: mux: Add i2c-arbitrator-cros-ec 'mux' driver Stephen Warren 2013-03-11 16:05 ` Doug Anderson 2013-03-11 16:05 ` Doug Anderson 2013-03-13 16:36 ` [PATCH v4 " Doug Anderson 2013-03-13 16:36 ` Doug Anderson 2013-03-13 16:36 ` [PATCH v4 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow Doug Anderson 2013-03-13 16:36 ` Doug Anderson 2013-03-13 16:36 ` [PATCH v4 3/3] ARM: dts: Add sbs-battery " Doug Anderson 2013-03-13 16:36 ` Doug Anderson 2013-03-13 16:53 ` [PATCH v4 1/3] i2c: mux: Add i2c-arbitrator-cros-ec 'mux' driver Stephen Warren 2013-03-13 16:53 ` Stephen Warren 2013-03-13 16:59 ` Doug Anderson 2013-03-13 16:59 ` Doug Anderson 2013-03-13 17:29 ` Stephen Warren 2013-03-13 17:29 ` Stephen Warren 2013-04-08 10:26 ` Wolfram Sang 2013-04-08 10:26 ` Wolfram Sang [not found] ` <20130408102617.GC3496-z923LK4zBo2bacvFa/9K2g@public.gmane.org> 2013-04-09 20:26 ` Doug Anderson [not found] ` <1363192583-26363-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> 2013-03-26 20:23 ` Doug Anderson [not found] ` <20130329115821.GC6359@the-dreams.de> [not found] ` <20130329115821.GC6359-z923LK4zBo2bacvFa/9K2g@public.gmane.org> 2013-03-29 18:28 ` Doug Anderson [not found] ` <20130403191938.GA7875@the-dreams.de> [not found] ` <20130403191938.GA7875-z923LK4zBo2bacvFa/9K2g@public.gmane.org> 2013-04-05 19:37 ` Simon Glass 2013-04-05 20:03 ` Stephen Warren 2013-04-05 20:03 ` Stephen Warren 2013-04-06 18:30 ` Guenter Roeck 2013-04-06 20:11 ` Wolfram Sang 2013-04-07 18:10 ` Guenter Roeck 2013-04-08 9:55 ` Wolfram Sang 2013-04-08 9:55 ` Wolfram Sang 2013-04-09 20:12 ` [PATCH v5 1/3] i2c: mux: Add i2c-arb-gpio-challenge " Doug Anderson 2013-04-09 20:12 ` [PATCH v5 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow Doug Anderson 2013-04-09 20:12 ` Doug Anderson 2013-04-09 20:12 ` [PATCH v5 3/3] ARM: dts: Add sbs-battery " Doug Anderson 2013-04-09 20:12 ` Doug Anderson 2013-04-09 21:34 ` [PATCH v5 1/3] i2c: mux: Add i2c-arb-gpio-challenge 'mux' driver Doug Anderson 2013-04-09 21:34 ` Doug Anderson 2013-04-09 21:34 ` [PATCH v5 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow Doug Anderson 2013-04-09 21:34 ` Doug Anderson 2013-04-10 10:59 ` Kukjin Kim 2013-04-10 10:59 ` Kukjin Kim 2013-04-10 11:02 ` Wolfram Sang 2013-04-10 11:02 ` Wolfram Sang 2013-04-10 14:12 ` Kukjin Kim 2013-04-10 14:12 ` Kukjin Kim 2013-04-09 21:34 ` [PATCH v5 3/3] ARM: dts: Add sbs-battery " Doug Anderson 2013-04-09 21:34 ` Doug Anderson 2013-04-16 9:36 ` [PATCH v5 1/3] i2c: mux: Add i2c-arb-gpio-challenge 'mux' driver Wolfram Sang 2013-04-16 9:36 ` Wolfram Sang 2013-04-16 9:44 ` Peter Korsgaard 2013-04-16 9:44 ` Peter Korsgaard 2013-04-16 13:38 ` Guenter Roeck 2013-04-16 15:42 ` Stephen Warren 2013-04-16 15:42 ` Stephen Warren [not found] ` <20130416093633.GC16978-z923LK4zBo2bacvFa/9K2g@public.gmane.org> 2013-04-16 16:25 ` Doug Anderson 2013-04-16 16:29 ` [PATCH v6 " Doug Anderson 2013-04-16 16:29 ` [PATCH v6 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow Doug Anderson 2013-04-16 16:29 ` Doug Anderson 2013-04-16 16:35 ` Olof Johansson 2013-04-16 16:35 ` Olof Johansson 2013-04-16 16:29 ` [PATCH v6 3/3] ARM: dts: Add sbs-battery " Doug Anderson 2013-04-16 16:29 ` Doug Anderson 2013-04-16 16:36 ` Olof Johansson 2013-04-16 16:36 ` Olof Johansson 2013-04-16 16:34 ` [PATCH v6 1/3] i2c: mux: Add i2c-arb-gpio-challenge 'mux' driver Olof Johansson 2013-04-17 9:34 ` Wolfram Sang [not found] ` <20130417093424.GC4508-z923LK4zBo2bacvFa/9K2g@public.gmane.org> 2013-04-17 13:57 ` Olof Johansson 2013-04-17 16:35 ` Olof Johansson 2013-04-16 16:45 ` Guenter Roeck 2013-04-16 16:45 ` Guenter Roeck [not found] ` <20130416164512.GB27488-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> 2013-04-16 16:51 ` Doug Anderson 2013-04-17 9:32 ` Wolfram Sang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1360887677-20758-2-git-send-email-dianders@chromium.org \ --to=dianders@chromium.org \ --cc=ben.dooks@codethink.co.uk \ --cc=bhushan.r@samsung.com \ --cc=broonie@opensource.wolfsonmicro.com \ --cc=ch.naveen@samsung.com \ --cc=djkurtz@chromium.org \ --cc=girish.shivananjappa@linaro.org \ --cc=grant.likely@secretlab.ca \ --cc=grundler@chromium.org \ --cc=kgene.kim@samsung.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=linux@roeck-us.net \ --cc=olof@lixom.net \ --cc=prashanth.g@samsung.com \ --cc=rahul.sharma@samsung.com \ --cc=sjg@chromium.org \ --cc=sreekumar.c@samsung.com \ --cc=thomas.abraham@linaro.org \ --cc=u.kleine-koenig@pengutronix.de \ --cc=wolfram@the-dreams.de \ --cc=yuvaraj.cd@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.