All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Fabio Fantoni <fabio.fantoni@heliman.it>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: Re: [PATCH] tools/libxl: Disable useless empty floppy drive with qemu-xen
Date: Fri, 15 Feb 2013 12:18:11 +0000	[thread overview]
Message-ID: <1360930691.31407.20.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <5111301B.8080304@heliman.it>

On Tue, 2013-02-05 at 16:15 +0000, Fabio Fantoni wrote:
> tools/libxl: Disable useless empty floppy drive with
>   qemu-xen
> 
> Signed-off-by: Fabio Fantoni <fabio.fantoni@heliman.it>
> ---
>   tools/libxl/libxl_dm.c |    3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> index 51f9914..c265618 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -406,6 +406,9 @@ static char ** 
> libxl__build_device_model_args_new(libxl__gc *gc,
>       if (b_info->type == LIBXL_DOMAIN_TYPE_HVM) {
>           int ioemu_nics = 0;
> 
> +        /* Disable useless empty floppy drive */
> +        flexarray_vappend(dm_args, "-global", "isa-fdc.driveA=", NULL);
> +
>           if (b_info->u.hvm.serial) {
>               flexarray_vappend(dm_args, "-serial", 
> b_info->u.hvm.serial, NULL);

I'm afraid this patch is whitespace corrupted. 

I strongly recommend that you investigate the use of git send-email.

Ian.

  parent reply	other threads:[~2013-02-15 12:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-05 16:15 [PATCH] tools/libxl: Disable useless empty floppy drive with qemu-xen Fabio Fantoni
2013-02-05 16:21 ` Ian Campbell
2013-02-08 12:39 ` Stefano Stabellini
2013-02-15 12:18 ` Ian Campbell [this message]
2013-02-15 13:14   ` Fabio Fantoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1360930691.31407.20.camel@zakaz.uk.xensource.com \
    --to=ian.campbell@citrix.com \
    --cc=Stefano.Stabellini@eu.citrix.com \
    --cc=fabio.fantoni@heliman.it \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.