Re: [PATCH] tools/libxl: Disable useless empty floppy drive with qemu-xen

From: Fabio Fantoni <fabio.fantoni@heliman.it>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: Re: [PATCH] tools/libxl: Disable useless empty floppy drive with qemu-xen
Date: Fri, 15 Feb 2013 14:14:16 +0100	[thread overview]
Message-ID: <511E34A8.9090706@heliman.it> (raw)
In-Reply-To: <1360930691.31407.20.camel@zakaz.uk.xensource.com>

Il 15/02/2013 13:18, Ian Campbell ha scritto:
> On Tue, 2013-02-05 at 16:15 +0000, Fabio Fantoni wrote:
>> tools/libxl: Disable useless empty floppy drive with
>>    qemu-xen
>>
>> Signed-off-by: Fabio Fantoni <fabio.fantoni@heliman.it>
>> ---
>>    tools/libxl/libxl_dm.c |    3 +++
>>    1 file changed, 3 insertions(+)
>>
>> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
>> index 51f9914..c265618 100644
>> --- a/tools/libxl/libxl_dm.c
>> +++ b/tools/libxl/libxl_dm.c
>> @@ -406,6 +406,9 @@ static char **
>> libxl__build_device_model_args_new(libxl__gc *gc,
>>        if (b_info->type == LIBXL_DOMAIN_TYPE_HVM) {
>>            int ioemu_nics = 0;
>>
>> +        /* Disable useless empty floppy drive */
>> +        flexarray_vappend(dm_args, "-global", "isa-fdc.driveA=", NULL);
>> +
>>            if (b_info->u.hvm.serial) {
>>                flexarray_vappend(dm_args, "-serial",
>> b_info->u.hvm.serial, NULL);
> I'm afraid this patch is whitespace corrupted.
>
> I strongly recommend that you investigate the use of git send-email.
>
> Ian.
>
I already resent with git send-email:
http://lists.xen.org/archives/html/xen-devel/2013-02/msg00391.html