[PATCH] cooker: now that we use a Pool, raise the exceptions

[PATCH] cooker: now that we use a Pool, raise the exceptions

[Christopher Larson]

From: Christopher Larson <chris_larson@mentor.com>

Multiprocessing catches these and handles passing them between processes
itself, we don't need to do it ourselves anymore.

[YOCTO #3926]

Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
 bitbake/lib/bb/cooker.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bitbake/lib/bb/cooker.py b/bitbake/lib/bb/cooker.py
index 9f7121f..1b84e86 100644
--- a/bitbake/lib/bb/cooker.py
+++ b/bitbake/lib/bb/cooker.py
@@ -1563,12 +1563,12 @@ def parse_file((filename, appends, caches_array)):
         tb = sys.exc_info()[2]
         exc.recipe = filename
         exc.traceback = list(bb.exceptions.extract_traceback(tb, context=3))
-        return True, exc
+        raise
     # Need to turn BaseExceptions into Exceptions here so we gracefully shutdown
     # and for example a worker thread doesn't just exit on its own in response to
     # a SystemExit event for example.
     except BaseException as exc:
-        return True, ParsingFailure(exc, filename)
+        raise ParsingFailure(exc, filename)
 
 class CookerParser(object):
     def __init__(self, cooker, filelist, masked):
-- 
1.8.1.1

Re: [PATCH] cooker: now that we use a Pool, raise the exceptions

[Richard Purdie]

On Mon, 2013-02-25 at 11:48 -0700, Christopher Larson wrote:
> From: Christopher Larson <chris_larson@mentor.com>
> 
> Multiprocessing catches these and handles passing them between processes
> itself, we don't need to do it ourselves anymore.
> 
> [YOCTO #3926]
> 
> Signed-off-by: Christopher Larson <chris_larson@mentor.com>
> ---
>  bitbake/lib/bb/cooker.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Makes sense, thanks (and merged)!

Richard