* [PATCH V2] systemd: set the location of the kill binary
@ 2013-02-26 17:53 Ross Burton
2013-02-26 19:52 ` Otavio Salvador
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Ross Burton @ 2013-02-26 17:53 UTC (permalink / raw)
To: openembedded-core
Otherwise systemd uses AC_PROG_PATH and finds it in the sysroot, which won't
work on the target.
Signed-off-by: Ross Burton <ross.burton@intel.com>
---
meta/recipes-core/systemd/systemd_197.bb | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/recipes-core/systemd/systemd_197.bb b/meta/recipes-core/systemd/systemd_197.bb
index c765c18..001d111 100644
--- a/meta/recipes-core/systemd/systemd_197.bb
+++ b/meta/recipes-core/systemd/systemd_197.bb
@@ -63,6 +63,7 @@ EXTRA_OECONF = " --with-rootprefix=${base_prefix} \
--disable-microhttpd \
--without-python \
--with-sysvrcnd-path=${sysconfdir} \
+ ac_cv_path_KILL=/bin/kill \
"
# uclibc does not have NSS
EXTRA_OECONF_append_libc-uclibc = " --disable-myhostname "
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH V2] systemd: set the location of the kill binary
2013-02-26 17:53 [PATCH V2] systemd: set the location of the kill binary Ross Burton
@ 2013-02-26 19:52 ` Otavio Salvador
2013-02-26 19:53 ` Otavio Salvador
2013-02-26 19:54 ` Koen Kooi
2013-02-26 20:00 ` Koen Kooi
2 siblings, 1 reply; 7+ messages in thread
From: Otavio Salvador @ 2013-02-26 19:52 UTC (permalink / raw)
To: Ross Burton; +Cc: Patches and discussions about the oe-core layer
On Tue, Feb 26, 2013 at 2:53 PM, Ross Burton <ross.burton@intel.com> wrote:
> Otherwise systemd uses AC_PROG_PATH and finds it in the sysroot, which won't
> work on the target.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
Acked-by: Otavio Salvador <otavio@ossystems.com.br>
--
Otavio Salvador O.S. Systems
E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH V2] systemd: set the location of the kill binary
2013-02-26 19:52 ` Otavio Salvador
@ 2013-02-26 19:53 ` Otavio Salvador
2013-02-26 20:05 ` Phil Blundell
0 siblings, 1 reply; 7+ messages in thread
From: Otavio Salvador @ 2013-02-26 19:53 UTC (permalink / raw)
To: Ross Burton; +Cc: Patches and discussions about the oe-core layer
On Tue, Feb 26, 2013 at 4:52 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> On Tue, Feb 26, 2013 at 2:53 PM, Ross Burton <ross.burton@intel.com> wrote:
>> Otherwise systemd uses AC_PROG_PATH and finds it in the sysroot, which won't
>> work on the target.
>>
>> Signed-off-by: Ross Burton <ross.burton@intel.com>
>
> Acked-by: Otavio Salvador <otavio@ossystems.com.br>
Now I saw the Khem suggestion to use /usr/bin/env kill; seems good.
--
Otavio Salvador O.S. Systems
E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH V2] systemd: set the location of the kill binary
2013-02-26 17:53 [PATCH V2] systemd: set the location of the kill binary Ross Burton
2013-02-26 19:52 ` Otavio Salvador
@ 2013-02-26 19:54 ` Koen Kooi
2013-02-26 20:00 ` Koen Kooi
2 siblings, 0 replies; 7+ messages in thread
From: Koen Kooi @ 2013-02-26 19:54 UTC (permalink / raw)
To: Ross Burton; +Cc: openembedded-core
On Tue, 2013-02-26 at 17:53 +0000, Ross Burton wrote:
> Otherwise systemd uses AC_PROG_PATH and finds it in the sysroot, which won't
> work on the target.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
> meta/recipes-core/systemd/systemd_197.bb | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-core/systemd/systemd_197.bb b/meta/recipes-core/systemd/systemd_197.bb
> index c765c18..001d111 100644
> --- a/meta/recipes-core/systemd/systemd_197.bb
> +++ b/meta/recipes-core/systemd/systemd_197.bb
> @@ -63,6 +63,7 @@ EXTRA_OECONF = " --with-rootprefix=${base_prefix} \
> --disable-microhttpd \
> --without-python \
> --with-sysvrcnd-path=${sysconfdir} \
> + ac_cv_path_KILL=/bin/kill \
${base_bindir} ?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH V2] systemd: set the location of the kill binary
2013-02-26 17:53 [PATCH V2] systemd: set the location of the kill binary Ross Burton
2013-02-26 19:52 ` Otavio Salvador
2013-02-26 19:54 ` Koen Kooi
@ 2013-02-26 20:00 ` Koen Kooi
2013-02-27 14:02 ` Burton, Ross
2 siblings, 1 reply; 7+ messages in thread
From: Koen Kooi @ 2013-02-26 20:00 UTC (permalink / raw)
To: Ross Burton; +Cc: openembedded-core
On Tue, 2013-02-26 at 17:53 +0000, Ross Burton wrote:
> Otherwise systemd uses AC_PROG_PATH and finds it in the sysroot, which won't
> work on the target.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
> meta/recipes-core/systemd/systemd_197.bb | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-core/systemd/systemd_197.bb b/meta/recipes-core/systemd/systemd_197.bb
> index c765c18..001d111 100644
> --- a/meta/recipes-core/systemd/systemd_197.bb
> +++ b/meta/recipes-core/systemd/systemd_197.bb
> @@ -63,6 +63,7 @@ EXTRA_OECONF = " --with-rootprefix=${base_prefix} \
> --disable-microhttpd \
> --without-python \
> --with-sysvrcnd-path=${sysconfdir} \
> + ac_cv_path_KILL=/bin/kill \
Like V1 this hardcodes ${base_bindir} to /bin, this breaks when your
DISTRO sets $base_prefix to /usr. So please change that to:
ac_cv_path+KILL=${base_bindir}/kill
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH V2] systemd: set the location of the kill binary
2013-02-26 19:53 ` Otavio Salvador
@ 2013-02-26 20:05 ` Phil Blundell
0 siblings, 0 replies; 7+ messages in thread
From: Phil Blundell @ 2013-02-26 20:05 UTC (permalink / raw)
To: Otavio Salvador; +Cc: oe-core layer, Patches
On Tue, 2013-02-26 at 16:53 -0300, Otavio Salvador wrote:
> On Tue, Feb 26, 2013 at 4:52 PM, Otavio Salvador
> <otavio@ossystems.com.br> wrote:
> > On Tue, Feb 26, 2013 at 2:53 PM, Ross Burton <ross.burton@intel.com> wrote:
> >> Otherwise systemd uses AC_PROG_PATH and finds it in the sysroot, which won't
> >> work on the target.
> >>
> >> Signed-off-by: Ross Burton <ross.burton@intel.com>
> >
> > Acked-by: Otavio Salvador <otavio@ossystems.com.br>
>
> Now I saw the Khem suggestion to use /usr/bin/env kill; seems good.
If it wants a target path then "/usr/bin/env kill" would fail for
targets that either don't have /usr or don't have "env" installed. That
might not be so good.
/usr/bin/env would be fine if we were talking about a build host path
but that doesn't appear to be the case here.
p.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH V2] systemd: set the location of the kill binary
2013-02-26 20:00 ` Koen Kooi
@ 2013-02-27 14:02 ` Burton, Ross
0 siblings, 0 replies; 7+ messages in thread
From: Burton, Ross @ 2013-02-27 14:02 UTC (permalink / raw)
To: Koen Kooi; +Cc: openembedded-core
On 26 February 2013 20:00, Koen Kooi <koen@dominion.thruhere.net> wrote:
> Like V1 this hardcodes ${base_bindir} to /bin, this breaks when your
> DISTRO sets $base_prefix to /usr. So please change that to:
>
> ac_cv_path+KILL=${base_bindir}/kill
Yeah, not sure why I did that. :/ V2 coming shortly.
Ross
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-02-27 14:18 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-26 17:53 [PATCH V2] systemd: set the location of the kill binary Ross Burton
2013-02-26 19:52 ` Otavio Salvador
2013-02-26 19:53 ` Otavio Salvador
2013-02-26 20:05 ` Phil Blundell
2013-02-26 19:54 ` Koen Kooi
2013-02-26 20:00 ` Koen Kooi
2013-02-27 14:02 ` Burton, Ross
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.