* [PATCH] [media] s5p-mfc: Fix frame skip bug
@ 2013-02-26 22:02 Arun Kumar K
2013-02-27 11:32 ` Kamil Debski
0 siblings, 1 reply; 2+ messages in thread
From: Arun Kumar K @ 2013-02-26 22:02 UTC (permalink / raw)
To: linux-media; +Cc: k.debski, jtp.park, s.nawrocki, arun.kk, arun.m
The issue was seen in VP8 decoding where the last frame was
skipped by the driver. This patch gets the correct frame_type value
to fix this bug.
Signed-off-by: Arun Kumar K <arun.kk@samsung.com>
Signed-off-by: Arun Mankuzhi <arun.m@samsung.com>
---
drivers/media/platform/s5p-mfc/s5p_mfc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c
index ac69e9b..64c55cf 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c
@@ -276,7 +276,7 @@ static void s5p_mfc_handle_frame_new(struct s5p_mfc_ctx *ctx, unsigned int err)
unsigned int frame_type;
dspl_y_addr = s5p_mfc_hw_call(dev->mfc_ops, get_dspl_y_adr, dev);
- frame_type = s5p_mfc_hw_call(dev->mfc_ops, get_dec_frame_type, dev);
+ frame_type = s5p_mfc_hw_call(dev->mfc_ops, get_disp_frame_type, ctx);
/* If frame is same as previous then skip and do not dequeue */
if (frame_type == S5P_FIMV_DECODE_FRAME_SKIPPED) {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] [media] s5p-mfc: Fix frame skip bug
2013-02-26 22:02 [PATCH] [media] s5p-mfc: Fix frame skip bug Arun Kumar K
@ 2013-02-27 11:32 ` Kamil Debski
0 siblings, 0 replies; 2+ messages in thread
From: Kamil Debski @ 2013-02-27 11:32 UTC (permalink / raw)
To: 'Arun Kumar K', linux-media; +Cc: jtp.park, Sylwester Nawrocki, arun.m
Hi Arun,
Thank you for your patch.
Best wishes,
--
Kamil Debski
Linux Platform Group
Samsung Poland R&D Center
> -----Original Message-----
> From: Arun Kumar K [mailto:arun.kk@samsung.com]
> Sent: Tuesday, February 26, 2013 11:02 PM
> To: linux-media@vger.kernel.org
> Cc: k.debski@samsung.com; jtp.park@samsung.com; s.nawrocki@samsung.com;
> arun.kk@samsung.com; arun.m@samsung.com
> Subject: [PATCH] [media] s5p-mfc: Fix frame skip bug
>
> The issue was seen in VP8 decoding where the last frame was skipped by
> the driver. This patch gets the correct frame_type value to fix this
> bug.
>
> Signed-off-by: Arun Kumar K <arun.kk@samsung.com>
> Signed-off-by: Arun Mankuzhi <arun.m@samsung.com>
Acked-by: Kamil Debski <k.debski@samsung.com>
> ---
> drivers/media/platform/s5p-mfc/s5p_mfc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c
> b/drivers/media/platform/s5p-mfc/s5p_mfc.c
> index ac69e9b..64c55cf 100644
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c
> @@ -276,7 +276,7 @@ static void s5p_mfc_handle_frame_new(struct
> s5p_mfc_ctx *ctx, unsigned int err)
> unsigned int frame_type;
>
> dspl_y_addr = s5p_mfc_hw_call(dev->mfc_ops, get_dspl_y_adr, dev);
> - frame_type = s5p_mfc_hw_call(dev->mfc_ops, get_dec_frame_type,
> dev);
> + frame_type = s5p_mfc_hw_call(dev->mfc_ops, get_disp_frame_type,
> ctx);
>
> /* If frame is same as previous then skip and do not dequeue */
> if (frame_type == S5P_FIMV_DECODE_FRAME_SKIPPED) {
> --
> 1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-27 11:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-26 22:02 [PATCH] [media] s5p-mfc: Fix frame skip bug Arun Kumar K
2013-02-27 11:32 ` Kamil Debski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.