All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] sp5100_tco: Fix the AcpiMmioSel bitmask value
@ 2013-03-03  5:48 Takahisa Tanaka
  2013-03-03  9:10 ` [PATCH v2] sp5100_tco: Set the AcpiMmioSel bitmask value to 1 instead of 2 Paul Menzel
  0 siblings, 1 reply; 4+ messages in thread
From: Takahisa Tanaka @ 2013-03-03  5:48 UTC (permalink / raw)
  To: linux-watchdog
  Cc: Wim Van Sebroeck, Paul Menzel, Arkadiusz Miskiewicz,
	Bjorn Helgaas, Andrew Morton, Jonathan Nieder, linux-kernel,
	Florian Mickler, Joseph Salisbury, Joseph Salisbury,
	Takahisa Tanaka

The AcpiMmioSel bit is the bit1 in AcpiMmioEn register, but, current
sp5100_tco driver was using bit2.

The sp5100_tco driver expects zero as a value of AcpiMmioSel (bit1).
fortunately, The problem didn't occur by this typo, because the default
value of misused bit2 is zero. However, the sp5100_tco driver should use
the correct bitmask value.

Signed-off-by: Takahisa Tanaka <mc74hc00@gmail.com>
---
 drivers/watchdog/sp5100_tco.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/sp5100_tco.h b/drivers/watchdog/sp5100_tco.h
index 71594a0..2b28c00 100644
--- a/drivers/watchdog/sp5100_tco.h
+++ b/drivers/watchdog/sp5100_tco.h
@@ -57,7 +57,7 @@
 #define SB800_PM_WATCHDOG_DISABLE	(1 << 2)
 #define SB800_PM_WATCHDOG_SECOND_RES	(3 << 0)
 #define SB800_ACPI_MMIO_DECODE_EN	(1 << 0)
-#define SB800_ACPI_MMIO_SEL		(1 << 2)
+#define SB800_ACPI_MMIO_SEL		(1 << 1)
 
 
 #define SB800_PM_WDT_MMIO_OFFSET	0xB00
-- 
1.8.1.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH v2] sp5100_tco: Set the AcpiMmioSel bitmask value to 1 instead of 2
  2013-03-03  5:48 [PATCH] sp5100_tco: Fix the AcpiMmioSel bitmask value Takahisa Tanaka
@ 2013-03-03  9:10 ` Paul Menzel
  2013-03-07 12:17     ` Tanaka Takahisa
  0 siblings, 1 reply; 4+ messages in thread
From: Paul Menzel @ 2013-03-03  9:10 UTC (permalink / raw)
  To: Takahisa Tanaka
  Cc: linux-watchdog, Wim Van Sebroeck, Arkadiusz Miskiewicz,
	Bjorn Helgaas, Andrew Morton, Jonathan Nieder, linux-kernel,
	Florian Mickler, Joseph Salisbury, Joseph Salisbury

[-- Attachment #1: Type: text/plain, Size: 1847 bytes --]

From: Takahisa Tanaka <mc74hc00@gmail.com>
Date: Sun, 3 Mar 2013 14:48:00 +0900

The AcpiMmioSel bit is bit 1 in the AcpiMmioEn register, but the current
sp5100_tco driver is using bit 2.

See 2.3.3 Power Management (PM) Registers page 150 of the
AMD SB800-Series Southbridges Register Reference Guide [1].

        AcpiMmioEn - RW – 8/16/32 bits - [PM_Reg: 24h]
        Field Name        Bits  Default  Description
        AcpiMMioDecodeEn  0     0b       Set to 1 to enable AcpiMMio space.
        AcpiMMIoSel       1     0b       Set AcpiMMio registers to be memory-mapped or IO-mapped space.
                                         0: Memory-mapped space
                                         1: I/O-mapped space

The sp5100_tco driver expects zero as a value of AcpiMmioSel (bit 1).

Fortunately, no problems were caused by this typo, because the default
value of the undocumented misused bit 2 seems to be zero.

However, the sp5100_tco driver should use the correct bitmask value.

[1] http://support.amd.com/us/Embedded_TechDocs/45482.pdf

Signed-off-by: Takahisa Tanaka <mc74hc00@gmail.com>
CC: stable@vger.kernel.org
Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
---
v2: Hopefully improved the commit message.

 drivers/watchdog/sp5100_tco.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/sp5100_tco.h b/drivers/watchdog/sp5100_tco.h
index 71594a0..2b28c00 100644
--- a/drivers/watchdog/sp5100_tco.h
+++ b/drivers/watchdog/sp5100_tco.h
@@ -57,7 +57,7 @@
 #define SB800_PM_WATCHDOG_DISABLE	(1 << 2)
 #define SB800_PM_WATCHDOG_SECOND_RES	(3 << 0)
 #define SB800_ACPI_MMIO_DECODE_EN	(1 << 0)
-#define SB800_ACPI_MMIO_SEL		(1 << 2)
+#define SB800_ACPI_MMIO_SEL		(1 << 1)
 
 
 #define SB800_PM_WDT_MMIO_OFFSET	0xB00
-- 
1.7.10.4

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] sp5100_tco: Set the AcpiMmioSel bitmask value to 1 instead of 2
  2013-03-03  9:10 ` [PATCH v2] sp5100_tco: Set the AcpiMmioSel bitmask value to 1 instead of 2 Paul Menzel
@ 2013-03-07 12:17     ` Tanaka Takahisa
  0 siblings, 0 replies; 4+ messages in thread
From: Tanaka Takahisa @ 2013-03-07 12:17 UTC (permalink / raw)
  To: Paul Menzel
  Cc: linux-watchdog, Wim Van Sebroeck, Arkadiusz Miskiewicz,
	Bjorn Helgaas, Andrew Morton, Jonathan Nieder, linux-kernel,
	Florian Mickler, Joseph Salisbury, Joseph Salisbury

Hi Paul,

2013/3/3 Paul Menzel <paulepanter@users.sourceforge.net>:
> From: Takahisa Tanaka <mc74hc00@gmail.com>
> Date: Sun, 3 Mar 2013 14:48:00 +0900
>
> The AcpiMmioSel bit is bit 1 in the AcpiMmioEn register, but the current
> sp5100_tco driver is using bit 2.
>
> See 2.3.3 Power Management (PM) Registers page 150 of the
> AMD SB800-Series Southbridges Register Reference Guide [1].
>
>         AcpiMmioEn - RW – 8/16/32 bits - [PM_Reg: 24h]
>         Field Name        Bits  Default  Description
>         AcpiMMioDecodeEn  0     0b       Set to 1 to enable AcpiMMio space.
>         AcpiMMIoSel       1     0b       Set AcpiMMio registers to be memory-mapped or IO-mapped space.
>                                          0: Memory-mapped space
>                                          1: I/O-mapped space
>
> The sp5100_tco driver expects zero as a value of AcpiMmioSel (bit 1).
>
> Fortunately, no problems were caused by this typo, because the default
> value of the undocumented misused bit 2 seems to be zero.
>
> However, the sp5100_tco driver should use the correct bitmask value.
>
> [1] http://support.amd.com/us/Embedded_TechDocs/45482.pdf
>
> Signed-off-by: Takahisa Tanaka <mc74hc00@gmail.com>
> CC: stable@vger.kernel.org
> Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
> ---
> v2: Hopefully improved the commit message.
>
>  drivers/watchdog/sp5100_tco.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/sp5100_tco.h b/drivers/watchdog/sp5100_tco.h
> index 71594a0..2b28c00 100644
> --- a/drivers/watchdog/sp5100_tco.h
> +++ b/drivers/watchdog/sp5100_tco.h
> @@ -57,7 +57,7 @@
>  #define SB800_PM_WATCHDOG_DISABLE      (1 << 2)
>  #define SB800_PM_WATCHDOG_SECOND_RES   (3 << 0)
>  #define SB800_ACPI_MMIO_DECODE_EN      (1 << 0)
> -#define SB800_ACPI_MMIO_SEL            (1 << 2)
> +#define SB800_ACPI_MMIO_SEL            (1 << 1)
>
>
>  #define SB800_PM_WDT_MMIO_OFFSET       0xB00
> --
> 1.7.10.4

I'm sorry for late reply.
Thank you for improving the commit log.


Regards,
Takahisa

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] sp5100_tco: Set the AcpiMmioSel bitmask value to 1 instead of 2
@ 2013-03-07 12:17     ` Tanaka Takahisa
  0 siblings, 0 replies; 4+ messages in thread
From: Tanaka Takahisa @ 2013-03-07 12:17 UTC (permalink / raw)
  To: Paul Menzel
  Cc: linux-watchdog, Wim Van Sebroeck, Arkadiusz Miskiewicz,
	Bjorn Helgaas, Andrew Morton, Jonathan Nieder, linux-kernel,
	Florian Mickler, Joseph Salisbury, Joseph Salisbury

Hi Paul,

2013/3/3 Paul Menzel <paulepanter@users.sourceforge.net>:
> From: Takahisa Tanaka <mc74hc00@gmail.com>
> Date: Sun, 3 Mar 2013 14:48:00 +0900
>
> The AcpiMmioSel bit is bit 1 in the AcpiMmioEn register, but the current
> sp5100_tco driver is using bit 2.
>
> See 2.3.3 Power Management (PM) Registers page 150 of the
> AMD SB800-Series Southbridges Register Reference Guide [1].
>
>         AcpiMmioEn - RW – 8/16/32 bits - [PM_Reg: 24h]
>         Field Name        Bits  Default  Description
>         AcpiMMioDecodeEn  0     0b       Set to 1 to enable AcpiMMio space.
>         AcpiMMIoSel       1     0b       Set AcpiMMio registers to be memory-mapped or IO-mapped space.
>                                          0: Memory-mapped space
>                                          1: I/O-mapped space
>
> The sp5100_tco driver expects zero as a value of AcpiMmioSel (bit 1).
>
> Fortunately, no problems were caused by this typo, because the default
> value of the undocumented misused bit 2 seems to be zero.
>
> However, the sp5100_tco driver should use the correct bitmask value.
>
> [1] http://support.amd.com/us/Embedded_TechDocs/45482.pdf
>
> Signed-off-by: Takahisa Tanaka <mc74hc00@gmail.com>
> CC: stable@vger.kernel.org
> Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
> ---
> v2: Hopefully improved the commit message.
>
>  drivers/watchdog/sp5100_tco.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/sp5100_tco.h b/drivers/watchdog/sp5100_tco.h
> index 71594a0..2b28c00 100644
> --- a/drivers/watchdog/sp5100_tco.h
> +++ b/drivers/watchdog/sp5100_tco.h
> @@ -57,7 +57,7 @@
>  #define SB800_PM_WATCHDOG_DISABLE      (1 << 2)
>  #define SB800_PM_WATCHDOG_SECOND_RES   (3 << 0)
>  #define SB800_ACPI_MMIO_DECODE_EN      (1 << 0)
> -#define SB800_ACPI_MMIO_SEL            (1 << 2)
> +#define SB800_ACPI_MMIO_SEL            (1 << 1)
>
>
>  #define SB800_PM_WDT_MMIO_OFFSET       0xB00
> --
> 1.7.10.4

I'm sorry for late reply.
Thank you for improving the commit log.


Regards,
Takahisa
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-03-07 12:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-03  5:48 [PATCH] sp5100_tco: Fix the AcpiMmioSel bitmask value Takahisa Tanaka
2013-03-03  9:10 ` [PATCH v2] sp5100_tco: Set the AcpiMmioSel bitmask value to 1 instead of 2 Paul Menzel
2013-03-07 12:17   ` Tanaka Takahisa
2013-03-07 12:17     ` Tanaka Takahisa

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.