* [PATCH] ARM: perf: Fix section mismatch on armpmu_init()
@ 2013-03-04 23:15 ` Stephen Boyd
0 siblings, 0 replies; 8+ messages in thread
From: Stephen Boyd @ 2013-03-04 23:15 UTC (permalink / raw)
To: Will Deacon; +Cc: linux-kernel, linux-arm-msm, linux-arm-kernel
WARNING: vmlinux.o(.text+0xfb80): Section mismatch in reference
from the function armpmu_register() to the function
.init.text:armpmu_init()
The function armpmu_register() references
the function __init armpmu_init().
This is often because armpmu_register lacks a __init
annotation or the annotation of armpmu_init is wrong.
Just drop the __init marking on armpmu_init() because
armpmu_register() no longer has an __init marking.
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
I doubt anyone is actually experiencing any problems because this
driver probes before kernel init is over. But the warning is a bit
annoying.
arch/arm/kernel/perf_event.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/kernel/perf_event.c b/arch/arm/kernel/perf_event.c
index 31e0eb3..32081ad 100644
--- a/arch/arm/kernel/perf_event.c
+++ b/arch/arm/kernel/perf_event.c
@@ -484,7 +484,7 @@ const struct dev_pm_ops armpmu_dev_pm_ops = {
SET_RUNTIME_PM_OPS(armpmu_runtime_suspend, armpmu_runtime_resume, NULL)
};
-static void __init armpmu_init(struct arm_pmu *armpmu)
+static void armpmu_init(struct arm_pmu *armpmu)
{
atomic_set(&armpmu->active_events, 0);
mutex_init(&armpmu->reserve_mutex);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] ARM: perf: Fix section mismatch on armpmu_init()
@ 2013-03-04 23:15 ` Stephen Boyd
0 siblings, 0 replies; 8+ messages in thread
From: Stephen Boyd @ 2013-03-04 23:15 UTC (permalink / raw)
To: linux-arm-kernel
WARNING: vmlinux.o(.text+0xfb80): Section mismatch in reference
from the function armpmu_register() to the function
.init.text:armpmu_init()
The function armpmu_register() references
the function __init armpmu_init().
This is often because armpmu_register lacks a __init
annotation or the annotation of armpmu_init is wrong.
Just drop the __init marking on armpmu_init() because
armpmu_register() no longer has an __init marking.
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
I doubt anyone is actually experiencing any problems because this
driver probes before kernel init is over. But the warning is a bit
annoying.
arch/arm/kernel/perf_event.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/kernel/perf_event.c b/arch/arm/kernel/perf_event.c
index 31e0eb3..32081ad 100644
--- a/arch/arm/kernel/perf_event.c
+++ b/arch/arm/kernel/perf_event.c
@@ -484,7 +484,7 @@ const struct dev_pm_ops armpmu_dev_pm_ops = {
SET_RUNTIME_PM_OPS(armpmu_runtime_suspend, armpmu_runtime_resume, NULL)
};
-static void __init armpmu_init(struct arm_pmu *armpmu)
+static void armpmu_init(struct arm_pmu *armpmu)
{
atomic_set(&armpmu->active_events, 0);
mutex_init(&armpmu->reserve_mutex);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: perf: Fix section mismatch on armpmu_init()
2013-03-04 23:15 ` Stephen Boyd
(?)
@ 2013-03-05 2:43 ` Will Deacon
-1 siblings, 0 replies; 8+ messages in thread
From: Will Deacon @ 2013-03-05 2:43 UTC (permalink / raw)
To: Stephen Boyd; +Cc: linux-kernel, linux-arm-msm, linux-arm-kernel
On Mon, Mar 04, 2013 at 11:15:37PM +0000, Stephen Boyd wrote:
> WARNING: vmlinux.o(.text+0xfb80): Section mismatch in reference
> from the function armpmu_register() to the function
> .init.text:armpmu_init()
> The function armpmu_register() references
> the function __init armpmu_init().
> This is often because armpmu_register lacks a __init
> annotation or the annotation of armpmu_init is wrong.
>
> Just drop the __init marking on armpmu_init() because
> armpmu_register() no longer has an __init marking.
>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Cheers Stephen:
Acked-by: Will Deacon <will.deacon@arm.com>
Can you put this into the patch system please?
Will
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: perf: Fix section mismatch on armpmu_init()
@ 2013-03-05 2:43 ` Will Deacon
0 siblings, 0 replies; 8+ messages in thread
From: Will Deacon @ 2013-03-05 2:43 UTC (permalink / raw)
To: Stephen Boyd; +Cc: linux-kernel, linux-arm-msm, linux-arm-kernel
On Mon, Mar 04, 2013 at 11:15:37PM +0000, Stephen Boyd wrote:
> WARNING: vmlinux.o(.text+0xfb80): Section mismatch in reference
> from the function armpmu_register() to the function
> .init.text:armpmu_init()
> The function armpmu_register() references
> the function __init armpmu_init().
> This is often because armpmu_register lacks a __init
> annotation or the annotation of armpmu_init is wrong.
>
> Just drop the __init marking on armpmu_init() because
> armpmu_register() no longer has an __init marking.
>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Cheers Stephen:
Acked-by: Will Deacon <will.deacon@arm.com>
Can you put this into the patch system please?
Will
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: perf: Fix section mismatch on armpmu_init()
@ 2013-03-05 2:43 ` Will Deacon
0 siblings, 0 replies; 8+ messages in thread
From: Will Deacon @ 2013-03-05 2:43 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Mar 04, 2013 at 11:15:37PM +0000, Stephen Boyd wrote:
> WARNING: vmlinux.o(.text+0xfb80): Section mismatch in reference
> from the function armpmu_register() to the function
> .init.text:armpmu_init()
> The function armpmu_register() references
> the function __init armpmu_init().
> This is often because armpmu_register lacks a __init
> annotation or the annotation of armpmu_init is wrong.
>
> Just drop the __init marking on armpmu_init() because
> armpmu_register() no longer has an __init marking.
>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Cheers Stephen:
Acked-by: Will Deacon <will.deacon@arm.com>
Can you put this into the patch system please?
Will
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: perf: Fix section mismatch on armpmu_init()
2013-03-05 2:43 ` Will Deacon
(?)
@ 2013-03-05 2:55 ` Stephen Boyd
-1 siblings, 0 replies; 8+ messages in thread
From: Stephen Boyd @ 2013-03-05 2:55 UTC (permalink / raw)
To: Will Deacon; +Cc: linux-kernel, linux-arm-msm, linux-arm-kernel
On 03/04/13 18:43, Will Deacon wrote:
> On Mon, Mar 04, 2013 at 11:15:37PM +0000, Stephen Boyd wrote:
>> WARNING: vmlinux.o(.text+0xfb80): Section mismatch in reference
>> from the function armpmu_register() to the function
>> .init.text:armpmu_init()
>> The function armpmu_register() references
>> the function __init armpmu_init().
>> This is often because armpmu_register lacks a __init
>> annotation or the annotation of armpmu_init is wrong.
>>
>> Just drop the __init marking on armpmu_init() because
>> armpmu_register() no longer has an __init marking.
>>
>> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> Cheers Stephen:
>
> Acked-by: Will Deacon <will.deacon@arm.com>
>
> Can you put this into the patch system please?
>
>
Thanks. 7667/1
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: perf: Fix section mismatch on armpmu_init()
@ 2013-03-05 2:55 ` Stephen Boyd
0 siblings, 0 replies; 8+ messages in thread
From: Stephen Boyd @ 2013-03-05 2:55 UTC (permalink / raw)
To: Will Deacon; +Cc: linux-kernel, linux-arm-msm, linux-arm-kernel
On 03/04/13 18:43, Will Deacon wrote:
> On Mon, Mar 04, 2013 at 11:15:37PM +0000, Stephen Boyd wrote:
>> WARNING: vmlinux.o(.text+0xfb80): Section mismatch in reference
>> from the function armpmu_register() to the function
>> .init.text:armpmu_init()
>> The function armpmu_register() references
>> the function __init armpmu_init().
>> This is often because armpmu_register lacks a __init
>> annotation or the annotation of armpmu_init is wrong.
>>
>> Just drop the __init marking on armpmu_init() because
>> armpmu_register() no longer has an __init marking.
>>
>> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> Cheers Stephen:
>
> Acked-by: Will Deacon <will.deacon@arm.com>
>
> Can you put this into the patch system please?
>
>
Thanks. 7667/1
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: perf: Fix section mismatch on armpmu_init()
@ 2013-03-05 2:55 ` Stephen Boyd
0 siblings, 0 replies; 8+ messages in thread
From: Stephen Boyd @ 2013-03-05 2:55 UTC (permalink / raw)
To: linux-arm-kernel
On 03/04/13 18:43, Will Deacon wrote:
> On Mon, Mar 04, 2013 at 11:15:37PM +0000, Stephen Boyd wrote:
>> WARNING: vmlinux.o(.text+0xfb80): Section mismatch in reference
>> from the function armpmu_register() to the function
>> .init.text:armpmu_init()
>> The function armpmu_register() references
>> the function __init armpmu_init().
>> This is often because armpmu_register lacks a __init
>> annotation or the annotation of armpmu_init is wrong.
>>
>> Just drop the __init marking on armpmu_init() because
>> armpmu_register() no longer has an __init marking.
>>
>> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> Cheers Stephen:
>
> Acked-by: Will Deacon <will.deacon@arm.com>
>
> Can you put this into the patch system please?
>
>
Thanks. 7667/1
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-03-05 2:55 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-04 23:15 [PATCH] ARM: perf: Fix section mismatch on armpmu_init() Stephen Boyd
2013-03-04 23:15 ` Stephen Boyd
2013-03-05 2:43 ` Will Deacon
2013-03-05 2:43 ` Will Deacon
2013-03-05 2:43 ` Will Deacon
2013-03-05 2:55 ` Stephen Boyd
2013-03-05 2:55 ` Stephen Boyd
2013-03-05 2:55 ` Stephen Boyd
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.