[PATCH v1] tty: ipwireless: Remove redundant NULL check before kfree

[PATCH v1] tty: ipwireless: Remove redundant NULL check before kfree

[syamsidhardh]

From: Syam Sidhardhan <s.syam@samsung.com>

kfree on NULL pointer is a no-op.

Signed-off-by: Syam Sidhardhan <s.syam@samsung.com>
---
v1 -> Corrected the from address.

 drivers/tty/ipwireless/hardware.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/tty/ipwireless/hardware.c b/drivers/tty/ipwireless/hardware.c
index 97a511f..2c14842 100644
--- a/drivers/tty/ipwireless/hardware.c
+++ b/drivers/tty/ipwireless/hardware.c
@@ -1732,8 +1732,7 @@ void ipwireless_hardware_free(struct ipw_hardware *hw)
 	flush_work(&hw->work_rx);
 
 	for (i = 0; i < NL_NUM_OF_ADDRESSES; i++)
-		if (hw->packet_assembler[i] != NULL)
-			kfree(hw->packet_assembler[i]);
+		kfree(hw->packet_assembler[i]);
 
 	for (i = 0; i < NL_NUM_OF_PRIORITIES; i++)
 		list_for_each_entry_safe(tp, tq, &hw->tx_queue[i], queue) {
-- 
1.7.9.5

Re: [PATCH v1] tty: ipwireless: Remove redundant NULL check before kfree

[Jiri Kosina]

On Thu, 7 Mar 2013, syamsidhardh@gmail.com wrote:

> From: Syam Sidhardhan <s.syam@samsung.com>
> 
> kfree on NULL pointer is a no-op.
> 
> Signed-off-by: Syam Sidhardhan <s.syam@samsung.com>

With my ipwireless maintainer hat on:

	Acked-by: Jiri Kosina <jkosina@suse.cz>

Greg, could you please take it through tty tree?

Thanks,

-- 
Jiri Kosina
SUSE Labs

Re: [PATCH v1] tty: ipwireless: Remove redundant NULL check before kfree

[Greg KH]

On Fri, Mar 08, 2013 at 02:26:43PM +0100, Jiri Kosina wrote:
> On Thu, 7 Mar 2013, syamsidhardh@gmail.com wrote:
> 
> > From: Syam Sidhardhan <s.syam@samsung.com>
> > 
> > kfree on NULL pointer is a no-op.
> > 
> > Signed-off-by: Syam Sidhardhan <s.syam@samsung.com>
> 
> With my ipwireless maintainer hat on:
> 
> 	Acked-by: Jiri Kosina <jkosina@suse.cz>
> 
> Greg, could you please take it through tty tree?

Ok, will do.

thanks,

greg k-h