* [PATCH] ARM: imx: fix typo "DEBUG_IMX50_IMX53_UART"
@ 2013-03-11 13:16 ` Paul Bolle
0 siblings, 0 replies; 18+ messages in thread
From: Paul Bolle @ 2013-03-11 13:16 UTC (permalink / raw)
To: Russell King; +Cc: Shawn Guo, linux-arm-kernel, linux-kernel
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) Tested by grepping the tree.
1) Typo was added in commit f8c95fe6d9adad72fc7bce90f4ab68d119f50c5b
("ARM: imx: support DEBUG_LL uart port selection for all i.MX SoCs").
Looking at that patch and at the tree makes clear that DEBUG_IMX53_UART
was intended here.
arch/arm/Kconfig.debug | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index acdddda..ecfcdba 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -492,7 +492,7 @@ config DEBUG_IMX_UART_PORT
DEBUG_IMX31_UART || \
DEBUG_IMX35_UART || \
DEBUG_IMX51_UART || \
- DEBUG_IMX50_IMX53_UART || \
+ DEBUG_IMX53_UART || \
DEBUG_IMX6Q_UART
default 1
help
--
1.7.11.7
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH] ARM: imx: fix typo "DEBUG_IMX50_IMX53_UART"
@ 2013-03-11 13:16 ` Paul Bolle
0 siblings, 0 replies; 18+ messages in thread
From: Paul Bolle @ 2013-03-11 13:16 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) Tested by grepping the tree.
1) Typo was added in commit f8c95fe6d9adad72fc7bce90f4ab68d119f50c5b
("ARM: imx: support DEBUG_LL uart port selection for all i.MX SoCs").
Looking at that patch and at the tree makes clear that DEBUG_IMX53_UART
was intended here.
arch/arm/Kconfig.debug | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index acdddda..ecfcdba 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -492,7 +492,7 @@ config DEBUG_IMX_UART_PORT
DEBUG_IMX31_UART || \
DEBUG_IMX35_UART || \
DEBUG_IMX51_UART || \
- DEBUG_IMX50_IMX53_UART || \
+ DEBUG_IMX53_UART || \
DEBUG_IMX6Q_UART
default 1
help
--
1.7.11.7
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH] ARM: imx: fix typo "DEBUG_IMX50_IMX53_UART"
2013-03-11 13:16 ` Paul Bolle
@ 2013-03-11 13:34 ` Sergei Shtylyov
-1 siblings, 0 replies; 18+ messages in thread
From: Sergei Shtylyov @ 2013-03-11 13:34 UTC (permalink / raw)
To: Paul Bolle; +Cc: Russell King, Shawn Guo, linux-kernel, linux-arm-kernel
Hello.
On 11-03-2013 17:16, Paul Bolle wrote:
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) Tested by grepping the tree.
> 1) Typo was added in commit f8c95fe6d9adad72fc7bce90f4ab68d119f50c5b
> ("ARM: imx: support DEBUG_LL uart port selection for all i.MX SoCs").
> Looking at that patch and at the tree makes clear that DEBUG_IMX53_UART
> was intended here.
Should probably be in the changelog instead.
WBR, Sergei
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] ARM: imx: fix typo "DEBUG_IMX50_IMX53_UART"
@ 2013-03-11 13:34 ` Sergei Shtylyov
0 siblings, 0 replies; 18+ messages in thread
From: Sergei Shtylyov @ 2013-03-11 13:34 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 11-03-2013 17:16, Paul Bolle wrote:
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) Tested by grepping the tree.
> 1) Typo was added in commit f8c95fe6d9adad72fc7bce90f4ab68d119f50c5b
> ("ARM: imx: support DEBUG_LL uart port selection for all i.MX SoCs").
> Looking at that patch and at the tree makes clear that DEBUG_IMX53_UART
> was intended here.
Should probably be in the changelog instead.
WBR, Sergei
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] ARM: imx: fix typo "DEBUG_IMX50_IMX53_UART"
2013-03-11 13:16 ` Paul Bolle
@ 2013-03-11 13:37 ` Shawn Guo
-1 siblings, 0 replies; 18+ messages in thread
From: Shawn Guo @ 2013-03-11 13:37 UTC (permalink / raw)
To: Paul Bolle; +Cc: Russell King, linux-arm-kernel, linux-kernel
Paul,
On Mon, Mar 11, 2013 at 02:16:00PM +0100, Paul Bolle wrote:
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) Tested by grepping the tree.
>
> 1) Typo was added in commit f8c95fe6d9adad72fc7bce90f4ab68d119f50c5b
> ("ARM: imx: support DEBUG_LL uart port selection for all i.MX SoCs").
> Looking at that patch and at the tree makes clear that DEBUG_IMX53_UART
> was intended here.
Thanks for the fixing. Above comment should really be in the commit
log. I just applied the patch as below.
Shawn
commit 0c52db7e681678f9b2a3fb96c3dd557168b4e025
Author: Paul Bolle <pebolle@tiscali.nl>
Date: Mon Mar 11 14:16:00 2013 +0100
ARM: imx: fix typo "DEBUG_IMX50_IMX53_UART"
Commit f8c95fe (ARM: imx: support DEBUG_LL uart port selection for all
i.MX SoCs) had a typo that DEBUG_IMX50_IMX53_UART should be
DEBUG_IMX53_UART.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] ARM: imx: fix typo "DEBUG_IMX50_IMX53_UART"
@ 2013-03-11 13:37 ` Shawn Guo
0 siblings, 0 replies; 18+ messages in thread
From: Shawn Guo @ 2013-03-11 13:37 UTC (permalink / raw)
To: linux-arm-kernel
Paul,
On Mon, Mar 11, 2013 at 02:16:00PM +0100, Paul Bolle wrote:
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) Tested by grepping the tree.
>
> 1) Typo was added in commit f8c95fe6d9adad72fc7bce90f4ab68d119f50c5b
> ("ARM: imx: support DEBUG_LL uart port selection for all i.MX SoCs").
> Looking at that patch and at the tree makes clear that DEBUG_IMX53_UART
> was intended here.
Thanks for the fixing. Above comment should really be in the commit
log. I just applied the patch as below.
Shawn
commit 0c52db7e681678f9b2a3fb96c3dd557168b4e025
Author: Paul Bolle <pebolle@tiscali.nl>
Date: Mon Mar 11 14:16:00 2013 +0100
ARM: imx: fix typo "DEBUG_IMX50_IMX53_UART"
Commit f8c95fe (ARM: imx: support DEBUG_LL uart port selection for all
i.MX SoCs) had a typo that DEBUG_IMX50_IMX53_UART should be
DEBUG_IMX53_UART.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] ARM: imx: fix typo "DEBUG_IMX50_IMX53_UART"
2013-03-11 13:34 ` Sergei Shtylyov
@ 2013-03-11 13:39 ` Paul Bolle
-1 siblings, 0 replies; 18+ messages in thread
From: Paul Bolle @ 2013-03-11 13:39 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: Russell King, Shawn Guo, linux-kernel, linux-arm-kernel
On Mon, 2013-03-11 at 17:34 +0400, Sergei Shtylyov wrote:
> On 11-03-2013 17:16, Paul Bolle wrote:
> > 1) Typo was added in commit f8c95fe6d9adad72fc7bce90f4ab68d119f50c5b
> > ("ARM: imx: support DEBUG_LL uart port selection for all i.MX SoCs").
> > Looking at that patch and at the tree makes clear that DEBUG_IMX53_UART
> > was intended here.
>
> Should probably be in the changelog instead.
I feared being to verbose. But putting it in the commit explanation is
fine with me. I'll try to send an updated patch later this day.
Paul Bolle
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] ARM: imx: fix typo "DEBUG_IMX50_IMX53_UART"
@ 2013-03-11 13:39 ` Paul Bolle
0 siblings, 0 replies; 18+ messages in thread
From: Paul Bolle @ 2013-03-11 13:39 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 2013-03-11 at 17:34 +0400, Sergei Shtylyov wrote:
> On 11-03-2013 17:16, Paul Bolle wrote:
> > 1) Typo was added in commit f8c95fe6d9adad72fc7bce90f4ab68d119f50c5b
> > ("ARM: imx: support DEBUG_LL uart port selection for all i.MX SoCs").
> > Looking at that patch and at the tree makes clear that DEBUG_IMX53_UART
> > was intended here.
>
> Should probably be in the changelog instead.
I feared being to verbose. But putting it in the commit explanation is
fine with me. I'll try to send an updated patch later this day.
Paul Bolle
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] ARM: imx: fix typo "DEBUG_IMX50_IMX53_UART"
2013-03-11 13:37 ` Shawn Guo
@ 2013-03-11 13:41 ` Fabio Estevam
-1 siblings, 0 replies; 18+ messages in thread
From: Fabio Estevam @ 2013-03-11 13:41 UTC (permalink / raw)
To: Shawn Guo; +Cc: Paul Bolle, Russell King, linux-kernel, linux-arm-kernel
On Mon, Mar 11, 2013 at 10:37 AM, Shawn Guo <shawn.guo@linaro.org> wrote:
> Paul,
>
> On Mon, Mar 11, 2013 at 02:16:00PM +0100, Paul Bolle wrote:
>> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
>> ---
>> 0) Tested by grepping the tree.
>>
>> 1) Typo was added in commit f8c95fe6d9adad72fc7bce90f4ab68d119f50c5b
>> ("ARM: imx: support DEBUG_LL uart port selection for all i.MX SoCs").
>> Looking at that patch and at the tree makes clear that DEBUG_IMX53_UART
>> was intended here.
>
> Thanks for the fixing. Above comment should really be in the commit
> log. I just applied the patch as below.
Please see my commit:
commit 7356420cd34e40fe27bf26555b0bf3f2849a43dd
Author: Fabio Estevam <fabio.estevam@freescale.com>
Date: Tue Jan 22 10:40:55 2013 -0200
ARM: imx: Remove mx508 support
Only mx508 based board is mach-mx50_rdp and it has been marked as BROKEN
for several releases.
mx508 currently lacks clock support.
In case someone needs to add mx508 support back, then the
recommended approach
is to use device tree.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
,it does remove the MX50 reference, so this patch is not needed.
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] ARM: imx: fix typo "DEBUG_IMX50_IMX53_UART"
@ 2013-03-11 13:41 ` Fabio Estevam
0 siblings, 0 replies; 18+ messages in thread
From: Fabio Estevam @ 2013-03-11 13:41 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Mar 11, 2013 at 10:37 AM, Shawn Guo <shawn.guo@linaro.org> wrote:
> Paul,
>
> On Mon, Mar 11, 2013 at 02:16:00PM +0100, Paul Bolle wrote:
>> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
>> ---
>> 0) Tested by grepping the tree.
>>
>> 1) Typo was added in commit f8c95fe6d9adad72fc7bce90f4ab68d119f50c5b
>> ("ARM: imx: support DEBUG_LL uart port selection for all i.MX SoCs").
>> Looking at that patch and at the tree makes clear that DEBUG_IMX53_UART
>> was intended here.
>
> Thanks for the fixing. Above comment should really be in the commit
> log. I just applied the patch as below.
Please see my commit:
commit 7356420cd34e40fe27bf26555b0bf3f2849a43dd
Author: Fabio Estevam <fabio.estevam@freescale.com>
Date: Tue Jan 22 10:40:55 2013 -0200
ARM: imx: Remove mx508 support
Only mx508 based board is mach-mx50_rdp and it has been marked as BROKEN
for several releases.
mx508 currently lacks clock support.
In case someone needs to add mx508 support back, then the
recommended approach
is to use device tree.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
,it does remove the MX50 reference, so this patch is not needed.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] ARM: imx: fix typo "DEBUG_IMX50_IMX53_UART"
2013-03-11 13:37 ` Shawn Guo
@ 2013-03-11 13:43 ` Paul Bolle
-1 siblings, 0 replies; 18+ messages in thread
From: Paul Bolle @ 2013-03-11 13:43 UTC (permalink / raw)
To: Shawn Guo; +Cc: Russell King, linux-arm-kernel, linux-kernel
On Mon, 2013-03-11 at 21:37 +0800, Shawn Guo wrote:
> On Mon, Mar 11, 2013 at 02:16:00PM +0100, Paul Bolle wrote:
> > 1) Typo was added in commit f8c95fe6d9adad72fc7bce90f4ab68d119f50c5b
> > ("ARM: imx: support DEBUG_LL uart port selection for all i.MX SoCs").
> > Looking at that patch and at the tree makes clear that DEBUG_IMX53_UART
> > was intended here.
>
> Thanks for the fixing. Above comment should really be in the commit
> log. I just applied the patch as below.
Thanks for updating the commit explanation. I guess I'll have to reserve
the "one line commit summary only" style for the really obvious typos.
Paul Bolle
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] ARM: imx: fix typo "DEBUG_IMX50_IMX53_UART"
@ 2013-03-11 13:43 ` Paul Bolle
0 siblings, 0 replies; 18+ messages in thread
From: Paul Bolle @ 2013-03-11 13:43 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 2013-03-11 at 21:37 +0800, Shawn Guo wrote:
> On Mon, Mar 11, 2013 at 02:16:00PM +0100, Paul Bolle wrote:
> > 1) Typo was added in commit f8c95fe6d9adad72fc7bce90f4ab68d119f50c5b
> > ("ARM: imx: support DEBUG_LL uart port selection for all i.MX SoCs").
> > Looking at that patch and at the tree makes clear that DEBUG_IMX53_UART
> > was intended here.
>
> Thanks for the fixing. Above comment should really be in the commit
> log. I just applied the patch as below.
Thanks for updating the commit explanation. I guess I'll have to reserve
the "one line commit summary only" style for the really obvious typos.
Paul Bolle
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] ARM: imx: fix typo "DEBUG_IMX50_IMX53_UART"
2013-03-11 13:41 ` Fabio Estevam
@ 2013-03-11 13:47 ` Paul Bolle
-1 siblings, 0 replies; 18+ messages in thread
From: Paul Bolle @ 2013-03-11 13:47 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Shawn Guo, Russell King, linux-kernel, linux-arm-kernel
On Mon, 2013-03-11 at 10:41 -0300, Fabio Estevam wrote:
> Please see my commit:
>
> commit 7356420cd34e40fe27bf26555b0bf3f2849a43dd
> Author: Fabio Estevam <fabio.estevam@freescale.com>
> Date: Tue Jan 22 10:40:55 2013 -0200
>
> ARM: imx: Remove mx508 support
>
> Only mx508 based board is mach-mx50_rdp and it has been marked as BROKEN
> for several releases.
>
> mx508 currently lacks clock support.
>
> In case someone needs to add mx508 support back, then the
> recommended approach
> is to use device tree.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
>
> ,it does remove the MX50 reference, so this patch is not needed.
That's not correct:
$ git grep -n DEBUG_IMX50_IMX53_UART v3.9-rc2
v3.9-rc2:arch/arm/Kconfig.debug:495: DEBUG_IMX50_IMX53_UART || \
Paul Bolle
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] ARM: imx: fix typo "DEBUG_IMX50_IMX53_UART"
@ 2013-03-11 13:47 ` Paul Bolle
0 siblings, 0 replies; 18+ messages in thread
From: Paul Bolle @ 2013-03-11 13:47 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 2013-03-11 at 10:41 -0300, Fabio Estevam wrote:
> Please see my commit:
>
> commit 7356420cd34e40fe27bf26555b0bf3f2849a43dd
> Author: Fabio Estevam <fabio.estevam@freescale.com>
> Date: Tue Jan 22 10:40:55 2013 -0200
>
> ARM: imx: Remove mx508 support
>
> Only mx508 based board is mach-mx50_rdp and it has been marked as BROKEN
> for several releases.
>
> mx508 currently lacks clock support.
>
> In case someone needs to add mx508 support back, then the
> recommended approach
> is to use device tree.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
>
> ,it does remove the MX50 reference, so this patch is not needed.
That's not correct:
$ git grep -n DEBUG_IMX50_IMX53_UART v3.9-rc2
v3.9-rc2:arch/arm/Kconfig.debug:495: DEBUG_IMX50_IMX53_UART || \
Paul Bolle
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] ARM: imx: fix typo "DEBUG_IMX50_IMX53_UART"
2013-03-11 13:47 ` Paul Bolle
@ 2013-03-11 13:50 ` Fabio Estevam
-1 siblings, 0 replies; 18+ messages in thread
From: Fabio Estevam @ 2013-03-11 13:50 UTC (permalink / raw)
To: Paul Bolle; +Cc: Shawn Guo, Russell King, linux-kernel, linux-arm-kernel
On Mon, Mar 11, 2013 at 10:47 AM, Paul Bolle <pebolle@tiscali.nl> wrote:
> That's not correct:
> $ git grep -n DEBUG_IMX50_IMX53_UART v3.9-rc2
> v3.9-rc2:arch/arm/Kconfig.debug:495: DEBUG_IMX50_IMX53_UART || \
Yes, you are right. I missed to remove one entry.
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] ARM: imx: fix typo "DEBUG_IMX50_IMX53_UART"
@ 2013-03-11 13:50 ` Fabio Estevam
0 siblings, 0 replies; 18+ messages in thread
From: Fabio Estevam @ 2013-03-11 13:50 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Mar 11, 2013 at 10:47 AM, Paul Bolle <pebolle@tiscali.nl> wrote:
> That's not correct:
> $ git grep -n DEBUG_IMX50_IMX53_UART v3.9-rc2
> v3.9-rc2:arch/arm/Kconfig.debug:495: DEBUG_IMX50_IMX53_UART || \
Yes, you are right. I missed to remove one entry.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] ARM: imx: fix typo "DEBUG_IMX50_IMX53_UART"
2013-03-11 13:50 ` Fabio Estevam
@ 2013-03-11 14:57 ` Paul Bolle
-1 siblings, 0 replies; 18+ messages in thread
From: Paul Bolle @ 2013-03-11 14:57 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Shawn Guo, Russell King, linux-kernel, linux-arm-kernel
On Mon, 2013-03-11 at 10:50 -0300, Fabio Estevam wrote:
> I missed to remove one entry.
Actually, your patch was fine. DEBUG_IMX50_IMX53_UART returned a bit
later - and by accident - in commit
f8c95fe6d9adad72fc7bce90f4ab68d119f50c5b ("ARM: imx: support DEBUG_LL
uart port selection for all i.MX SoCs").
Paul Bolle
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] ARM: imx: fix typo "DEBUG_IMX50_IMX53_UART"
@ 2013-03-11 14:57 ` Paul Bolle
0 siblings, 0 replies; 18+ messages in thread
From: Paul Bolle @ 2013-03-11 14:57 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 2013-03-11 at 10:50 -0300, Fabio Estevam wrote:
> I missed to remove one entry.
Actually, your patch was fine. DEBUG_IMX50_IMX53_UART returned a bit
later - and by accident - in commit
f8c95fe6d9adad72fc7bce90f4ab68d119f50c5b ("ARM: imx: support DEBUG_LL
uart port selection for all i.MX SoCs").
Paul Bolle
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2013-03-11 14:57 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-11 13:16 [PATCH] ARM: imx: fix typo "DEBUG_IMX50_IMX53_UART" Paul Bolle
2013-03-11 13:16 ` Paul Bolle
2013-03-11 13:34 ` Sergei Shtylyov
2013-03-11 13:34 ` Sergei Shtylyov
2013-03-11 13:39 ` Paul Bolle
2013-03-11 13:39 ` Paul Bolle
2013-03-11 13:37 ` Shawn Guo
2013-03-11 13:37 ` Shawn Guo
2013-03-11 13:41 ` Fabio Estevam
2013-03-11 13:41 ` Fabio Estevam
2013-03-11 13:47 ` Paul Bolle
2013-03-11 13:47 ` Paul Bolle
2013-03-11 13:50 ` Fabio Estevam
2013-03-11 13:50 ` Fabio Estevam
2013-03-11 14:57 ` Paul Bolle
2013-03-11 14:57 ` Paul Bolle
2013-03-11 13:43 ` Paul Bolle
2013-03-11 13:43 ` Paul Bolle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.