* [PATCH] drivers: thermal: cpu_cooling: fix checkpatch warning
@ 2013-02-26 13:42 Laurent Navet
2013-03-11 14:24 ` Zhang Rui
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Navet @ 2013-02-26 13:42 UTC (permalink / raw)
To: rui.zhang; +Cc: linux-pm, linux-kernel, Laurent Navet
- WARNING: Avoid CamelCase: <maskPtr>
Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
---
drivers/thermal/cpu_cooling.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
index 836828e..47b7d32 100644
--- a/drivers/thermal/cpu_cooling.c
+++ b/drivers/thermal/cpu_cooling.c
@@ -175,8 +175,8 @@ static int cpufreq_apply_cooling(struct cpufreq_cooling_device *cpufreq_device,
unsigned long cooling_state)
{
unsigned int cpuid, clip_freq;
- struct cpumask *maskPtr = &cpufreq_device->allowed_cpus;
- unsigned int cpu = cpumask_any(maskPtr);
+ struct cpumask *mask = &cpufreq_device->allowed_cpus;
+ unsigned int cpu = cpumask_any(mask);
/* Check if the old cooling action is same as new cooling action */
@@ -191,7 +191,7 @@ static int cpufreq_apply_cooling(struct cpufreq_cooling_device *cpufreq_device,
cpufreq_device->cpufreq_val = clip_freq;
notify_device = cpufreq_device;
- for_each_cpu(cpuid, maskPtr) {
+ for_each_cpu(cpuid, mask) {
if (is_cpufreq_valid(cpuid))
cpufreq_update_policy(cpuid);
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: thermal: cpu_cooling: fix checkpatch warning
2013-02-26 13:42 [PATCH] drivers: thermal: cpu_cooling: fix checkpatch warning Laurent Navet
@ 2013-03-11 14:24 ` Zhang Rui
2013-03-11 19:42 ` Laurent Navet
0 siblings, 1 reply; 3+ messages in thread
From: Zhang Rui @ 2013-03-11 14:24 UTC (permalink / raw)
To: Laurent Navet; +Cc: linux-pm, linux-kernel
On Tue, 2013-02-26 at 14:42 +0100, Laurent Navet wrote:
> - WARNING: Avoid CamelCase: <maskPtr>
>
> Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
> ---
> drivers/thermal/cpu_cooling.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
> index 836828e..47b7d32 100644
> --- a/drivers/thermal/cpu_cooling.c
> +++ b/drivers/thermal/cpu_cooling.c
> @@ -175,8 +175,8 @@ static int cpufreq_apply_cooling(struct cpufreq_cooling_device *cpufreq_device,
> unsigned long cooling_state)
> {
> unsigned int cpuid, clip_freq;
> - struct cpumask *maskPtr = &cpufreq_device->allowed_cpus;
> - unsigned int cpu = cpumask_any(maskPtr);
> + struct cpumask *mask = &cpufreq_device->allowed_cpus;
> + unsigned int cpu = cpumask_any(mask);
>
>
> /* Check if the old cooling action is same as new cooling action */
> @@ -191,7 +191,7 @@ static int cpufreq_apply_cooling(struct cpufreq_cooling_device *cpufreq_device,
> cpufreq_device->cpufreq_val = clip_freq;
> notify_device = cpufreq_device;
>
> - for_each_cpu(cpuid, maskPtr) {
> + for_each_cpu(cpuid, mask) {
> if (is_cpufreq_valid(cpuid))
> cpufreq_update_policy(cpuid);
> }
why not fix the code in cpufreq_get_max_state() as well, in one patch?
thanks,
rui
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: thermal: cpu_cooling: fix checkpatch warning
2013-03-11 14:24 ` Zhang Rui
@ 2013-03-11 19:42 ` Laurent Navet
0 siblings, 0 replies; 3+ messages in thread
From: Laurent Navet @ 2013-03-11 19:42 UTC (permalink / raw)
To: Zhang Rui; +Cc: linux-pm, linux-kernel
> why not fix the code in cpufreq_get_max_state() as well, in one patch?
>
> thanks,
> rui
right, will do that and re-send.
Laurent.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-11 19:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-26 13:42 [PATCH] drivers: thermal: cpu_cooling: fix checkpatch warning Laurent Navet
2013-03-11 14:24 ` Zhang Rui
2013-03-11 19:42 ` Laurent Navet
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.