* [PATCH] [media] soc_camera: remove two outdated selects
@ 2013-03-11 21:30 Paul Bolle
2013-03-12 7:05 ` Guennadi Liakhovetski
0 siblings, 1 reply; 2+ messages in thread
From: Paul Bolle @ 2013-03-11 21:30 UTC (permalink / raw)
To: Guennadi Liakhovetski, Mauro Carvalho Chehab; +Cc: linux-media, linux-kernel
Release v2.6.30 removed the MT9M001_PCA9536_SWITCH and
MT9V022_PCA9536_SWITCH Kconfig symbols, in commits
36034dc325ecab63c8cfb992fbf9a1a8e94738a2 ("V4L/DVB (11032): mt9m001:
allow setting of bus width from board code") and
e958e27adeade7fa085dd396a8a0dfaef7e338c1 ("V4L/DVB (11033): mt9v022:
allow setting of bus width from board code").
These two commits removed all gpio related code from these two drivers.
But they skipped removing their two selects of GPIO_PCA953X. Remove
these now as they are outdated. Their dependencies can never evaluate to
true anyhow.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Tested by grepping the tree.
drivers/media/i2c/soc_camera/Kconfig | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/i2c/soc_camera/Kconfig b/drivers/media/i2c/soc_camera/Kconfig
index 6dff2b7..23d352f 100644
--- a/drivers/media/i2c/soc_camera/Kconfig
+++ b/drivers/media/i2c/soc_camera/Kconfig
@@ -9,7 +9,6 @@ config SOC_CAMERA_IMX074
config SOC_CAMERA_MT9M001
tristate "mt9m001 support"
depends on SOC_CAMERA && I2C
- select GPIO_PCA953X if MT9M001_PCA9536_SWITCH
help
This driver supports MT9M001 cameras from Micron, monochrome
and colour models.
@@ -36,7 +35,6 @@ config SOC_CAMERA_MT9T112
config SOC_CAMERA_MT9V022
tristate "mt9v022 and mt9v024 support"
depends on SOC_CAMERA && I2C
- select GPIO_PCA953X if MT9V022_PCA9536_SWITCH
help
This driver supports MT9V022 cameras from Micron
--
1.7.11.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [media] soc_camera: remove two outdated selects
2013-03-11 21:30 [PATCH] [media] soc_camera: remove two outdated selects Paul Bolle
@ 2013-03-12 7:05 ` Guennadi Liakhovetski
0 siblings, 0 replies; 2+ messages in thread
From: Guennadi Liakhovetski @ 2013-03-12 7:05 UTC (permalink / raw)
To: Paul Bolle; +Cc: Mauro Carvalho Chehab, linux-media, linux-kernel
Hi Paul
On Mon, 11 Mar 2013, Paul Bolle wrote:
> Release v2.6.30 removed the MT9M001_PCA9536_SWITCH and
> MT9V022_PCA9536_SWITCH Kconfig symbols, in commits
> 36034dc325ecab63c8cfb992fbf9a1a8e94738a2 ("V4L/DVB (11032): mt9m001:
> allow setting of bus width from board code") and
> e958e27adeade7fa085dd396a8a0dfaef7e338c1 ("V4L/DVB (11033): mt9v022:
> allow setting of bus width from board code").
>
> These two commits removed all gpio related code from these two drivers.
> But they skipped removing their two selects of GPIO_PCA953X. Remove
> these now as they are outdated. Their dependencies can never evaluate to
> true anyhow.
Thanks, this is definitely a left-over. Queued for 3.10.
Thanks
Guennadi
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Tested by grepping the tree.
>
> drivers/media/i2c/soc_camera/Kconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/i2c/soc_camera/Kconfig b/drivers/media/i2c/soc_camera/Kconfig
> index 6dff2b7..23d352f 100644
> --- a/drivers/media/i2c/soc_camera/Kconfig
> +++ b/drivers/media/i2c/soc_camera/Kconfig
> @@ -9,7 +9,6 @@ config SOC_CAMERA_IMX074
> config SOC_CAMERA_MT9M001
> tristate "mt9m001 support"
> depends on SOC_CAMERA && I2C
> - select GPIO_PCA953X if MT9M001_PCA9536_SWITCH
> help
> This driver supports MT9M001 cameras from Micron, monochrome
> and colour models.
> @@ -36,7 +35,6 @@ config SOC_CAMERA_MT9T112
> config SOC_CAMERA_MT9V022
> tristate "mt9v022 and mt9v024 support"
> depends on SOC_CAMERA && I2C
> - select GPIO_PCA953X if MT9V022_PCA9536_SWITCH
> help
> This driver supports MT9V022 cameras from Micron
>
> --
> 1.7.11.7
>
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-12 7:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-11 21:30 [PATCH] [media] soc_camera: remove two outdated selects Paul Bolle
2013-03-12 7:05 ` Guennadi Liakhovetski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.