All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-fsl-arm][PATCH] image_types_fsl.bbclass: fix partition type for SD card boot partition
@ 2013-03-18  9:44 Vladan Jovanovic
  2013-03-18 11:53 ` Otavio Salvador
  0 siblings, 1 reply; 2+ messages in thread
From: Vladan Jovanovic @ 2013-03-18  9:44 UTC (permalink / raw)
  To: meta-freescale

Create first partition on SD card as fat32. As boot.img is formatted as vfat, this will ensure information in partition table matches actual partition type.

Signed-off-by: Vladan Jovanovic <vladan.jovanovic@gmail.com>
---
 classes/image_types_fsl.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/classes/image_types_fsl.bbclass b/classes/image_types_fsl.bbclass
index 6d1f6dd..b803aef 100644
--- a/classes/image_types_fsl.bbclass
+++ b/classes/image_types_fsl.bbclass
@@ -89,7 +89,7 @@ SDCARD_GENERATION_COMMAND_mx6 = "generate_imx_sdcard"
 generate_imx_sdcard () {
 	# Create partition table
 	parted -s ${SDCARD} mklabel msdos
-	parted -s ${SDCARD} unit KiB mkpart primary ${IMAGE_ROOTFS_ALIGNMENT} $(expr ${IMAGE_ROOTFS_ALIGNMENT} \+ ${BOOT_SPACE_ALIGNED})
+	parted -s ${SDCARD} unit KiB mkpart primary fat32 ${IMAGE_ROOTFS_ALIGNMENT} $(expr ${IMAGE_ROOTFS_ALIGNMENT} \+ ${BOOT_SPACE_ALIGNED})
 	parted -s ${SDCARD} unit KiB mkpart primary $(expr  ${IMAGE_ROOTFS_ALIGNMENT} \+ ${BOOT_SPACE_ALIGNED}) $(expr ${IMAGE_ROOTFS_ALIGNMENT} \+ ${BOOT_SPACE_ALIGNED} \+ $ROOTFS_SIZE)
 	parted ${SDCARD} print
 
-- 
1.7.9.5



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [meta-fsl-arm][PATCH] image_types_fsl.bbclass: fix partition type for SD card boot partition
  2013-03-18  9:44 [meta-fsl-arm][PATCH] image_types_fsl.bbclass: fix partition type for SD card boot partition Vladan Jovanovic
@ 2013-03-18 11:53 ` Otavio Salvador
  0 siblings, 0 replies; 2+ messages in thread
From: Otavio Salvador @ 2013-03-18 11:53 UTC (permalink / raw)
  To: Vladan Jovanovic; +Cc: meta-freescale

On Mon, Mar 18, 2013 at 6:44 AM, Vladan Jovanovic
<vladan.jovanovic@gmail.com> wrote:
> Create first partition on SD card as fat32. As boot.img is formatted as vfat, this will ensure information in partition table matches actual partition type.
>
> Signed-off-by: Vladan Jovanovic <vladan.jovanovic@gmail.com>

The long commit log needs to be down 80 colums. But more important is
does it fixes a bug you see or it is just cosmetic?

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-03-18 11:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-18  9:44 [meta-fsl-arm][PATCH] image_types_fsl.bbclass: fix partition type for SD card boot partition Vladan Jovanovic
2013-03-18 11:53 ` Otavio Salvador

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.