All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: <netdev@vger.kernel.org>, <xen-devel@lists.xen.org>
Cc: <ian.campbell@citrix.com>, <konrad.wilk@oracle.com>,
	<annie.li@oracle.com>, Wei Liu <wei.liu2@citrix.com>
Subject: [PATCH 1/4] xen-netfront: remove unused variable `extra'
Date: Mon, 18 Mar 2013 10:35:52 +0000	[thread overview]
Message-ID: <1363602955-24790-2-git-send-email-wei.liu2@citrix.com> (raw)
In-Reply-To: <1363602955-24790-1-git-send-email-wei.liu2@citrix.com>

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 drivers/net/xen-netfront.c |    8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 7ffa43b..5527663 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -537,7 +537,6 @@ static int xennet_start_xmit(struct sk_buff *skb, struct net_device *dev)
 	struct netfront_info *np = netdev_priv(dev);
 	struct netfront_stats *stats = this_cpu_ptr(np->stats);
 	struct xen_netif_tx_request *tx;
-	struct xen_netif_extra_info *extra;
 	char *data = skb->data;
 	RING_IDX i;
 	grant_ref_t ref;
@@ -581,7 +580,6 @@ static int xennet_start_xmit(struct sk_buff *skb, struct net_device *dev)
 	tx->gref = np->grant_tx_ref[id] = ref;
 	tx->offset = offset;
 	tx->size = len;
-	extra = NULL;
 
 	tx->flags = 0;
 	if (skb->ip_summed == CHECKSUM_PARTIAL)
@@ -597,10 +595,7 @@ static int xennet_start_xmit(struct sk_buff *skb, struct net_device *dev)
 		gso = (struct xen_netif_extra_info *)
 			RING_GET_REQUEST(&np->tx, ++i);
 
-		if (extra)
-			extra->flags |= XEN_NETIF_EXTRA_FLAG_MORE;
-		else
-			tx->flags |= XEN_NETTXF_extra_info;
+		tx->flags |= XEN_NETTXF_extra_info;
 
 		gso->u.gso.size = skb_shinfo(skb)->gso_size;
 		gso->u.gso.type = XEN_NETIF_GSO_TYPE_TCPV4;
@@ -609,7 +604,6 @@ static int xennet_start_xmit(struct sk_buff *skb, struct net_device *dev)
 
 		gso->type = XEN_NETIF_EXTRA_TYPE_GSO;
 		gso->flags = 0;
-		extra = gso;
 	}
 
 	np->tx.req_prod_pvt = i + 1;
-- 
1.7.10.4

  parent reply	other threads:[~2013-03-18 10:36 UTC|newest]

Thread overview: 97+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-18 10:35 [PATCH 0/4] Bundle fixes for xen-netfront/back Wei Liu
2013-03-18 10:35 ` [PATCH 1/4] xen-netfront: remove unused variable `extra' Wei Liu
2013-03-18 10:35 ` Wei Liu [this message]
2013-03-18 11:42   ` Ian Campbell
2013-03-18 11:42   ` Ian Campbell
2013-03-18 12:04     ` Wei Liu
2013-03-18 12:14       ` Ian Campbell
2013-03-18 12:14       ` Ian Campbell
2013-03-19  2:39         ` annie li
2013-03-19  2:39         ` annie li
2013-03-19  3:02           ` [Xen-devel] " James Harper
2013-03-19  3:02           ` James Harper
2013-03-19  9:28           ` Paul Durrant
2013-03-19  9:28           ` [Xen-devel] " Paul Durrant
2013-03-19  9:53             ` annie li
2013-03-19  9:53             ` [Xen-devel] " annie li
2013-03-19 10:03               ` Paul Durrant
2013-03-19 10:03               ` Paul Durrant
2013-03-19 15:26             ` Wei Liu
2013-03-19 15:26             ` [Xen-devel] " Wei Liu
2013-04-09 14:28               ` Ian Campbell
2013-04-09 14:28               ` Ian Campbell
2013-03-18 12:04     ` Wei Liu
2013-03-18 10:35 ` [PATCH 2/4] xen-netfront: drop skb when skb->len > 65535 Wei Liu
2013-03-18 11:42   ` Ian Campbell
2013-03-18 14:40     ` Wei Liu
2013-03-18 14:40     ` Wei Liu
2013-03-18 14:54       ` Ian Campbell
2013-03-18 14:54       ` Ian Campbell
2013-03-18 15:04         ` Wei Liu
2013-03-18 15:07           ` Ian Campbell
2013-03-18 15:10             ` Wei Liu
2013-03-18 15:10             ` Wei Liu
2013-03-19 21:24             ` Ben Hutchings
2013-03-19 21:24             ` Ben Hutchings
2013-03-19 21:28               ` Ben Hutchings
2013-04-09 14:30                 ` Ian Campbell
2013-04-09 14:30                 ` Ian Campbell
2013-04-09 14:45                   ` Ben Hutchings
2013-04-09 14:53                     ` [Xen-devel] " Christoph Egger
2013-04-09 14:59                       ` Ben Hutchings
2013-04-09 14:59                       ` [Xen-devel] " Ben Hutchings
2013-04-09 14:53                     ` Christoph Egger
2013-04-09 14:45                   ` Ben Hutchings
2013-03-19 21:28               ` Ben Hutchings
2013-03-18 15:07           ` Ian Campbell
2013-03-18 15:04         ` Wei Liu
2013-03-18 11:42   ` Ian Campbell
2013-03-18 13:44   ` Konrad Rzeszutek Wilk
2013-03-18 13:44   ` Konrad Rzeszutek Wilk
2013-03-18 13:46   ` David Vrabel
2013-03-18 13:46   ` [Xen-devel] " David Vrabel
2013-03-18 13:48     ` Ian Campbell
2013-03-18 13:48     ` [Xen-devel] " Ian Campbell
2013-03-18 14:00       ` David Vrabel
2013-03-18 14:19         ` Wei Liu
2013-03-19 13:40           ` David Vrabel
2013-03-19 13:40           ` [Xen-devel] " David Vrabel
2013-03-19 15:23             ` Wei Liu
2013-03-19 15:23             ` [Xen-devel] " Wei Liu
2013-03-18 14:19         ` Wei Liu
2013-03-20 20:02         ` David Vrabel
2013-03-20 20:02         ` [Xen-devel] " David Vrabel
2013-03-21 13:40           ` Wei Liu
2013-03-21 14:11             ` David Vrabel
2013-03-21 14:11             ` [Xen-devel] " David Vrabel
2013-03-21 14:15               ` Wei Liu
2013-03-21 14:15               ` [Xen-devel] " Wei Liu
2013-03-21 14:20                 ` Wei Liu
2013-03-21 14:20                 ` [Xen-devel] " Wei Liu
2013-03-21 13:40           ` Wei Liu
2013-03-18 14:00       ` David Vrabel
2013-03-19  1:35   ` [Xen-devel] " annie li
2013-03-19  1:35   ` annie li
2013-03-19 20:13   ` Nick Pegg
2013-03-18 10:35 ` Wei Liu
2013-03-18 10:35 ` [PATCH 3/4] xen-netback: remove skb in xen_netbk_alloc_page Wei Liu
2013-03-18 11:37   ` Ian Campbell
2013-03-18 11:37   ` Ian Campbell
2013-03-18 10:35 ` Wei Liu
2013-03-18 10:35 ` [PATCH 4/4] xen-netback: coalesce slots before copying Wei Liu
2013-03-18 12:07   ` Ian Campbell
2013-03-18 12:07   ` Ian Campbell
2013-03-21 18:37     ` Wei Liu
2013-03-21 18:37     ` Wei Liu
2013-03-18 13:09   ` James Harper
2013-03-18 13:27     ` James Harper
2013-03-21 19:08       ` Wei Liu
2013-03-21 22:14         ` James Harper
2013-03-21 22:14         ` [Xen-devel] " James Harper
2013-03-22 11:06           ` Wei Liu
2013-03-22 11:19             ` James Harper
2013-03-22 11:19             ` [Xen-devel] " James Harper
2013-03-22 11:28               ` Wei Liu
2013-03-22 11:28               ` [Xen-devel] " Wei Liu
2013-03-22 11:06           ` Wei Liu
2013-03-18 10:35 ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363602955-24790-2-git-send-email-wei.liu2@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=annie.li@oracle.com \
    --cc=ian.campbell@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=netdev@vger.kernel.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.