From: Wei Liu <wei.liu2@citrix.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: <wei.liu2@citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"annie.li@oracle.com" <annie.li@oracle.com>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [Xen-devel] [PATCH 2/4] xen-netfront: drop skb when skb->len > 65535
Date: Thu, 21 Mar 2013 14:20:13 +0000 [thread overview]
Message-ID: <1363875613.2160.17.camel@zion.uk.xensource.com> (raw)
In-Reply-To: <1363875350.2160.16.camel@zion.uk.xensource.com>
On Thu, 2013-03-21 at 14:15 +0000, Wei Liu wrote:
> On Thu, 2013-03-21 at 14:11 +0000, David Vrabel wrote:
> > On 21/03/13 13:40, Wei Liu wrote:
> > >
> > >
> > > I think the correct action is to just take first txp and loop responding
> > > until we consume the whole packet.
> >
> > Um. This is what the patch is doing.
> >
>
> No. The idx you passed in is the index of the first txp, and idx + fras
> doesn't necessary point to last tx requests of the packet. We should use
> XEN_NETTXF_more_data to loop through the packet.
>
Sorry for the noise, this patch already loop through the whole packet.
Wei.
>
> Wei.
>
> > David
>
>
next prev parent reply other threads:[~2013-03-21 14:20 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-18 10:35 [PATCH 0/4] Bundle fixes for xen-netfront/back Wei Liu
2013-03-18 10:35 ` [PATCH 1/4] xen-netfront: remove unused variable `extra' Wei Liu
2013-03-18 10:35 ` Wei Liu
2013-03-18 11:42 ` Ian Campbell
2013-03-18 11:42 ` Ian Campbell
2013-03-18 12:04 ` Wei Liu
2013-03-18 12:14 ` Ian Campbell
2013-03-18 12:14 ` Ian Campbell
2013-03-19 2:39 ` annie li
2013-03-19 2:39 ` annie li
2013-03-19 3:02 ` [Xen-devel] " James Harper
2013-03-19 3:02 ` James Harper
2013-03-19 9:28 ` Paul Durrant
2013-03-19 9:28 ` [Xen-devel] " Paul Durrant
2013-03-19 9:53 ` annie li
2013-03-19 9:53 ` [Xen-devel] " annie li
2013-03-19 10:03 ` Paul Durrant
2013-03-19 10:03 ` Paul Durrant
2013-03-19 15:26 ` Wei Liu
2013-03-19 15:26 ` [Xen-devel] " Wei Liu
2013-04-09 14:28 ` Ian Campbell
2013-04-09 14:28 ` Ian Campbell
2013-03-18 12:04 ` Wei Liu
2013-03-18 10:35 ` [PATCH 2/4] xen-netfront: drop skb when skb->len > 65535 Wei Liu
2013-03-18 11:42 ` Ian Campbell
2013-03-18 14:40 ` Wei Liu
2013-03-18 14:40 ` Wei Liu
2013-03-18 14:54 ` Ian Campbell
2013-03-18 14:54 ` Ian Campbell
2013-03-18 15:04 ` Wei Liu
2013-03-18 15:07 ` Ian Campbell
2013-03-18 15:10 ` Wei Liu
2013-03-18 15:10 ` Wei Liu
2013-03-19 21:24 ` Ben Hutchings
2013-03-19 21:24 ` Ben Hutchings
2013-03-19 21:28 ` Ben Hutchings
2013-04-09 14:30 ` Ian Campbell
2013-04-09 14:30 ` Ian Campbell
2013-04-09 14:45 ` Ben Hutchings
2013-04-09 14:53 ` [Xen-devel] " Christoph Egger
2013-04-09 14:59 ` Ben Hutchings
2013-04-09 14:59 ` [Xen-devel] " Ben Hutchings
2013-04-09 14:53 ` Christoph Egger
2013-04-09 14:45 ` Ben Hutchings
2013-03-19 21:28 ` Ben Hutchings
2013-03-18 15:07 ` Ian Campbell
2013-03-18 15:04 ` Wei Liu
2013-03-18 11:42 ` Ian Campbell
2013-03-18 13:44 ` Konrad Rzeszutek Wilk
2013-03-18 13:44 ` Konrad Rzeszutek Wilk
2013-03-18 13:46 ` David Vrabel
2013-03-18 13:46 ` [Xen-devel] " David Vrabel
2013-03-18 13:48 ` Ian Campbell
2013-03-18 13:48 ` [Xen-devel] " Ian Campbell
2013-03-18 14:00 ` David Vrabel
2013-03-18 14:19 ` Wei Liu
2013-03-19 13:40 ` David Vrabel
2013-03-19 13:40 ` [Xen-devel] " David Vrabel
2013-03-19 15:23 ` Wei Liu
2013-03-19 15:23 ` [Xen-devel] " Wei Liu
2013-03-18 14:19 ` Wei Liu
2013-03-20 20:02 ` David Vrabel
2013-03-20 20:02 ` [Xen-devel] " David Vrabel
2013-03-21 13:40 ` Wei Liu
2013-03-21 14:11 ` David Vrabel
2013-03-21 14:11 ` [Xen-devel] " David Vrabel
2013-03-21 14:15 ` Wei Liu
2013-03-21 14:15 ` [Xen-devel] " Wei Liu
2013-03-21 14:20 ` Wei Liu
2013-03-21 14:20 ` Wei Liu [this message]
2013-03-21 13:40 ` Wei Liu
2013-03-18 14:00 ` David Vrabel
2013-03-19 1:35 ` [Xen-devel] " annie li
2013-03-19 1:35 ` annie li
2013-03-19 20:13 ` Nick Pegg
2013-03-18 10:35 ` Wei Liu
2013-03-18 10:35 ` [PATCH 3/4] xen-netback: remove skb in xen_netbk_alloc_page Wei Liu
2013-03-18 11:37 ` Ian Campbell
2013-03-18 11:37 ` Ian Campbell
2013-03-18 10:35 ` Wei Liu
2013-03-18 10:35 ` [PATCH 4/4] xen-netback: coalesce slots before copying Wei Liu
2013-03-18 12:07 ` Ian Campbell
2013-03-18 12:07 ` Ian Campbell
2013-03-21 18:37 ` Wei Liu
2013-03-21 18:37 ` Wei Liu
2013-03-18 13:09 ` James Harper
2013-03-18 13:27 ` James Harper
2013-03-21 19:08 ` Wei Liu
2013-03-21 22:14 ` James Harper
2013-03-21 22:14 ` [Xen-devel] " James Harper
2013-03-22 11:06 ` Wei Liu
2013-03-22 11:19 ` James Harper
2013-03-22 11:19 ` [Xen-devel] " James Harper
2013-03-22 11:28 ` Wei Liu
2013-03-22 11:28 ` [Xen-devel] " Wei Liu
2013-03-22 11:06 ` Wei Liu
2013-03-18 10:35 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363875613.2160.17.camel@zion.uk.xensource.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=annie.li@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.