All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Hunter <jon-hunter@ti.com>
To: Rob Herring <rob.herring@calxeda.com>,
	Grant Likely <grant.likely@secretlab.ca>,
	Tony Lindgren <tony@atomide.com>,
	Benoit Cousson <b-cousson@ti.com>
Cc: device-tree <devicetree-discuss@lists.ozlabs.org>,
	linux-omap <linux-omap@vger.kernel.org>,
	linux-arm <linux-arm-kernel@lists.infradead.org>,
	Daniel Mack <zonque@gmail.com>,
	Ezequiel Garcia <elezegarcia@gmail.com>,
	Mark Jackson <mpfj-list@mimc.co.uk>,
	Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
	Jon Hunter <jon-hunter@ti.com>
Subject: [PATCH V4 18/18] ARM: OMAP2+: return -ENODEV if GPMC child device creation fails
Date: Tue, 19 Mar 2013 11:35:56 -0500	[thread overview]
Message-ID: <1363710956-26773-19-git-send-email-jon-hunter@ti.com> (raw)
In-Reply-To: <1363710956-26773-1-git-send-email-jon-hunter@ti.com>

From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>

gpmc_probe_nor_child() calls of_platform_device_create() to create a
platform device for the NOR child. If this function fails the value
of ret is returned to the caller but this value is zero since it was
assigned the return of a previous call to gpmc_cs_program_settings()
that had to succeed or otherwise gpmc_probe_nor_child() would have
returned before.

This means that if of_platform_device_create() fails, 0 will be returned
to the caller instead of an appropriate error code.

Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Signed-off-by: Jon Hunter <jon-hunter@ti.com>
Tested-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
---
 arch/arm/mach-omap2/gpmc.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index 9208d8e..615da97 100644
--- a/arch/arm/mach-omap2/gpmc.c
+++ b/arch/arm/mach-omap2/gpmc.c
@@ -1495,6 +1495,7 @@ static int gpmc_probe_nor_child(struct platform_device *pdev,
 		return 0;
 
 	dev_err(&pdev->dev, "failed to create gpmc child %s\n", child->name);
+	ret = -ENODEV;
 
 err:
 	gpmc_cs_free(cs);
-- 
1.7.10.4


WARNING: multiple messages have this Message-ID (diff)
From: jon-hunter@ti.com (Jon Hunter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 18/18] ARM: OMAP2+: return -ENODEV if GPMC child device creation fails
Date: Tue, 19 Mar 2013 11:35:56 -0500	[thread overview]
Message-ID: <1363710956-26773-19-git-send-email-jon-hunter@ti.com> (raw)
In-Reply-To: <1363710956-26773-1-git-send-email-jon-hunter@ti.com>

From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>

gpmc_probe_nor_child() calls of_platform_device_create() to create a
platform device for the NOR child. If this function fails the value
of ret is returned to the caller but this value is zero since it was
assigned the return of a previous call to gpmc_cs_program_settings()
that had to succeed or otherwise gpmc_probe_nor_child() would have
returned before.

This means that if of_platform_device_create() fails, 0 will be returned
to the caller instead of an appropriate error code.

Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Signed-off-by: Jon Hunter <jon-hunter@ti.com>
Tested-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
---
 arch/arm/mach-omap2/gpmc.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index 9208d8e..615da97 100644
--- a/arch/arm/mach-omap2/gpmc.c
+++ b/arch/arm/mach-omap2/gpmc.c
@@ -1495,6 +1495,7 @@ static int gpmc_probe_nor_child(struct platform_device *pdev,
 		return 0;
 
 	dev_err(&pdev->dev, "failed to create gpmc child %s\n", child->name);
+	ret = -ENODEV;
 
 err:
 	gpmc_cs_free(cs);
-- 
1.7.10.4

  parent reply	other threads:[~2013-03-19 16:35 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-19 16:35 [PATCH V4 00/18] ARM: OMAP2+: GPMC clean-up and DT update Jon Hunter
2013-03-19 16:35 ` Jon Hunter
2013-03-19 16:35 ` [PATCH V4 01/18] ARM: OMAP2+: Simplify code configuring ONENAND devices Jon Hunter
2013-03-19 16:35   ` Jon Hunter
2013-03-19 16:35 ` [PATCH V4 02/18] ARM: OMAP2+: Add variable to store number of GPMC waitpins Jon Hunter
2013-03-19 16:35   ` Jon Hunter
2013-03-19 16:35 ` [PATCH V4 03/18] ARM: OMAP2+: Add structure for storing GPMC settings Jon Hunter
2013-03-19 16:35   ` Jon Hunter
2013-03-19 16:35 ` [PATCH V4 04/18] ARM: OMAP2+: Add function for configuring " Jon Hunter
2013-03-19 16:35   ` Jon Hunter
2013-03-19 16:35 ` [PATCH V4 05/18] ARM: OMAP2+: Convert ONENAND to use gpmc_cs_program_settings() Jon Hunter
2013-03-19 16:35   ` Jon Hunter
2013-03-19 16:35 ` [PATCH V4 06/18] ARM: OMAP2+: Convert NAND " Jon Hunter
2013-03-19 16:35   ` Jon Hunter
2013-03-19 16:35 ` [PATCH V4 07/18] ARM: OMAP2+: Convert SMC91x " Jon Hunter
2013-03-19 16:35   ` Jon Hunter
2013-03-19 16:35 ` [PATCH V4 08/18] ARM: OMAP2+: Convert TUSB " Jon Hunter
2013-03-19 16:35   ` Jon Hunter
2013-03-19 16:35 ` [PATCH V4 09/18] ARM: OMAP2+: Don't configure of chip-select options in gpmc_cs_configure() Jon Hunter
2013-03-19 16:35   ` Jon Hunter
2013-03-19 16:35 ` [PATCH V4 10/18] ARM: OMAP2+: Add function to read GPMC settings from device-tree Jon Hunter
2013-03-19 16:35   ` Jon Hunter
2013-04-15 13:27   ` Grant Likely
2013-04-15 13:27     ` Grant Likely
2013-04-15 16:54     ` Jon Hunter
2013-04-15 16:54       ` Jon Hunter
2013-03-19 16:35 ` [PATCH V4 11/18] ARM: OMAP2+: Add additional GPMC timing parameters Jon Hunter
2013-03-19 16:35   ` Jon Hunter
2013-03-19 16:35 ` [PATCH V4 12/18] ARM: OMAP2+: Add device-tree support for NOR flash Jon Hunter
2013-03-19 16:35   ` Jon Hunter
2013-03-19 16:35 ` [PATCH V4 13/18] ARM: OMAP2+: Convert NAND to retrieve GPMC settings from DT Jon Hunter
2013-03-19 16:35   ` Jon Hunter
2013-03-19 16:35 ` [PATCH V4 14/18] ARM: OMAP2+: Convert ONENAND " Jon Hunter
2013-03-19 16:35   ` Jon Hunter
2013-03-19 16:35 ` [PATCH V4 15/18] ARM: OMAP2+: Detect incorrectly aligned GPMC base address Jon Hunter
2013-03-19 16:35   ` Jon Hunter
2013-03-19 16:35 ` [PATCH V4 16/18] ARM: OMAP2+: Remove unnecesssary GPMC definitions and variable Jon Hunter
2013-03-19 16:35   ` Jon Hunter
2013-03-19 16:35 ` [PATCH V4 17/18] ARM: OMAP2+: Allow GPMC probe to complete even if CS mapping fails Jon Hunter
2013-03-19 16:35   ` Jon Hunter
2013-03-19 16:35 ` Jon Hunter [this message]
2013-03-19 16:35   ` [PATCH V4 18/18] ARM: OMAP2+: return -ENODEV if GPMC child device creation fails Jon Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363710956-26773-19-git-send-email-jon-hunter@ti.com \
    --to=jon-hunter@ti.com \
    --cc=b-cousson@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=elezegarcia@gmail.com \
    --cc=grant.likely@secretlab.ca \
    --cc=javier.martinez@collabora.co.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mpfj-list@mimc.co.uk \
    --cc=rob.herring@calxeda.com \
    --cc=tony@atomide.com \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.