All of lore.kernel.org
 help / color / mirror / Atom feed
* CONFIG_EARLY_PRINTK
@ 2013-03-13 17:15 Thomas Meyer
  2013-03-13 19:56 ` CONFIG_EARLY_PRINTK Randy Dunlap
  0 siblings, 1 reply; 7+ messages in thread
From: Thomas Meyer @ 2013-03-13 17:15 UTC (permalink / raw)
  To: Linux Kernel Mailing List

Hi,

 -*- Early printk 

help text says:
"You should normally N here, unless you want to debug such a crash.
(Depends on: EXPERT [=n])"

How to normally N here?

kind regards
thomas



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: CONFIG_EARLY_PRINTK
  2013-03-13 17:15 CONFIG_EARLY_PRINTK Thomas Meyer
@ 2013-03-13 19:56 ` Randy Dunlap
  2013-03-16 15:08   ` CONFIG_EARLY_PRINTK Thomas Meyer
  0 siblings, 1 reply; 7+ messages in thread
From: Randy Dunlap @ 2013-03-13 19:56 UTC (permalink / raw)
  To: Thomas Meyer; +Cc: Linux Kernel Mailing List

On 03/13/13 10:15, Thomas Meyer wrote:
> Hi,
> 
>  -*- Early printk 
> 
> help text says:
> "You should normally N here, unless you want to debug such a crash.
> (Depends on: EXPERT [=n])"
> 
> How to normally N here?

You'll have to enable CONFIG_EXPERT and then you can disable EARLY_PRINTK.

You may even have to disable CONFIG_EMBEDDED before you can enable
CONFIG_EXPERT (I did).

Too many hoops to have to jump through.   :(


-- 
~Randy

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: CONFIG_EARLY_PRINTK
  2013-03-13 19:56 ` CONFIG_EARLY_PRINTK Randy Dunlap
@ 2013-03-16 15:08   ` Thomas Meyer
  2013-03-16 17:38     ` CONFIG_EARLY_PRINTK Randy Dunlap
  0 siblings, 1 reply; 7+ messages in thread
From: Thomas Meyer @ 2013-03-16 15:08 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: Linux Kernel Mailing List

Am Mittwoch, den 13.03.2013, 12:56 -0700 schrieb Randy Dunlap:
> On 03/13/13 10:15, Thomas Meyer wrote:
> > Hi,
> > 
> >  -*- Early printk 
> > 
> > help text says:
> > "You should normally N here, unless you want to debug such a crash.
> > (Depends on: EXPERT [=n])"
> > 
> > How to normally N here?
> 
> You'll have to enable CONFIG_EXPERT and then you can disable EARLY_PRINTK.
> 
> You may even have to disable CONFIG_EMBEDDED before you can enable
> CONFIG_EXPERT (I did).
> 
> Too many hoops to have to jump through.   :(
> 

Yes,

so why not do this? As the text to EARLY_PRINTK explains?

diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
index b322f12..d6c2d89 100644
--- a/arch/x86/Kconfig.debug
+++ b/arch/x86/Kconfig.debug
@@ -32,7 +32,7 @@ config X86_VERBOSE_BOOTUP
 
 config EARLY_PRINTK
        bool "Early printk" if EXPERT
-       default y
+       default n
        ---help---
          Write kernel log output directly into the VGA buffer or to a
serial
          port.




^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: CONFIG_EARLY_PRINTK
  2013-03-16 15:08   ` CONFIG_EARLY_PRINTK Thomas Meyer
@ 2013-03-16 17:38     ` Randy Dunlap
  2013-03-16 20:10       ` CONFIG_EARLY_PRINTK Geert Uytterhoeven
  2013-03-22 14:07       ` CONFIG_EARLY_PRINTK Thomas Meyer
  0 siblings, 2 replies; 7+ messages in thread
From: Randy Dunlap @ 2013-03-16 17:38 UTC (permalink / raw)
  To: Thomas Meyer; +Cc: Linux Kernel Mailing List, x86

On 03/16/13 08:08, Thomas Meyer wrote:
> Am Mittwoch, den 13.03.2013, 12:56 -0700 schrieb Randy Dunlap:
>> On 03/13/13 10:15, Thomas Meyer wrote:
>>> Hi,
>>>
>>>  -*- Early printk 
>>>
>>> help text says:
>>> "You should normally N here, unless you want to debug such a crash.
>>> (Depends on: EXPERT [=n])"
>>>
>>> How to normally N here?
>>
>> You'll have to enable CONFIG_EXPERT and then you can disable EARLY_PRINTK.
>>
>> You may even have to disable CONFIG_EMBEDDED before you can enable
>> CONFIG_EXPERT (I did).
>>
>> Too many hoops to have to jump through.   :(
>>
> 
> Yes,
> 
> so why not do this? As the text to EARLY_PRINTK explains?

Yes, the default should match the help text.
Acked-by: Randy Dunlap <rdunlap@infradead.org>

Please resend your patch with Signed-off-by: line.

Thanks.

> 
> diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
> index b322f12..d6c2d89 100644
> --- a/arch/x86/Kconfig.debug
> +++ b/arch/x86/Kconfig.debug
> @@ -32,7 +32,7 @@ config X86_VERBOSE_BOOTUP
>  
>  config EARLY_PRINTK
>         bool "Early printk" if EXPERT
> -       default y
> +       default n
>         ---help---
>           Write kernel log output directly into the VGA buffer or to a
> serial
>           port.
> 
> 
> 


-- 
~Randy

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: CONFIG_EARLY_PRINTK
  2013-03-16 17:38     ` CONFIG_EARLY_PRINTK Randy Dunlap
@ 2013-03-16 20:10       ` Geert Uytterhoeven
  2013-03-22 14:07       ` CONFIG_EARLY_PRINTK Thomas Meyer
  1 sibling, 0 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2013-03-16 20:10 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: Thomas Meyer, Linux Kernel Mailing List, x86

On Sat, Mar 16, 2013 at 6:38 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
> On 03/16/13 08:08, Thomas Meyer wrote:
>> Am Mittwoch, den 13.03.2013, 12:56 -0700 schrieb Randy Dunlap:
>>> On 03/13/13 10:15, Thomas Meyer wrote:
>>>> help text says:
>>>> "You should normally N here, unless you want to debug such a crash.
>>>> (Depends on: EXPERT [=n])"
>>>>
>>>> How to normally N here?

>> so why not do this? As the text to EARLY_PRINTK explains?
>
> Yes, the default should match the help text.

So just remove the "default n" line, as "n" is the default.

> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>
> Please resend your patch with Signed-off-by: line.
>
> Thanks.
>
>>
>> diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
>> index b322f12..d6c2d89 100644
>> --- a/arch/x86/Kconfig.debug
>> +++ b/arch/x86/Kconfig.debug
>> @@ -32,7 +32,7 @@ config X86_VERBOSE_BOOTUP
>>
>>  config EARLY_PRINTK
>>         bool "Early printk" if EXPERT
>> -       default y
>> +       default n
>>         ---help---
>>           Write kernel log output directly into the VGA buffer or to a
>> serial
>>           port.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: CONFIG_EARLY_PRINTK
  2013-03-16 17:38     ` CONFIG_EARLY_PRINTK Randy Dunlap
  2013-03-16 20:10       ` CONFIG_EARLY_PRINTK Geert Uytterhoeven
@ 2013-03-22 14:07       ` Thomas Meyer
  2013-03-25 23:23         ` CONFIG_EARLY_PRINTK Randy Dunlap
  1 sibling, 1 reply; 7+ messages in thread
From: Thomas Meyer @ 2013-03-22 14:07 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: Linux Kernel Mailing List, x86

Am Samstag, den 16.03.2013, 10:38 -0700 schrieb Randy Dunlap:
> On 03/16/13 08:08, Thomas Meyer wrote:
> > Am Mittwoch, den 13.03.2013, 12:56 -0700 schrieb Randy Dunlap:
> > Yes,
> > 
> > so why not do this? As the text to EARLY_PRINTK explains?
> 
> Yes, the default should match the help text.
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
> 
> Please resend your patch with Signed-off-by: line.
> 
> Thanks.

Align EARLY_PRINTK default value with help text value.

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---

diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
index b322f12..852d51c 100644
--- a/arch/x86/Kconfig.debug
+++ b/arch/x86/Kconfig.debug
@@ -32,7 +32,6 @@ config X86_VERBOSE_BOOTUP
 
 config EARLY_PRINTK
        bool "Early printk" if EXPERT
-       default y
        ---help---
          Write kernel log output directly into the VGA buffer or to a serial
          port.



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: CONFIG_EARLY_PRINTK
  2013-03-22 14:07       ` CONFIG_EARLY_PRINTK Thomas Meyer
@ 2013-03-25 23:23         ` Randy Dunlap
  0 siblings, 0 replies; 7+ messages in thread
From: Randy Dunlap @ 2013-03-25 23:23 UTC (permalink / raw)
  To: Thomas Meyer; +Cc: Linux Kernel Mailing List, x86

On 03/22/13 07:07, Thomas Meyer wrote:
> Am Samstag, den 16.03.2013, 10:38 -0700 schrieb Randy Dunlap:
>> On 03/16/13 08:08, Thomas Meyer wrote:
>>> Am Mittwoch, den 13.03.2013, 12:56 -0700 schrieb Randy Dunlap:
>>> Yes,
>>>
>>> so why not do this? As the text to EARLY_PRINTK explains?
>>
>> Yes, the default should match the help text.
>> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>>
>> Please resend your patch with Signed-off-by: line.
>>
>> Thanks.
> 
> Align EARLY_PRINTK default value with help text value.
> 
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

tip??

> ---
> 
> diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
> index b322f12..852d51c 100644
> --- a/arch/x86/Kconfig.debug
> +++ b/arch/x86/Kconfig.debug
> @@ -32,7 +32,6 @@ config X86_VERBOSE_BOOTUP
>  
>  config EARLY_PRINTK
>         bool "Early printk" if EXPERT
> -       default y
>         ---help---
>           Write kernel log output directly into the VGA buffer or to a serial
>           port.
> 
> 
> --


-- 
~Randy

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2013-03-26  0:23 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-13 17:15 CONFIG_EARLY_PRINTK Thomas Meyer
2013-03-13 19:56 ` CONFIG_EARLY_PRINTK Randy Dunlap
2013-03-16 15:08   ` CONFIG_EARLY_PRINTK Thomas Meyer
2013-03-16 17:38     ` CONFIG_EARLY_PRINTK Randy Dunlap
2013-03-16 20:10       ` CONFIG_EARLY_PRINTK Geert Uytterhoeven
2013-03-22 14:07       ` CONFIG_EARLY_PRINTK Thomas Meyer
2013-03-25 23:23         ` CONFIG_EARLY_PRINTK Randy Dunlap

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.