* [PATCH 2/2] ACPI,acpi_memhotplug: Remove acpi_memory_info->failed bit
@ 2013-03-21 4:39 ` Yasuaki Ishimatsu
0 siblings, 0 replies; 33+ messages in thread
From: Yasuaki Ishimatsu @ 2013-03-21 4:39 UTC (permalink / raw)
To: Toshi Kani, rjw; +Cc: linux-acpi, tangchen, wency, laijs, linux-kernel
acpi_memory_info has enabled bit and failed bit for controlling memory
hotplug. But we don't need to keep both bits.
The patch removes acpi_memory_info->failed bit.
Signed-off-by: yasuaki ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
---
v2 : Changed a based kernel from linux-3.9-rc2 to linux-pm.git/bleeding-edge.
---
drivers/acpi/acpi_memhotplug.c | 13 +------------
1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
index ea78988..597cd65 100644
--- a/drivers/acpi/acpi_memhotplug.c
+++ b/drivers/acpi/acpi_memhotplug.c
@@ -73,7 +73,6 @@ struct acpi_memory_info {
unsigned short caching; /* memory cache attribute */
unsigned short write_protect; /* memory read/write attribute */
unsigned int enabled:1;
- unsigned int failed:1;
};
struct acpi_memory_device {
@@ -201,10 +200,8 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
* returns -EEXIST. If add_memory() returns the other error, it
* means that this memory block is not used by the kernel.
*/
- if (result && result != -EEXIST) {
- info->failed = 1;
+ if (result && result != -EEXIST)
continue;
- }
info->enabled = 1;
@@ -238,15 +235,7 @@ static int acpi_memory_remove_memory(struct acpi_memory_device *mem_device)
nid = acpi_get_node(mem_device->device->handle);
list_for_each_entry_safe(info, n, &mem_device->res_list, list) {
- if (info->failed)
- /* The kernel does not use this memory block */
- continue;
-
if (!info->enabled)
- /*
- * The kernel uses this memory block, but it may be not
- * managed by us.
- */
return -EBUSY;
if (nid < 0)
^ permalink raw reply related [flat|nested] 33+ messages in thread* Re: [PATCH 2/2] ACPI,acpi_memhotplug: Remove acpi_memory_info->failed bit
2013-03-21 4:39 ` Yasuaki Ishimatsu
@ 2013-03-21 4:45 ` Yasuaki Ishimatsu
-1 siblings, 0 replies; 33+ messages in thread
From: Yasuaki Ishimatsu @ 2013-03-21 4:45 UTC (permalink / raw)
To: Toshi Kani, rjw; +Cc: linux-acpi, tangchen, wency, laijs, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2306 bytes --]
The mail's tab become spaces. So I attached origianl patch.
Thanks,
Yasuaki Ishimatsu
2013/03/21 13:39, Yasuaki Ishimatsu wrote:
> acpi_memory_info has enabled bit and failed bit for controlling memory
> hotplug. But we don't need to keep both bits.
>
> The patch removes acpi_memory_info->failed bit.
>
> Signed-off-by: yasuaki ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
> ---
>
> v2 : Changed a based kernel from linux-3.9-rc2 to linux-pm.git/bleeding-edge.
>
> ---
> drivers/acpi/acpi_memhotplug.c | 13 +------------
> 1 files changed, 1 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
> index ea78988..597cd65 100644
> --- a/drivers/acpi/acpi_memhotplug.c
> +++ b/drivers/acpi/acpi_memhotplug.c
> @@ -73,7 +73,6 @@ struct acpi_memory_info {
> unsigned short caching; /* memory cache attribute */
> unsigned short write_protect; /* memory read/write attribute */
> unsigned int enabled:1;
> - unsigned int failed:1;
> };
>
> struct acpi_memory_device {
> @@ -201,10 +200,8 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
> * returns -EEXIST. If add_memory() returns the other error, it
> * means that this memory block is not used by the kernel.
> */
> - if (result && result != -EEXIST) {
> - info->failed = 1;
> + if (result && result != -EEXIST)
> continue;
> - }
>
> info->enabled = 1;
>
> @@ -238,15 +235,7 @@ static int acpi_memory_remove_memory(struct acpi_memory_device *mem_device)
> nid = acpi_get_node(mem_device->device->handle);
>
> list_for_each_entry_safe(info, n, &mem_device->res_list, list) {
> - if (info->failed)
> - /* The kernel does not use this memory block */
> - continue;
> -
> if (!info->enabled)
> - /*
> - * The kernel uses this memory block, but it may be not
> - * managed by us.
> - */
> return -EBUSY;
>
> if (nid < 0)
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: 0002-Remove-acpi_memory_info-failed-bit.patch --]
[-- Type: text/x-patch, Size: 1706 bytes --]
acpi_memory_info has enabled bit and failed bit for controlling memory
hotplug. But we don't need to keep both bits.
The patch removes acpi_memory_info->failed bit.
Signed-off-by: yasuaki ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
---
v2 : Changed a based kernel from linux-3.9-rc2 to linux-pm.git/bleeding-edge.
---
drivers/acpi/acpi_memhotplug.c | 13 +------------
1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
index ea78988..597cd65 100644
--- a/drivers/acpi/acpi_memhotplug.c
+++ b/drivers/acpi/acpi_memhotplug.c
@@ -73,7 +73,6 @@ struct acpi_memory_info {
unsigned short caching; /* memory cache attribute */
unsigned short write_protect; /* memory read/write attribute */
unsigned int enabled:1;
- unsigned int failed:1;
};
struct acpi_memory_device {
@@ -201,10 +200,8 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
* returns -EEXIST. If add_memory() returns the other error, it
* means that this memory block is not used by the kernel.
*/
- if (result && result != -EEXIST) {
- info->failed = 1;
+ if (result && result != -EEXIST)
continue;
- }
info->enabled = 1;
@@ -238,15 +235,7 @@ static int acpi_memory_remove_memory(struct acpi_memory_device *mem_device)
nid = acpi_get_node(mem_device->device->handle);
list_for_each_entry_safe(info, n, &mem_device->res_list, list) {
- if (info->failed)
- /* The kernel does not use this memory block */
- continue;
-
if (!info->enabled)
- /*
- * The kernel uses this memory block, but it may be not
- * managed by us.
- */
return -EBUSY;
if (nid < 0)
--
1.7.1
^ permalink raw reply related [flat|nested] 33+ messages in thread* Re: [PATCH 2/2] ACPI,acpi_memhotplug: Remove acpi_memory_info->failed bit
@ 2013-03-21 4:45 ` Yasuaki Ishimatsu
0 siblings, 0 replies; 33+ messages in thread
From: Yasuaki Ishimatsu @ 2013-03-21 4:45 UTC (permalink / raw)
To: Toshi Kani, rjw; +Cc: linux-acpi, tangchen, wency, laijs, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2306 bytes --]
The mail's tab become spaces. So I attached origianl patch.
Thanks,
Yasuaki Ishimatsu
2013/03/21 13:39, Yasuaki Ishimatsu wrote:
> acpi_memory_info has enabled bit and failed bit for controlling memory
> hotplug. But we don't need to keep both bits.
>
> The patch removes acpi_memory_info->failed bit.
>
> Signed-off-by: yasuaki ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
> ---
>
> v2 : Changed a based kernel from linux-3.9-rc2 to linux-pm.git/bleeding-edge.
>
> ---
> drivers/acpi/acpi_memhotplug.c | 13 +------------
> 1 files changed, 1 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
> index ea78988..597cd65 100644
> --- a/drivers/acpi/acpi_memhotplug.c
> +++ b/drivers/acpi/acpi_memhotplug.c
> @@ -73,7 +73,6 @@ struct acpi_memory_info {
> unsigned short caching; /* memory cache attribute */
> unsigned short write_protect; /* memory read/write attribute */
> unsigned int enabled:1;
> - unsigned int failed:1;
> };
>
> struct acpi_memory_device {
> @@ -201,10 +200,8 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
> * returns -EEXIST. If add_memory() returns the other error, it
> * means that this memory block is not used by the kernel.
> */
> - if (result && result != -EEXIST) {
> - info->failed = 1;
> + if (result && result != -EEXIST)
> continue;
> - }
>
> info->enabled = 1;
>
> @@ -238,15 +235,7 @@ static int acpi_memory_remove_memory(struct acpi_memory_device *mem_device)
> nid = acpi_get_node(mem_device->device->handle);
>
> list_for_each_entry_safe(info, n, &mem_device->res_list, list) {
> - if (info->failed)
> - /* The kernel does not use this memory block */
> - continue;
> -
> if (!info->enabled)
> - /*
> - * The kernel uses this memory block, but it may be not
> - * managed by us.
> - */
> return -EBUSY;
>
> if (nid < 0)
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: 0002-Remove-acpi_memory_info-failed-bit.patch --]
[-- Type: text/x-patch, Size: 1706 bytes --]
acpi_memory_info has enabled bit and failed bit for controlling memory
hotplug. But we don't need to keep both bits.
The patch removes acpi_memory_info->failed bit.
Signed-off-by: yasuaki ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
---
v2 : Changed a based kernel from linux-3.9-rc2 to linux-pm.git/bleeding-edge.
---
drivers/acpi/acpi_memhotplug.c | 13 +------------
1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
index ea78988..597cd65 100644
--- a/drivers/acpi/acpi_memhotplug.c
+++ b/drivers/acpi/acpi_memhotplug.c
@@ -73,7 +73,6 @@ struct acpi_memory_info {
unsigned short caching; /* memory cache attribute */
unsigned short write_protect; /* memory read/write attribute */
unsigned int enabled:1;
- unsigned int failed:1;
};
struct acpi_memory_device {
@@ -201,10 +200,8 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
* returns -EEXIST. If add_memory() returns the other error, it
* means that this memory block is not used by the kernel.
*/
- if (result && result != -EEXIST) {
- info->failed = 1;
+ if (result && result != -EEXIST)
continue;
- }
info->enabled = 1;
@@ -238,15 +235,7 @@ static int acpi_memory_remove_memory(struct acpi_memory_device *mem_device)
nid = acpi_get_node(mem_device->device->handle);
list_for_each_entry_safe(info, n, &mem_device->res_list, list) {
- if (info->failed)
- /* The kernel does not use this memory block */
- continue;
-
if (!info->enabled)
- /*
- * The kernel uses this memory block, but it may be not
- * managed by us.
- */
return -EBUSY;
if (nid < 0)
--
1.7.1
^ permalink raw reply related [flat|nested] 33+ messages in thread
* Re: [PATCH 2/2] ACPI,acpi_memhotplug: Remove acpi_memory_info->failed bit
2013-03-21 4:39 ` Yasuaki Ishimatsu
(?)
(?)
@ 2013-03-22 0:29 ` Toshi Kani
2013-03-22 1:35 ` Yasuaki Ishimatsu
2013-03-22 1:53 ` Yasuaki Ishimatsu
-1 siblings, 2 replies; 33+ messages in thread
From: Toshi Kani @ 2013-03-22 0:29 UTC (permalink / raw)
To: Yasuaki Ishimatsu; +Cc: rjw, linux-acpi, tangchen, wency, laijs, linux-kernel
On Thu, 2013-03-21 at 13:39 +0900, Yasuaki Ishimatsu wrote:
> acpi_memory_info has enabled bit and failed bit for controlling memory
> hotplug. But we don't need to keep both bits.
>
> The patch removes acpi_memory_info->failed bit.
>
> Signed-off-by: yasuaki ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
> ---
>
> v2 : Changed a based kernel from linux-3.9-rc2 to linux-pm.git/bleeding-edge.
>
> ---
> drivers/acpi/acpi_memhotplug.c | 13 +------------
> 1 files changed, 1 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
> index ea78988..597cd65 100644
> --- a/drivers/acpi/acpi_memhotplug.c
> +++ b/drivers/acpi/acpi_memhotplug.c
> @@ -73,7 +73,6 @@ struct acpi_memory_info {
> unsigned short caching; /* memory cache attribute */
> unsigned short write_protect; /* memory read/write attribute */
> unsigned int enabled:1;
> - unsigned int failed:1;
> };
>
> struct acpi_memory_device {
> @@ -201,10 +200,8 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
> * returns -EEXIST. If add_memory() returns the other error, it
> * means that this memory block is not used by the kernel.
> */
> - if (result && result != -EEXIST) {
> - info->failed = 1;
> + if (result && result != -EEXIST)
> continue;
> - }
>
> info->enabled = 1;
>
> @@ -238,15 +235,7 @@ static int acpi_memory_remove_memory(struct acpi_memory_device *mem_device)
> nid = acpi_get_node(mem_device->device->handle);
>
> list_for_each_entry_safe(info, n, &mem_device->res_list, list) {
> - if (info->failed)
> - /* The kernel does not use this memory block */
> - continue;
> -
> if (!info->enabled)
> - /*
> - * The kernel uses this memory block, but it may be not
> - * managed by us.
> - */
> return -EBUSY;
Shouldn't this case (!info->enabled) continue since it is the same as
info->failed before? -EBUSY was previously used for the -EEXIST case,
which is no longer a failure case with this patchset.
Thanks,
-Toshi
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [PATCH 2/2] ACPI,acpi_memhotplug: Remove acpi_memory_info->failed bit
2013-03-22 0:29 ` Toshi Kani
@ 2013-03-22 1:35 ` Yasuaki Ishimatsu
2013-03-22 1:53 ` Yasuaki Ishimatsu
1 sibling, 0 replies; 33+ messages in thread
From: Yasuaki Ishimatsu @ 2013-03-22 1:35 UTC (permalink / raw)
To: Toshi Kani; +Cc: rjw, linux-acpi, tangchen, wency, laijs, linux-kernel
Hi Toshi,
2013/03/22 9:29, Toshi Kani wrote:
> On Thu, 2013-03-21 at 13:39 +0900, Yasuaki Ishimatsu wrote:
>> acpi_memory_info has enabled bit and failed bit for controlling memory
>> hotplug. But we don't need to keep both bits.
>>
>> The patch removes acpi_memory_info->failed bit.
>>
>> Signed-off-by: yasuaki ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
>> ---
>>
>> v2 : Changed a based kernel from linux-3.9-rc2 to linux-pm.git/bleeding-edge.
>>
>> ---
>> drivers/acpi/acpi_memhotplug.c | 13 +------------
>> 1 files changed, 1 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
>> index ea78988..597cd65 100644
>> --- a/drivers/acpi/acpi_memhotplug.c
>> +++ b/drivers/acpi/acpi_memhotplug.c
>> @@ -73,7 +73,6 @@ struct acpi_memory_info {
>> unsigned short caching; /* memory cache attribute */
>> unsigned short write_protect; /* memory read/write attribute */
>> unsigned int enabled:1;
>> - unsigned int failed:1;
>> };
>>
>> struct acpi_memory_device {
>> @@ -201,10 +200,8 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
>> * returns -EEXIST. If add_memory() returns the other error, it
>> * means that this memory block is not used by the kernel.
>> */
>> - if (result && result != -EEXIST) {
>> - info->failed = 1;
>> + if (result && result != -EEXIST)
>> continue;
>> - }
>>
>> info->enabled = 1;
>>
>> @@ -238,15 +235,7 @@ static int acpi_memory_remove_memory(struct acpi_memory_device *mem_device)
>> nid = acpi_get_node(mem_device->device->handle);
>>
>> list_for_each_entry_safe(info, n, &mem_device->res_list, list) {
>> - if (info->failed)
>> - /* The kernel does not use this memory block */
>> - continue;
>> -
>> if (!info->enabled)
>> - /*
>> - * The kernel uses this memory block, but it may be not
>> - * managed by us.
>> - */
>> return -EBUSY;
>
> Shouldn't this case (!info->enabled) continue since it is the same as
> info->failed before? -EBUSY was previously used for the -EEXIST case,
> which is no longer a failure case with this patchset.
You are right. It is my mitake. We need to continue to hot remove memory.
I'll update soon.
Thanks,
Yasuaki Ishimatsu
>
> Thanks,
> -Toshi
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [PATCH 2/2] ACPI,acpi_memhotplug: Remove acpi_memory_info->failed bit
@ 2013-03-22 1:35 ` Yasuaki Ishimatsu
0 siblings, 0 replies; 33+ messages in thread
From: Yasuaki Ishimatsu @ 2013-03-22 1:35 UTC (permalink / raw)
To: Toshi Kani; +Cc: rjw, linux-acpi, tangchen, wency, laijs, linux-kernel
Hi Toshi,
2013/03/22 9:29, Toshi Kani wrote:
> On Thu, 2013-03-21 at 13:39 +0900, Yasuaki Ishimatsu wrote:
>> acpi_memory_info has enabled bit and failed bit for controlling memory
>> hotplug. But we don't need to keep both bits.
>>
>> The patch removes acpi_memory_info->failed bit.
>>
>> Signed-off-by: yasuaki ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
>> ---
>>
>> v2 : Changed a based kernel from linux-3.9-rc2 to linux-pm.git/bleeding-edge.
>>
>> ---
>> drivers/acpi/acpi_memhotplug.c | 13 +------------
>> 1 files changed, 1 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
>> index ea78988..597cd65 100644
>> --- a/drivers/acpi/acpi_memhotplug.c
>> +++ b/drivers/acpi/acpi_memhotplug.c
>> @@ -73,7 +73,6 @@ struct acpi_memory_info {
>> unsigned short caching; /* memory cache attribute */
>> unsigned short write_protect; /* memory read/write attribute */
>> unsigned int enabled:1;
>> - unsigned int failed:1;
>> };
>>
>> struct acpi_memory_device {
>> @@ -201,10 +200,8 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
>> * returns -EEXIST. If add_memory() returns the other error, it
>> * means that this memory block is not used by the kernel.
>> */
>> - if (result && result != -EEXIST) {
>> - info->failed = 1;
>> + if (result && result != -EEXIST)
>> continue;
>> - }
>>
>> info->enabled = 1;
>>
>> @@ -238,15 +235,7 @@ static int acpi_memory_remove_memory(struct acpi_memory_device *mem_device)
>> nid = acpi_get_node(mem_device->device->handle);
>>
>> list_for_each_entry_safe(info, n, &mem_device->res_list, list) {
>> - if (info->failed)
>> - /* The kernel does not use this memory block */
>> - continue;
>> -
>> if (!info->enabled)
>> - /*
>> - * The kernel uses this memory block, but it may be not
>> - * managed by us.
>> - */
>> return -EBUSY;
>
> Shouldn't this case (!info->enabled) continue since it is the same as
> info->failed before? -EBUSY was previously used for the -EEXIST case,
> which is no longer a failure case with this patchset.
You are right. It is my mitake. We need to continue to hot remove memory.
I'll update soon.
Thanks,
Yasuaki Ishimatsu
>
> Thanks,
> -Toshi
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH v3 2/2] ACPI,acpi_memhotplug: Remove acpi_memory_info->failed bit
2013-03-22 0:29 ` Toshi Kani
@ 2013-03-22 1:53 ` Yasuaki Ishimatsu
2013-03-22 1:53 ` Yasuaki Ishimatsu
1 sibling, 0 replies; 33+ messages in thread
From: Yasuaki Ishimatsu @ 2013-03-22 1:53 UTC (permalink / raw)
To: Toshi Kani; +Cc: rjw, linux-acpi, tangchen, wency, laijs, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1853 bytes --]
acpi_memory_info has enabled bit and failed bit for controlling memory
hotplug. But we don't need to keep both bits.
The patch removes acpi_memory_info->failed bit.
Signed-off-by: yasuaki ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
---
v3 : Continue to memory hot remove when (!info->enabled) case.
v2 : Changed a based kernel from linux-3.9-rc2 to linux-pm.git/bleeding-edge.
---
drivers/acpi/acpi_memhotplug.c | 15 ++-------------
1 files changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
index ea78988..5e6301e 100644
--- a/drivers/acpi/acpi_memhotplug.c
+++ b/drivers/acpi/acpi_memhotplug.c
@@ -73,7 +73,6 @@ struct acpi_memory_info {
unsigned short caching; /* memory cache attribute */
unsigned short write_protect; /* memory read/write attribute */
unsigned int enabled:1;
- unsigned int failed:1;
};
struct acpi_memory_device {
@@ -201,10 +200,8 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
* returns -EEXIST. If add_memory() returns the other error, it
* means that this memory block is not used by the kernel.
*/
- if (result && result != -EEXIST) {
- info->failed = 1;
+ if (result && result != -EEXIST)
continue;
- }
info->enabled = 1;
@@ -238,16 +235,8 @@ static int acpi_memory_remove_memory(struct acpi_memory_device *mem_device)
nid = acpi_get_node(mem_device->device->handle);
list_for_each_entry_safe(info, n, &mem_device->res_list, list) {
- if (info->failed)
- /* The kernel does not use this memory block */
- continue;
-
if (!info->enabled)
- /*
- * The kernel uses this memory block, but it may be not
- * managed by us.
- */
- return -EBUSY;
+ continue;
if (nid < 0)
nid = memory_add_physaddr_to_nid(info->start_addr);
[-- Attachment #2: 0002-Remove-acpi_memory_info-failed-bit.patch --]
[-- Type: text/x-patch, Size: 1843 bytes --]
acpi_memory_info has enabled bit and failed bit for controlling memory
hotplug. But we don't need to keep both bits.
The patch removes acpi_memory_info->failed bit.
Signed-off-by: yasuaki ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
---
v3 : Continue to memory hot remove when (!info->enabled) case.
v2 : Changed a based kernel from linux-3.9-rc2 to linux-pm.git/bleeding-edge.
---
drivers/acpi/acpi_memhotplug.c | 15 ++-------------
1 files changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
index ea78988..5e6301e 100644
--- a/drivers/acpi/acpi_memhotplug.c
+++ b/drivers/acpi/acpi_memhotplug.c
@@ -73,7 +73,6 @@ struct acpi_memory_info {
unsigned short caching; /* memory cache attribute */
unsigned short write_protect; /* memory read/write attribute */
unsigned int enabled:1;
- unsigned int failed:1;
};
struct acpi_memory_device {
@@ -201,10 +200,8 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
* returns -EEXIST. If add_memory() returns the other error, it
* means that this memory block is not used by the kernel.
*/
- if (result && result != -EEXIST) {
- info->failed = 1;
+ if (result && result != -EEXIST)
continue;
- }
info->enabled = 1;
@@ -238,16 +235,8 @@ static int acpi_memory_remove_memory(struct acpi_memory_device *mem_device)
nid = acpi_get_node(mem_device->device->handle);
list_for_each_entry_safe(info, n, &mem_device->res_list, list) {
- if (info->failed)
- /* The kernel does not use this memory block */
- continue;
-
if (!info->enabled)
- /*
- * The kernel uses this memory block, but it may be not
- * managed by us.
- */
- return -EBUSY;
+ continue;
if (nid < 0)
nid = memory_add_physaddr_to_nid(info->start_addr);
--
1.7.5.1
^ permalink raw reply related [flat|nested] 33+ messages in thread* [PATCH v3 2/2] ACPI,acpi_memhotplug: Remove acpi_memory_info->failed bit
@ 2013-03-22 1:53 ` Yasuaki Ishimatsu
0 siblings, 0 replies; 33+ messages in thread
From: Yasuaki Ishimatsu @ 2013-03-22 1:53 UTC (permalink / raw)
To: Toshi Kani; +Cc: rjw, linux-acpi, tangchen, wency, laijs, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1853 bytes --]
acpi_memory_info has enabled bit and failed bit for controlling memory
hotplug. But we don't need to keep both bits.
The patch removes acpi_memory_info->failed bit.
Signed-off-by: yasuaki ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
---
v3 : Continue to memory hot remove when (!info->enabled) case.
v2 : Changed a based kernel from linux-3.9-rc2 to linux-pm.git/bleeding-edge.
---
drivers/acpi/acpi_memhotplug.c | 15 ++-------------
1 files changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
index ea78988..5e6301e 100644
--- a/drivers/acpi/acpi_memhotplug.c
+++ b/drivers/acpi/acpi_memhotplug.c
@@ -73,7 +73,6 @@ struct acpi_memory_info {
unsigned short caching; /* memory cache attribute */
unsigned short write_protect; /* memory read/write attribute */
unsigned int enabled:1;
- unsigned int failed:1;
};
struct acpi_memory_device {
@@ -201,10 +200,8 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
* returns -EEXIST. If add_memory() returns the other error, it
* means that this memory block is not used by the kernel.
*/
- if (result && result != -EEXIST) {
- info->failed = 1;
+ if (result && result != -EEXIST)
continue;
- }
info->enabled = 1;
@@ -238,16 +235,8 @@ static int acpi_memory_remove_memory(struct acpi_memory_device *mem_device)
nid = acpi_get_node(mem_device->device->handle);
list_for_each_entry_safe(info, n, &mem_device->res_list, list) {
- if (info->failed)
- /* The kernel does not use this memory block */
- continue;
-
if (!info->enabled)
- /*
- * The kernel uses this memory block, but it may be not
- * managed by us.
- */
- return -EBUSY;
+ continue;
if (nid < 0)
nid = memory_add_physaddr_to_nid(info->start_addr);
[-- Attachment #2: 0002-Remove-acpi_memory_info-failed-bit.patch --]
[-- Type: text/x-patch, Size: 1843 bytes --]
acpi_memory_info has enabled bit and failed bit for controlling memory
hotplug. But we don't need to keep both bits.
The patch removes acpi_memory_info->failed bit.
Signed-off-by: yasuaki ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
---
v3 : Continue to memory hot remove when (!info->enabled) case.
v2 : Changed a based kernel from linux-3.9-rc2 to linux-pm.git/bleeding-edge.
---
drivers/acpi/acpi_memhotplug.c | 15 ++-------------
1 files changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
index ea78988..5e6301e 100644
--- a/drivers/acpi/acpi_memhotplug.c
+++ b/drivers/acpi/acpi_memhotplug.c
@@ -73,7 +73,6 @@ struct acpi_memory_info {
unsigned short caching; /* memory cache attribute */
unsigned short write_protect; /* memory read/write attribute */
unsigned int enabled:1;
- unsigned int failed:1;
};
struct acpi_memory_device {
@@ -201,10 +200,8 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
* returns -EEXIST. If add_memory() returns the other error, it
* means that this memory block is not used by the kernel.
*/
- if (result && result != -EEXIST) {
- info->failed = 1;
+ if (result && result != -EEXIST)
continue;
- }
info->enabled = 1;
@@ -238,16 +235,8 @@ static int acpi_memory_remove_memory(struct acpi_memory_device *mem_device)
nid = acpi_get_node(mem_device->device->handle);
list_for_each_entry_safe(info, n, &mem_device->res_list, list) {
- if (info->failed)
- /* The kernel does not use this memory block */
- continue;
-
if (!info->enabled)
- /*
- * The kernel uses this memory block, but it may be not
- * managed by us.
- */
- return -EBUSY;
+ continue;
if (nid < 0)
nid = memory_add_physaddr_to_nid(info->start_addr);
--
1.7.5.1
^ permalink raw reply related [flat|nested] 33+ messages in thread* Re: [PATCH v3 2/2] ACPI,acpi_memhotplug: Remove acpi_memory_info->failed bit
2013-03-22 1:53 ` Yasuaki Ishimatsu
(?)
@ 2013-03-22 20:24 ` Toshi Kani
2013-03-25 23:57 ` Yasuaki Ishimatsu
-1 siblings, 1 reply; 33+ messages in thread
From: Toshi Kani @ 2013-03-22 20:24 UTC (permalink / raw)
To: Yasuaki Ishimatsu; +Cc: rjw, linux-acpi, tangchen, wency, laijs, linux-kernel
On Fri, 2013-03-22 at 10:53 +0900, Yasuaki Ishimatsu wrote:
> acpi_memory_info has enabled bit and failed bit for controlling memory
> hotplug. But we don't need to keep both bits.
>
> The patch removes acpi_memory_info->failed bit.
>
> Signed-off-by: yasuaki ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Thanks for the update. It looks good. For the series:
Acked-by: Toshi Kani <toshi.kani@hp.com>
-Toshi
> ---
>
> v3 : Continue to memory hot remove when (!info->enabled) case.
> v2 : Changed a based kernel from linux-3.9-rc2 to linux-pm.git/bleeding-edge.
>
> ---
> drivers/acpi/acpi_memhotplug.c | 15 ++-------------
> 1 files changed, 2 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
> index ea78988..5e6301e 100644
> --- a/drivers/acpi/acpi_memhotplug.c
> +++ b/drivers/acpi/acpi_memhotplug.c
> @@ -73,7 +73,6 @@ struct acpi_memory_info {
> unsigned short caching; /* memory cache attribute */
> unsigned short write_protect; /* memory read/write attribute */
> unsigned int enabled:1;
> - unsigned int failed:1;
> };
>
> struct acpi_memory_device {
> @@ -201,10 +200,8 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
> * returns -EEXIST. If add_memory() returns the other error, it
> * means that this memory block is not used by the kernel.
> */
> - if (result && result != -EEXIST) {
> - info->failed = 1;
> + if (result && result != -EEXIST)
> continue;
> - }
>
> info->enabled = 1;
>
> @@ -238,16 +235,8 @@ static int acpi_memory_remove_memory(struct acpi_memory_device *mem_device)
> nid = acpi_get_node(mem_device->device->handle);
>
> list_for_each_entry_safe(info, n, &mem_device->res_list, list) {
> - if (info->failed)
> - /* The kernel does not use this memory block */
> - continue;
> -
> if (!info->enabled)
> - /*
> - * The kernel uses this memory block, but it may be not
> - * managed by us.
> - */
> - return -EBUSY;
> + continue;
>
> if (nid < 0)
> nid = memory_add_physaddr_to_nid(info->start_addr);
>
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [PATCH v3 2/2] ACPI,acpi_memhotplug: Remove acpi_memory_info->failed bit
2013-03-22 20:24 ` Toshi Kani
@ 2013-03-25 23:57 ` Yasuaki Ishimatsu
0 siblings, 0 replies; 33+ messages in thread
From: Yasuaki Ishimatsu @ 2013-03-25 23:57 UTC (permalink / raw)
To: Toshi Kani; +Cc: rjw, linux-acpi, tangchen, wency, laijs, linux-kernel
2013/03/23 5:24, Toshi Kani wrote:
> On Fri, 2013-03-22 at 10:53 +0900, Yasuaki Ishimatsu wrote:
>> acpi_memory_info has enabled bit and failed bit for controlling memory
>> hotplug. But we don't need to keep both bits.
>>
>> The patch removes acpi_memory_info->failed bit.
>>
>> Signed-off-by: yasuaki ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
>
> Thanks for the update. It looks good. For the series:
>
> Acked-by: Toshi Kani <toshi.kani@hp.com>
Thanks!
>
> -Toshi
>
>
>> ---
>>
>> v3 : Continue to memory hot remove when (!info->enabled) case.
>> v2 : Changed a based kernel from linux-3.9-rc2 to linux-pm.git/bleeding-edge.
>>
>> ---
>> drivers/acpi/acpi_memhotplug.c | 15 ++-------------
>> 1 files changed, 2 insertions(+), 13 deletions(-)
>>
>> diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
>> index ea78988..5e6301e 100644
>> --- a/drivers/acpi/acpi_memhotplug.c
>> +++ b/drivers/acpi/acpi_memhotplug.c
>> @@ -73,7 +73,6 @@ struct acpi_memory_info {
>> unsigned short caching; /* memory cache attribute */
>> unsigned short write_protect; /* memory read/write attribute */
>> unsigned int enabled:1;
>> - unsigned int failed:1;
>> };
>>
>> struct acpi_memory_device {
>> @@ -201,10 +200,8 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
>> * returns -EEXIST. If add_memory() returns the other error, it
>> * means that this memory block is not used by the kernel.
>> */
>> - if (result && result != -EEXIST) {
>> - info->failed = 1;
>> + if (result && result != -EEXIST)
>> continue;
>> - }
>>
>> info->enabled = 1;
>>
>> @@ -238,16 +235,8 @@ static int acpi_memory_remove_memory(struct acpi_memory_device *mem_device)
>> nid = acpi_get_node(mem_device->device->handle);
>>
>> list_for_each_entry_safe(info, n, &mem_device->res_list, list) {
>> - if (info->failed)
>> - /* The kernel does not use this memory block */
>> - continue;
>> -
>> if (!info->enabled)
>> - /*
>> - * The kernel uses this memory block, but it may be not
>> - * managed by us.
>> - */
>> - return -EBUSY;
>> + continue;
>>
>> if (nid < 0)
>> nid = memory_add_physaddr_to_nid(info->start_addr);
>>
>
>
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [PATCH v3 2/2] ACPI,acpi_memhotplug: Remove acpi_memory_info->failed bit
@ 2013-03-25 23:57 ` Yasuaki Ishimatsu
0 siblings, 0 replies; 33+ messages in thread
From: Yasuaki Ishimatsu @ 2013-03-25 23:57 UTC (permalink / raw)
To: Toshi Kani; +Cc: rjw, linux-acpi, tangchen, wency, laijs, linux-kernel
2013/03/23 5:24, Toshi Kani wrote:
> On Fri, 2013-03-22 at 10:53 +0900, Yasuaki Ishimatsu wrote:
>> acpi_memory_info has enabled bit and failed bit for controlling memory
>> hotplug. But we don't need to keep both bits.
>>
>> The patch removes acpi_memory_info->failed bit.
>>
>> Signed-off-by: yasuaki ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
>
> Thanks for the update. It looks good. For the series:
>
> Acked-by: Toshi Kani <toshi.kani@hp.com>
Thanks!
>
> -Toshi
>
>
>> ---
>>
>> v3 : Continue to memory hot remove when (!info->enabled) case.
>> v2 : Changed a based kernel from linux-3.9-rc2 to linux-pm.git/bleeding-edge.
>>
>> ---
>> drivers/acpi/acpi_memhotplug.c | 15 ++-------------
>> 1 files changed, 2 insertions(+), 13 deletions(-)
>>
>> diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
>> index ea78988..5e6301e 100644
>> --- a/drivers/acpi/acpi_memhotplug.c
>> +++ b/drivers/acpi/acpi_memhotplug.c
>> @@ -73,7 +73,6 @@ struct acpi_memory_info {
>> unsigned short caching; /* memory cache attribute */
>> unsigned short write_protect; /* memory read/write attribute */
>> unsigned int enabled:1;
>> - unsigned int failed:1;
>> };
>>
>> struct acpi_memory_device {
>> @@ -201,10 +200,8 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
>> * returns -EEXIST. If add_memory() returns the other error, it
>> * means that this memory block is not used by the kernel.
>> */
>> - if (result && result != -EEXIST) {
>> - info->failed = 1;
>> + if (result && result != -EEXIST)
>> continue;
>> - }
>>
>> info->enabled = 1;
>>
>> @@ -238,16 +235,8 @@ static int acpi_memory_remove_memory(struct acpi_memory_device *mem_device)
>> nid = acpi_get_node(mem_device->device->handle);
>>
>> list_for_each_entry_safe(info, n, &mem_device->res_list, list) {
>> - if (info->failed)
>> - /* The kernel does not use this memory block */
>> - continue;
>> -
>> if (!info->enabled)
>> - /*
>> - * The kernel uses this memory block, but it may be not
>> - * managed by us.
>> - */
>> - return -EBUSY;
>> + continue;
>>
>> if (nid < 0)
>> nid = memory_add_physaddr_to_nid(info->start_addr);
>>
>
>
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [PATCH v3 2/2] ACPI,acpi_memhotplug: Remove acpi_memory_info->failed bit
2013-03-25 23:57 ` Yasuaki Ishimatsu
(?)
@ 2013-03-26 13:41 ` Rafael J. Wysocki
2013-03-27 23:58 ` Yasuaki Ishimatsu
-1 siblings, 1 reply; 33+ messages in thread
From: Rafael J. Wysocki @ 2013-03-26 13:41 UTC (permalink / raw)
To: Yasuaki Ishimatsu
Cc: Toshi Kani, linux-acpi, tangchen, wency, laijs, linux-kernel
On Tuesday, March 26, 2013 08:57:05 AM Yasuaki Ishimatsu wrote:
> 2013/03/23 5:24, Toshi Kani wrote:
> > On Fri, 2013-03-22 at 10:53 +0900, Yasuaki Ishimatsu wrote:
> >> acpi_memory_info has enabled bit and failed bit for controlling memory
> >> hotplug. But we don't need to keep both bits.
> >>
> >> The patch removes acpi_memory_info->failed bit.
> >>
> >> Signed-off-by: yasuaki ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
> >
> > Thanks for the update. It looks good. For the series:
> >
> > Acked-by: Toshi Kani <toshi.kani@hp.com>
>
> Thanks!
Both patches applied to linux-pm.git/linux-next.
Thanks,
Rafael
> >> ---
> >>
> >> v3 : Continue to memory hot remove when (!info->enabled) case.
> >> v2 : Changed a based kernel from linux-3.9-rc2 to linux-pm.git/bleeding-edge.
> >>
> >> ---
> >> drivers/acpi/acpi_memhotplug.c | 15 ++-------------
> >> 1 files changed, 2 insertions(+), 13 deletions(-)
> >>
> >> diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
> >> index ea78988..5e6301e 100644
> >> --- a/drivers/acpi/acpi_memhotplug.c
> >> +++ b/drivers/acpi/acpi_memhotplug.c
> >> @@ -73,7 +73,6 @@ struct acpi_memory_info {
> >> unsigned short caching; /* memory cache attribute */
> >> unsigned short write_protect; /* memory read/write attribute */
> >> unsigned int enabled:1;
> >> - unsigned int failed:1;
> >> };
> >>
> >> struct acpi_memory_device {
> >> @@ -201,10 +200,8 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
> >> * returns -EEXIST. If add_memory() returns the other error, it
> >> * means that this memory block is not used by the kernel.
> >> */
> >> - if (result && result != -EEXIST) {
> >> - info->failed = 1;
> >> + if (result && result != -EEXIST)
> >> continue;
> >> - }
> >>
> >> info->enabled = 1;
> >>
> >> @@ -238,16 +235,8 @@ static int acpi_memory_remove_memory(struct acpi_memory_device *mem_device)
> >> nid = acpi_get_node(mem_device->device->handle);
> >>
> >> list_for_each_entry_safe(info, n, &mem_device->res_list, list) {
> >> - if (info->failed)
> >> - /* The kernel does not use this memory block */
> >> - continue;
> >> -
> >> if (!info->enabled)
> >> - /*
> >> - * The kernel uses this memory block, but it may be not
> >> - * managed by us.
> >> - */
> >> - return -EBUSY;
> >> + continue;
> >>
> >> if (nid < 0)
> >> nid = memory_add_physaddr_to_nid(info->start_addr);
> >>
> >
> >
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [PATCH v3 2/2] ACPI,acpi_memhotplug: Remove acpi_memory_info->failed bit
2013-03-26 13:41 ` Rafael J. Wysocki
@ 2013-03-27 23:58 ` Yasuaki Ishimatsu
0 siblings, 0 replies; 33+ messages in thread
From: Yasuaki Ishimatsu @ 2013-03-27 23:58 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Toshi Kani, linux-acpi, tangchen, wency, laijs, linux-kernel
Hi Rafael,
2013/03/26 22:41, Rafael J. Wysocki wrote:
> On Tuesday, March 26, 2013 08:57:05 AM Yasuaki Ishimatsu wrote:
>> 2013/03/23 5:24, Toshi Kani wrote:
>>> On Fri, 2013-03-22 at 10:53 +0900, Yasuaki Ishimatsu wrote:
>>>> acpi_memory_info has enabled bit and failed bit for controlling memory
>>>> hotplug. But we don't need to keep both bits.
>>>>
>>>> The patch removes acpi_memory_info->failed bit.
>>>>
>>>> Signed-off-by: yasuaki ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
>>>
>>> Thanks for the update. It looks good. For the series:
>>>
>>> Acked-by: Toshi Kani <toshi.kani@hp.com>
>>
>> Thanks!
>
> Both patches applied to linux-pm.git/linux-next.
Thank you for applying both patches.
If you don't mind, I hope these patches are merged into linux-3.9
since this is bug fix.
Thanks,
Yasuaki Ishimatsu
>
> Thanks,
> Rafael
>
>
>>>> ---
>>>>
>>>> v3 : Continue to memory hot remove when (!info->enabled) case.
>>>> v2 : Changed a based kernel from linux-3.9-rc2 to linux-pm.git/bleeding-edge.
>>>>
>>>> ---
>>>> drivers/acpi/acpi_memhotplug.c | 15 ++-------------
>>>> 1 files changed, 2 insertions(+), 13 deletions(-)
>>>>
>>>> diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
>>>> index ea78988..5e6301e 100644
>>>> --- a/drivers/acpi/acpi_memhotplug.c
>>>> +++ b/drivers/acpi/acpi_memhotplug.c
>>>> @@ -73,7 +73,6 @@ struct acpi_memory_info {
>>>> unsigned short caching; /* memory cache attribute */
>>>> unsigned short write_protect; /* memory read/write attribute */
>>>> unsigned int enabled:1;
>>>> - unsigned int failed:1;
>>>> };
>>>>
>>>> struct acpi_memory_device {
>>>> @@ -201,10 +200,8 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
>>>> * returns -EEXIST. If add_memory() returns the other error, it
>>>> * means that this memory block is not used by the kernel.
>>>> */
>>>> - if (result && result != -EEXIST) {
>>>> - info->failed = 1;
>>>> + if (result && result != -EEXIST)
>>>> continue;
>>>> - }
>>>>
>>>> info->enabled = 1;
>>>>
>>>> @@ -238,16 +235,8 @@ static int acpi_memory_remove_memory(struct acpi_memory_device *mem_device)
>>>> nid = acpi_get_node(mem_device->device->handle);
>>>>
>>>> list_for_each_entry_safe(info, n, &mem_device->res_list, list) {
>>>> - if (info->failed)
>>>> - /* The kernel does not use this memory block */
>>>> - continue;
>>>> -
>>>> if (!info->enabled)
>>>> - /*
>>>> - * The kernel uses this memory block, but it may be not
>>>> - * managed by us.
>>>> - */
>>>> - return -EBUSY;
>>>> + continue;
>>>>
>>>> if (nid < 0)
>>>> nid = memory_add_physaddr_to_nid(info->start_addr);
>>>>
>>>
>>>
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [PATCH v3 2/2] ACPI,acpi_memhotplug: Remove acpi_memory_info->failed bit
@ 2013-03-27 23:58 ` Yasuaki Ishimatsu
0 siblings, 0 replies; 33+ messages in thread
From: Yasuaki Ishimatsu @ 2013-03-27 23:58 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Toshi Kani, linux-acpi, tangchen, wency, laijs, linux-kernel
Hi Rafael,
2013/03/26 22:41, Rafael J. Wysocki wrote:
> On Tuesday, March 26, 2013 08:57:05 AM Yasuaki Ishimatsu wrote:
>> 2013/03/23 5:24, Toshi Kani wrote:
>>> On Fri, 2013-03-22 at 10:53 +0900, Yasuaki Ishimatsu wrote:
>>>> acpi_memory_info has enabled bit and failed bit for controlling memory
>>>> hotplug. But we don't need to keep both bits.
>>>>
>>>> The patch removes acpi_memory_info->failed bit.
>>>>
>>>> Signed-off-by: yasuaki ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
>>>
>>> Thanks for the update. It looks good. For the series:
>>>
>>> Acked-by: Toshi Kani <toshi.kani@hp.com>
>>
>> Thanks!
>
> Both patches applied to linux-pm.git/linux-next.
Thank you for applying both patches.
If you don't mind, I hope these patches are merged into linux-3.9
since this is bug fix.
Thanks,
Yasuaki Ishimatsu
>
> Thanks,
> Rafael
>
>
>>>> ---
>>>>
>>>> v3 : Continue to memory hot remove when (!info->enabled) case.
>>>> v2 : Changed a based kernel from linux-3.9-rc2 to linux-pm.git/bleeding-edge.
>>>>
>>>> ---
>>>> drivers/acpi/acpi_memhotplug.c | 15 ++-------------
>>>> 1 files changed, 2 insertions(+), 13 deletions(-)
>>>>
>>>> diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
>>>> index ea78988..5e6301e 100644
>>>> --- a/drivers/acpi/acpi_memhotplug.c
>>>> +++ b/drivers/acpi/acpi_memhotplug.c
>>>> @@ -73,7 +73,6 @@ struct acpi_memory_info {
>>>> unsigned short caching; /* memory cache attribute */
>>>> unsigned short write_protect; /* memory read/write attribute */
>>>> unsigned int enabled:1;
>>>> - unsigned int failed:1;
>>>> };
>>>>
>>>> struct acpi_memory_device {
>>>> @@ -201,10 +200,8 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
>>>> * returns -EEXIST. If add_memory() returns the other error, it
>>>> * means that this memory block is not used by the kernel.
>>>> */
>>>> - if (result && result != -EEXIST) {
>>>> - info->failed = 1;
>>>> + if (result && result != -EEXIST)
>>>> continue;
>>>> - }
>>>>
>>>> info->enabled = 1;
>>>>
>>>> @@ -238,16 +235,8 @@ static int acpi_memory_remove_memory(struct acpi_memory_device *mem_device)
>>>> nid = acpi_get_node(mem_device->device->handle);
>>>>
>>>> list_for_each_entry_safe(info, n, &mem_device->res_list, list) {
>>>> - if (info->failed)
>>>> - /* The kernel does not use this memory block */
>>>> - continue;
>>>> -
>>>> if (!info->enabled)
>>>> - /*
>>>> - * The kernel uses this memory block, but it may be not
>>>> - * managed by us.
>>>> - */
>>>> - return -EBUSY;
>>>> + continue;
>>>>
>>>> if (nid < 0)
>>>> nid = memory_add_physaddr_to_nid(info->start_addr);
>>>>
>>>
>>>
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [PATCH v3 2/2] ACPI,acpi_memhotplug: Remove acpi_memory_info->failed bit
2013-03-27 23:58 ` Yasuaki Ishimatsu
(?)
@ 2013-04-01 23:48 ` Rafael J. Wysocki
2013-04-02 0:12 ` Yasuaki Ishimatsu
-1 siblings, 1 reply; 33+ messages in thread
From: Rafael J. Wysocki @ 2013-04-01 23:48 UTC (permalink / raw)
To: Yasuaki Ishimatsu
Cc: Toshi Kani, linux-acpi, tangchen, wency, laijs, linux-kernel
On Thursday, March 28, 2013 08:58:03 AM Yasuaki Ishimatsu wrote:
> Hi Rafael,
>
> 2013/03/26 22:41, Rafael J. Wysocki wrote:
> > On Tuesday, March 26, 2013 08:57:05 AM Yasuaki Ishimatsu wrote:
> >> 2013/03/23 5:24, Toshi Kani wrote:
> >>> On Fri, 2013-03-22 at 10:53 +0900, Yasuaki Ishimatsu wrote:
> >>>> acpi_memory_info has enabled bit and failed bit for controlling memory
> >>>> hotplug. But we don't need to keep both bits.
> >>>>
> >>>> The patch removes acpi_memory_info->failed bit.
> >>>>
> >>>> Signed-off-by: yasuaki ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
> >>>
> >>> Thanks for the update. It looks good. For the series:
> >>>
> >>> Acked-by: Toshi Kani <toshi.kani@hp.com>
> >>
> >> Thanks!
> >
> > Both patches applied to linux-pm.git/linux-next.
>
> Thank you for applying both patches.
> If you don't mind, I hope these patches are merged into linux-3.9
> since this is bug fix.
I honestly don't think that [2/2] is 3.9 material, but I can push [1/2]
for 3.9 provided that you also regard it as material for 3.8-stable.
Thanks,
Rafael
> >>>> ---
> >>>>
> >>>> v3 : Continue to memory hot remove when (!info->enabled) case.
> >>>> v2 : Changed a based kernel from linux-3.9-rc2 to linux-pm.git/bleeding-edge.
> >>>>
> >>>> ---
> >>>> drivers/acpi/acpi_memhotplug.c | 15 ++-------------
> >>>> 1 files changed, 2 insertions(+), 13 deletions(-)
> >>>>
> >>>> diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
> >>>> index ea78988..5e6301e 100644
> >>>> --- a/drivers/acpi/acpi_memhotplug.c
> >>>> +++ b/drivers/acpi/acpi_memhotplug.c
> >>>> @@ -73,7 +73,6 @@ struct acpi_memory_info {
> >>>> unsigned short caching; /* memory cache attribute */
> >>>> unsigned short write_protect; /* memory read/write attribute */
> >>>> unsigned int enabled:1;
> >>>> - unsigned int failed:1;
> >>>> };
> >>>>
> >>>> struct acpi_memory_device {
> >>>> @@ -201,10 +200,8 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
> >>>> * returns -EEXIST. If add_memory() returns the other error, it
> >>>> * means that this memory block is not used by the kernel.
> >>>> */
> >>>> - if (result && result != -EEXIST) {
> >>>> - info->failed = 1;
> >>>> + if (result && result != -EEXIST)
> >>>> continue;
> >>>> - }
> >>>>
> >>>> info->enabled = 1;
> >>>>
> >>>> @@ -238,16 +235,8 @@ static int acpi_memory_remove_memory(struct acpi_memory_device *mem_device)
> >>>> nid = acpi_get_node(mem_device->device->handle);
> >>>>
> >>>> list_for_each_entry_safe(info, n, &mem_device->res_list, list) {
> >>>> - if (info->failed)
> >>>> - /* The kernel does not use this memory block */
> >>>> - continue;
> >>>> -
> >>>> if (!info->enabled)
> >>>> - /*
> >>>> - * The kernel uses this memory block, but it may be not
> >>>> - * managed by us.
> >>>> - */
> >>>> - return -EBUSY;
> >>>> + continue;
> >>>>
> >>>> if (nid < 0)
> >>>> nid = memory_add_physaddr_to_nid(info->start_addr);
> >>>>
> >>>
> >>>
> >>
> >>
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [PATCH v3 2/2] ACPI,acpi_memhotplug: Remove acpi_memory_info->failed bit
2013-04-01 23:48 ` Rafael J. Wysocki
@ 2013-04-02 0:12 ` Yasuaki Ishimatsu
0 siblings, 0 replies; 33+ messages in thread
From: Yasuaki Ishimatsu @ 2013-04-02 0:12 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Toshi Kani, linux-acpi, tangchen, wency, laijs, linux-kernel
Hi Rafael,
2013/04/02 8:48, Rafael J. Wysocki wrote:
> On Thursday, March 28, 2013 08:58:03 AM Yasuaki Ishimatsu wrote:
>> Hi Rafael,
>>
>> 2013/03/26 22:41, Rafael J. Wysocki wrote:
>>> On Tuesday, March 26, 2013 08:57:05 AM Yasuaki Ishimatsu wrote:
>>>> 2013/03/23 5:24, Toshi Kani wrote:
>>>>> On Fri, 2013-03-22 at 10:53 +0900, Yasuaki Ishimatsu wrote:
>>>>>> acpi_memory_info has enabled bit and failed bit for controlling memory
>>>>>> hotplug. But we don't need to keep both bits.
>>>>>>
>>>>>> The patch removes acpi_memory_info->failed bit.
>>>>>>
>>>>>> Signed-off-by: yasuaki ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
>>>>>
>>>>> Thanks for the update. It looks good. For the series:
>>>>>
>>>>> Acked-by: Toshi Kani <toshi.kani@hp.com>
>>>>
>>>> Thanks!
>>>
>>> Both patches applied to linux-pm.git/linux-next.
>>
>> Thank you for applying both patches.
>> If you don't mind, I hope these patches are merged into linux-3.9
>> since this is bug fix.
>
> I honestly don't think that [2/2] is 3.9 material, but I can push [1/2]
> for 3.9 provided that you also regard it as material for 3.8-stable.
linux-3.8 does not support physical memory hot remove. It has been supported
since linux-3.9. So I don't need [1/2] patch to linux-3.8 but need it to
linux-3.9. So please push [1/2] patch to linux-3.9.
Thanks,
Yasuaki Ishimatsu
>
> Thanks,
> Rafael
>
>
>>>>>> ---
>>>>>>
>>>>>> v3 : Continue to memory hot remove when (!info->enabled) case.
>>>>>> v2 : Changed a based kernel from linux-3.9-rc2 to linux-pm.git/bleeding-edge.
>>>>>>
>>>>>> ---
>>>>>> drivers/acpi/acpi_memhotplug.c | 15 ++-------------
>>>>>> 1 files changed, 2 insertions(+), 13 deletions(-)
>>>>>>
>>>>>> diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
>>>>>> index ea78988..5e6301e 100644
>>>>>> --- a/drivers/acpi/acpi_memhotplug.c
>>>>>> +++ b/drivers/acpi/acpi_memhotplug.c
>>>>>> @@ -73,7 +73,6 @@ struct acpi_memory_info {
>>>>>> unsigned short caching; /* memory cache attribute */
>>>>>> unsigned short write_protect; /* memory read/write attribute */
>>>>>> unsigned int enabled:1;
>>>>>> - unsigned int failed:1;
>>>>>> };
>>>>>>
>>>>>> struct acpi_memory_device {
>>>>>> @@ -201,10 +200,8 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
>>>>>> * returns -EEXIST. If add_memory() returns the other error, it
>>>>>> * means that this memory block is not used by the kernel.
>>>>>> */
>>>>>> - if (result && result != -EEXIST) {
>>>>>> - info->failed = 1;
>>>>>> + if (result && result != -EEXIST)
>>>>>> continue;
>>>>>> - }
>>>>>>
>>>>>> info->enabled = 1;
>>>>>>
>>>>>> @@ -238,16 +235,8 @@ static int acpi_memory_remove_memory(struct acpi_memory_device *mem_device)
>>>>>> nid = acpi_get_node(mem_device->device->handle);
>>>>>>
>>>>>> list_for_each_entry_safe(info, n, &mem_device->res_list, list) {
>>>>>> - if (info->failed)
>>>>>> - /* The kernel does not use this memory block */
>>>>>> - continue;
>>>>>> -
>>>>>> if (!info->enabled)
>>>>>> - /*
>>>>>> - * The kernel uses this memory block, but it may be not
>>>>>> - * managed by us.
>>>>>> - */
>>>>>> - return -EBUSY;
>>>>>> + continue;
>>>>>>
>>>>>> if (nid < 0)
>>>>>> nid = memory_add_physaddr_to_nid(info->start_addr);
>>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
>>>> the body of a message to majordomo@vger.kernel.org
>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [PATCH v3 2/2] ACPI,acpi_memhotplug: Remove acpi_memory_info->failed bit
@ 2013-04-02 0:12 ` Yasuaki Ishimatsu
0 siblings, 0 replies; 33+ messages in thread
From: Yasuaki Ishimatsu @ 2013-04-02 0:12 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Toshi Kani, linux-acpi, tangchen, wency, laijs, linux-kernel
Hi Rafael,
2013/04/02 8:48, Rafael J. Wysocki wrote:
> On Thursday, March 28, 2013 08:58:03 AM Yasuaki Ishimatsu wrote:
>> Hi Rafael,
>>
>> 2013/03/26 22:41, Rafael J. Wysocki wrote:
>>> On Tuesday, March 26, 2013 08:57:05 AM Yasuaki Ishimatsu wrote:
>>>> 2013/03/23 5:24, Toshi Kani wrote:
>>>>> On Fri, 2013-03-22 at 10:53 +0900, Yasuaki Ishimatsu wrote:
>>>>>> acpi_memory_info has enabled bit and failed bit for controlling memory
>>>>>> hotplug. But we don't need to keep both bits.
>>>>>>
>>>>>> The patch removes acpi_memory_info->failed bit.
>>>>>>
>>>>>> Signed-off-by: yasuaki ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
>>>>>
>>>>> Thanks for the update. It looks good. For the series:
>>>>>
>>>>> Acked-by: Toshi Kani <toshi.kani@hp.com>
>>>>
>>>> Thanks!
>>>
>>> Both patches applied to linux-pm.git/linux-next.
>>
>> Thank you for applying both patches.
>> If you don't mind, I hope these patches are merged into linux-3.9
>> since this is bug fix.
>
> I honestly don't think that [2/2] is 3.9 material, but I can push [1/2]
> for 3.9 provided that you also regard it as material for 3.8-stable.
linux-3.8 does not support physical memory hot remove. It has been supported
since linux-3.9. So I don't need [1/2] patch to linux-3.8 but need it to
linux-3.9. So please push [1/2] patch to linux-3.9.
Thanks,
Yasuaki Ishimatsu
>
> Thanks,
> Rafael
>
>
>>>>>> ---
>>>>>>
>>>>>> v3 : Continue to memory hot remove when (!info->enabled) case.
>>>>>> v2 : Changed a based kernel from linux-3.9-rc2 to linux-pm.git/bleeding-edge.
>>>>>>
>>>>>> ---
>>>>>> drivers/acpi/acpi_memhotplug.c | 15 ++-------------
>>>>>> 1 files changed, 2 insertions(+), 13 deletions(-)
>>>>>>
>>>>>> diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
>>>>>> index ea78988..5e6301e 100644
>>>>>> --- a/drivers/acpi/acpi_memhotplug.c
>>>>>> +++ b/drivers/acpi/acpi_memhotplug.c
>>>>>> @@ -73,7 +73,6 @@ struct acpi_memory_info {
>>>>>> unsigned short caching; /* memory cache attribute */
>>>>>> unsigned short write_protect; /* memory read/write attribute */
>>>>>> unsigned int enabled:1;
>>>>>> - unsigned int failed:1;
>>>>>> };
>>>>>>
>>>>>> struct acpi_memory_device {
>>>>>> @@ -201,10 +200,8 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
>>>>>> * returns -EEXIST. If add_memory() returns the other error, it
>>>>>> * means that this memory block is not used by the kernel.
>>>>>> */
>>>>>> - if (result && result != -EEXIST) {
>>>>>> - info->failed = 1;
>>>>>> + if (result && result != -EEXIST)
>>>>>> continue;
>>>>>> - }
>>>>>>
>>>>>> info->enabled = 1;
>>>>>>
>>>>>> @@ -238,16 +235,8 @@ static int acpi_memory_remove_memory(struct acpi_memory_device *mem_device)
>>>>>> nid = acpi_get_node(mem_device->device->handle);
>>>>>>
>>>>>> list_for_each_entry_safe(info, n, &mem_device->res_list, list) {
>>>>>> - if (info->failed)
>>>>>> - /* The kernel does not use this memory block */
>>>>>> - continue;
>>>>>> -
>>>>>> if (!info->enabled)
>>>>>> - /*
>>>>>> - * The kernel uses this memory block, but it may be not
>>>>>> - * managed by us.
>>>>>> - */
>>>>>> - return -EBUSY;
>>>>>> + continue;
>>>>>>
>>>>>> if (nid < 0)
>>>>>> nid = memory_add_physaddr_to_nid(info->start_addr);
>>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
>>>> the body of a message to majordomo@vger.kernel.org
>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [PATCH v3 2/2] ACPI,acpi_memhotplug: Remove acpi_memory_info->failed bit
2013-04-02 0:12 ` Yasuaki Ishimatsu
(?)
@ 2013-04-02 12:57 ` Rafael J. Wysocki
2013-04-02 23:55 ` Yasuaki Ishimatsu
-1 siblings, 1 reply; 33+ messages in thread
From: Rafael J. Wysocki @ 2013-04-02 12:57 UTC (permalink / raw)
To: Yasuaki Ishimatsu
Cc: Toshi Kani, linux-acpi, tangchen, wency, laijs, linux-kernel
On Tuesday, April 02, 2013 09:12:44 AM Yasuaki Ishimatsu wrote:
> Hi Rafael,
>
> 2013/04/02 8:48, Rafael J. Wysocki wrote:
> > On Thursday, March 28, 2013 08:58:03 AM Yasuaki Ishimatsu wrote:
> >> Hi Rafael,
> >>
> >> 2013/03/26 22:41, Rafael J. Wysocki wrote:
> >>> On Tuesday, March 26, 2013 08:57:05 AM Yasuaki Ishimatsu wrote:
> >>>> 2013/03/23 5:24, Toshi Kani wrote:
> >>>>> On Fri, 2013-03-22 at 10:53 +0900, Yasuaki Ishimatsu wrote:
> >>>>>> acpi_memory_info has enabled bit and failed bit for controlling memory
> >>>>>> hotplug. But we don't need to keep both bits.
> >>>>>>
> >>>>>> The patch removes acpi_memory_info->failed bit.
> >>>>>>
> >>>>>> Signed-off-by: yasuaki ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
> >>>>>
> >>>>> Thanks for the update. It looks good. For the series:
> >>>>>
> >>>>> Acked-by: Toshi Kani <toshi.kani@hp.com>
> >>>>
> >>>> Thanks!
> >>>
> >>> Both patches applied to linux-pm.git/linux-next.
> >>
> >> Thank you for applying both patches.
> >> If you don't mind, I hope these patches are merged into linux-3.9
> >> since this is bug fix.
> >
> > I honestly don't think that [2/2] is 3.9 material, but I can push [1/2]
> > for 3.9 provided that you also regard it as material for 3.8-stable.
>
> linux-3.8 does not support physical memory hot remove. It has been supported
> since linux-3.9. So I don't need [1/2] patch to linux-3.8 but need it to
> linux-3.9. So please push [1/2] patch to linux-3.9.
Well, I don't think it would be a good idea to push that patch for 3.9 so late
in the cycle. Yes, it would make memory hotplug work in 3.9, but that might
surprise some people and cause problems to happen as a result and we wouldn't
have the time to address them before the 3.9 release.
If that's not a big problem, I'd prefer to defer that patch until the 3.10
merge window is open (which is just about 2 weeks from now) and if need be we
can still push it for 3.9-stable afterward.
Thanks,
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH v3 2/2] ACPI,acpi_memhotplug: Remove acpi_memory_info->failed bit
2013-04-02 12:57 ` Rafael J. Wysocki
@ 2013-04-02 23:55 ` Yasuaki Ishimatsu
0 siblings, 0 replies; 33+ messages in thread
From: Yasuaki Ishimatsu @ 2013-04-02 23:55 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Toshi Kani, linux-acpi, tangchen, wency, laijs, linux-kernel
Hi Rafael,
2013/04/02 21:57, Rafael J. Wysocki wrote:
> On Tuesday, April 02, 2013 09:12:44 AM Yasuaki Ishimatsu wrote:
>> Hi Rafael,
>>
>> 2013/04/02 8:48, Rafael J. Wysocki wrote:
>>> On Thursday, March 28, 2013 08:58:03 AM Yasuaki Ishimatsu wrote:
>>>> Hi Rafael,
>>>>
>>>> 2013/03/26 22:41, Rafael J. Wysocki wrote:
>>>>> On Tuesday, March 26, 2013 08:57:05 AM Yasuaki Ishimatsu wrote:
>>>>>> 2013/03/23 5:24, Toshi Kani wrote:
>>>>>>> On Fri, 2013-03-22 at 10:53 +0900, Yasuaki Ishimatsu wrote:
>>>>>>>> acpi_memory_info has enabled bit and failed bit for controlling memory
>>>>>>>> hotplug. But we don't need to keep both bits.
>>>>>>>>
>>>>>>>> The patch removes acpi_memory_info->failed bit.
>>>>>>>>
>>>>>>>> Signed-off-by: yasuaki ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
>>>>>>>
>>>>>>> Thanks for the update. It looks good. For the series:
>>>>>>>
>>>>>>> Acked-by: Toshi Kani <toshi.kani@hp.com>
>>>>>>
>>>>>> Thanks!
>>>>>
>>>>> Both patches applied to linux-pm.git/linux-next.
>>>>
>>>> Thank you for applying both patches.
>>>> If you don't mind, I hope these patches are merged into linux-3.9
>>>> since this is bug fix.
>>>
>>> I honestly don't think that [2/2] is 3.9 material, but I can push [1/2]
>>> for 3.9 provided that you also regard it as material for 3.8-stable.
>>
>> linux-3.8 does not support physical memory hot remove. It has been supported
>> since linux-3.9. So I don't need [1/2] patch to linux-3.8 but need it to
>> linux-3.9. So please push [1/2] patch to linux-3.9.
>
> Well, I don't think it would be a good idea to push that patch for 3.9 so late
> in the cycle. Yes, it would make memory hotplug work in 3.9, but that might
> surprise some people and cause problems to happen as a result and we wouldn't
> have the time to address them before the 3.9 release.
>
> If that's not a big problem, I'd prefer to defer that patch until the 3.10
> merge window is open (which is just about 2 weeks from now) and if need be we
> can still push it for 3.9-stable afterward.
Sorry for bothering you by my mention.
I understood your thought. Please merge this patch to 3.10 and push if for
3.9-stable.
Thanks,
Yasuaki Ishimatsu
>
> Thanks,
> Rafael
>
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH v3 2/2] ACPI,acpi_memhotplug: Remove acpi_memory_info->failed bit
@ 2013-04-02 23:55 ` Yasuaki Ishimatsu
0 siblings, 0 replies; 33+ messages in thread
From: Yasuaki Ishimatsu @ 2013-04-02 23:55 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Toshi Kani, linux-acpi, tangchen, wency, laijs, linux-kernel
Hi Rafael,
2013/04/02 21:57, Rafael J. Wysocki wrote:
> On Tuesday, April 02, 2013 09:12:44 AM Yasuaki Ishimatsu wrote:
>> Hi Rafael,
>>
>> 2013/04/02 8:48, Rafael J. Wysocki wrote:
>>> On Thursday, March 28, 2013 08:58:03 AM Yasuaki Ishimatsu wrote:
>>>> Hi Rafael,
>>>>
>>>> 2013/03/26 22:41, Rafael J. Wysocki wrote:
>>>>> On Tuesday, March 26, 2013 08:57:05 AM Yasuaki Ishimatsu wrote:
>>>>>> 2013/03/23 5:24, Toshi Kani wrote:
>>>>>>> On Fri, 2013-03-22 at 10:53 +0900, Yasuaki Ishimatsu wrote:
>>>>>>>> acpi_memory_info has enabled bit and failed bit for controlling memory
>>>>>>>> hotplug. But we don't need to keep both bits.
>>>>>>>>
>>>>>>>> The patch removes acpi_memory_info->failed bit.
>>>>>>>>
>>>>>>>> Signed-off-by: yasuaki ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
>>>>>>>
>>>>>>> Thanks for the update. It looks good. For the series:
>>>>>>>
>>>>>>> Acked-by: Toshi Kani <toshi.kani@hp.com>
>>>>>>
>>>>>> Thanks!
>>>>>
>>>>> Both patches applied to linux-pm.git/linux-next.
>>>>
>>>> Thank you for applying both patches.
>>>> If you don't mind, I hope these patches are merged into linux-3.9
>>>> since this is bug fix.
>>>
>>> I honestly don't think that [2/2] is 3.9 material, but I can push [1/2]
>>> for 3.9 provided that you also regard it as material for 3.8-stable.
>>
>> linux-3.8 does not support physical memory hot remove. It has been supported
>> since linux-3.9. So I don't need [1/2] patch to linux-3.8 but need it to
>> linux-3.9. So please push [1/2] patch to linux-3.9.
>
> Well, I don't think it would be a good idea to push that patch for 3.9 so late
> in the cycle. Yes, it would make memory hotplug work in 3.9, but that might
> surprise some people and cause problems to happen as a result and we wouldn't
> have the time to address them before the 3.9 release.
>
> If that's not a big problem, I'd prefer to defer that patch until the 3.10
> merge window is open (which is just about 2 weeks from now) and if need be we
> can still push it for 3.9-stable afterward.
Sorry for bothering you by my mention.
I understood your thought. Please merge this patch to 3.10 and push if for
3.9-stable.
Thanks,
Yasuaki Ishimatsu
>
> Thanks,
> Rafael
>
>
^ permalink raw reply [flat|nested] 33+ messages in thread