* [PATCH] ARM: autcpu12: Fix config check in autcpu12_init_late()
@ 2013-03-22 21:35 Ben Hutchings
2013-03-23 5:22 ` Alexander Shiyan
0 siblings, 1 reply; 5+ messages in thread
From: Ben Hutchings @ 2013-03-22 21:35 UTC (permalink / raw)
To: linux-arm-kernel
The 'CONFIG_' prefix is not implicit in IS_ENABLED().
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Alexander Shiyan <shc_work@mail.ru>
Cc: Olof Johansson <olof@lixom.net>
Cc: Paul Bolle <pebolle@tiscali.nl>
Cc: <stable@vger.kernel.org> # 3.8+
---
Found by inspection. This is not even compile-tested.
Ben.
arch/arm/mach-clps711x/board-autcpu12.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-clps711x/board-autcpu12.c b/arch/arm/mach-clps711x/board-autcpu12.c
index f385847..8138523 100644
--- a/arch/arm/mach-clps711x/board-autcpu12.c
+++ b/arch/arm/mach-clps711x/board-autcpu12.c
@@ -158,7 +158,8 @@ static void __init autcpu12_init(void)
static void __init autcpu12_init_late(void)
{
- if (IS_ENABLED(MTD_NAND_GPIO) && IS_ENABLED(GPIO_GENERIC_PLATFORM)) {
+ if (IS_ENABLED(CONFIG_MTD_NAND_GPIO) &&
+ IS_ENABLED(CONFIG_GPIO_GENERIC_PLATFORM)) {
/* We are need both drivers to handle NAND */
platform_device_register(&autcpu12_nand_pdev);
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130322/1bd4af3f/attachment.sig>
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: autcpu12: Fix config check in autcpu12_init_late()
2013-03-22 21:35 [PATCH] ARM: autcpu12: Fix config check in autcpu12_init_late() Ben Hutchings
@ 2013-03-23 5:22 ` Alexander Shiyan
2013-04-02 17:12 ` Olof Johansson
0 siblings, 1 reply; 5+ messages in thread
From: Alexander Shiyan @ 2013-03-23 5:22 UTC (permalink / raw)
To: linux-arm-kernel
> The 'CONFIG_' prefix is not implicit in IS_ENABLED().
>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> Cc: Alexander Shiyan <shc_work@mail.ru>
> Cc: Olof Johansson <olof@lixom.net>
> Cc: Paul Bolle <pebolle@tiscali.nl>
> Cc: <stable@vger.kernel.org> # 3.8+
> ---
> Found by inspection. This is not even compile-tested.
>
> Ben.
>
> arch/arm/mach-clps711x/board-autcpu12.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-clps711x/board-autcpu12.c b/arch/arm/mach-clps711x/board-autcpu12.c
> index f385847..8138523 100644
> --- a/arch/arm/mach-clps711x/board-autcpu12.c
> +++ b/arch/arm/mach-clps711x/board-autcpu12.c
> @@ -158,7 +158,8 @@ static void __init autcpu12_init(void)
>
> static void __init autcpu12_init_late(void)
> {
> - if (IS_ENABLED(MTD_NAND_GPIO) && IS_ENABLED(GPIO_GENERIC_PLATFORM)) {
> + if (IS_ENABLED(CONFIG_MTD_NAND_GPIO) &&
> + IS_ENABLED(CONFIG_GPIO_GENERIC_PLATFORM)) {
> /* We are need both drivers to handle NAND */
> platform_device_register(&autcpu12_nand_pdev);
> }
Oops. Right.
And I think checks can be removed completely.
---
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: autcpu12: Fix config check in autcpu12_init_late()
2013-03-23 5:22 ` Alexander Shiyan
@ 2013-04-02 17:12 ` Olof Johansson
2013-04-03 2:53 ` Ben Hutchings
2013-04-03 6:57 ` Alexander Shiyan
0 siblings, 2 replies; 5+ messages in thread
From: Olof Johansson @ 2013-04-02 17:12 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Mar 23, 2013 at 09:22:20AM +0400, Alexander Shiyan wrote:
> > The 'CONFIG_' prefix is not implicit in IS_ENABLED().
> >
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > Cc: Alexander Shiyan <shc_work@mail.ru>
> > Cc: Olof Johansson <olof@lixom.net>
> > Cc: Paul Bolle <pebolle@tiscali.nl>
> > Cc: <stable@vger.kernel.org> # 3.8+
> > ---
> > Found by inspection. This is not even compile-tested.
> >
> > Ben.
> >
> > arch/arm/mach-clps711x/board-autcpu12.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/mach-clps711x/board-autcpu12.c b/arch/arm/mach-clps711x/board-autcpu12.c
> > index f385847..8138523 100644
> > --- a/arch/arm/mach-clps711x/board-autcpu12.c
> > +++ b/arch/arm/mach-clps711x/board-autcpu12.c
> > @@ -158,7 +158,8 @@ static void __init autcpu12_init(void)
> >
> > static void __init autcpu12_init_late(void)
> > {
> > - if (IS_ENABLED(MTD_NAND_GPIO) && IS_ENABLED(GPIO_GENERIC_PLATFORM)) {
> > + if (IS_ENABLED(CONFIG_MTD_NAND_GPIO) &&
> > + IS_ENABLED(CONFIG_GPIO_GENERIC_PLATFORM)) {
> > /* We are need both drivers to handle NAND */
> > platform_device_register(&autcpu12_nand_pdev);
> > }
>
> Oops. Right.
> And I think checks can be removed completely.
Seems reasonable -- there's no reason to hold off registering the device just
because the driver isn't enabled.
Who'll repost a patch to just remove the tests? Ben? Alexander?
-Olof
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: autcpu12: Fix config check in autcpu12_init_late()
2013-04-02 17:12 ` Olof Johansson
@ 2013-04-03 2:53 ` Ben Hutchings
2013-04-03 6:57 ` Alexander Shiyan
1 sibling, 0 replies; 5+ messages in thread
From: Ben Hutchings @ 2013-04-03 2:53 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 2013-04-02 at 10:12 -0700, Olof Johansson wrote:
> On Sat, Mar 23, 2013 at 09:22:20AM +0400, Alexander Shiyan wrote:
> > > The 'CONFIG_' prefix is not implicit in IS_ENABLED().
> > >
> > > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > > Cc: Alexander Shiyan <shc_work@mail.ru>
> > > Cc: Olof Johansson <olof@lixom.net>
> > > Cc: Paul Bolle <pebolle@tiscali.nl>
> > > Cc: <stable@vger.kernel.org> # 3.8+
> > > ---
> > > Found by inspection. This is not even compile-tested.
> > >
> > > Ben.
> > >
> > > arch/arm/mach-clps711x/board-autcpu12.c | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm/mach-clps711x/board-autcpu12.c b/arch/arm/mach-clps711x/board-autcpu12.c
> > > index f385847..8138523 100644
> > > --- a/arch/arm/mach-clps711x/board-autcpu12.c
> > > +++ b/arch/arm/mach-clps711x/board-autcpu12.c
> > > @@ -158,7 +158,8 @@ static void __init autcpu12_init(void)
> > >
> > > static void __init autcpu12_init_late(void)
> > > {
> > > - if (IS_ENABLED(MTD_NAND_GPIO) && IS_ENABLED(GPIO_GENERIC_PLATFORM)) {
> > > + if (IS_ENABLED(CONFIG_MTD_NAND_GPIO) &&
> > > + IS_ENABLED(CONFIG_GPIO_GENERIC_PLATFORM)) {
> > > /* We are need both drivers to handle NAND */
> > > platform_device_register(&autcpu12_nand_pdev);
> > > }
> >
> > Oops. Right.
> > And I think checks can be removed completely.
>
> Seems reasonable -- there's no reason to hold off registering the device just
> because the driver isn't enabled.
>
> Who'll repost a patch to just remove the tests? Ben? Alexander?
I won't - I don't know anything about this code other than it's spelt
wrong.
Ben.
--
Ben Hutchings
Power corrupts. Absolute power is kind of neat.
- John Lehman, Secretary of the US Navy 1981-1987
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130403/4f0c7b9c/attachment.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: autcpu12: Fix config check in autcpu12_init_late()
2013-04-02 17:12 ` Olof Johansson
2013-04-03 2:53 ` Ben Hutchings
@ 2013-04-03 6:57 ` Alexander Shiyan
1 sibling, 0 replies; 5+ messages in thread
From: Alexander Shiyan @ 2013-04-03 6:57 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
> On Sat, Mar 23, 2013 at 09:22:20AM +0400, Alexander Shiyan wrote:
> > > The 'CONFIG_' prefix is not implicit in IS_ENABLED().
> > >
> > > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > > Cc: Alexander Shiyan <shc_work@mail.ru>
> > > Cc: Olof Johansson <olof@lixom.net>
> > > Cc: Paul Bolle <pebolle@tiscali.nl>
> > > Cc: <stable@vger.kernel.org> # 3.8+
> > > ---
> > > Found by inspection. This is not even compile-tested.
> > >
> > > Ben.
> > >
> > > arch/arm/mach-clps711x/board-autcpu12.c | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm/mach-clps711x/board-autcpu12.c b/arch/arm/mach-clps711x/board-autcpu12.c
> > > index f385847..8138523 100644
> > > --- a/arch/arm/mach-clps711x/board-autcpu12.c
> > > +++ b/arch/arm/mach-clps711x/board-autcpu12.c
> > > @@ -158,7 +158,8 @@ static void __init autcpu12_init(void)
> > >
> > > static void __init autcpu12_init_late(void)
> > > {
> > > - if (IS_ENABLED(MTD_NAND_GPIO) && IS_ENABLED(GPIO_GENERIC_PLATFORM)) {
> > > + if (IS_ENABLED(CONFIG_MTD_NAND_GPIO) &&
> > > + IS_ENABLED(CONFIG_GPIO_GENERIC_PLATFORM)) {
> > > /* We are need both drivers to handle NAND */
> > > platform_device_register(&autcpu12_nand_pdev);
> > > }
> >
> > Oops. Right.
> > And I think checks can be removed completely.
>
> Seems reasonable -- there's no reason to hold off registering the device just
> because the driver isn't enabled.
>
> Who'll repost a patch to just remove the tests? Ben? Alexander?
Please apply the patch just yet. I will keep in mind this change.
Thanks.
---
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-04-03 6:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-22 21:35 [PATCH] ARM: autcpu12: Fix config check in autcpu12_init_late() Ben Hutchings
2013-03-23 5:22 ` Alexander Shiyan
2013-04-02 17:12 ` Olof Johansson
2013-04-03 2:53 ` Ben Hutchings
2013-04-03 6:57 ` Alexander Shiyan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.