All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: David Miller <davem@davemloft.net>
Cc: <khc@pm.waw.pl>, <netdev@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <c.aeschlimann@acn-group.ch>
Subject: Re: [PATCH] Fix IXP4xx coherent allocations
Date: Sun, 24 Mar 2013 19:11:07 +0000	[thread overview]
Message-ID: <1364152267.3620.31.camel@deadeye.wl.decadent.org.uk> (raw)
In-Reply-To: <20130323.195740.2108147521543354261.davem@davemloft.net>

On Sat, 2013-03-23 at 19:57 -0400, David Miller wrote:
> From: Krzysztof Halasa <khc@pm.waw.pl>
> Date: Sat, 23 Mar 2013 20:35:46 +0100
> 
> > ARM core code currently requires coherent DMA mask to be set. Make sure
> > we limit PCI devices to 64 MiB while allowing on-chip devices to access
> > the whole 4 GiB address space.
> > 
> > This fixes a v3.7+ regression which broke IXP4xx built-in network devices.
> > 
> > Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
> 
> This requirement is not reasonable.
> 
> The DMA API documentation clearly states what the default must be,
> and what drivers are guarenteed will be the default.

I'm failing to see where it says the default can't be narrower than 32
bits due to platform limits.  And how do you think DMA mapping is
supposed to work for PCI devices on these platforms, anyway?

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.


WARNING: multiple messages have this Message-ID (diff)
From: bhutchings@solarflare.com (Ben Hutchings)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Fix IXP4xx coherent allocations
Date: Sun, 24 Mar 2013 19:11:07 +0000	[thread overview]
Message-ID: <1364152267.3620.31.camel@deadeye.wl.decadent.org.uk> (raw)
In-Reply-To: <20130323.195740.2108147521543354261.davem@davemloft.net>

On Sat, 2013-03-23 at 19:57 -0400, David Miller wrote:
> From: Krzysztof Halasa <khc@pm.waw.pl>
> Date: Sat, 23 Mar 2013 20:35:46 +0100
> 
> > ARM core code currently requires coherent DMA mask to be set. Make sure
> > we limit PCI devices to 64 MiB while allowing on-chip devices to access
> > the whole 4 GiB address space.
> > 
> > This fixes a v3.7+ regression which broke IXP4xx built-in network devices.
> > 
> > Signed-off-by: Krzysztof Ha?asa <khc@pm.waw.pl>
> 
> This requirement is not reasonable.
> 
> The DMA API documentation clearly states what the default must be,
> and what drivers are guarenteed will be the default.

I'm failing to see where it says the default can't be narrower than 32
bits due to platform limits.  And how do you think DMA mapping is
supposed to work for PCI devices on these platforms, anyway?

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

  reply	other threads:[~2013-03-24 19:11 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-23 19:35 [PATCH] Fix IXP4xx coherent allocations Krzysztof Halasa
2013-03-23 19:35 ` Krzysztof Halasa
2013-03-23 23:57 ` David Miller
2013-03-23 23:57   ` David Miller
2013-03-24 19:11   ` Ben Hutchings [this message]
2013-03-24 19:11     ` Ben Hutchings
2013-03-24 21:15     ` Krzysztof Halasa
2013-03-24 21:15       ` Krzysztof Halasa
2013-03-30 13:29       ` Russell King - ARM Linux
2013-03-30 13:29         ` Russell King - ARM Linux
2013-03-30 14:22         ` Krzysztof Halasa
2013-03-30 14:22           ` Krzysztof Halasa
2013-03-30 15:31           ` Russell King - ARM Linux
2013-03-30 15:31             ` Russell King - ARM Linux
2013-04-01 20:17             ` Krzysztof Halasa
2013-04-01 20:17               ` Krzysztof Halasa
2013-04-02  0:40               ` Ben Hutchings
2013-04-02  0:40                 ` Ben Hutchings
2013-03-30 13:18   ` Krzysztof Halasa
2013-03-30 13:18     ` Krzysztof Halasa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1364152267.3620.31.camel@deadeye.wl.decadent.org.uk \
    --to=bhutchings@solarflare.com \
    --cc=c.aeschlimann@acn-group.ch \
    --cc=davem@davemloft.net \
    --cc=khc@pm.waw.pl \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.