* [PATCH 3.8-stable] r8169: fix auto speed down issue
@ 2013-04-07 2:17 Jonghwan Choi
2013-04-08 9:21 ` hayeswang
0 siblings, 1 reply; 3+ messages in thread
From: Jonghwan Choi @ 2013-04-07 2:17 UTC (permalink / raw)
To: Realtek linux nic maintainers, hayeswang
Cc: stable, netdev, David S. Miller, Jonghwan Choi
From: hayeswang <hayeswang@realtek.com>
This patch looks like it should be in the 3.8-stable tree, should we apply
it?
------------------
From: "hayeswang <hayeswang@realtek.com>"
commit e2409d83434d77874b461b78af6a19cd6e6a1280 upstream
It would cause no link after suspending or shutdowning when the
nic changes the speed to 10M and connects to a link partner which
forces the speed to 100M.
Check the link partner ability to determine which speed to set.
Signed-off-by: Hayes Wang <hayeswang@realtek.com>
Acked-by: Francois Romieu <romieu@fr.zoreil.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
---
drivers/net/ethernet/realtek/r8169.c | 28 +++++++++++++++++++++++++---
1 file changed, 25 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 998974f..2d849da 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -3819,6 +3819,30 @@ static void rtl_init_mdio_ops(struct rtl8169_private *tp)
}
}
+static void rtl_speed_down(struct rtl8169_private *tp)
+{
+ u32 adv;
+ int lpa;
+
+ rtl_writephy(tp, 0x1f, 0x0000);
+ lpa = rtl_readphy(tp, MII_LPA);
+
+ if (lpa & (LPA_10HALF | LPA_10FULL))
+ adv = ADVERTISED_10baseT_Half | ADVERTISED_10baseT_Full;
+ else if (lpa & (LPA_100HALF | LPA_100FULL))
+ adv = ADVERTISED_10baseT_Half | ADVERTISED_10baseT_Full |
+ ADVERTISED_100baseT_Half | ADVERTISED_100baseT_Full;
+ else
+ adv = ADVERTISED_10baseT_Half | ADVERTISED_10baseT_Full |
+ ADVERTISED_100baseT_Half | ADVERTISED_100baseT_Full |
+ (tp->mii.supports_gmii ?
+ ADVERTISED_1000baseT_Half |
+ ADVERTISED_1000baseT_Full : 0);
+
+ rtl8169_set_speed(tp->dev, AUTONEG_ENABLE, SPEED_1000, DUPLEX_FULL,
+ adv);
+}
+
static void rtl_wol_suspend_quirk(struct rtl8169_private *tp)
{
void __iomem *ioaddr = tp->mmio_addr;
@@ -3849,9 +3873,7 @@ static bool rtl_wol_pll_power_down(struct rtl8169_private *tp)
if (!(__rtl8169_get_wol(tp) & WAKE_ANY))
return false;
- rtl_writephy(tp, 0x1f, 0x0000);
- rtl_writephy(tp, MII_BMCR, 0x0000);
-
+ rtl_speed_down(tp);
rtl_wol_suspend_quirk(tp);
return true;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH 3.8-stable] r8169: fix auto speed down issue
2013-04-07 2:17 [PATCH 3.8-stable] r8169: fix auto speed down issue Jonghwan Choi
@ 2013-04-08 9:21 ` hayeswang
2013-04-11 12:34 ` Luis Henriques
0 siblings, 1 reply; 3+ messages in thread
From: hayeswang @ 2013-04-08 9:21 UTC (permalink / raw)
To: 'Jonghwan Choi', 'nic_swsd'
Cc: stable, netdev, 'David S. Miller', 'Jonghwan Choi'
From: Jonghwan Choi [mailto:jhbird.choi@gmail.com]
[...]
> This patch looks like it should be in the 3.8-stable tree,
> should we apply it?
Yes.
Best Regards,
Hayes
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 3.8-stable] r8169: fix auto speed down issue
2013-04-08 9:21 ` hayeswang
@ 2013-04-11 12:34 ` Luis Henriques
0 siblings, 0 replies; 3+ messages in thread
From: Luis Henriques @ 2013-04-11 12:34 UTC (permalink / raw)
To: hayeswang
Cc: 'Jonghwan Choi', 'nic_swsd',
stable, netdev, 'David S. Miller',
'Jonghwan Choi'
On Mon, Apr 08, 2013 at 05:21:23PM +0800, hayeswang wrote:
> From: Jonghwan Choi [mailto:jhbird.choi@gmail.com]
> [...]
> > This patch looks like it should be in the 3.8-stable tree,
> > should we apply it?
>
> Yes.
I'm queuing this patch for the 3.5 kernel as well. Thanks.
Cheers,
--
Luis
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-11 12:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-07 2:17 [PATCH 3.8-stable] r8169: fix auto speed down issue Jonghwan Choi
2013-04-08 9:21 ` hayeswang
2013-04-11 12:34 ` Luis Henriques
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.