* [RESEND][PATCH 1/3] PM / devfreq: exynos4_bus: Fix missing mutex_unlock if opp_find_freq_floor fails
@ 2013-04-12 5:54 Axel Lin
2013-04-12 5:55 ` [RESEND][PATCH 2/3] PM / devfreq: exynos4_bus: Constify clock divider table Axel Lin
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Axel Lin @ 2013-04-12 5:54 UTC (permalink / raw)
To: Rafael J. Wysocki, MyungJoo Ham
Cc: Kyungmin Park, Kukjin Kim, linux-pm, linux-kernel
We need to call mutex_unlock() in the error path.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/devfreq/exynos4_bus.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/devfreq/exynos4_bus.c b/drivers/devfreq/exynos4_bus.c
index 1deee09..54b9615 100644
--- a/drivers/devfreq/exynos4_bus.c
+++ b/drivers/devfreq/exynos4_bus.c
@@ -974,7 +974,8 @@ static int exynos4_busfreq_pm_notifier_event(struct notifier_block *this,
rcu_read_unlock();
dev_err(data->dev, "%s: unable to find a min freq\n",
__func__);
- return PTR_ERR(opp);
+ err = PTR_ERR(opp);
+ goto unlock;
}
new_oppinfo.rate = opp_get_freq(opp);
new_oppinfo.volt = opp_get_voltage(opp);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [RESEND][PATCH 2/3] PM / devfreq: exynos4_bus: Constify clock divider table
2013-04-12 5:54 [RESEND][PATCH 1/3] PM / devfreq: exynos4_bus: Fix missing mutex_unlock if opp_find_freq_floor fails Axel Lin
@ 2013-04-12 5:55 ` Axel Lin
2013-04-12 5:56 ` [RESEND][PATCH 3/3] PM / devfreq: exynos4_bus: Fix table entry size for exynos4x12_clkdiv_dmc1 Axel Lin
2013-04-12 11:51 ` [RESEND][PATCH 1/3] PM / devfreq: exynos4_bus: Fix missing mutex_unlock if opp_find_freq_floor fails Rafael J. Wysocki
2 siblings, 0 replies; 8+ messages in thread
From: Axel Lin @ 2013-04-12 5:55 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: MyungJoo Ham, Kyungmin Park, Kukjin Kim, linux-pm, linux-kernel
These tables are never modified, make them const.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/devfreq/exynos4_bus.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/devfreq/exynos4_bus.c b/drivers/devfreq/exynos4_bus.c
index 3f37f3b..45d00d1 100644
--- a/drivers/devfreq/exynos4_bus.c
+++ b/drivers/devfreq/exynos4_bus.c
@@ -177,7 +177,7 @@ static unsigned int exynos4x12_int_volt[][EX4x12_LV_NUM] = {
};
/*** Clock Divider Data for Exynos4210 ***/
-static unsigned int exynos4210_clkdiv_dmc0[][8] = {
+static const unsigned int exynos4210_clkdiv_dmc0[][8] = {
/*
* Clock divider value for following
* { DIVACP, DIVACP_PCLK, DIVDPHY, DIVDMC, DIVDMCD
@@ -191,7 +191,7 @@ static unsigned int exynos4210_clkdiv_dmc0[][8] = {
/* DMC L2: 133MHz */
{ 5, 1, 1, 5, 1, 1, 3, 1 },
};
-static unsigned int exynos4210_clkdiv_top[][5] = {
+static const unsigned int exynos4210_clkdiv_top[][5] = {
/*
* Clock divider value for following
* { DIVACLK200, DIVACLK100, DIVACLK160, DIVACLK133, DIVONENAND }
@@ -203,7 +203,7 @@ static unsigned int exynos4210_clkdiv_top[][5] = {
/* ACLK200 L2: 133MHz */
{ 5, 7, 7, 7, 1 },
};
-static unsigned int exynos4210_clkdiv_lr_bus[][2] = {
+static const unsigned int exynos4210_clkdiv_lr_bus[][2] = {
/*
* Clock divider value for following
* { DIVGDL/R, DIVGPL/R }
@@ -217,7 +217,7 @@ static unsigned int exynos4210_clkdiv_lr_bus[][2] = {
};
/*** Clock Divider Data for Exynos4212/4412 ***/
-static unsigned int exynos4x12_clkdiv_dmc0[][6] = {
+static const unsigned int exynos4x12_clkdiv_dmc0[][6] = {
/*
* Clock divider value for following
* { DIVACP, DIVACP_PCLK, DIVDPHY, DIVDMC, DIVDMCD
@@ -235,7 +235,7 @@ static unsigned int exynos4x12_clkdiv_dmc0[][6] = {
/* DMC L4: 100MHz */
{7, 1, 1, 7, 1, 1},
};
-static unsigned int exynos4x12_clkdiv_dmc1[][6] = {
+static const unsigned int exynos4x12_clkdiv_dmc1[][6] = {
/*
* Clock divider value for following
* { G2DACP, DIVC2C, DIVC2C_ACLK }
@@ -252,7 +252,7 @@ static unsigned int exynos4x12_clkdiv_dmc1[][6] = {
/* DMC L4: 100MHz */
{7, 7, 1},
};
-static unsigned int exynos4x12_clkdiv_top[][5] = {
+static const unsigned int exynos4x12_clkdiv_top[][5] = {
/*
* Clock divider value for following
* { DIVACLK266_GPS, DIVACLK100, DIVACLK160,
@@ -270,7 +270,7 @@ static unsigned int exynos4x12_clkdiv_top[][5] = {
/* ACLK_GDL/R L4: 100MHz */
{7, 7, 7, 7, 1},
};
-static unsigned int exynos4x12_clkdiv_lr_bus[][2] = {
+static const unsigned int exynos4x12_clkdiv_lr_bus[][2] = {
/*
* Clock divider value for following
* { DIVGDL/R, DIVGPL/R }
@@ -287,7 +287,7 @@ static unsigned int exynos4x12_clkdiv_lr_bus[][2] = {
/* ACLK_GDL/R L4: 100MHz */
{7, 1},
};
-static unsigned int exynos4x12_clkdiv_sclkip[][3] = {
+static const unsigned int exynos4x12_clkdiv_sclkip[][3] = {
/*
* Clock divider value for following
* { DIVMFC, DIVJPEG, DIVFIMC0~3}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [RESEND][PATCH 3/3] PM / devfreq: exynos4_bus: Fix table entry size for exynos4x12_clkdiv_dmc1
2013-04-12 5:54 [RESEND][PATCH 1/3] PM / devfreq: exynos4_bus: Fix missing mutex_unlock if opp_find_freq_floor fails Axel Lin
2013-04-12 5:55 ` [RESEND][PATCH 2/3] PM / devfreq: exynos4_bus: Constify clock divider table Axel Lin
@ 2013-04-12 5:56 ` Axel Lin
2013-04-12 11:51 ` [RESEND][PATCH 1/3] PM / devfreq: exynos4_bus: Fix missing mutex_unlock if opp_find_freq_floor fails Rafael J. Wysocki
2 siblings, 0 replies; 8+ messages in thread
From: Axel Lin @ 2013-04-12 5:56 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: MyungJoo Ham, Kyungmin Park, Kukjin Kim, linux-pm, linux-kernel
exynos4x12_clkdiv_dmc1 contains { G2DACP, DIVC2C, DIVC2C_ACLK }, thus
set the size to 3 rather than 6.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/devfreq/exynos4_bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/devfreq/exynos4_bus.c b/drivers/devfreq/exynos4_bus.c
index 45d00d1..1deee09 100644
--- a/drivers/devfreq/exynos4_bus.c
+++ b/drivers/devfreq/exynos4_bus.c
@@ -235,7 +235,7 @@ static const unsigned int exynos4x12_clkdiv_dmc0[][6] = {
/* DMC L4: 100MHz */
{7, 1, 1, 7, 1, 1},
};
-static const unsigned int exynos4x12_clkdiv_dmc1[][6] = {
+static const unsigned int exynos4x12_clkdiv_dmc1[][3] = {
/*
* Clock divider value for following
* { G2DACP, DIVC2C, DIVC2C_ACLK }
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [RESEND][PATCH 1/3] PM / devfreq: exynos4_bus: Fix missing mutex_unlock if opp_find_freq_floor fails
2013-04-12 5:54 [RESEND][PATCH 1/3] PM / devfreq: exynos4_bus: Fix missing mutex_unlock if opp_find_freq_floor fails Axel Lin
2013-04-12 5:55 ` [RESEND][PATCH 2/3] PM / devfreq: exynos4_bus: Constify clock divider table Axel Lin
2013-04-12 5:56 ` [RESEND][PATCH 3/3] PM / devfreq: exynos4_bus: Fix table entry size for exynos4x12_clkdiv_dmc1 Axel Lin
@ 2013-04-12 11:51 ` Rafael J. Wysocki
2013-04-12 12:11 ` myungjoo.ham
2 siblings, 1 reply; 8+ messages in thread
From: Rafael J. Wysocki @ 2013-04-12 11:51 UTC (permalink / raw)
To: Axel Lin, MyungJoo Ham, Kyungmin Park, Kukjin Kim
Cc: Rafael J. Wysocki, linux-pm, linux-kernel
On Friday, April 12, 2013 01:54:18 PM Axel Lin wrote:
> We need to call mutex_unlock() in the error path.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
All three patches applied to linux-pm.git/linux-next.
Exynos maintainers, if you have any objections, please holler.
Thanks,
Rafael
> ---
> drivers/devfreq/exynos4_bus.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/exynos4_bus.c b/drivers/devfreq/exynos4_bus.c
> index 1deee09..54b9615 100644
> --- a/drivers/devfreq/exynos4_bus.c
> +++ b/drivers/devfreq/exynos4_bus.c
> @@ -974,7 +974,8 @@ static int exynos4_busfreq_pm_notifier_event(struct notifier_block *this,
> rcu_read_unlock();
> dev_err(data->dev, "%s: unable to find a min freq\n",
> __func__);
> - return PTR_ERR(opp);
> + err = PTR_ERR(opp);
> + goto unlock;
> }
> new_oppinfo.rate = opp_get_freq(opp);
> new_oppinfo.volt = opp_get_voltage(opp);
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [RESEND][PATCH 1/3] PM / devfreq: exynos4_bus: Fix missing mutex_unlock if opp_find_freq_floor fails
2013-04-12 11:51 ` [RESEND][PATCH 1/3] PM / devfreq: exynos4_bus: Fix missing mutex_unlock if opp_find_freq_floor fails Rafael J. Wysocki
@ 2013-04-12 12:11 ` myungjoo.ham
2013-04-12 23:20 ` Rafael J. Wysocki
0 siblings, 1 reply; 8+ messages in thread
From: myungjoo.ham @ 2013-04-12 12:11 UTC (permalink / raw)
To: 'Rafael J. Wysocki', 'Axel Lin',
'Kyungmin Park', 'Kukjin Kim'
Cc: 'Rafael J. Wysocki', linux-pm, linux-kernel
> On Friday, April 12, 2013 11:52:01 AM 함명주 wrote:
> > > On Friday, April 12, 2013 01:54:18 PM Axel Lin wrote:
> > > > We need to call mutex_unlock() in the error path.
> > > >
> > > > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> > >
> > > All three patches applied to linux-pm.git/linux-next.
> > >
> > > Exynos maintainers, if you have any objections, please holler.
> > >
> > > Thanks,
> > > Rafael
> >
> > This patch was included in the last pull-request patchset
> > though the path was updated. (its precedessor patch moved
> > exynos drivers to /drivers/devfreq/exynos/* after adding
> > Exynos common driver files)
>
> OK, so do you want me to drop it?
>
> What about the remaining two?
Yes, please drop 1/3. It's duplicated.
The patches 2~3/3 can wait. They are actually not bugfixes.
>
> Do you have any more devfreq patches for me to take into v3.10? If so,
> please send a pull request ASAP.
>
> Thanks,
> Rafael
>
>
> > >
> > > > ---
> > > > drivers/devfreq/exynos4_bus.c | 3 ++-
> > > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/devfreq/exynos4_bus.c b/drivers/devfreq/exynos4_bus.c
> > > > index 1deee09..54b9615 100644
> > > > --- a/drivers/devfreq/exynos4_bus.c
> > > > +++ b/drivers/devfreq/exynos4_bus.c
> > > > @@ -974,7 +974,8 @@ static int exynos4_busfreq_pm_notifier_event(struct notifier_block *this,
> > > > rcu_read_unlock();
> > > > dev_err(data->dev, "%s: unable to find a min freq\n",
> > > > __func__);
> > > > - return PTR_ERR(opp);
> > > > + err = PTR_ERR(opp);
> > > > + goto unlock;
> > > > }
> > > > new_oppinfo.rate = opp_get_freq(opp);
> > > > new_oppinfo.volt = opp_get_voltage(opp);
> > > >
> > > --
> > > I speak only for myself.
> > > Rafael J. Wysocki, Intel Open Source Technology Center.
> > >
> > >
> > >
> > >
> > >
> > >
> > >
>
> --
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.
>
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RESEND][PATCH 1/3] PM / devfreq: exynos4_bus: Fix missing mutex_unlock if opp_find_freq_floor fails
2013-04-12 12:11 ` myungjoo.ham
@ 2013-04-12 23:20 ` Rafael J. Wysocki
2013-04-13 1:40 ` Axel Lin
0 siblings, 1 reply; 8+ messages in thread
From: Rafael J. Wysocki @ 2013-04-12 23:20 UTC (permalink / raw)
To: myungjoo.ham, 'Axel Lin'
Cc: 'Kyungmin Park', 'Kukjin Kim',
'Rafael J. Wysocki',
linux-pm, linux-kernel
On Friday, April 12, 2013 09:11:00 PM myungjoo.ham wrote:
> > On Friday, April 12, 2013 11:52:01 AM 함명주 wrote:
> > > > On Friday, April 12, 2013 01:54:18 PM Axel Lin wrote:
> > > > > We need to call mutex_unlock() in the error path.
> > > > >
> > > > > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> > > >
> > > > All three patches applied to linux-pm.git/linux-next.
> > > >
> > > > Exynos maintainers, if you have any objections, please holler.
> > > >
> > > > Thanks,
> > > > Rafael
> > >
> > > This patch was included in the last pull-request patchset
> > > though the path was updated. (its precedessor patch moved
> > > exynos drivers to /drivers/devfreq/exynos/* after adding
> > > Exynos common driver files)
> >
> > OK, so do you want me to drop it?
> >
> > What about the remaining two?
>
> Yes, please drop 1/3. It's duplicated.
>
> The patches 2~3/3 can wait. They are actually not bugfixes.
OK, I've dropped all three.
Axel, please push [2-3/3] thorugh the Exynos tree.
Thanks,
Rafael
> > > > > ---
> > > > > drivers/devfreq/exynos4_bus.c | 3 ++-
> > > > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/drivers/devfreq/exynos4_bus.c b/drivers/devfreq/exynos4_bus.c
> > > > > index 1deee09..54b9615 100644
> > > > > --- a/drivers/devfreq/exynos4_bus.c
> > > > > +++ b/drivers/devfreq/exynos4_bus.c
> > > > > @@ -974,7 +974,8 @@ static int exynos4_busfreq_pm_notifier_event(struct notifier_block *this,
> > > > > rcu_read_unlock();
> > > > > dev_err(data->dev, "%s: unable to find a min freq\n",
> > > > > __func__);
> > > > > - return PTR_ERR(opp);
> > > > > + err = PTR_ERR(opp);
> > > > > + goto unlock;
> > > > > }
> > > > > new_oppinfo.rate = opp_get_freq(opp);
> > > > > new_oppinfo.volt = opp_get_voltage(opp);
> > > > >
> >
> >
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RESEND][PATCH 1/3] PM / devfreq: exynos4_bus: Fix missing mutex_unlock if opp_find_freq_floor fails
2013-04-12 23:20 ` Rafael J. Wysocki
@ 2013-04-13 1:40 ` Axel Lin
2013-04-17 16:39 ` Rafael J. Wysocki
0 siblings, 1 reply; 8+ messages in thread
From: Axel Lin @ 2013-04-13 1:40 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: myungjoo.ham, Kyungmin Park, Kukjin Kim, Rafael J. Wysocki,
linux-pm, linux-kernel
2013/4/13 Rafael J. Wysocki <rjw@sisk.pl>:
> On Friday, April 12, 2013 09:11:00 PM myungjoo.ham wrote:
>> > On Friday, April 12, 2013 11:52:01 AM 함명주 wrote:
>> > > > On Friday, April 12, 2013 01:54:18 PM Axel Lin wrote:
>> > > > > We need to call mutex_unlock() in the error path.
>> > > > >
>> > > > > Signed-off-by: Axel Lin <axel.lin@ingics.com>
>> > > >
>> > > > All three patches applied to linux-pm.git/linux-next.
>> > > >
>> > > > Exynos maintainers, if you have any objections, please holler.
>> > > >
>> > > > Thanks,
>> > > > Rafael
>> > >
>> > > This patch was included in the last pull-request patchset
>> > > though the path was updated. (its precedessor patch moved
>> > > exynos drivers to /drivers/devfreq/exynos/* after adding
>> > > Exynos common driver files)
>> >
>> > OK, so do you want me to drop it?
>> >
>> > What about the remaining two?
>>
>> Yes, please drop 1/3. It's duplicated.
>>
>> The patches 2~3/3 can wait. They are actually not bugfixes.
>
> OK, I've dropped all three.
>
> Axel, please push [2-3/3] thorugh the Exynos tree.
I thought I already Cc all devfreq maintainers.
Is there any other thing I need to do?
Regards,
Axel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RESEND][PATCH 1/3] PM / devfreq: exynos4_bus: Fix missing mutex_unlock if opp_find_freq_floor fails
2013-04-13 1:40 ` Axel Lin
@ 2013-04-17 16:39 ` Rafael J. Wysocki
0 siblings, 0 replies; 8+ messages in thread
From: Rafael J. Wysocki @ 2013-04-17 16:39 UTC (permalink / raw)
To: Axel Lin
Cc: myungjoo.ham, Kyungmin Park, Kukjin Kim, Rafael J. Wysocki,
linux-pm, linux-kernel
On Saturday, April 13, 2013 09:40:49 AM Axel Lin wrote:
> 2013/4/13 Rafael J. Wysocki <rjw@sisk.pl>:
> > On Friday, April 12, 2013 09:11:00 PM myungjoo.ham wrote:
> >> > On Friday, April 12, 2013 11:52:01 AM 함명주 wrote:
> >> > > > On Friday, April 12, 2013 01:54:18 PM Axel Lin wrote:
> >> > > > > We need to call mutex_unlock() in the error path.
> >> > > > >
> >> > > > > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> >> > > >
> >> > > > All three patches applied to linux-pm.git/linux-next.
> >> > > >
> >> > > > Exynos maintainers, if you have any objections, please holler.
> >> > > >
> >> > > > Thanks,
> >> > > > Rafael
> >> > >
> >> > > This patch was included in the last pull-request patchset
> >> > > though the path was updated. (its precedessor patch moved
> >> > > exynos drivers to /drivers/devfreq/exynos/* after adding
> >> > > Exynos common driver files)
> >> >
> >> > OK, so do you want me to drop it?
> >> >
> >> > What about the remaining two?
> >>
> >> Yes, please drop 1/3. It's duplicated.
> >>
> >> The patches 2~3/3 can wait. They are actually not bugfixes.
> >
> > OK, I've dropped all three.
> >
> > Axel, please push [2-3/3] thorugh the Exynos tree.
>
> I thought I already Cc all devfreq maintainers.
> Is there any other thing I need to do?
Just please let them know that you'd like them to take the patches, not me. :-)
Thanks,
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-04-17 16:32 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-12 5:54 [RESEND][PATCH 1/3] PM / devfreq: exynos4_bus: Fix missing mutex_unlock if opp_find_freq_floor fails Axel Lin
2013-04-12 5:55 ` [RESEND][PATCH 2/3] PM / devfreq: exynos4_bus: Constify clock divider table Axel Lin
2013-04-12 5:56 ` [RESEND][PATCH 3/3] PM / devfreq: exynos4_bus: Fix table entry size for exynos4x12_clkdiv_dmc1 Axel Lin
2013-04-12 11:51 ` [RESEND][PATCH 1/3] PM / devfreq: exynos4_bus: Fix missing mutex_unlock if opp_find_freq_floor fails Rafael J. Wysocki
2013-04-12 12:11 ` myungjoo.ham
2013-04-12 23:20 ` Rafael J. Wysocki
2013-04-13 1:40 ` Axel Lin
2013-04-17 16:39 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.