All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: M A Young <m.a.young@durham.ac.uk>
Cc: Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] allow xendomains to work for xl list -l
Date: Fri, 12 Apr 2013 09:03:03 +0100	[thread overview]
Message-ID: <1365753783.8126.78.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1304112302210.20163@procyon.dur.ac.uk>

On Thu, 2013-04-11 at 23:06 +0100, M A Young wrote:
> On Wed, 10 Apr 2013, Ian Campbell wrote:
> 
> >>  and accepts the "Xen saved
> >> domain" as a valid header for a saved xen image if xl is being used.
> >
> > This bit sounds independently useful too. ISTR someone else sending a
> > similar patch but it fell through the cracks for some reason which I
> > don't remember and I can't find it now.
> 
> I have thought about this further, and since xm only reads files with the 
> "LinuxGuestRecord" header and xl only reads files with the "Xen saved 
> domain" header should we be trying to use whichever of xm or xl matches 
> the header (assuming it works) regardless of which one we chose at the 
> start of the xendomains script.

I don't think so, if xend is running then using xl is not
recommended/supported and vice versa. So if xemdomains things one is in
use it shouldn't use the other.

You could perhaps make xendomains print a suitable message but I suppose
xm and xl will both fail on each others format anyway, although perhaps
not with a very useful message?

I'd be happy to see an xl patch which detects xm format save files and
prints something informative, and even happier if there was some
conversion routine (which might be non-trivial though, I haven't looked)

Ian.

  reply	other threads:[~2013-04-12  8:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-09 20:05 [PATCH] allow xendomains to work for xl list -l M A Young
2013-04-10 13:00 ` Ian Campbell
2013-04-10 13:04   ` Ian Campbell
2013-04-10 23:15   ` M A Young
2013-04-11  7:57     ` Ian Campbell
2013-04-11 23:02       ` M A Young
2013-04-12 11:41         ` Ian Campbell
2013-04-11 12:46     ` [PATCH] allow xendomains to work for xl list -l [and 1 more messages] Ian Jackson
2013-04-11 13:10       ` Ian Campbell
2013-04-11 15:56         ` Ian Jackson
2013-04-11 22:06   ` [PATCH] allow xendomains to work for xl list -l M A Young
2013-04-12  8:03     ` Ian Campbell [this message]
2013-04-11 11:38 ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365753783.8126.78.camel@zakaz.uk.xensource.com \
    --to=ian.campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=Stefano.Stabellini@eu.citrix.com \
    --cc=m.a.young@durham.ac.uk \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.