All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: M A Young <m.a.young@durham.ac.uk>
Cc: Roger Pau Monne <roger.pau@citrix.com>,
	Ian Campbell <Ian.Campbell@citrix.com>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] allow xendomains to work for xl list -l
Date: Thu, 11 Apr 2013 12:38:13 +0100	[thread overview]
Message-ID: <20838.41125.619897.512392@mariner.uk.xensource.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1304091932470.10223@procyon.dur.ac.uk>

M A Young writes ("[PATCH] allow xendomains to work for xl list -l"):
> I have discovered a few problems when using the 
> tools/hotplug/Linux/init.d/xendomains startup script if you use xl instead 
> of xm.
> >From xen 4.2 onwards xl list -l gives a JSON format output containing no 
> spaces or line feeds, but the xendomains script expects the older format 
> (of xl in xen 4.1 and xm) of one key-value pair per line.
> This patch adds a new line after each comma in the output of xl list -l 
> before processing it further, allows there to be not to be a space between 
> the key and value format used by xl list -l and accepts the "Xen saved 
> domain" as a valid header for a saved xen image if xl is being used.
...
> This patch inserts a line feed after each comma in the output from
> xl list -l, allows there not to be a space between "name" and "domid" keys
> and their value, and accepts the "Xen saved domain" value as a valid header
> for a saved xen image if xl is being used.

Roger, do you have an opinion about this ?  Without testing it myself,
I'm inclined to accept the patch.

This does illuminate the fact that the JSON output is not the most
convenient thing for a shell to deal with.

Ian.

      parent reply	other threads:[~2013-04-11 11:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-09 20:05 [PATCH] allow xendomains to work for xl list -l M A Young
2013-04-10 13:00 ` Ian Campbell
2013-04-10 13:04   ` Ian Campbell
2013-04-10 23:15   ` M A Young
2013-04-11  7:57     ` Ian Campbell
2013-04-11 23:02       ` M A Young
2013-04-12 11:41         ` Ian Campbell
2013-04-11 12:46     ` [PATCH] allow xendomains to work for xl list -l [and 1 more messages] Ian Jackson
2013-04-11 13:10       ` Ian Campbell
2013-04-11 15:56         ` Ian Jackson
2013-04-11 22:06   ` [PATCH] allow xendomains to work for xl list -l M A Young
2013-04-12  8:03     ` Ian Campbell
2013-04-11 11:38 ` Ian Jackson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20838.41125.619897.512392@mariner.uk.xensource.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Stefano.Stabellini@eu.citrix.com \
    --cc=m.a.young@durham.ac.uk \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.