All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fix initconst in lib/decompress.c
@ 2013-04-21  3:44 Andi Kleen
  2013-04-23 22:02 ` Andrew Morton
  0 siblings, 1 reply; 3+ messages in thread
From: Andi Kleen @ 2013-04-21  3:44 UTC (permalink / raw)
  To: akpm; +Cc: hein_tibosch, linux-kernel, Andi Kleen

From: Andi Kleen <ak@linux.intel.com>


diff --git a/lib/decompress.c b/lib/decompress.c
index 31a8042..f8fdeda 100644
--- a/lib/decompress.c
+++ b/lib/decompress.c
@@ -38,7 +38,7 @@ struct compress_format {
 	decompress_fn decompressor;
 };
 
-static const struct compress_format compressed_formats[] __initdata = {
+static const struct compress_format compressed_formats[] __initconst = {
 	{ {037, 0213}, "gzip", gunzip },
 	{ {037, 0236}, "gzip", gunzip },
 	{ {0x42, 0x5a}, "bzip2", bunzip2 },

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] fix initconst in lib/decompress.c
  2013-04-21  3:44 [PATCH] fix initconst in lib/decompress.c Andi Kleen
@ 2013-04-23 22:02 ` Andrew Morton
  2013-04-23 22:10   ` Andi Kleen
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2013-04-23 22:02 UTC (permalink / raw)
  To: Andi Kleen; +Cc: hein_tibosch, linux-kernel, Andi Kleen

On Sat, 20 Apr 2013 20:44:45 -0700 Andi Kleen <andi@firstfloor.org> wrote:

> From: Andi Kleen <ak@linux.intel.com>
> 
> 
> diff --git a/lib/decompress.c b/lib/decompress.c
> index 31a8042..f8fdeda 100644
> --- a/lib/decompress.c
> +++ b/lib/decompress.c
> @@ -38,7 +38,7 @@ struct compress_format {
>  	decompress_fn decompressor;
>  };
>  
> -static const struct compress_format compressed_formats[] __initdata = {
> +static const struct compress_format compressed_formats[] __initconst = {
>  	{ {037, 0213}, "gzip", gunzip },
>  	{ {037, 0236}, "gzip", gunzip },
>  	{ {0x42, 0x5a}, "bzip2", bunzip2 },

That's missing both a changelog and the signed-off-by.  Did your
scripts break?


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] fix initconst in lib/decompress.c
  2013-04-23 22:02 ` Andrew Morton
@ 2013-04-23 22:10   ` Andi Kleen
  0 siblings, 0 replies; 3+ messages in thread
From: Andi Kleen @ 2013-04-23 22:10 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Andi Kleen, hein_tibosch, linux-kernel

On Tue, Apr 23, 2013 at 03:02:09PM -0700, Andrew Morton wrote:
> On Sat, 20 Apr 2013 20:44:45 -0700 Andi Kleen <andi@firstfloor.org> wrote:
> 
> > From: Andi Kleen <ak@linux.intel.com>
> > 
> > 
> > diff --git a/lib/decompress.c b/lib/decompress.c
> > index 31a8042..f8fdeda 100644
> > --- a/lib/decompress.c
> > +++ b/lib/decompress.c
> > @@ -38,7 +38,7 @@ struct compress_format {
> >  	decompress_fn decompressor;
> >  };
> >  
> > -static const struct compress_format compressed_formats[] __initdata = {
> > +static const struct compress_format compressed_formats[] __initconst = {
> >  	{ {037, 0213}, "gzip", gunzip },
> >  	{ {037, 0236}, "gzip", gunzip },
> >  	{ {0x42, 0x5a}, "bzip2", bunzip2 },
> 
> That's missing both a changelog and the signed-off-by.  Did your
> scripts break?

I normally don't write a description for initconst patches, as
they should be obvious.

Sorry for the missing Signed-off-by. Hereby added:

Signed-off-by: Andi Kleen <ak@linux.intel.com>

Please let me know if I should resend.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-04-23 22:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-21  3:44 [PATCH] fix initconst in lib/decompress.c Andi Kleen
2013-04-23 22:02 ` Andrew Morton
2013-04-23 22:10   ` Andi Kleen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.