* [RFC][PATCH] video: imx: Select VIDEOMODE_HELPERS
@ 2013-04-22 21:28 Marek Vasut
2013-04-22 22:35 ` Fabio Estevam
0 siblings, 1 reply; 10+ messages in thread
From: Marek Vasut @ 2013-04-22 21:28 UTC (permalink / raw)
To: linux-arm-kernel
Without this, I get the following problem when building kernel:
drivers/built-in.o: In function `imx_pd_connector_get_modes':
/linux-2.6/drivers/staging/imx-drm/parallel-display.c:78: undefined reference to `of_get_drm_display_mode'
make: *** [vmlinux] Error 1
NOTE: I think this patch is almost absolutely not correct.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/staging/imx-drm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/imx-drm/Kconfig b/drivers/staging/imx-drm/Kconfig
index 8c9e403..5ad9165 100644
--- a/drivers/staging/imx-drm/Kconfig
+++ b/drivers/staging/imx-drm/Kconfig
@@ -1,6 +1,7 @@
config DRM_IMX
tristate "DRM Support for Freescale i.MX"
select DRM_KMS_HELPER
+ select VIDEOMODE_HELPERS
select DRM_GEM_CMA_HELPER
select DRM_KMS_CMA_HELPER
depends on DRM && (ARCH_MXC || ARCH_MULTIPLATFORM)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [RFC][PATCH] video: imx: Select VIDEOMODE_HELPERS
2013-04-22 21:28 [RFC][PATCH] video: imx: Select VIDEOMODE_HELPERS Marek Vasut
@ 2013-04-22 22:35 ` Fabio Estevam
2013-04-22 23:57 ` Marek Vasut
0 siblings, 1 reply; 10+ messages in thread
From: Fabio Estevam @ 2013-04-22 22:35 UTC (permalink / raw)
To: linux-arm-kernel
Hi Marek,
On Mon, Apr 22, 2013 at 6:28 PM, Marek Vasut <marex@denx.de> wrote:
> Without this, I get the following problem when building kernel:
>
> drivers/built-in.o: In function `imx_pd_connector_get_modes':
> /linux-2.6/drivers/staging/imx-drm/parallel-display.c:78: undefined reference to `of_get_drm_display_mode'
> make: *** [vmlinux] Error 1
>
> NOTE: I think this patch is almost absolutely not correct.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
Patch looks good, but you should have copied Greg Kroah-Hartman, as he
is the one who takes patches into staging.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 10+ messages in thread
* [RFC][PATCH] video: imx: Select VIDEOMODE_HELPERS
2013-04-22 22:35 ` Fabio Estevam
@ 2013-04-22 23:57 ` Marek Vasut
2013-04-23 5:07 ` Sascha Hauer
2013-04-23 7:41 ` Philipp Zabel
0 siblings, 2 replies; 10+ messages in thread
From: Marek Vasut @ 2013-04-22 23:57 UTC (permalink / raw)
To: linux-arm-kernel
Dear Fabio Estevam,
> Hi Marek,
>
> On Mon, Apr 22, 2013 at 6:28 PM, Marek Vasut <marex@denx.de> wrote:
> > Without this, I get the following problem when building kernel:
> >
> > drivers/built-in.o: In function `imx_pd_connector_get_modes':
> > /linux-2.6/drivers/staging/imx-drm/parallel-display.c:78: undefined
> > reference to `of_get_drm_display_mode' make: *** [vmlinux] Error 1
> >
> > NOTE: I think this patch is almost absolutely not correct.
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > Cc: Fabio Estevam <fabio.estevam@freescale.com>
>
> Patch looks good, but you should have copied Greg Kroah-Hartman, as he
> is the one who takes patches into staging.
I'm not sure if the select is at correct symbol, I dont think it is.
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 10+ messages in thread
* [RFC][PATCH] video: imx: Select VIDEOMODE_HELPERS
2013-04-22 23:57 ` Marek Vasut
@ 2013-04-23 5:07 ` Sascha Hauer
2013-04-23 10:29 ` Marek Vasut
2013-04-23 7:41 ` Philipp Zabel
1 sibling, 1 reply; 10+ messages in thread
From: Sascha Hauer @ 2013-04-23 5:07 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Apr 23, 2013 at 01:57:47AM +0200, Marek Vasut wrote:
> Dear Fabio Estevam,
>
> > Hi Marek,
> >
> > On Mon, Apr 22, 2013 at 6:28 PM, Marek Vasut <marex@denx.de> wrote:
> > > Without this, I get the following problem when building kernel:
> > >
> > > drivers/built-in.o: In function `imx_pd_connector_get_modes':
> > > /linux-2.6/drivers/staging/imx-drm/parallel-display.c:78: undefined
> > > reference to `of_get_drm_display_mode' make: *** [vmlinux] Error 1
> > >
> > > NOTE: I think this patch is almost absolutely not correct.
> > >
> > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > > Cc: Fabio Estevam <fabio.estevam@freescale.com>
> >
> > Patch looks good, but you should have copied Greg Kroah-Hartman, as he
> > is the one who takes patches into staging.
>
> I'm not sure if the select is at correct symbol, I dont think it is.
No it's not. The parallel display driver needs it, not the i.MX drm
support in general.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 10+ messages in thread
* [RFC][PATCH] video: imx: Select VIDEOMODE_HELPERS
2013-04-22 23:57 ` Marek Vasut
2013-04-23 5:07 ` Sascha Hauer
@ 2013-04-23 7:41 ` Philipp Zabel
2013-04-24 0:31 ` Marek Vasut
2013-04-24 2:48 ` Fabio Estevam
1 sibling, 2 replies; 10+ messages in thread
From: Philipp Zabel @ 2013-04-23 7:41 UTC (permalink / raw)
To: linux-arm-kernel
Hi Marek,
Am Dienstag, den 23.04.2013, 01:57 +0200 schrieb Marek Vasut:
> Dear Fabio Estevam,
>
> > Hi Marek,
> >
> > On Mon, Apr 22, 2013 at 6:28 PM, Marek Vasut <marex@denx.de> wrote:
> > > Without this, I get the following problem when building kernel:
> > >
> > > drivers/built-in.o: In function `imx_pd_connector_get_modes':
> > > /linux-2.6/drivers/staging/imx-drm/parallel-display.c:78: undefined
> > > reference to `of_get_drm_display_mode' make: *** [vmlinux] Error 1
> > >
> > > NOTE: I think this patch is almost absolutely not correct.
> > >
> > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > > Cc: Fabio Estevam <fabio.estevam@freescale.com>
> >
> > Patch looks good, but you should have copied Greg Kroah-Hartman, as he
> > is the one who takes patches into staging.
>
> I'm not sure if the select is at correct symbol, I dont think it is.
OF_VIDEOMODE is the correct one. The implementation of
of_get_drm_display_mode in drivers/gpu/drm/drm_modes.c depends on it.
regards
Philipp
^ permalink raw reply [flat|nested] 10+ messages in thread
* [RFC][PATCH] video: imx: Select VIDEOMODE_HELPERS
2013-04-23 5:07 ` Sascha Hauer
@ 2013-04-23 10:29 ` Marek Vasut
2013-04-23 17:43 ` Sascha Hauer
0 siblings, 1 reply; 10+ messages in thread
From: Marek Vasut @ 2013-04-23 10:29 UTC (permalink / raw)
To: linux-arm-kernel
Dear Sascha Hauer,
> On Tue, Apr 23, 2013 at 01:57:47AM +0200, Marek Vasut wrote:
> > Dear Fabio Estevam,
> >
> > > Hi Marek,
> > >
> > > On Mon, Apr 22, 2013 at 6:28 PM, Marek Vasut <marex@denx.de> wrote:
> > > > Without this, I get the following problem when building kernel:
> > > >
> > > > drivers/built-in.o: In function `imx_pd_connector_get_modes':
> > > > /linux-2.6/drivers/staging/imx-drm/parallel-display.c:78: undefined
> > > > reference to `of_get_drm_display_mode' make: *** [vmlinux] Error 1
> > > >
> > > > NOTE: I think this patch is almost absolutely not correct.
> > > >
> > > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > > > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > > > Cc: Fabio Estevam <fabio.estevam@freescale.com>
> > >
> > > Patch looks good, but you should have copied Greg Kroah-Hartman, as he
> > > is the one who takes patches into staging.
> >
> > I'm not sure if the select is at correct symbol, I dont think it is.
>
> No it's not. The parallel display driver needs it, not the i.MX drm
> support in general.
Yep, I expected this coming, thus RFC. I'll roll out new patch and move this to
parallel display, ok?
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 10+ messages in thread
* [RFC][PATCH] video: imx: Select VIDEOMODE_HELPERS
2013-04-23 10:29 ` Marek Vasut
@ 2013-04-23 17:43 ` Sascha Hauer
0 siblings, 0 replies; 10+ messages in thread
From: Sascha Hauer @ 2013-04-23 17:43 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Apr 23, 2013 at 12:29:48PM +0200, Marek Vasut wrote:
> Dear Sascha Hauer,
>
> > On Tue, Apr 23, 2013 at 01:57:47AM +0200, Marek Vasut wrote:
> > > Dear Fabio Estevam,
> > >
> > > > Hi Marek,
> > > >
> > > > On Mon, Apr 22, 2013 at 6:28 PM, Marek Vasut <marex@denx.de> wrote:
> > > > > Without this, I get the following problem when building kernel:
> > > > >
> > > > > drivers/built-in.o: In function `imx_pd_connector_get_modes':
> > > > > /linux-2.6/drivers/staging/imx-drm/parallel-display.c:78: undefined
> > > > > reference to `of_get_drm_display_mode' make: *** [vmlinux] Error 1
> > > > >
> > > > > NOTE: I think this patch is almost absolutely not correct.
> > > > >
> > > > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > > > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > > > > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > > > > Cc: Fabio Estevam <fabio.estevam@freescale.com>
> > > >
> > > > Patch looks good, but you should have copied Greg Kroah-Hartman, as he
> > > > is the one who takes patches into staging.
> > >
> > > I'm not sure if the select is at correct symbol, I dont think it is.
> >
> > No it's not. The parallel display driver needs it, not the i.MX drm
> > support in general.
>
> Yep, I expected this coming, thus RFC. I'll roll out new patch and move this to
> parallel display, ok?
ok
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 10+ messages in thread
* [RFC][PATCH] video: imx: Select VIDEOMODE_HELPERS
2013-04-23 7:41 ` Philipp Zabel
@ 2013-04-24 0:31 ` Marek Vasut
2013-04-24 8:22 ` Philipp Zabel
2013-04-24 2:48 ` Fabio Estevam
1 sibling, 1 reply; 10+ messages in thread
From: Marek Vasut @ 2013-04-24 0:31 UTC (permalink / raw)
To: linux-arm-kernel
Hi Philipp,
> Hi Marek,
>
> Am Dienstag, den 23.04.2013, 01:57 +0200 schrieb Marek Vasut:
> > Dear Fabio Estevam,
> >
> > > Hi Marek,
> > >
> > > On Mon, Apr 22, 2013 at 6:28 PM, Marek Vasut <marex@denx.de> wrote:
> > > > Without this, I get the following problem when building kernel:
> > > >
> > > > drivers/built-in.o: In function `imx_pd_connector_get_modes':
> > > > /linux-2.6/drivers/staging/imx-drm/parallel-display.c:78: undefined
> > > > reference to `of_get_drm_display_mode' make: *** [vmlinux] Error 1
> > > >
> > > > NOTE: I think this patch is almost absolutely not correct.
> > > >
> > > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > > > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > > > Cc: Fabio Estevam <fabio.estevam@freescale.com>
> > >
> > > Patch looks good, but you should have copied Greg Kroah-Hartman, as he
> > > is the one who takes patches into staging.
> >
> > I'm not sure if the select is at correct symbol, I dont think it is.
>
> OF_VIDEOMODE is the correct one. The implementation of
> of_get_drm_display_mode in drivers/gpu/drm/drm_modes.c depends on it.
I really need VIDEOMODE_HELPERS, not OF_VIDEOMODE. If I select only
OF_VIDEOMODE, I still get the issue above.
Check drivers/gpu/drm/drm_modes.c , it's protected by CONFIG_VIDEOMODE_HELPERS
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 10+ messages in thread
* [RFC][PATCH] video: imx: Select VIDEOMODE_HELPERS
2013-04-23 7:41 ` Philipp Zabel
2013-04-24 0:31 ` Marek Vasut
@ 2013-04-24 2:48 ` Fabio Estevam
1 sibling, 0 replies; 10+ messages in thread
From: Fabio Estevam @ 2013-04-24 2:48 UTC (permalink / raw)
To: linux-arm-kernel
Hi Philipp,
On Tue, Apr 23, 2013 at 4:41 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> OF_VIDEOMODE is the correct one. The implementation of
> of_get_drm_display_mode in drivers/gpu/drm/drm_modes.c depends on it.
The symbol OF_VIDEOMODE has been deprecated.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 10+ messages in thread
* [RFC][PATCH] video: imx: Select VIDEOMODE_HELPERS
2013-04-24 0:31 ` Marek Vasut
@ 2013-04-24 8:22 ` Philipp Zabel
0 siblings, 0 replies; 10+ messages in thread
From: Philipp Zabel @ 2013-04-24 8:22 UTC (permalink / raw)
To: linux-arm-kernel
Hi Marek,
Am Mittwoch, den 24.04.2013, 02:31 +0200 schrieb Marek Vasut:
> Hi Philipp,
>
> > Hi Marek,
> >
> > Am Dienstag, den 23.04.2013, 01:57 +0200 schrieb Marek Vasut:
> > > Dear Fabio Estevam,
> > >
> > > > Hi Marek,
> > > >
> > > > On Mon, Apr 22, 2013 at 6:28 PM, Marek Vasut <marex@denx.de> wrote:
> > > > > Without this, I get the following problem when building kernel:
> > > > >
> > > > > drivers/built-in.o: In function `imx_pd_connector_get_modes':
> > > > > /linux-2.6/drivers/staging/imx-drm/parallel-display.c:78: undefined
> > > > > reference to `of_get_drm_display_mode' make: *** [vmlinux] Error 1
> > > > >
> > > > > NOTE: I think this patch is almost absolutely not correct.
> > > > >
> > > > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > > > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > > > > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > > > > Cc: Fabio Estevam <fabio.estevam@freescale.com>
> > > >
> > > > Patch looks good, but you should have copied Greg Kroah-Hartman, as he
> > > > is the one who takes patches into staging.
> > >
> > > I'm not sure if the select is at correct symbol, I dont think it is.
> >
> > OF_VIDEOMODE is the correct one. The implementation of
> > of_get_drm_display_mode in drivers/gpu/drm/drm_modes.c depends on it.
>
> I really need VIDEOMODE_HELPERS, not OF_VIDEOMODE. If I select only
> OF_VIDEOMODE, I still get the issue above.
>
> Check drivers/gpu/drm/drm_modes.c , it's protected by CONFIG_VIDEOMODE_HELPERS
Indeed, I was looking at the wrong checkout. Sorry for the noise.
regards
Philipp
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-04-24 8:22 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-22 21:28 [RFC][PATCH] video: imx: Select VIDEOMODE_HELPERS Marek Vasut
2013-04-22 22:35 ` Fabio Estevam
2013-04-22 23:57 ` Marek Vasut
2013-04-23 5:07 ` Sascha Hauer
2013-04-23 10:29 ` Marek Vasut
2013-04-23 17:43 ` Sascha Hauer
2013-04-23 7:41 ` Philipp Zabel
2013-04-24 0:31 ` Marek Vasut
2013-04-24 8:22 ` Philipp Zabel
2013-04-24 2:48 ` Fabio Estevam
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.