* [PATCH net-next] net: remove redundant code in dev_hard_start_xmit()
@ 2013-04-23 0:31 Eric Dumazet
2013-04-25 5:39 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Eric Dumazet @ 2013-04-23 0:31 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Krishna Kumar
From: Eric Dumazet <edumazet@google.com>
This reverts commit 068a2de57ddf4f4 (net: release dst entry while
cache-hot for GSO case too)
Before GSO packet segmentation, we already take care of skb->dst if it
can be released.
There is no point adding extra test for every segment in the gso loop.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Krishna Kumar <krkumar2@in.ibm.com>
---
net/core/dev.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 8a3cb2c..6a82eed 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2543,13 +2543,6 @@ gso:
skb->next = nskb->next;
nskb->next = NULL;
- /*
- * If device doesn't need nskb->dst, release it right now while
- * its hot in this cpu cache
- */
- if (dev->priv_flags & IFF_XMIT_DST_RELEASE)
- skb_dst_drop(nskb);
-
if (!list_empty(&ptype_all))
dev_queue_xmit_nit(nskb, dev);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: remove redundant code in dev_hard_start_xmit()
2013-04-23 0:31 [PATCH net-next] net: remove redundant code in dev_hard_start_xmit() Eric Dumazet
@ 2013-04-25 5:39 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-04-25 5:39 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev, krkumar2
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 22 Apr 2013 17:31:34 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> This reverts commit 068a2de57ddf4f4 (net: release dst entry while
> cache-hot for GSO case too)
>
> Before GSO packet segmentation, we already take care of skb->dst if it
> can be released.
>
> There is no point adding extra test for every segment in the gso loop.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks Eric.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-25 5:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-23 0:31 [PATCH net-next] net: remove redundant code in dev_hard_start_xmit() Eric Dumazet
2013-04-25 5:39 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.