[PATCH] drm/i915: fix Haswell pfit power well check

* [PATCH] drm/i915: fix Haswell pfit power well check
@ 2013-05-02 22:24 Jesse Barnes
  2013-05-02 22:30 ` [PATCH] drm/i915: fix Haswell pfit power well check v2 Jesse Barnes
  0 siblings, 1 reply; 6+ messages in thread
From: Jesse Barnes @ 2013-05-02 22:24 UTC (permalink / raw)
  To: intel-gfx

We can't read the pfit regs if the power well is off, so use the cached
value.

However, I think this check is incorrect (it was taken from an earlier
check against dev_priv).  We should probably just drop it altogether,
since the panel fitter isn't useful without a pipe to fetch from and
an encoder to feed.

Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
---
 drivers/gpu/drm/i915/intel_display.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 6504337..c451940 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -5917,8 +5917,7 @@ static void haswell_modeset_global_resources(struct drm_device *dev)
 		/* XXX: Should check for edp transcoder here, but thanks to init
 		 * sequence that's not yet available. Just in case desktop eDP
 		 * on PORT D is possible on haswell, too. */
-		/* Even the eDP panel fitter is outside the always-on well. */
-		if (I915_READ(PF_WIN_SZ(crtc->pipe)))
+		if (crtc->config.pch_pfit.size)
 			enable = true;
 	}
 
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread