[PATCH 1/2] ALSA: mips/hal2: Remove redundant platform_set_drvdata()

[PATCH 1/2] ALSA: mips/hal2: Remove redundant platform_set_drvdata()

[Sachin Kamat]

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Thomas Bogendoerfer <tsbogend@alpha.fanken.de>
---
 sound/mips/hal2.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/mips/hal2.c b/sound/mips/hal2.c
index 7420c59..2b7f6e8 100644
--- a/sound/mips/hal2.c
+++ b/sound/mips/hal2.c
@@ -922,7 +922,6 @@ static int hal2_remove(struct platform_device *pdev)
 	struct snd_card *card = platform_get_drvdata(pdev);
 
 	snd_card_free(card);
-	platform_set_drvdata(pdev, NULL);
 	return 0;
 }
 
-- 
1.7.9.5

[PATCH 2/2] Input: mips/sgio2audio: Remove redundant platform_set_drvdata()

[Sachin Kamat]

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Vivien Chappelier <vivien.chappelier@linux-mips.org>
---
 sound/mips/sgio2audio.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/mips/sgio2audio.c b/sound/mips/sgio2audio.c
index 01a03ef..cfe99ae 100644
--- a/sound/mips/sgio2audio.c
+++ b/sound/mips/sgio2audio.c
@@ -963,7 +963,6 @@ static int snd_sgio2audio_remove(struct platform_device *pdev)
 	struct snd_card *card = platform_get_drvdata(pdev);
 
 	snd_card_free(card);
-	platform_set_drvdata(pdev, NULL);
 	return 0;
 }
 
-- 
1.7.9.5

Re: [PATCH 1/2] ALSA: mips/hal2: Remove redundant platform_set_drvdata()

[Takashi Iwai]

At Mon,  6 May 2013 10:16:15 +0530,
Sachin Kamat wrote:
> 
> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> driver is bound) removes the need to set driver data field to
> NULL.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.fanken.de>

Thanks, applied both patches (with the subject fix for the second
patch).


Takashi

> ---
>  sound/mips/hal2.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/sound/mips/hal2.c b/sound/mips/hal2.c
> index 7420c59..2b7f6e8 100644
> --- a/sound/mips/hal2.c
> +++ b/sound/mips/hal2.c
> @@ -922,7 +922,6 @@ static int hal2_remove(struct platform_device *pdev)
>  	struct snd_card *card = platform_get_drvdata(pdev);
>  
>  	snd_card_free(card);
> -	platform_set_drvdata(pdev, NULL);
>  	return 0;
>  }
>  
> -- 
> 1.7.9.5
> 

Re: [PATCH 1/2] ALSA: mips/hal2: Remove redundant platform_set_drvdata()

[Sachin Kamat]

On 6 May 2013 14:16, Takashi Iwai <tiwai@suse.de> wrote:
> At Mon,  6 May 2013 10:16:15 +0530,
> Sachin Kamat wrote:
>>
>> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
>> driver is bound) removes the need to set driver data field to
>> NULL.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> Cc: Thomas Bogendoerfer <tsbogend@alpha.fanken.de>
>
> Thanks, applied both patches (with the subject fix for the second
> patch).

Thanks. I had already resent the second patch with subject fix. Thanks anyway.

-- 
With warm regards,
Sachin