[PATCH 1/3] wlcore: allow TX BA on all TIDs

[PATCH 1/3] wlcore: allow TX BA on all TIDs

[Eliad Peller]

Previous fw limitation prevented us from from doing
TX BA on TIDs 6/7. However, this restriction no
longer exists, so enable TX BA on all TIDs.

Signed-off-by: Eliad Peller <eliad@wizery.com>
---
 drivers/net/wireless/ti/wlcore/conf.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ti/wlcore/conf.h b/drivers/net/wireless/ti/wlcore/conf.h
index 2b96ff8..80c1ac1 100644
--- a/drivers/net/wireless/ti/wlcore/conf.h
+++ b/drivers/net/wireless/ti/wlcore/conf.h
@@ -590,8 +590,8 @@ struct conf_tx_ac_category {
 
 #define CONF_TX_MAX_TID_COUNT 8
 
-/* Allow TX BA on all TIDs but 6,7. These are currently reserved in the FW */
-#define CONF_TX_BA_ENABLED_TID_BITMAP 0x3F
+/* Allow TX BA on all TIDs */
+#define CONF_TX_BA_ENABLED_TID_BITMAP 0xFF
 
 enum {
 	CONF_CHANNEL_TYPE_DCF = 0,   /* DC/LEGACY*/
-- 
1.8.1.2

[PATCH 2/3] wlcore: configure rates in multiple cases

[Eliad Peller]

The current code configures the peer caps only on BSS_CHANGED_HT
notification. However, we have to configure the peer caps
(and rates) even when HT is not enabled. Otherwise, the fw
continues working with low rates.

Configure the peer caps when sta_exists is true (i.e. when
we extracted the sta rates, e.g. on association).

Signed-off-by: Eliad Peller <eliad@wizery.com>
---
 drivers/net/wireless/ti/wlcore/main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c
index d220ae6..26d0d757 100644
--- a/drivers/net/wireless/ti/wlcore/main.c
+++ b/drivers/net/wireless/ti/wlcore/main.c
@@ -4230,8 +4230,7 @@ static void wl1271_bss_info_changed_sta(struct wl1271 *wl,
 	}
 
 	/* Handle new association with HT. Do this after join. */
-	if (sta_exists &&
-	    (changed & BSS_CHANGED_HT)) {
+	if (sta_exists) {
 		bool enabled =
 			bss_conf->chandef.width != NL80211_CHAN_WIDTH_20_NOHT;
 
-- 
1.8.1.2

[PATCH 3/3] wl12xx/wl18xx: scan all 5ghz channels

[Eliad Peller]

Due to a typo, the current code copies only sizeof(cmd->channels_2)
bytes, which is smaller than the correct sizeof(cmd->channels_5)
size, resulting in a partial scan (some channels are skipped).

Signed-off-by: Eliad Peller <eliad@wizery.com>
---
 drivers/net/wireless/ti/wl12xx/scan.c | 2 +-
 drivers/net/wireless/ti/wl18xx/scan.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ti/wl12xx/scan.c b/drivers/net/wireless/ti/wl12xx/scan.c
index affdb3e..4a0bbb1 100644
--- a/drivers/net/wireless/ti/wl12xx/scan.c
+++ b/drivers/net/wireless/ti/wl12xx/scan.c
@@ -310,7 +310,7 @@ static void wl12xx_adjust_channels(struct wl1271_cmd_sched_scan_config *cmd,
 	memcpy(cmd->channels_2, cmd_channels->channels_2,
 	       sizeof(cmd->channels_2));
 	memcpy(cmd->channels_5, cmd_channels->channels_5,
-	       sizeof(cmd->channels_2));
+	       sizeof(cmd->channels_5));
 	/* channels_4 are not supported, so no need to copy them */
 }
 
diff --git a/drivers/net/wireless/ti/wl18xx/scan.c b/drivers/net/wireless/ti/wl18xx/scan.c
index 09d9445..2b642f8 100644
--- a/drivers/net/wireless/ti/wl18xx/scan.c
+++ b/drivers/net/wireless/ti/wl18xx/scan.c
@@ -34,7 +34,7 @@ static void wl18xx_adjust_channels(struct wl18xx_cmd_scan_params *cmd,
 	memcpy(cmd->channels_2, cmd_channels->channels_2,
 	       sizeof(cmd->channels_2));
 	memcpy(cmd->channels_5, cmd_channels->channels_5,
-	       sizeof(cmd->channels_2));
+	       sizeof(cmd->channels_5));
 	/* channels_4 are not supported, so no need to copy them */
 }
 
-- 
1.8.1.2

Re: [PATCH 1/3] wlcore: allow TX BA on all TIDs

[Luciano Coelho]

Hi Eliad,

On Tue, 2013-05-07 at 15:41 +0300, Eliad Peller wrote:
> Previous fw limitation prevented us from from doing
> TX BA on TIDs 6/7. However, this restriction no
> longer exists, so enable TX BA on all TIDs.
> 
> Signed-off-by: Eliad Peller <eliad@wizery.com>
> ---
>  drivers/net/wireless/ti/wlcore/conf.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/ti/wlcore/conf.h b/drivers/net/wireless/ti/wlcore/conf.h
> index 2b96ff8..80c1ac1 100644
> --- a/drivers/net/wireless/ti/wlcore/conf.h
> +++ b/drivers/net/wireless/ti/wlcore/conf.h
> @@ -590,8 +590,8 @@ struct conf_tx_ac_category {
>  
>  #define CONF_TX_MAX_TID_COUNT 8
>  
> -/* Allow TX BA on all TIDs but 6,7. These are currently reserved in the FW */
> -#define CONF_TX_BA_ENABLED_TID_BITMAP 0x3F
> +/* Allow TX BA on all TIDs */
> +#define CONF_TX_BA_ENABLED_TID_BITMAP 0xFF
>  
>  enum {
>  	CONF_CHANNEL_TYPE_DCF = 0,   /* DC/LEGACY*/

What happened with this?

https://patchwork.kernel.org/patch/1802841/

--
Luca.

Re: [PATCH 1/3] wlcore: allow TX BA on all TIDs

[Eliad Peller]

On Tue, May 7, 2013 at 3:49 PM, Luciano Coelho <coelho@ti.com> wrote:
> Hi Eliad,
>
> On Tue, 2013-05-07 at 15:41 +0300, Eliad Peller wrote:
>> Previous fw limitation prevented us from from doing
>> TX BA on TIDs 6/7. However, this restriction no
>> longer exists, so enable TX BA on all TIDs.
>>
>> Signed-off-by: Eliad Peller <eliad@wizery.com>
>> ---
>>  drivers/net/wireless/ti/wlcore/conf.h | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ti/wlcore/conf.h b/drivers/net/wireless/ti/wlcore/conf.h
>> index 2b96ff8..80c1ac1 100644
>> --- a/drivers/net/wireless/ti/wlcore/conf.h
>> +++ b/drivers/net/wireless/ti/wlcore/conf.h
>> @@ -590,8 +590,8 @@ struct conf_tx_ac_category {
>>
>>  #define CONF_TX_MAX_TID_COUNT 8
>>
>> -/* Allow TX BA on all TIDs but 6,7. These are currently reserved in the FW */
>> -#define CONF_TX_BA_ENABLED_TID_BITMAP 0x3F
>> +/* Allow TX BA on all TIDs */
>> +#define CONF_TX_BA_ENABLED_TID_BITMAP 0xFF
>>
>>  enum {
>>       CONF_CHANNEL_TYPE_DCF = 0,   /* DC/LEGACY*/
>
> What happened with this?
>
> https://patchwork.kernel.org/patch/1802841/
>
hmm... you're right.
i forgot about it.
i'll delete it from my internal tree :)

thanks for catching it.
Eliad.

Re: [PATCH 1/3] wlcore: allow TX BA on all TIDs

[Luciano Coelho]

On Tue, 2013-05-07 at 15:59 +0300, Eliad Peller wrote:
> On Tue, May 7, 2013 at 3:49 PM, Luciano Coelho <coelho@ti.com> wrote:
> > Hi Eliad,
> >
> > On Tue, 2013-05-07 at 15:41 +0300, Eliad Peller wrote:
> >> Previous fw limitation prevented us from from doing
> >> TX BA on TIDs 6/7. However, this restriction no
> >> longer exists, so enable TX BA on all TIDs.
> >>
> >> Signed-off-by: Eliad Peller <eliad@wizery.com>
> >> ---
> >>  drivers/net/wireless/ti/wlcore/conf.h | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/net/wireless/ti/wlcore/conf.h b/drivers/net/wireless/ti/wlcore/conf.h
> >> index 2b96ff8..80c1ac1 100644
> >> --- a/drivers/net/wireless/ti/wlcore/conf.h
> >> +++ b/drivers/net/wireless/ti/wlcore/conf.h
> >> @@ -590,8 +590,8 @@ struct conf_tx_ac_category {
> >>
> >>  #define CONF_TX_MAX_TID_COUNT 8
> >>
> >> -/* Allow TX BA on all TIDs but 6,7. These are currently reserved in the FW */
> >> -#define CONF_TX_BA_ENABLED_TID_BITMAP 0x3F
> >> +/* Allow TX BA on all TIDs */
> >> +#define CONF_TX_BA_ENABLED_TID_BITMAP 0xFF
> >>
> >>  enum {
> >>       CONF_CHANNEL_TYPE_DCF = 0,   /* DC/LEGACY*/
> >
> > What happened with this?
> >
> > https://patchwork.kernel.org/patch/1802841/
> >
> hmm... you're right.
> i forgot about it.
> i'll delete it from my internal tree :)

Okay, I'll remove from my rebased tree as well.

--
Luca.

Re: [PATCH 2/3] wlcore: configure rates in multiple cases

[Luciano Coelho]

On Tue, 2013-05-07 at 15:41 +0300, Eliad Peller wrote:
> The current code configures the peer caps only on BSS_CHANGED_HT
> notification. However, we have to configure the peer caps
> (and rates) even when HT is not enabled. Otherwise, the fw
> continues working with low rates.
> 
> Configure the peer caps when sta_exists is true (i.e. when
> we extracted the sta rates, e.g. on association).
> 
> Signed-off-by: Eliad Peller <eliad@wizery.com>
> ---

Applied and pushed 2/3 and 3/3.  Thanks, Eliad!

--
Luca.