* [PATCH 1/1] ARM: mcpm: Fix build error with gic_secondary_init call
@ 2013-05-10 6:15 ` Sachin Kamat
0 siblings, 0 replies; 4+ messages in thread
From: Sachin Kamat @ 2013-05-10 6:15 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel
Cc: linux, sachin.kamat, Catalin Marinas, Nicolas Pitre
Commit c0114709ed ("irqchip: gic: Perform the gic_secondary_init()
call via CPU notifier") removed all platform calls to gic_secondary_init.
Since this file got merged after the removal of the above call, this
function got left out in the current file which is causing the following
build error:
arch/arm/common/mcpm_platsmp.c:52:2: error: implicit declaration of function
‘gic_secondary_init’ [-Werror=implicit-function-declaration]
gic_secondary_init(0);
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Nicolas Pitre <nico@linaro.org>
---
Compile tested only.
---
arch/arm/common/mcpm_platsmp.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/arm/common/mcpm_platsmp.c b/arch/arm/common/mcpm_platsmp.c
index 52b88d8..3caed0d 100644
--- a/arch/arm/common/mcpm_platsmp.c
+++ b/arch/arm/common/mcpm_platsmp.c
@@ -15,8 +15,6 @@
#include <linux/smp.h>
#include <linux/spinlock.h>
-#include <linux/irqchip/arm-gic.h>
-
#include <asm/mcpm.h>
#include <asm/smp.h>
#include <asm/smp_plat.h>
@@ -49,7 +47,6 @@ static int __cpuinit mcpm_boot_secondary(unsigned int cpu, struct task_struct *i
static void __cpuinit mcpm_secondary_init(unsigned int cpu)
{
mcpm_cpu_powered_up();
- gic_secondary_init(0);
}
#ifdef CONFIG_HOTPLUG_CPU
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 1/1] ARM: mcpm: Fix build error with gic_secondary_init call
@ 2013-05-10 6:15 ` Sachin Kamat
0 siblings, 0 replies; 4+ messages in thread
From: Sachin Kamat @ 2013-05-10 6:15 UTC (permalink / raw)
To: linux-arm-kernel
Commit c0114709ed ("irqchip: gic: Perform the gic_secondary_init()
call via CPU notifier") removed all platform calls to gic_secondary_init.
Since this file got merged after the removal of the above call, this
function got left out in the current file which is causing the following
build error:
arch/arm/common/mcpm_platsmp.c:52:2: error: implicit declaration of function
?gic_secondary_init? [-Werror=implicit-function-declaration]
gic_secondary_init(0);
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Nicolas Pitre <nico@linaro.org>
---
Compile tested only.
---
arch/arm/common/mcpm_platsmp.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/arm/common/mcpm_platsmp.c b/arch/arm/common/mcpm_platsmp.c
index 52b88d8..3caed0d 100644
--- a/arch/arm/common/mcpm_platsmp.c
+++ b/arch/arm/common/mcpm_platsmp.c
@@ -15,8 +15,6 @@
#include <linux/smp.h>
#include <linux/spinlock.h>
-#include <linux/irqchip/arm-gic.h>
-
#include <asm/mcpm.h>
#include <asm/smp.h>
#include <asm/smp_plat.h>
@@ -49,7 +47,6 @@ static int __cpuinit mcpm_boot_secondary(unsigned int cpu, struct task_struct *i
static void __cpuinit mcpm_secondary_init(unsigned int cpu)
{
mcpm_cpu_powered_up();
- gic_secondary_init(0);
}
#ifdef CONFIG_HOTPLUG_CPU
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] ARM: mcpm: Fix build error with gic_secondary_init call
2013-05-10 6:15 ` Sachin Kamat
@ 2013-05-10 12:41 ` Nicolas Pitre
-1 siblings, 0 replies; 4+ messages in thread
From: Nicolas Pitre @ 2013-05-10 12:41 UTC (permalink / raw)
To: Sachin Kamat
Cc: linux-arm-kernel, linux-kernel, Russell King - ARM Linux,
Catalin Marinas
[-- Attachment #1: Type: TEXT/PLAIN, Size: 785 bytes --]
On Fri, 10 May 2013, Sachin Kamat wrote:
> Commit c0114709ed ("irqchip: gic: Perform the gic_secondary_init()
> call via CPU notifier") removed all platform calls to gic_secondary_init.
> Since this file got merged after the removal of the above call, this
> function got left out in the current file which is causing the following
> build error:
> arch/arm/common/mcpm_platsmp.c:52:2: error: implicit declaration of function
> ‘gic_secondary_init’ [-Werror=implicit-function-declaration]
> gic_secondary_init(0);
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Nicolas Pitre <nico@linaro.org>
I already submitted a patch to fix this:
http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=7715/1
Nicolas
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] ARM: mcpm: Fix build error with gic_secondary_init call
@ 2013-05-10 12:41 ` Nicolas Pitre
0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Pitre @ 2013-05-10 12:41 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, 10 May 2013, Sachin Kamat wrote:
> Commit c0114709ed ("irqchip: gic: Perform the gic_secondary_init()
> call via CPU notifier") removed all platform calls to gic_secondary_init.
> Since this file got merged after the removal of the above call, this
> function got left out in the current file which is causing the following
> build error:
> arch/arm/common/mcpm_platsmp.c:52:2: error: implicit declaration of function
> ?gic_secondary_init? [-Werror=implicit-function-declaration]
> gic_secondary_init(0);
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Nicolas Pitre <nico@linaro.org>
I already submitted a patch to fix this:
http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=7715/1
Nicolas
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-05-10 12:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-10 6:15 [PATCH 1/1] ARM: mcpm: Fix build error with gic_secondary_init call Sachin Kamat
2013-05-10 6:15 ` Sachin Kamat
2013-05-10 12:41 ` Nicolas Pitre
2013-05-10 12:41 ` Nicolas Pitre
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.