From: Scott Wood <scottwood@freescale.com>
To: tiejun.chen <tiejun.chen@windriver.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Alexander Graf <agraf@suse.de>,
"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>,
Bhushan Bharat-R65777 <R65777@freescale.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v2 3/4] kvm/ppc: Call trace_hardirqs_on before entry
Date: Fri, 10 May 2013 17:47:00 -0500 [thread overview]
Message-ID: <1368226020.19683.14@snotra> (raw)
In-Reply-To: <518C7A28.4000903@windriver.com> (from tiejun.chen@windriver.com on Thu May 9 23:40:08 2013)
On 05/09/2013 11:40:08 PM, tiejun.chen wrote:
> On 05/10/2013 11:34 AM, Bhushan Bharat-R65777 wrote:
>>> diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c
>>> index 705fc5c..eb89b83 100644
>>> --- a/arch/powerpc/kvm/booke.c
>>> +++ b/arch/powerpc/kvm/booke.c
>>> @@ -673,7 +673,7 @@ int kvmppc_vcpu_run(struct kvm_run *kvm_run,
>>> struct kvm_vcpu
>>> *vcpu)
>>> ret = s;
>>> goto out;
>>> }
>>> - kvmppc_lazy_ee_enable();
>>> + kvmppc_fix_ee_before_entry();
>>
>> local_irq_disable() is called before kvmppc_prepare_to_enter().
>
> In patch 4, we call hard_irq_disable() once enter
> kvmppc_prepare_to_enter().
And before patch 4, we have the code near the end of
kvmppc_prepare_to_enter() that checks lazy_irq_pending() and aborts
guest entry if there was a race. If I'd known about that bit of code
beforehand, I probably wouldn't have bothered with most of patch 4/4,
but now that it's been done it seems cleaner.
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: tiejun.chen <tiejun.chen@windriver.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Alexander Graf <agraf@suse.de>,
"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>,
Bhushan Bharat-R65777 <R65777@freescale.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v2 3/4] kvm/ppc: Call trace_hardirqs_on before entry
Date: Fri, 10 May 2013 17:47:00 -0500 [thread overview]
Message-ID: <1368226020.19683.14@snotra> (raw)
In-Reply-To: <518C7A28.4000903@windriver.com> (from tiejun.chen@windriver.com on Thu May 9 23:40:08 2013)
On 05/09/2013 11:40:08 PM, tiejun.chen wrote:
> On 05/10/2013 11:34 AM, Bhushan Bharat-R65777 wrote:
>>> diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c
>>> index 705fc5c..eb89b83 100644
>>> --- a/arch/powerpc/kvm/booke.c
>>> +++ b/arch/powerpc/kvm/booke.c
>>> @@ -673,7 +673,7 @@ int kvmppc_vcpu_run(struct kvm_run *kvm_run, =20
>>> struct kvm_vcpu
>>> *vcpu)
>>> ret =3D s;
>>> goto out;
>>> }
>>> - kvmppc_lazy_ee_enable();
>>> + kvmppc_fix_ee_before_entry();
>>=20
>> local_irq_disable() is called before kvmppc_prepare_to_enter().
>=20
> In patch 4, we call hard_irq_disable() once enter =20
> kvmppc_prepare_to_enter().
And before patch 4, we have the code near the end of =20
kvmppc_prepare_to_enter() that checks lazy_irq_pending() and aborts =20
guest entry if there was a race. If I'd known about that bit of code =20
beforehand, I probably wouldn't have bothered with most of patch 4/4, =20
but now that it's been done it seems cleaner.
-Scott=
next prev parent reply other threads:[~2013-05-10 22:47 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-10 3:09 [PATCH v2 0/4] kvm/ppc: interrupt disabling fixes Scott Wood
2013-05-10 3:09 ` Scott Wood
2013-05-10 3:09 ` Scott Wood
2013-05-10 3:09 ` [PATCH v2 1/4] powerpc: hard_irq_disable(): Call trace_hardirqs_off after disabling Scott Wood
2013-05-10 3:09 ` Scott Wood
2013-05-10 3:09 ` Scott Wood
2013-05-10 7:00 ` Benjamin Herrenschmidt
2013-05-10 7:00 ` Benjamin Herrenschmidt
2013-05-10 7:00 ` Benjamin Herrenschmidt
2013-05-10 3:09 ` [PATCH v2 2/4] kvm/ppc/booke64: Fix lazy ee handling in kvmppc_handle_exit() Scott Wood
2013-05-10 3:09 ` Scott Wood
2013-05-10 3:09 ` Scott Wood
2013-05-10 5:01 ` Bhushan Bharat-R65777
2013-05-10 5:01 ` Bhushan Bharat-R65777
2013-05-10 22:43 ` Scott Wood
2013-05-10 22:43 ` Scott Wood
2013-05-10 22:43 ` Scott Wood
2013-05-10 3:09 ` [PATCH v2 3/4] kvm/ppc: Call trace_hardirqs_on before entry Scott Wood
2013-05-10 3:09 ` Scott Wood
2013-05-10 3:09 ` Scott Wood
2013-05-10 3:34 ` Bhushan Bharat-R65777
2013-05-10 3:34 ` Bhushan Bharat-R65777
2013-05-10 4:40 ` tiejun.chen
2013-05-10 4:40 ` tiejun.chen
2013-05-10 4:40 ` tiejun.chen
2013-05-10 22:47 ` Scott Wood [this message]
2013-05-10 22:47 ` Scott Wood
2013-05-10 3:09 ` [PATCH v2 4/4] kvm/ppc: IRQ disabling cleanup Scott Wood
2013-05-10 3:09 ` Scott Wood
2013-05-10 3:09 ` Scott Wood
2013-05-10 5:01 ` Bhushan Bharat-R65777
2013-05-10 5:01 ` Bhushan Bharat-R65777
2013-05-10 5:31 ` tiejun.chen
2013-05-10 5:31 ` tiejun.chen
2013-05-10 5:31 ` tiejun.chen
2013-05-10 22:53 ` Scott Wood
2013-05-10 22:53 ` Scott Wood
2013-05-10 22:53 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368226020.19683.14@snotra \
--to=scottwood@freescale.com \
--cc=B07421@freescale.com \
--cc=R65777@freescale.com \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=tiejun.chen@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.