All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dolev Raviv <draviv@codeaurora.org>
To: linux-scsi@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org,
	Dolev Raviv <draviv@codeaurora.org>,
	Maya Erez <merez@codeaurora.org>,
	Sujit Reddy Thumma <sthumma@codeaurora.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: [PATCH V1 2/8] scsi: ufs: Fix the response UPIU length setting
Date: Sun, 12 May 2013 17:23:54 +0300	[thread overview]
Message-ID: <1368368640-10167-3-git-send-email-draviv@codeaurora.org> (raw)
In-Reply-To: <1368368640-10167-1-git-send-email-draviv@codeaurora.org>

The response UPIU length should be in DWORD and not in bytes.

Signed-off-by: Maya Erez <merez@codeaurora.org>
Signed-off-by: Sujit Reddy Thumma <sthumma@codeaurora.org>
Signed-off-by: Dolev Raviv <draviv@codeaurora.org>
Tested-by: Dolev Raviv <draviv@codeaurora.org>

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 4ddc8be..7ce40a5 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -807,7 +807,7 @@ static void ufshcd_host_memory_configure(struct ufs_hba *hba)
 		utrdlp[i].prd_table_offset =
 				cpu_to_le16((prdt_offset >> 2));
 		utrdlp[i].response_upiu_length =
-				cpu_to_le16(ALIGNED_UPIU_SIZE);
+				cpu_to_le16(ALIGNED_UPIU_SIZE >> 2);
 
 		hba->lrb[i].utr_descriptor_ptr = (utrdlp + i);
 		hba->lrb[i].ucd_req_ptr =
-- 
1.7.6

-- 
QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

WARNING: multiple messages have this Message-ID (diff)
From: Dolev Raviv <draviv@codeaurora.org>
To: linux-scsi@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org,
	Dolev Raviv <draviv@codeaurora.org>,
	Maya Erez <merez@codeaurora.org>,
	Sujit Reddy Thumma <sthumma@codeaurora.org>,
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH V1 2/8] scsi: ufs: Fix the response UPIU length setting
Date: Sun, 12 May 2013 17:23:54 +0300	[thread overview]
Message-ID: <1368368640-10167-3-git-send-email-draviv@codeaurora.org> (raw)
In-Reply-To: <1368368640-10167-1-git-send-email-draviv@codeaurora.org>

The response UPIU length should be in DWORD and not in bytes.

Signed-off-by: Maya Erez <merez@codeaurora.org>
Signed-off-by: Sujit Reddy Thumma <sthumma@codeaurora.org>
Signed-off-by: Dolev Raviv <draviv@codeaurora.org>
Tested-by: Dolev Raviv <draviv@codeaurora.org>

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 4ddc8be..7ce40a5 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -807,7 +807,7 @@ static void ufshcd_host_memory_configure(struct ufs_hba *hba)
 		utrdlp[i].prd_table_offset =
 				cpu_to_le16((prdt_offset >> 2));
 		utrdlp[i].response_upiu_length =
-				cpu_to_le16(ALIGNED_UPIU_SIZE);
+				cpu_to_le16(ALIGNED_UPIU_SIZE >> 2);
 
 		hba->lrb[i].utr_descriptor_ptr = (utrdlp + i);
 		hba->lrb[i].ucd_req_ptr =
-- 
1.7.6

-- 
QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

  parent reply	other threads:[~2013-05-12 14:23 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-12 14:23 [PATCH V1 0/8] ufs patch siries Dolev Raviv
2013-05-12 14:23 ` [PATCH V1 1/8] Documentation: devicetree: Add DT bindings for UFS host controller Dolev Raviv
2013-05-12 14:23   ` Dolev Raviv
2013-05-12 14:23 ` Dolev Raviv [this message]
2013-05-12 14:23   ` [PATCH V1 2/8] scsi: ufs: Fix the response UPIU length setting Dolev Raviv
2013-05-12 14:23 ` [PATCH V1 3/8] scsi: ufs: wrap the i/o access operations Dolev Raviv
2013-05-12 14:23   ` Dolev Raviv
2013-05-13  4:07   ` Seungwon Jeon
2013-05-13  6:29     ` Dolev Raviv
2013-05-12 14:23 ` [PATCH V1 4/8] scsi: ufs: amend interrupt configuration Dolev Raviv
2013-05-12 14:23   ` Dolev Raviv
2013-05-12 14:23 ` [PATCH V1 5/8] scsi: ufs: fix interrupt status clears Dolev Raviv
2013-05-12 14:23   ` Dolev Raviv
2013-05-12 14:23 ` [PATCH V1 6/8] scsi: ufs: rework link start-up process Dolev Raviv
2013-05-12 14:23   ` Dolev Raviv
2013-05-12 14:23 ` [PATCH V1 7/8] scsi: ufs: Add support for sending NOP OUT UPIU Dolev Raviv
2013-05-12 14:23   ` Dolev Raviv
2013-05-12 14:24 ` [PATCH V1 8/8] scsi: ufs: Set fDeviceInit flag to initiate device initialization Dolev Raviv
2013-05-12 14:24   ` Dolev Raviv
2013-05-13 10:02 [PATCH V1 0/8] ufs patch siries Dolev Raviv
2013-05-13 10:02 ` [PATCH V1 2/8] scsi: ufs: Fix the response UPIU length setting Dolev Raviv
2013-05-13 10:02   ` Dolev Raviv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1368368640-10167-3-git-send-email-draviv@codeaurora.org \
    --to=draviv@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=merez@codeaurora.org \
    --cc=sthumma@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.