From: Laurent Navet <laurent.navet@gmail.com> To: FlorianSchandinat@gmx.de Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Navet <laurent.navet@gmail.com> Subject: [PATCH] drivers: video: mxsfb: clean use of devm_ioremap_resource() Date: Tue, 14 May 2013 11:25:08 +0200 [thread overview] Message-ID: <1368523508-30967-1-git-send-email-laurent.navet@gmail.com> (raw) Check of 'res' and calls to dev_err are already done in devm_ioremap_resource, so no need to do them twice. Signed-off-by: Laurent Navet <laurent.navet@gmail.com> --- drivers/video/mxsfb.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c index 21223d4..0f3d0fc 100644 --- a/drivers/video/mxsfb.c +++ b/drivers/video/mxsfb.c @@ -884,9 +884,10 @@ static int mxsfb_probe(struct platform_device *pdev) pdev->id_entry = of_id->data; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) { - dev_err(&pdev->dev, "Cannot get memory IO resource\n"); - return -ENODEV; + host->base = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(host->base)) { + ret = PTR_ERR(host->base); + goto fb_release; } fb_info = framebuffer_alloc(sizeof(struct mxsfb_info), &pdev->dev); @@ -897,13 +898,6 @@ static int mxsfb_probe(struct platform_device *pdev) host = to_imxfb_host(fb_info); - host->base = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(host->base)) { - dev_err(&pdev->dev, "ioremap failed\n"); - ret = PTR_ERR(host->base); - goto fb_release; - } - host->pdev = pdev; platform_set_drvdata(pdev, host); -- 1.7.10.4
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Navet <laurent.navet@gmail.com> To: FlorianSchandinat@gmx.de Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Navet <laurent.navet@gmail.com> Subject: [PATCH] drivers: video: mxsfb: clean use of devm_ioremap_resource() Date: Tue, 14 May 2013 09:25:08 +0000 [thread overview] Message-ID: <1368523508-30967-1-git-send-email-laurent.navet@gmail.com> (raw) Check of 'res' and calls to dev_err are already done in devm_ioremap_resource, so no need to do them twice. Signed-off-by: Laurent Navet <laurent.navet@gmail.com> --- drivers/video/mxsfb.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c index 21223d4..0f3d0fc 100644 --- a/drivers/video/mxsfb.c +++ b/drivers/video/mxsfb.c @@ -884,9 +884,10 @@ static int mxsfb_probe(struct platform_device *pdev) pdev->id_entry = of_id->data; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) { - dev_err(&pdev->dev, "Cannot get memory IO resource\n"); - return -ENODEV; + host->base = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(host->base)) { + ret = PTR_ERR(host->base); + goto fb_release; } fb_info = framebuffer_alloc(sizeof(struct mxsfb_info), &pdev->dev); @@ -897,13 +898,6 @@ static int mxsfb_probe(struct platform_device *pdev) host = to_imxfb_host(fb_info); - host->base = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(host->base)) { - dev_err(&pdev->dev, "ioremap failed\n"); - ret = PTR_ERR(host->base); - goto fb_release; - } - host->pdev = pdev; platform_set_drvdata(pdev, host); -- 1.7.10.4
next reply other threads:[~2013-05-14 9:18 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-05-14 9:25 Laurent Navet [this message] 2013-05-14 9:25 ` [PATCH] drivers: video: mxsfb: clean use of devm_ioremap_resource() Laurent Navet 2013-05-16 8:41 Jingoo Han 2013-05-16 8:41 ` Jingoo Han 2013-05-16 9:46 ` Laurent Navet 2013-05-16 9:46 ` Laurent Navet 2013-05-21 12:33 ` [PATCH V2] " Laurent Navet 2013-05-21 12:33 ` Laurent Navet
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1368523508-30967-1-git-send-email-laurent.navet@gmail.com \ --to=laurent.navet@gmail.com \ --cc=FlorianSchandinat@gmx.de \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.